D19280: [TaskManager] Modernize and reorganize configuration settings

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> config.qml:27
> +         name: i18n("Appearance")
> +         icon: "preferences-desktop-plasma-theme"
> +         source: "ConfigAppearance.qml"

Hmm, not sure this really fits, TBH. I kind of likes the colors-style icon you used in a previous version.

> GB_2 wrote in ConfigBehavior.qml:64
> "Task Manager" should be lowercase and a better text would be "Only group when the task manager is full".
> I'd also switch the position with the above checkbox.

Uppercase is fine since it's a proper noun.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190224/c0b5796a/attachment-0001.html>