D19077: Redesign the theme preview window

Björn Feber noreply at phabricator.kde.org
Thu Feb 21 22:37:22 GMT 2019


GB_2 added a comment.


  In D19077#417065 <https://phabricator.kde.org/D19077#417065>, @filipf wrote:
  
  > OK so down to only one hack now. If possible I'd really like to keep it because it works in 100% of the cases I tested it with and results in better visuals; don't know how to fix on the C++ side of things.
  >
  > Couple of things that might be worthy of being discussed:
  >
  > 1. changes to the layout of the text - @ngraham already had some suggestions, @abetts do you have some other ideas?
  > 2. add a dummy rectangle that would show up when there is no previewImage and that would say "Image preview not available"?
  
  
  It could show a Kirigami Icon "view-preview" when there's no image. 
  Can you also change the description to not be italic?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/70bd3c4b/attachment.html>


More information about the Plasma-devel mailing list