D18964: UpdatesPage: Fix icon sizing on small screens

Jonah BrĂ¼chert noreply at phabricator.kde.org
Tue Feb 12 17:30:09 GMT 2019


jbbgameich created this revision.
jbbgameich added a reviewer: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  On Small screens (e.g phones), not all list items have the same height, for example when a package has a long version string.
  Since the width of the icon was previously copied from the height, this resulted in inconsistent icon sizes.
  
  This patch sets the icon size to a constant value, which fixes the problem.

TEST PLAN
  Icon sizes are consistent and still correctly sized

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: jbbgameich, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190212/4fe0d9b6/attachment.html>


More information about the Plasma-devel mailing list