D18936: [weather] Fix weather Notices tab not showing
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Feb 12 00:23:06 GMT 2019
kossebau added inline comments.
INLINE COMMENTS
> kossebau wrote in NoticesView.qml:46
> Npt sure about this one, in my test data I always had >1 warnings/watches, and left aligned then somehow looked better.
>
> But fine to +1 this for now, we can always change it later if we finally get more real world usage by your fix and a better idea what looks good to most, other than the original developer :)
IIRC my issue had been that with centering everything, the result is that all of the "Current observed status" below icon, name of tab "Details", header "Warnings"/"Watches" of section and the warnng entries all have been centered, so by the eye they somehow looked to be one big list.
By having the heading left aligned, that appearance was broken up a bit.
Though as I realize now this only works properly if there are >1 warnings/watches, in case of one item only it looks strange again indeed. Possibly needs other eye guiding helpers. Left for another round of thinking. Or real UI designers :)
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D18936
To: Zren, kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190212/fc0bb0f6/attachment.html>
More information about the Plasma-devel
mailing list