D18890: Add button to reset index database and repair Baloo crashing

Nathaniel Graham noreply at phabricator.kde.org
Sun Feb 10 18:14:23 GMT 2019


ngraham added a comment.


  Thanks! This is pretty good as-is, and I can confirm that it works just fine. However once the user presses the button, there's no further feedback, which could encourage them to repeatedly press it again--not a good idea. Maybe while the initial index is being generated, we could display a progress spinner (and a label too) and disable the button. What do you think?

INLINE COMMENTS

> kcm.cpp:208
> +    proc->start(balooctl, args3);
> +    proc->waitForFinished();
> +}

This whole section could benefit from a few more line breaks to separate the commands into logical groups.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18890

To: guoyunhe, #plasma, #baloo
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190210/47d1fd03/attachment.html>


More information about the Plasma-devel mailing list