D18809: Image Wallpaper Slideshow - display the list of images that will be shown

David Redondo noreply at phabricator.kde.org
Fri Feb 8 20:36:39 GMT 2019


davidre marked an inline comment as done.
davidre added inline comments.

INLINE COMMENTS

> ngraham wrote in image.cpp:877
> This generates a warning (variable `krun` is unused). I would suggest using `KIO::highlightInFileManager()` instead. For example: https://cgit.kde.org/spectacle.git/tree/src/Gui/KSMainWindow.cpp#n327

Yes I also saw this method since the backgroundlist uses it but the Header said to use KRun if you want to open a folder instead of it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190208/f4fbd4c3/attachment.html>


More information about the Plasma-devel mailing list