D18632: Port away from deprecated KIO::UDSEntry::insert()

[Chinmoy Ranjan Pradhan]

chinmoyr accepted this revision.
chinmoyr added a comment.
This revision is now accepted and ready to land.


  LGTM

INLINE COMMENTS

> kossebau wrote in kio_desktop.cpp:183
> :)
> 
> Well, I would rather be safe then sorry. We have no control over what other code might do to the entry object, also is there nothing noted in any API contracts.
> And it's not very performance critical code here, so I propose future-proof code for now.

I agree with you here.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  portudsentryinsert

REVISION DETAIL
  https://phabricator.kde.org/D18632

To: kossebau, #plasma, chinmoyr
Cc: chinmoyr, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190205/90e70ec3/attachment.html>