D23356: Add ksysguard plugin for taskmanager integration

David Edmundson noreply at phabricator.kde.org
Thu Aug 22 17:47:55 BST 2019


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Currently this is all hardcoded in ProcessModel. By moving it into a
  plugin we can make that model half the size.
  
  Code is ported to use libTM instead of KWindowSystem for a few reasons:
  
    - It works on wayland (assuming we have the extra permissions set)
    - We get to make use of the more complex advanced mapping in libTM
  - It has fixed code to get the right PID for a window so apps in a PID
  
  namespace have the icon in the right place (currently broken in
  ksysguard)
  
  Requires some tiny mods in ProcessModel to map the decoration role.
  
  Introduces a p-w dependency in ksysguard, but not the lib so there's no
  lib.

TEST PLAN
  Opened ksysguard, data matched the old ksysguard, except for my flatpak
  app which now had the icon on the correct process not some random kernel 
  process

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23356

AFFECTED FILES
  plugins/CMakeLists.txt
  plugins/process/taskmanager/CMakeLists.txt
  plugins/process/taskmanager/taskmanager.cpp
  plugins/process/taskmanager/taskmanager.h
  plugins/process/taskmanager/taskmanager.json

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190822/fd318b6b/attachment.html>


More information about the Plasma-devel mailing list