D15306: BookmarksRunner: Avoid multiple connections of identical signal

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> bruns wrote in bookmarksrunner.cpp:66
> yes, after readding the `dynamic_cast<QObject*>`, m_browser is a non-QObject interface class.

The only syntax which works is

  connect(this, &Plasma::AbstractRunner:teardown,
          dynamic_cast<QObject*>(m_browser), [this] () { m_browser->teardown(); });

The context object has to be a QObject* (or derived).
&Browser::teardown is not a pointer to a QObject member function, thus we need a functor.

The other approach would be to make Browser a QObject derived class.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180906/6e72f70b/attachment.html>