Review Request 129255: Fixed unrar version check.

Massimiliano Torromeo massimiliano.torromeo at gmail.com
Fri Jan 20 23:13:45 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129255/
-----------------------------------------------------------

(Updated Jan. 20, 2017, 11:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit c734c5d5a1b47f749ef9230454f963b3b7daf573 by Albert Astals Cid to branch Applications/16.12.


Bugs: 341305
    https://bugs.kde.org/show_bug.cgi?id=341305


Repository: kio-extras


Description
-------

The parameter "--version" stopped working since unrar 5.2 which was
released almost 2 years ago.
With this change this now becomes the minimum version required but
every distribution that is going to include a version of KDE with
this commit has probably been using unrar > 5.2 for quite a while
so I don't think there is any need to provide a fallback.

This fixes bugs 367626 and 341305


Diffs
-----

  thumbnail/comiccreator.cpp 4ec0db8c6953e2d9983e4a9d7f542b27404175e4 

Diff: https://git.reviewboard.kde.org/r/129255/diff/


Testing
-------

Verified that the previously missing thumbnails for cbr files are now being correctly generated.


Thanks,

Massimiliano Torromeo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170120/340fc0b4/attachment.html>


More information about the Plasma-devel mailing list