[Differential] [Request, 4 lines] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

[Alex Richardson]

arichardson created this revision.
arichardson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We currently get the following sequence of calls:
  
  KDEPlatformFileDialogHelper::setDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh")
  KDEPlatformFileDialogHelper::setDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh")
  KDEPlatformFileDialogHelper::selectFile QUrl("file:///home/alex/build_sdk.sh")
  KDEPlatformFileDialogHelper::setDirectory QUrl("file:///home/alex/)
  
  Previously KDEPlatformFileDialogHelper::selectFile() would change
  options()->initialDirectory() unconditionally even if it was already
  set by the QFileDialog code. The final setDirectory() call is actually a call
  to setDirectory(options->initialDirectory()) which was set in the selectFile()
  call. It no longer seems to be required to derive initialDirectory from the
  selectFile() call and this will now to override the correct initial directory
  that was set by Qt.
  Qt should not be passing a local URL when the actual directory URL is remote
  but the code in QFileDialogPrivate::init() unconditionally sets a local URL
  until https://codereview.qt-project.org/#/c/182661/ or another fix is submitted.
  
  BUG: 374913

TEST PLAN
  Remote directory is now opened correctly

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4193

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arichardson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170118/48196cc2/attachment.html>