[Differential] [Changed Subscribers] D4086: If we changed containment with the config open, relaunch the config dialog

Marco Martin noreply at phabricator.kde.org
Wed Jan 11 18:30:17 UTC 2017


mart added inline comments.

INLINE COMMENTS

> desktopview.cpp:267
>          m_configView = new ContainmentConfigView(cont);
> +        //if we changed containment with the config open, relaunch the config dialog but for the new containment
> +        connect(this, &ContainmentView::containmentChanged, m_configView.data(), [this]() {

this should be disconnected somewhere..
wouldn't this always show the config dialog after the first time, regardless the config dialog is open or not? (ie, activity switch)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4086

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170111/87a6e00a/attachment-0001.html>


More information about the Plasma-devel mailing list