[Differential] [Commented On] D4082: parse the desktop file 2 times

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Jan 11 14:18:41 UTC 2017


apol added a comment.


  How about adding a test?
  
  Other than that, the patch looks good.
  
  It's horrible that we need to do so, but I guess it's the price of backwards compatibility. There's the possibility of doing the processing in two steps (desktop to pairs, pairs to json), but we agreed that this code shouldn't be optimized anyway (as it's transitional and what we support is json).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4082

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, dfaure, davidedmundson
Cc: apol, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170111/11e59517/attachment-0001.html>


More information about the Plasma-devel mailing list