[Differential] [Accepted] D3964: Fade out OnScreenNotification when moving with the mouse over it

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> onscreennotification.cpp:209
> +        if (!m_animation) {
> +            m_animation = new QPropertyAnimation(w, "opacity", this);
> +            m_animation->setStartValue(1.0);

you could have put the animation in the constructor normally and then do setTargetObject once you make the window

BRANCH
  osn-fade-out

REVISION DETAIL
  https://phabricator.kde.org/D3964

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170104/7473923a/attachment-0001.html>