Review Request 129046: Port to KWindowSystem::forceActiveWindow

David Edmundson david at davidedmundson.co.uk
Tue Sep 27 10:02:55 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129046/#review99567
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Sept. 27, 2016, 10 a.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129046/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 10 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> activate() doesn't restore a minimized window. forceActiveWindow() is suggested by the docs for KDBusService::activateRequested.
> 
> This doesn't work on Wayland, but fixes X11 behavior. It doesn't regress on Wayland, either, but it's sad.
> 
> 
> Diffs
> -----
> 
>   app/SystemSettingsApp.cpp e9f43d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129046/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160927/4231abe7/attachment.html>


More information about the Plasma-devel mailing list