Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

[David Rosca]

> On March 4, 2016, 10:23 p.m., David Edmundson wrote:
> > autotests/iconitemtest.cpp, line 299
> > <https://git.reviewboard.kde.org/r/127282/diff/1/?file=447999#file447999line299>
> >
> >     ?

svg imagePath was set in setSource and also in loadPixmap. It is now set only in loadPixmap, so it is needed to grab image to call it.

I can also restore the old behavior, but I think this way it is better.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127282/#review93177
-----------------------------------------------------------


On March 4, 2016, 10:12 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127282/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 10:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> source should always return the same value as it was assigned.
> Also removed duplicated code (empty sourceString is now handled as if the source couldn't be converted to any type).
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.h 2de8512 
>   autotests/iconitemtest.cpp 8d3f494 
>   src/declarativeimports/core/iconitem.h 651a101 
>   src/declarativeimports/core/iconitem.cpp b1c4c7a 
> 
> Diff: https://git.reviewboard.kde.org/r/127282/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160304/ffb40b9e/attachment.html>