Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128552/#review97953
-----------------------------------------------------------




containments/desktop/package/contents/ui/FolderItemDelegate.qml (line 305)
<https://git.reviewboard.kde.org/r/128552/#comment65989>

    This approach is kind of wrong because return values of method calls are not notifyable props. If the file turns into a symlink or from a symlink into a not-symlink, this prop binding will have no way to know. It might work in practice because KDirModel will in most cases probably do remove+insert or model resets, but it's not correct to write code against this assumptions.
    
    My advice is whether the KDirModel::Type model column correctly identifies symlinks as such, then add a new bool data role IsSymlink or similar to FolderModel and use that in the view code.


- Eike Hein


On July 29, 2016, 3:40 p.m., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128552/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 3:40 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, Bhushan Shah, and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> In folder view plasmoid symlinks and ordinary files look similar. This patch makes the symlink look different by italicising its name and adding an icon overlay.
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/FolderItemDelegate.qml e4fcd67 
>   containments/desktop/plugins/folder/CMakeLists.txt 1095f81 
>   containments/desktop/plugins/folder/foldermodel.h a6992bb 
>   containments/desktop/plugins/folder/foldermodel.cpp 2b9d41b 
> 
> Diff: https://git.reviewboard.kde.org/r/128552/diff/
> 
> 
> Testing
> -------
> 
> build
> 
> 
> File Attachments
> ----------------
> 
> symlinks and other files/folders look similar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/7428b23d-03f9-4aed-8ca0-536d44e45e8c__beforepatch.png
> after patch , everything looks fine
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/040b2e3b-9ea0-4347-9e6c-ca3bdb73b36a__link.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160731/466c8c63/attachment.html>