Review Request 128493: [Button Styles] Horizontally center in icon-only mode

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128493/#review97852
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On July 21, 2016, 2:45 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128493/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 2:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 365947
>     http://bugs.kde.org/show_bug.cgi?id=365947
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> QtQuick.Layouts by default left aligns content and because the Layout is anchors.fill'd the icon would show off-center in a button when no text has been set. This fixes this.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/ButtonStyle.qml a962512 
>   src/declarativeimports/plasmastyle/ToolButtonStyle.qml 1562590 
> 
> Diff: https://git.reviewboard.kde.org/r/128493/diff/
> 
> 
> Testing
> -------
> 
> * Close button icon in present window is no longer misaligned
> * Close button icon in notification is no longer misaligned
> * Button icons in panel controller (German locale where text is so long it hides the labels) are no longer misaligned
> * Panel controller more menu buttons are fine (both the ones with and without label)
> * Ran tests/components/button.qml all looked fine
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160726/9ec49ce3/attachment.html>