[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> graesslin wrote in Jobs.qml:88
> why !!

!! is the JavaScript-way of casting to a bool, error is the KIO error number.

I could do Boolean(error) or error ? true : false if you like. I do a toBool() in the notification action but I'd prefer being explicit here

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160719/da7dc90a/attachment-0001.html>