Review Request 127009: Add transparency support to xembedsniproxy

Martin Gräßlin mgraesslin at kde.org
Mon Feb 8 07:49:36 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127009/#review92147
-----------------------------------------------------------




xembed-sni-proxy/fdoselectionmanager.cpp (line 178)
<https://git.reviewboard.kde.org/r/127009/#comment62863>

    we should probably also connect to the changed signal and re-evaluate the situation if compositing changed?


- Martin Gräßlin


On Feb. 8, 2016, 6:23 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127009/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 6:23 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Spec details:
> https://specifications.freedesktop.org/systemtray-spec/systemtray-spec-latest.html#idm139990069470464
> 
> 
> Diffs
> -----
> 
>   xembed-sni-proxy/fdoselectionmanager.cpp f236e9c 
>   xembed-sni-proxy/sniproxy.cpp 3827fdd 
>   xembed-sni-proxy/xcbutils.h 5e2b6dc 
> 
> Diff: https://git.reviewboard.kde.org/r/127009/diff/
> 
> 
> Testing
> -------
> 
> goldendict/skype, both are qt4 apps, now without black background (when not using sni-qt). More tests are welcome.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160208/f3a72d18/attachment.html>


More information about the Plasma-devel mailing list