Review Request 126954: [Notifications] Fix Job finished persistency

Kai Uwe Broulik kde at privat.broulik.de
Mon Feb 1 20:39:22 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126954/
-----------------------------------------------------------

Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
-------

This was an oversight when porting to call the dataengine for that notification.


Diffs
-----

  applets/notifications/package/contents/ui/Jobs.qml 669d0bd 
  dataengines/notifications/notificationaction.cpp c2da498 

Diff: https://git.reviewboard.kde.org/r/126954/diff/


Testing
-------

Works now.

KNotificationDBusTest also works fine.

Plasma Undo notifications are no longer persistent but this is unrelated to this patch.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/7f1996df/attachment.html>


More information about the Plasma-devel mailing list