Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

Kai Uwe Broulik kde at privat.broulik.de
Mon Feb 1 11:30:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126942/#review91843
-----------------------------------------------------------



>  but tooltip: "str" has no effect.

That's because kscreenlocker_greet is a QGuiApplication and QToolTip used by QtQuick.Controls requires QApplication

- Kai Uwe Broulik


On Feb. 1, 2016, 11:14 vorm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126942/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 11:14 vorm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Displaying layout variant makes the button too big.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 
> 
> Diff: https://git.reviewboard.kde.org/r/126942/diff/
> 
> 
> Testing
> -------
> 
> "de(nodeadkeys)" is now just "de"
> 
> Might be good idea to show full name in tooltip, but `tooltip: "str"` has no effect.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/53796a3e/attachment.html>


More information about the Plasma-devel mailing list