Review Request 123478: ensure the filePath "metadata" is there

Sebastian Kügler sebas at kde.org
Thu Apr 23 14:39:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123478/#review79394
-----------------------------------------------------------

Ship it!


Yes, please.

I was wondering if I could rely on metadata.desktop always being there, this changes makes my life so much easier.

- Sebastian Kügler


On April 23, 2015, 2:34 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123478/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 2:34 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Sebastian Kügler.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> packages are supposed to always have a filePath called "metadata" that returns the path of the metadata desktop file, regardless of their package structure.
> but at some point in the various portings this got lost
> 
> 
> Diffs
> -----
> 
>   src/kpackage/package.cpp 7057804 
> 
> Diff: https://git.reviewboard.kde.org/r/123478/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150423/eaa28171/attachment-0001.html>


More information about the Plasma-devel mailing list