Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123411/#review79155
-----------------------------------------------------------


thanks for putting it on reviewboard. Overall it looks like we will need to do more work once we have support for it in Wayland. But to make it not crash it seems like a good approach at the moment.


applets/pager/plugin/pager.h (line 144)
<https://git.reviewboard.kde.org/r/123411/#comment54092>

    m_rows seems not to be initialized if m_isX11 is false



applets/pager/plugin/pager.h (line 160)
<https://git.reviewboard.kde.org/r/123411/#comment54091>

    make it:
    bool m_isX11 = false;
    
    and remove the
    #else
    #endif
    block in the initializer list


- Martin Gräßlin


On April 18, 2015, 4:07 a.m., Nerdopolis Turfwalker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123411/
> -----------------------------------------------------------
> 
> (Updated April 18, 2015, 4:07 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland
> 
> 
> Diffs
> -----
> 
>   applets/pager/plugin/pager.cpp 22c6ca2747f297dc3d37d02b46cb33196e64b1e0 
>   applets/pager/plugin/pager.h 78d461d2554e4885721da3d2eff82151c97f9305 
> 
> Diff: https://git.reviewboard.kde.org/r/123411/diff/
> 
> 
> Testing
> -------
> 
> Ran plasmoidviewer -a org.kde.plasma.pager in with QT_QPA_PLATFORM=wayland got no crash from plasmoid viewer.
> 
> Started an Xephyr session, set QT_QPA_PLATFORM=xcb and DISPLAY=:1, started kwin_x11, and then plasmoidviewer -a org.kde.plasma.pager and had full functionality.
> 
> 
> Thanks,
> 
> Nerdopolis Turfwalker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150418/52c47082/attachment-0001.html>