Review Request 123211: Ask for confirmation before deleting a wallpaper.

[Thomas Pfeiffer]

> On April 1, 2015, 3:58 nachm., Kai Uwe Broulik wrote:
> > I don't think the wallpaper dialog should ever delete an actual image file, especially not when it's in the user's Pictures folder. Only exception is when it has been installed through GHNS in which case it is in some hidden dot folder.
> > 
> > As for the confirmation, I think we should rather provide an undo functionality so you don't accidentally remove the wallpaper from the list and then have to search it on the filesystem again.
> 
> Marco Martin wrote:
>     I think the patch for now is fine as is, modulo using QtQuickcontrols.
>     the file is deleted in ghns case and just the entry removed in case of photo on the hard drive.
>     the wording on the dialog should reflect that.
> 
> Thomas Pfeiffer wrote:
>     The patch may be fine from a technical perspective, but it has a considerable negative impact on user experience, and therefore should not be shipped anyway.
> 
> Marco Martin wrote:
>     It adresses a specific bug, so no, it doesn't have a negative impact compared to now.
>     I agree that an undo feature would be better, but I consider more productive having iterative revisions even with different approaches rather than shoot down contributors.
>     I have a couple of ideas how an undo feature could be implemented, in this case i think it can be shown an undo button on like a greyed down wallpaper thumbnail until ok or apply is clicked, that moment the change is committed irreversibely.
>     will discuss the implementation in another comment

Yes, it addresses the situation that people may accidentally delete a wallpaper that was downloaded from GHNS and then cannot not find it there anymore. I would not consider this problem as important enough to put all users through another conformation dialog, though, so I do not see it as an incremental step towards a better user experience.

I didn't mean to criticize Antonis for that, though. I apologize if that's how it came across. According to your expert review (which I fully trust), Antonis provied a sound patch to address a bug report.
The problem I have is that the usability team was informed neither of the bug nor the patch, even though both clearly had usability implications. So, Antonis did a fine job, but our usability review process still seems to be imperfect (though it's steadily improving).


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123211/#review78350
-----------------------------------------------------------


On April 1, 2015, 3:27 nachm., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123211/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 3:27 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 338729
>     https://bugs.kde.org/show_bug.cgi?id=338729
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch is adding a confirmation dialog which is being called before we remove a wallpaper.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f 
>   wallpapers/image/imagepackage/contents/ui/config.qml 2108082 
> 
> Diff: https://git.reviewboard.kde.org/r/123211/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150401/6a0ea586/attachment.html>