Review Request 115859: Force-allow background contrast while sliding desktops

Sebastian Kügler sebas at kde.org
Tue Feb 18 01:16:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115859/
-----------------------------------------------------------

Review request for kwin and Plasma.


Repository: kde-workspace


Description
-------

Force-allow background contrast while sliding

When the sliding effect is active, the background blur of the panel
would be disabled unless forced with WindowForceBackgroundContrastRole,
which is actually what we want: during sliding, the backgroundcontrast
effect would otherwise be disabled, leading to the panel and popups
flickering between contrast enabled and disabled.

With this patch, the panel keeps its coloring during desktop changes.


Diffs
-----

  kwin/effects/slide/slide.cpp 8ecb2a625057451f599261e244a05c94c8814fea 

Diff: https://git.reviewboard.kde.org/r/115859/diff/


Testing
-------

Switched desktops, panel keeps color, fullscreen video player doesn't seem to be affected negatively, everything still works as expected, except that the flickering in Plasma Dialogs is gone.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140218/1891f0cd/attachment.html>


More information about the Plasma-devel mailing list