Review Request 121346: Some fixes on battery monitor

Kai Uwe Broulik kde at privat.broulik.de
Thu Dec 4 20:43:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121346/#review71363
-----------------------------------------------------------

Ship it!


Please commit your mousewheel fixes.

Regarding the percentage, thanks to your heads up, I finally came around to implementing it in the way I wanted it: https://git.reviewboard.kde.org/r/121355/

- Kai Uwe Broulik


On Dez. 4, 2014, 8:56 vorm., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121346/
> -----------------------------------------------------------
> 
> (Updated Dez. 4, 2014, 8:56 vorm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> 1. remove redundant "percentage" brightness
> 2. make wheel on tray usable on high precision touchpad: http://qt-project.org/doc/qt-5/qml-qtquick-wheelevent.html#angleDelta-prop
> See also for a bug with similar reason https://bugs.kde.org/show_bug.cgi?id=313579
> 
> 
> Diffs
> -----
> 
>   applets/batterymonitor/package/contents/code/logic.js a5ac7f0 
>   applets/batterymonitor/package/contents/ui/PopupDialog.qml 0298f7f 
>   applets/batterymonitor/package/contents/ui/batterymonitor.qml 5e61a21 
> 
> Diff: https://git.reviewboard.kde.org/r/121346/diff/
> 
> 
> Testing
> -------
> 
> touchpad scrolling now works in a more reasonable adjustion speed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141204/16481e55/attachment.html>


More information about the Plasma-devel mailing list