plasma-desktop/kcms/input breakage

Harald Sitter sitter at kde.org
Wed Apr 2 12:12:57 UTC 2014


alohas

the input kcm has a bit of a logic problem resulting in this build failure:
https://launchpadlibrarian.net/171550502/buildloga_ubuntu-trusty-amd64.project-neon5-plasma-desktop_0.0%2Bgit20140402.19%2Bneon3~7ac423f~14.04_FAILEDTOBUILD.txt.gz

problems I have identified thus far:
- no cmake logging/check in place for xcursor dependency
- when xcursor dependency is not present a different set of includes
will be used [1]
- the includes for when xcursor is not present have no include path to
qlayout/qvboxlayout producing the aformentioned build failure

I am not sure how exactly this is supposed to work. The fix might be
as simple as introducing the cmake feature logging and adding an
include of vboxlayout to kcmcursor.cpp, or something more elaborate.
It would be lovely if someone with more background knowledge could
take a look at this.

[1] https://projects.kde.org/projects/kde/workspace/plasma-desktop/repository/revisions/master/entry/kcms/input/CMakeLists.txt#L8

HS

(P.S. in my opinion build time paths like this require additional
handling in jenkins as currently this path is not covered by CI at
all, which is probably why it is broken, alternatively xcursor should
simply be promoted to a require dependency)


More information about the Plasma-devel mailing list