From wengxt at gmail.com  Thu Aug  1 01:23:12 2013
From: wengxt at gmail.com (Xuetian Weng)
Date: Thu, 01 Aug 2013 01:23:12 -0000
Subject: Review Request 111828: fix link click in notification
Message-ID: <20130801012312.18279.55171@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111828/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Description
-------

handle the linkActivated signal in both popup and notification history.

now click on link can open browser (or anything it should be) correctly.


Diffs
-----

  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ca7564f 
  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 29a6a2d 

Diff: http://git.reviewboard.kde.org/r/111828/diff/


Testing
-------

No problem, and seems the drag operation is not affected (if not dragging from link).

test with:
notify-send "<a href="https://google.com">test link</a>"


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130801/2f3149f3/attachment.html>

From sebas at kde.org  Thu Aug  1 09:16:11 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Thu, 01 Aug 2013 09:16:11 -0000
Subject: Review Request 111828: fix link click in notification
In-Reply-To: <20130801012312.18279.55171@vidsolbach.de>
References: <20130801012312.18279.55171@vidsolbach.de>
Message-ID: <20130801091611.19831.44732@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111828/#review36897
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian K?gler


On Aug. 1, 2013, 1:23 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111828/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 1:23 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> handle the linkActivated signal in both popup and notification history.
> 
> now click on link can open browser (or anything it should be) correctly.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ca7564f 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 29a6a2d 
> 
> Diff: http://git.reviewboard.kde.org/r/111828/diff/
> 
> 
> Testing
> -------
> 
> No problem, and seems the drag operation is not affected (if not dragging from link).
> 
> test with:
> notify-send "<a href="https://google.com">test link</a>"
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130801/6a8ac2e0/attachment.html>

From null at kde.org  Thu Aug  1 20:28:21 2013
From: null at kde.org (Commit Hook)
Date: Thu, 01 Aug 2013 20:28:21 -0000
Subject: Review Request 111828: fix link click in notification
In-Reply-To: <20130801012312.18279.55171@vidsolbach.de>
References: <20130801012312.18279.55171@vidsolbach.de>
Message-ID: <20130801202821.16329.19385@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111828/#review36944
-----------------------------------------------------------


This review has been submitted with commit 20765b4479db5d3788ef799fa45bad5503075a09 by Weng Xuetian to branch KDE/4.11.

- Commit Hook


On Aug. 1, 2013, 1:23 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111828/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 1:23 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> handle the linkActivated signal in both popup and notification history.
> 
> now click on link can open browser (or anything it should be) correctly.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ca7564f 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 29a6a2d 
> 
> Diff: http://git.reviewboard.kde.org/r/111828/diff/
> 
> 
> Testing
> -------
> 
> No problem, and seems the drag operation is not affected (if not dragging from link).
> 
> test with:
> notify-send "<a href="https://google.com">test link</a>"
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130801/4c674ea2/attachment.html>

From null at kde.org  Thu Aug  1 20:28:25 2013
From: null at kde.org (Commit Hook)
Date: Thu, 01 Aug 2013 20:28:25 -0000
Subject: Review Request 111828: fix link click in notification
In-Reply-To: <20130801012312.18279.55171@vidsolbach.de>
References: <20130801012312.18279.55171@vidsolbach.de>
Message-ID: <20130801202825.16880.20989@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111828/
-----------------------------------------------------------

(Updated Aug. 1, 2013, 8:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Description
-------

handle the linkActivated signal in both popup and notification history.

now click on link can open browser (or anything it should be) correctly.


Diffs
-----

  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ca7564f 
  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 29a6a2d 

Diff: http://git.reviewboard.kde.org/r/111828/diff/


Testing
-------

No problem, and seems the drag operation is not affected (if not dragging from link).

test with:
notify-send "<a href="https://google.com">test link</a>"


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130801/24b3bfcf/attachment.html>

From bugzilla_noreply at kde.org  Fri Aug  2 06:00:10 2013
From: bugzilla_noreply at kde.org (bugzilla_noreply at kde.org)
Date: Fri, 02 Aug 2013 06:00:10 +0000
Subject: [KDE Bugtracking System] REMINDER: current Plasma regressions
Message-ID: <E1V58PK-0002iY-Bz@bugs.kde.org>

Please find below a list of the current regressions reported for Plasma. This is a weekly reminder.

  This search was scheduled by myriam at kde.org.


Plasma regressions
------------------
Bug 301424:
  https://bugs.kde.org/show_bug.cgi?id=301424
  Priority: NOR  Severity: normal  Platform: openSUSE RPMs
  Assignee: plasma-bugs at kde.org
    Status: REOPENED
   Summary: Cannot open battery monitor applet if set to hidden in systray
Bug 311354:
  https://bugs.kde.org/show_bug.cgi?id=311354
  Priority: NOR  Severity: normal  Platform: unspecified
  Assignee: plasma-bugs at kde.org
    Status: CONFIRMED
   Summary: System Tray widget can't be resized to fit all icons in one row when added to the desktop


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130802/7526e128/attachment.html>

From sebas at kde.org  Fri Aug  2 13:37:46 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Fri, 02 Aug 2013 15:37:46 +0200
Subject: Add custom first week support to KDE digital clock.
In-Reply-To: <CAGoZsjiRt7D6QMG0u_hw7-PZ8UvzEJ2++Vpkrx5NdBai7s3QUw@mail.gmail.com>
References: <CAGoZsjj-VikaAh5dyFDfqz4tdfSrFXy8ELxBLUwQX_2Kfo7ckA@mail.gmail.com>
 <91612708.EgajKWTZLQ@monet>
 <CAGoZsjiRt7D6QMG0u_hw7-PZ8UvzEJ2++Vpkrx5NdBai7s3QUw@mail.gmail.com>
Message-ID: <1543638.izhrCgAe5k@monet>

Hi Hu Zheng,

Thanks for the patch, and welcome to Plasma development!

On Friday, August 02, 2013 20:01:19 Hu Zheng wrote:
> Here is the custom first week patch. Can anyone add it to the source
> repository?

We use reviewboard to review changes to Plasma source code. This way, we can 
look at the changes in detail, improve things that need fixing, and review for 
example changes in the UI.

Could you post your patch to our Reviewboard instance at 
http://git.reviewboard.kde.org and assign it to the Plasma group?

A good explanation of what your code tries to achieve and how it does that 
helps reviewers to understand the changes. 
As your code introduces visual changes, please also attach screenshots (before 
and after) to the review request. 

Also, a note on our development cycle. kde-workspace is feature-frozen, as we 
move to development of the upcoming version of Plasma. This means that any new 
feature has to target Plasma Workspaces 2, which we intend to release next 
summer.

Kind regards,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From jpwhiting at kde.org  Fri Aug  2 20:14:15 2013
From: jpwhiting at kde.org (Jeremy Whiting)
Date: Fri, 2 Aug 2013 14:14:15 -0600
Subject: Fixing plasma theme removal
Message-ID: <CADWV2K52QUz4Oo1ncP2z4rNforZCL=HO6sjRRHoJa203Hp9fBQ@mail.gmail.com>

Hello,

Today I applied and pushed a fix to make uninstalling from KNS3 for most
cases work again, however https://bugs.kde.org/show_bug.cgi?id=149479 is
still broken for plasma theme uninstallation and here's why:

PlasmaStructure doesn't accept application/x-xz-compressed-tar format files
which 'Helium' theme is. Then plasmapkg -t theme -r filename is failing
since it's actually expecting the name of the theme rather than a plasma
package archive file.  Looking at the plasma-themes.knsrc we use plasmapkg
-t theme -i %f to install which works fine for .xz .gz and such archives,
but then uninstall we use plasmapkg -t theme -r %f with the same filename
and it fails.

So we either need to add a new command to plasmapkg to inspect a plasma
package to get it's name then we could do something like 'plasmapkg -r
`plasmapkg -n %f`' for removals if we added -n to get a plasma package's
name.

This "solution" has a problem though because opening the archives of plasma
themes fails since their metadata.desktop file's are in a subfolder of the
archive.  Even for plasmapkg -i themefile there's a warning saying the
metadata.desktop file wasn't found where it was expected. So we also need
to make plasmapkg extract the KTar directory's sources without the top
level folder, or make PlasmaStructure dive a folder deeper to look for the
metadata.desktop.

Any suggestions on which approach I should take would be greatly
appreciated.

thanks,
Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130802/7c42f1bc/attachment.html>

From huzheng001 at gmail.com  Sat Aug  3 03:32:32 2013
From: huzheng001 at gmail.com (Hu Zheng)
Date: Sat, 03 Aug 2013 03:32:32 -0000
Subject: Review Request 111849: custom first week for plasmaclock.
Message-ID: <20130803033232.19709.65658@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/111849/diff/


Testing
-------

cd kde-workspace-4.10.5/libs/plasmaclock
patch -p1 < customfirstweek.patch

The save configuration codes are not very beautiful, but it works fine!


Thanks,

Hu Zheng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130803/ab852454/attachment.html>

From huzheng001 at gmail.com  Sat Aug  3 03:36:33 2013
From: huzheng001 at gmail.com (Hu Zheng)
Date: Sat, 03 Aug 2013 03:36:33 -0000
Subject: Review Request 111849: custom first week for plasmaclock.
In-Reply-To: <20130803033232.19709.65658@vidsolbach.de>
References: <20130803033232.19709.65658@vidsolbach.de>
Message-ID: <20130803033633.19898.17573@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/
-----------------------------------------------------------

(Updated Aug. 3, 2013, 3:36 a.m.)


Review request for Plasma.


Changes
-------

Add patch.


Description
-------

In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/111849/diff/


Testing
-------

cd kde-workspace-4.10.5/libs/plasmaclock
patch -p1 < customfirstweek.patch

The save configuration codes are not very beautiful, but it works fine!


File Attachments (updated)
----------------

patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch


Thanks,

Hu Zheng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130803/f3a91ac7/attachment.html>

From heena393 at gmail.com  Sat Aug  3 10:02:25 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Sat, 3 Aug 2013 10:02:25 +0000
Subject: dirmodel in plasma-framework
Message-ID: <CAFCfA1_JPqSZpJC_gzZdD5DhRvVe4tXg8=-UHfrnKnfSMh3Heg@mail.gmail.com>

Hi ,
Is dirModel ported to plasma2 ? As when in dirModelplugin.cpp I changed
 qmlRegisterType<DirModel>(uri, 0, 1, "DirModel") to
qmlRegisterType<DirModel>(uri, 2,0,  "DirModel") I am getting an output in
my trashcan plasmoid that url trash:/ can not be listed .However it worked
fine with plasma1 .
Further I want to know how shall I be able to use data engines in plasma2
as window-list requires tasks data engine .
Regards

-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130803/0bf525ab/attachment.html>

From notmart at gmail.com  Sat Aug  3 10:07:29 2013
From: notmart at gmail.com (Marco Martin)
Date: Sat, 3 Aug 2013 12:07:29 +0200
Subject: dirmodel in plasma-framework
In-Reply-To: <CAFCfA1_JPqSZpJC_gzZdD5DhRvVe4tXg8=-UHfrnKnfSMh3Heg@mail.gmail.com>
References: <CAFCfA1_JPqSZpJC_gzZdD5DhRvVe4tXg8=-UHfrnKnfSMh3Heg@mail.gmail.com>
Message-ID: <201308031207.30002.notmart@gmail.com>

On Saturday 03 August 2013, Heena Mahour wrote:
> Hi ,
> Is dirModel ported to plasma2 ? As when in dirModelplugin.cpp I changed
>  qmlRegisterType<DirModel>(uri, 0, 1, "DirModel") to
> qmlRegisterType<DirModel>(uri, 2,0,  "DirModel") I am getting an output in
> my trashcan plasmoid that url trash:/ can not be listed .However it worked
> fine with plasma1 .
> Further I want to know how shall I be able to use data engines in plasma2
> as window-list requires tasks data engine .
> Regards
yes, dirmodel exists 
plasma-framework/src/declarativeimports/dirmodel/
(and yes, changing the version to 2,0 is correct, i forgot that, can you 
push?)

the reason this doesn't work yet, is probably that most kioslaves aren't 
ported yet, so it will need a bit of blind navigation still :/

-- 
Marco Martin

From heena393 at gmail.com  Sat Aug  3 11:41:44 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Sat, 3 Aug 2013 11:41:44 +0000
Subject: dirmodel in plasma-framework
In-Reply-To: <201308031207.30002.notmart@gmail.com>
References: <CAFCfA1_JPqSZpJC_gzZdD5DhRvVe4tXg8=-UHfrnKnfSMh3Heg@mail.gmail.com>
 <201308031207.30002.notmart@gmail.com>
Message-ID: <CAFCfA1-11ZFE2xe=9qVAj3C8FujoCtgu3CptOPcCHRM=njsUrA@mail.gmail.com>

I have pushed it in branch heenamahour/gsoc (plasma-framework)
http://quickgit.kde.org/?p=plasma-framework.git&a=commit&h=18266f3ab78108a3246bac3540cb3aef6f97bbe6
>the reason this doesn't work yet, is probably that most kioslaves aren't
ported yet, so it will need a bit of blind navigation still
So, shall I port the plasma2 plasmoid I ported I guess it will work
completely when plasma-framework will be build completely ?


On Sat, Aug 3, 2013 at 10:07 AM, Marco Martin <notmart at gmail.com> wrote:

> On Saturday 03 August 2013, Heena Mahour wrote:
> > Hi ,
> > Is dirModel ported to plasma2 ? As when in dirModelplugin.cpp I changed
> >  qmlRegisterType<DirModel>(uri, 0, 1, "DirModel") to
> > qmlRegisterType<DirModel>(uri, 2,0,  "DirModel") I am getting an output
> in
> > my trashcan plasmoid that url trash:/ can not be listed .However it
> worked
> > fine with plasma1 .
> > Further I want to know how shall I be able to use data engines in plasma2
> > as window-list requires tasks data engine .
> > Regards
> yes, dirmodel exists
> plasma-framework/src/declarativeimports/dirmodel/
> (and yes, changing the version to 2,0 is correct, i forgot that, can you
> push?)
>
> the reason this doesn't work yet, is probably that most kioslaves aren't
> ported yet, so it will need a bit of blind navigation still :/
>
> --
> Marco Martin
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130803/2f44955a/attachment-0001.html>

From ivan.cukic at kde.org  Sat Aug  3 17:34:32 2013
From: ivan.cukic at kde.org (Ivan =?utf-8?B?xIx1a2nEhw==?=)
Date: Sat, 03 Aug 2013 19:34:32 +0200
Subject: Branch review request
Message-ID: <1967303.8KXXA0zMFk@drako>

Hi all,

I've realized that it will be painful if I wait until everything is finished 
to merge into master, and that there is not much reason for it to be so since 
the master is in a playground mode anyway.

One of the reasons for the request is that I'd like to do a few things in 
parallel to the main work - cleaning up the whole plasma code, use allowed 
levels of C++11 (and the 'spiffy' d-pointers as Aaron called them)...

So, I'm requesting a review of the ivan/shell-switching branch.

There are some things that are removed and should be returned, and there are 
some things that should be removed before the merger:
 - panels (to return after merger, a bit more complex)
 - desktopcorona (to be removed after the panels are added to shellcorona)
 - src/shells folder can be merged into qmlpackages*(1) (and binary parts of 
src/shells removed - those are not needed, but was a good example/test of more 
advanced mechanism that can be achieved - for example, shells providing custom 
components etc.) - this will be greatly simplified very soon!
 - change config names

What works:

(required: git at git.kde.org:scratch/ivan/solidx, 
kde:scratch/ivan/platformcomponents - these should be merged into 
declarativeimports)

Currently, we have two shells - the org.kde.desktop and org.kde.blank. When 
you plug in a touch-screen, the blank one is loaded. And the desktop is loaded 
again when you remove the device.

There is a dbus interface for fake hw:
qdbus org.kde.SolidXTest /FakeInput addDevice fake FakeTouch 2 2
qdbus org.kde.SolidXTest /FakeInput removeDevice fake

Obviously, the loading conditions will be changed when we get more into the 
shell production mode. Now, those are only there for testing purposes.


*(1) Shells folder can be merged with the parts of qmlpackages that are 
concerning shells. What I'd like to do is to move those into a separate folder 
- to be more obvious what is where.

But the problem is that it would mean having src/shells and src/shell as it is 
currently in the branch. What I'd like to have is a following structure:
lib/plasma
lib/declarativeimports
lib/kpart
application (or similar - for plasma-shell - core, app, main, ...)
something/shells
something/qmlpackages
something/plasmapkg (have no idea what 'something' could be)


*(2) The other thing I wanted to ask is can I rename org.kde.desktop to 
org.kde.plasma.desktop?


Cheerio,
Ivan


-- 
I don't really trust a sane person.
  -- Lyle Alzado


From akshay_ratan at yahoo.com  Sat Aug  3 18:10:44 2013
From: akshay_ratan at yahoo.com (Akshay Ratan)
Date: Sat, 03 Aug 2013 18:10:44 -0000
Subject: Review Request 111863: Feature: Folder Preview in Local Pictures
 Browsing
Message-ID: <20130803181044.23880.16241@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111863/
-----------------------------------------------------------

Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Description
-------

Folder Contents(Images) are previewed when we browse the local directories for Pictures.


Diffs
-----

  browsingbackends/localfiles/localpictures/CMakeLists.txt 2acbd59 
  browsingbackends/localfiles/localpictures/localpicturesmodel.h d61f2a3 
  browsingbackends/localfiles/localpictures/localpicturesmodel.cpp afb852f 
  browsingbackends/localfiles/localpictures/localpicturesthumbnailprovider.h PRE-CREATION 
  browsingbackends/localfiles/localpictures/localpicturesthumbnailprovider.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111863/diff/


Testing
-------

Yes. Works fine.


Thanks,

Akshay Ratan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130803/8b906535/attachment.html>

From ivan.cukic at kde.org  Sun Aug  4 06:58:37 2013
From: ivan.cukic at kde.org (=?UTF-8?B?SXZhbiDEjHVracSH?=)
Date: Sun, 4 Aug 2013 08:58:37 +0200
Subject: Branch review request
In-Reply-To: <1967303.8KXXA0zMFk@drako>
References: <1967303.8KXXA0zMFk@drako>
Message-ID: <CAFkAKBzRBeDOV=fuW7F7HrJSGzHPaZccT+35AhRdChH4jLE7ow@mail.gmail.com>

A small addendum - the ivan/shell-switching branch is sufficient - no
need for the scratch repos.

The loaders are quite simplified.

The blank shell behaves like failsafe - it loads xterm application
when shown - don't know how it behaves when  xterm is not installed.

-- 
Cheerio,
Ivan

--
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun

From sebas at kde.org  Sun Aug  4 14:21:27 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Sun, 04 Aug 2013 16:21:27 +0200
Subject: Add custom first week support to KDE digital clock.
In-Reply-To: <CAGoZsjgbyC3tO+hJFc2OkQ=+FHQvnOBOc-093gdYzbOrnor+4w@mail.gmail.com>
References: <CAGoZsjj-VikaAh5dyFDfqz4tdfSrFXy8ELxBLUwQX_2Kfo7ckA@mail.gmail.com>
 <1543638.izhrCgAe5k@monet>
 <CAGoZsjgbyC3tO+hJFc2OkQ=+FHQvnOBOc-093gdYzbOrnor+4w@mail.gmail.com>
Message-ID: <2117394.I5ydiA5Mtz@monet>

Hi Hu Zheng,

On Saturday, August 03, 2013 11:42:22 Hu Zheng wrote:
> Done! See:
> https://git.reviewboard.kde.org/r/111849/

Please submit the patch as patch on reviewboard, not as attachment. That way, 
it can be read easily from the web interface.

Please also attach screenshots of any UI that has been changed.

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From huzheng001 at gmail.com  Fri Aug  2 12:01:19 2013
From: huzheng001 at gmail.com (Hu Zheng)
Date: Fri, 2 Aug 2013 20:01:19 +0800
Subject: Add custom first week support to KDE digital clock.
In-Reply-To: <91612708.EgajKWTZLQ@monet>
References: <CAGoZsjj-VikaAh5dyFDfqz4tdfSrFXy8ELxBLUwQX_2Kfo7ckA@mail.gmail.com>
 <2138507.narW42gxtJ@monet>
 <CAGoZsji+oEaiVFG3BUY+g=YLZ4g0Z80D1KciVgYmUcs0LV9Hgg@mail.gmail.com>
 <91612708.EgajKWTZLQ@monet>
Message-ID: <CAGoZsjiRt7D6QMG0u_hw7-PZ8UvzEJ2++Vpkrx5NdBai7s3QUw@mail.gmail.com>

Here is the custom first week patch. Can anyone add it to the source
repository?

cd kde-workspace-4.10.5/libs/plasmaclock
patch -p1 < customfirstweek.patch

The save configuration codes are not very beautiful, but it works fine!

2013/7/18 Sebastian K?gler <sebas at kde.org>

> On Sunday, July 14, 2013 15:49:04 Hu Zheng wrote:
> > "Now I am not sure what you mean with first week support, maybe you could
> > explain that?"
> > In normal case, the first week is the first week in the year, but the
> > teachers may want to custom the first week, for example, make the 8th
> week
> > as the first week, then the 9th week will be the second week, and so on.
> > Then the teacher can easily do their work as a custom teaching period!
>
> Thanks for the explanation!
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
>



-- 
http://www.huzheng.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130802/a2b82363/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: customfirstweek.patch
Type: application/octet-stream
Size: 12956 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130802/a2b82363/attachment-0001.obj>

From frank78ac at googlemail.com  Fri Aug  2 15:45:58 2013
From: frank78ac at googlemail.com (Frank Reininghaus)
Date: Fri, 2 Aug 2013 17:45:58 +0200
Subject: Unintended changes at community.kde.org?
Message-ID: <CAFoZWWgR66KJ6jH+OW3mMe9B9GUz7auY35mirqpA-86Ez0-K0Q@mail.gmail.com>

Hi everyone,

(please CC me in any replies, I'm not subscribed)

I recently had a look at the Dolphin pages at community.kde.org. We
don't actually use them much - Peter and I mostly used
http://community.kde.org/Dolphin/Dolphin-2.0-Status to list the things
that still needed to be done for the new view engine before the KDE
4.8 release (the page is mostly empty now because the vast majority of
these issues had been resolved a long time ago).

I found out that a certain user 'Cyberhacker' has recently started
adding links to bug reports to the page:

http://community.kde.org/index.php?title=Dolphin/Dolphin-2.0-Status&action=history

It's not hard to guess which bugs.kde.org user 'Cyberhacker' is.

The reason why I'm telling you about this is that he did the same
thing with the "Plasma/Tasks" page:

http://community.kde.org/index.php?title=Plasma/Tasks&action=history

I don't know how much you use that page, but if you do, be aware that
not all content on the page is made by the Plasma team.

Moreover, 'Cyberhacker' has set up this page:

http://community.kde.org/Back_to_basics

which is linked to from the community.kde.org start page with the
comment "Let's make KDE better!" - I'm not sure if we want that.

I wish everyone a nice weekend!

Best regards,
Frank

From huzheng001 at gmail.com  Sat Aug  3 03:42:22 2013
From: huzheng001 at gmail.com (Hu Zheng)
Date: Sat, 3 Aug 2013 11:42:22 +0800
Subject: Add custom first week support to KDE digital clock.
In-Reply-To: <1543638.izhrCgAe5k@monet>
References: <CAGoZsjj-VikaAh5dyFDfqz4tdfSrFXy8ELxBLUwQX_2Kfo7ckA@mail.gmail.com>
 <91612708.EgajKWTZLQ@monet>
 <CAGoZsjiRt7D6QMG0u_hw7-PZ8UvzEJ2++Vpkrx5NdBai7s3QUw@mail.gmail.com>
 <1543638.izhrCgAe5k@monet>
Message-ID: <CAGoZsjgbyC3tO+hJFc2OkQ=+FHQvnOBOc-093gdYzbOrnor+4w@mail.gmail.com>

Done! See:
https://git.reviewboard.kde.org/r/111849/

Thank you very much!


2013/8/2 Sebastian K?gler <sebas at kde.org>

> Hi Hu Zheng,
>
> Thanks for the patch, and welcome to Plasma development!
>
> On Friday, August 02, 2013 20:01:19 Hu Zheng wrote:
> > Here is the custom first week patch. Can anyone add it to the source
> > repository?
>
> We use reviewboard to review changes to Plasma source code. This way, we
> can
> look at the changes in detail, improve things that need fixing, and review
> for
> example changes in the UI.
>
> Could you post your patch to our Reviewboard instance at
> http://git.reviewboard.kde.org and assign it to the Plasma group?
>
> A good explanation of what your code tries to achieve and how it does that
> helps reviewers to understand the changes.
> As your code introduces visual changes, please also attach screenshots
> (before
> and after) to the review request.
>
> Also, a note on our development cycle. kde-workspace is feature-frozen, as
> we
> move to development of the upcoming version of Plasma. This means that any
> new
> feature has to target Plasma Workspaces 2, which we intend to release next
> summer.
>
> Kind regards,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
>



-- 
http://www.huzheng.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130803/149ff8e8/attachment-0001.html>

From akshay_ratan at yahoo.com  Mon Aug  5 16:33:42 2013
From: akshay_ratan at yahoo.com (Akshay Ratan)
Date: Mon, 05 Aug 2013 16:33:42 -0000
Subject: Review Request 111863: Feature: Folder Preview in Local Pictures
 Browsing
In-Reply-To: <20130803181044.23880.16241@vidsolbach.de>
References: <20130803181044.23880.16241@vidsolbach.de>
Message-ID: <20130805163342.31306.78845@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111863/
-----------------------------------------------------------

(Updated Aug. 5, 2013, 4:33 p.m.)


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Changes
-------

Thumbnail Provider class relocated so that now both picturemodel and video model includes and use it :) 
Renaming of the class done and CMakeLists.txt edited accordingly ! 


Description
-------

Folder Contents(Images) are previewed when we browse the local directories for Pictures.


Diffs (updated)
-----

  browsingbackends/localfiles/localpictures/CMakeLists.txt 2acbd59 
  browsingbackends/localfiles/localpictures/localpicturesmodel.h d61f2a3 
  browsingbackends/localfiles/localpictures/localpicturesmodel.cpp afb852f 
  browsingbackends/localfiles/localthumbnailprovider.h PRE-CREATION 
  browsingbackends/localfiles/localthumbnailprovider.cpp PRE-CREATION 
  browsingbackends/localfiles/localvideos/CMakeLists.txt 3cac82c 
  browsingbackends/localfiles/localvideos/localvideosmodel.h 3b4b668 
  browsingbackends/localfiles/localvideos/localvideosmodel.cpp 6bdf386 
  browsingbackends/localfiles/localvideos/localvideothumbnailprovider.h d485b11 
  browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp d666ac4 

Diff: http://git.reviewboard.kde.org/r/111863/diff/


Testing
-------

Yes. Works fine.


Thanks,

Akshay Ratan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130805/67f95820/attachment.html>

From null at kde.org  Mon Aug  5 16:41:09 2013
From: null at kde.org (Commit Hook)
Date: Mon, 05 Aug 2013 16:41:09 -0000
Subject: Review Request 111691: Add KPluginFactory compatible ctor to
 dataengine
In-Reply-To: <20130728232447.10329.98727@vidsolbach.de>
References: <20130728232447.10329.98727@vidsolbach.de>
Message-ID: <20130805164109.31831.53021@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111691/#review37144
-----------------------------------------------------------


This review has been submitted with commit 0368d7423c98c1b9ffcacc16b28dec415d76e8d5 by Sebastian K?gler to branch master.

- Commit Hook


On July 28, 2013, 11:24 p.m., Sebastian K?gler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111691/
> -----------------------------------------------------------
> 
> (Updated July 28, 2013, 11:24 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> This adds back a ctor that is useful for creating a KPluginFactory, which has the metadata baked into the plugin. With corresponding patches to kdelibs, this allows to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. without using KService)
> 
> 
> Diffs
> -----
> 
>   src/plasma/dataengine.h d3baad3 
>   src/plasma/dataengine.cpp a2c68cb 
>   src/plasma/private/dataengine_p.h d8ade83 
> 
> Diff: http://git.reviewboard.kde.org/r/111691/diff/
> 
> 
> Testing
> -------
> 
> Build and loaded plugin, verified metadata is completely inside KPluginInfo
> 
> 
> Thanks,
> 
> Sebastian K?gler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130805/2d875dbb/attachment.html>

From null at kde.org  Mon Aug  5 16:41:12 2013
From: null at kde.org (Commit Hook)
Date: Mon, 05 Aug 2013 16:41:12 -0000
Subject: Review Request 111691: Add KPluginFactory compatible ctor to
 dataengine
In-Reply-To: <20130728232447.10329.98727@vidsolbach.de>
References: <20130728232447.10329.98727@vidsolbach.de>
Message-ID: <20130805164112.31781.36569@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111691/
-----------------------------------------------------------

(Updated Aug. 5, 2013, 4:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Aaron J. Seigo.


Description
-------

This adds back a ctor that is useful for creating a KPluginFactory, which has the metadata baked into the plugin. With corresponding patches to kdelibs, this allows to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. without using KService)


Diffs
-----

  src/plasma/dataengine.h d3baad3 
  src/plasma/dataengine.cpp a2c68cb 
  src/plasma/private/dataengine_p.h d8ade83 

Diff: http://git.reviewboard.kde.org/r/111691/diff/


Testing
-------

Build and loaded plugin, verified metadata is completely inside KPluginInfo


Thanks,

Sebastian K?gler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130805/7eb512fc/attachment.html>

From afiestas at kde.org  Tue Aug  6 07:02:19 2013
From: afiestas at kde.org (=?utf-8?q?=C3=80lex_Fiestas?=)
Date: Tue, 06 Aug 2013 07:02:19 -0000
Subject: Review Request 111899: Make QGuiPlatformPlugin react to
 iconChanges
In-Reply-To: <20130805195129.2180.63646@vidsolbach.de>
References: <20130805195129.2180.63646@vidsolbach.de>
Message-ID: <20130806070219.19310.95079@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111899/
-----------------------------------------------------------

(Updated Aug. 6, 2013, 7:02 a.m.)


Review request for Plasma and Olivier Goffart.


Description
-------

When KDE changes the iconSize, send a StyleChange event to QToolbar and QMainWindow (this one is required for QToolBar that are children of it).


Diffs
-----

  qguiplatformplugin_kde/qguiplatformplugin_kde.cpp cc74dc0 

Diff: http://git.reviewboard.kde.org/r/111899/diff/


Testing
-------

Played a while with assistant, designer and quasselclient, seems to work fine.


Thanks,

?lex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/fbef220a/attachment.html>

From ogoffart at kde.org  Tue Aug  6 08:19:06 2013
From: ogoffart at kde.org (Olivier Goffart)
Date: Tue, 06 Aug 2013 08:19:06 -0000
Subject: Review Request 111899: Make QGuiPlatformPlugin react to
 iconChanges
In-Reply-To: <20130806070219.19310.95079@vidsolbach.de>
References: <20130806070219.19310.95079@vidsolbach.de>
Message-ID: <20130806081906.32398.71237@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111899/#review37191
-----------------------------------------------------------

Ship it!


Ship It!

- Olivier Goffart


On Aug. 6, 2013, 7:02 a.m., ?lex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111899/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 7:02 a.m.)
> 
> 
> Review request for Plasma and Olivier Goffart.
> 
> 
> Description
> -------
> 
> When KDE changes the iconSize, send a StyleChange event to QToolbar and QMainWindow (this one is required for QToolBar that are children of it).
> 
> 
> Diffs
> -----
> 
>   qguiplatformplugin_kde/qguiplatformplugin_kde.cpp cc74dc0 
> 
> Diff: http://git.reviewboard.kde.org/r/111899/diff/
> 
> 
> Testing
> -------
> 
> Played a while with assistant, designer and quasselclient, seems to work fine.
> 
> 
> Thanks,
> 
> ?lex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/ffd759c3/attachment-0001.html>

From notmart at gmail.com  Tue Aug  6 09:51:11 2013
From: notmart at gmail.com (Marco Martin)
Date: Tue, 06 Aug 2013 09:51:11 -0000
Subject: Review Request 111748: Better wrap QMimeData by retaining support
 for QByteArray
In-Reply-To: <20130727184112.22041.90400@vidsolbach.de>
References: <20130727184112.22041.90400@vidsolbach.de>
Message-ID: <20130806095111.12920.35074@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111748/#review37196
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On July 27, 2013, 6:41 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111748/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 6:41 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> DeclarativeMimeData::setData() is QString type, QString data, while QMimeData::setData() is QString type, QByteArray data. The former ends up calling the latter with data.toLatin1().
> 
> I have a need to set a QByteArray payload in the taskbar - X11 WIds, as understood e.g. by pagers.
> 
> The proposed patch changes the DeclarativeMimeData::setData() signature to QString type, QVariant data. The implementation checks whether the QVariant is a byte array, and if so, hands it to the base class implementation. If it's not a byte array, it checks if it can be converted to a QString, and if so, hands the string version's toLatin1() to the base class. If the QVariant is neither a byte array nor convertable to a string, nothing is done.
> 
> This means behavior changes as follows:
> - Byte array support is back.
> - Anything that QVariant knows how to convert to a QString is converted. This maybe subtly different from how QML "casts" to QString, but I think fits the original sentiment of changing the signature to use QString.
> - Non-bytearray/string-convertable data is silently dropped.
> 
> If this patch is accepted, I would like to backport it to KDE/4.11 as well and make use of the improved implementation to restore drag-task-to-pager behavior in the new QML task manager.
> 
> 
> This addresses bug 322567.
>     http://bugs.kde.org/show_bug.cgi?id=322567
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/draganddrop/DeclarativeMimeData.h ec725af 
>   src/declarativeimports/draganddrop/DeclarativeMimeData.cpp e7cab10 
> 
> Diff: http://git.reviewboard.kde.org/r/111748/diff/
> 
> 
> Testing
> -------
> 
> I haven't even built the thing. It's terribad.
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/b116af62/attachment.html>

From null at kde.org  Tue Aug  6 10:01:52 2013
From: null at kde.org (Commit Hook)
Date: Tue, 06 Aug 2013 10:01:52 -0000
Subject: Review Request 111748: Better wrap QMimeData by retaining support
 for QByteArray
In-Reply-To: <20130727184112.22041.90400@vidsolbach.de>
References: <20130727184112.22041.90400@vidsolbach.de>
Message-ID: <20130806100152.14324.3587@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111748/#review37198
-----------------------------------------------------------


This review has been submitted with commit f63357bd29944c777de2954289d9573922fe8222 by Eike Hein to branch master.

- Commit Hook


On July 27, 2013, 6:41 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111748/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 6:41 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> DeclarativeMimeData::setData() is QString type, QString data, while QMimeData::setData() is QString type, QByteArray data. The former ends up calling the latter with data.toLatin1().
> 
> I have a need to set a QByteArray payload in the taskbar - X11 WIds, as understood e.g. by pagers.
> 
> The proposed patch changes the DeclarativeMimeData::setData() signature to QString type, QVariant data. The implementation checks whether the QVariant is a byte array, and if so, hands it to the base class implementation. If it's not a byte array, it checks if it can be converted to a QString, and if so, hands the string version's toLatin1() to the base class. If the QVariant is neither a byte array nor convertable to a string, nothing is done.
> 
> This means behavior changes as follows:
> - Byte array support is back.
> - Anything that QVariant knows how to convert to a QString is converted. This maybe subtly different from how QML "casts" to QString, but I think fits the original sentiment of changing the signature to use QString.
> - Non-bytearray/string-convertable data is silently dropped.
> 
> If this patch is accepted, I would like to backport it to KDE/4.11 as well and make use of the improved implementation to restore drag-task-to-pager behavior in the new QML task manager.
> 
> 
> This addresses bug 322567.
>     http://bugs.kde.org/show_bug.cgi?id=322567
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/draganddrop/DeclarativeMimeData.h ec725af 
>   src/declarativeimports/draganddrop/DeclarativeMimeData.cpp e7cab10 
> 
> Diff: http://git.reviewboard.kde.org/r/111748/diff/
> 
> 
> Testing
> -------
> 
> I haven't even built the thing. It's terribad.
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/6d2dc4b2/attachment.html>

From null at kde.org  Tue Aug  6 10:01:55 2013
From: null at kde.org (Commit Hook)
Date: Tue, 06 Aug 2013 10:01:55 -0000
Subject: Review Request 111748: Better wrap QMimeData by retaining support
 for QByteArray
In-Reply-To: <20130727184112.22041.90400@vidsolbach.de>
References: <20130727184112.22041.90400@vidsolbach.de>
Message-ID: <20130806100155.14607.84206@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111748/
-----------------------------------------------------------

(Updated Aug. 6, 2013, 10:01 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Marco Martin and Sebastian K?gler.


Description
-------

DeclarativeMimeData::setData() is QString type, QString data, while QMimeData::setData() is QString type, QByteArray data. The former ends up calling the latter with data.toLatin1().

I have a need to set a QByteArray payload in the taskbar - X11 WIds, as understood e.g. by pagers.

The proposed patch changes the DeclarativeMimeData::setData() signature to QString type, QVariant data. The implementation checks whether the QVariant is a byte array, and if so, hands it to the base class implementation. If it's not a byte array, it checks if it can be converted to a QString, and if so, hands the string version's toLatin1() to the base class. If the QVariant is neither a byte array nor convertable to a string, nothing is done.

This means behavior changes as follows:
- Byte array support is back.
- Anything that QVariant knows how to convert to a QString is converted. This maybe subtly different from how QML "casts" to QString, but I think fits the original sentiment of changing the signature to use QString.
- Non-bytearray/string-convertable data is silently dropped.

If this patch is accepted, I would like to backport it to KDE/4.11 as well and make use of the improved implementation to restore drag-task-to-pager behavior in the new QML task manager.


This addresses bug 322567.
    http://bugs.kde.org/show_bug.cgi?id=322567


Diffs
-----

  src/declarativeimports/draganddrop/DeclarativeMimeData.h ec725af 
  src/declarativeimports/draganddrop/DeclarativeMimeData.cpp e7cab10 

Diff: http://git.reviewboard.kde.org/r/111748/diff/


Testing
-------

I haven't even built the thing. It's terribad.


Thanks,

Eike Hein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/b2201120/attachment.html>

From ksinny at gmail.com  Tue Aug  6 11:06:35 2013
From: ksinny at gmail.com (Sinny Kumari)
Date: Tue, 06 Aug 2013 11:06:35 -0000
Subject: Review Request 111863: Feature: Folder Preview in Local Pictures
 Browsing
In-Reply-To: <20130805163342.31306.78845@vidsolbach.de>
References: <20130805163342.31306.78845@vidsolbach.de>
Message-ID: <20130806110635.26351.94195@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111863/#review37204
-----------------------------------------------------------



browsingbackends/localfiles/localpictures/localpicturesmodel.cpp
<http://git.reviewboard.kde.org/r/111863/#comment27516>

    I am getting some weird behaviour in browse pictures thumbnails. Now, it doesn't show thumbnail for all pictures http://imgur.com/0hZlaqI . please try to reproduce same because I see similar behaviour at many places. 
    
    Right now, reason for same could be that we are asking thumbnail in this manner for all image files and directories. Directory preview works fine now. So, what I am suggesting is call new way of getting decoration only 
    if MediaCenter::IsExpandableRole role is false i.e for directory else keep previous logic (i.e files) for getting thumbnail of pictures.


- Sinny Kumari


On Aug. 5, 2013, 4:33 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111863/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 4:33 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Folder Contents(Images) are previewed when we browse the local directories for Pictures.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localpictures/CMakeLists.txt 2acbd59 
>   browsingbackends/localfiles/localpictures/localpicturesmodel.h d61f2a3 
>   browsingbackends/localfiles/localpictures/localpicturesmodel.cpp afb852f 
>   browsingbackends/localfiles/localthumbnailprovider.h PRE-CREATION 
>   browsingbackends/localfiles/localthumbnailprovider.cpp PRE-CREATION 
>   browsingbackends/localfiles/localvideos/CMakeLists.txt 3cac82c 
>   browsingbackends/localfiles/localvideos/localvideosmodel.h 3b4b668 
>   browsingbackends/localfiles/localvideos/localvideosmodel.cpp 6bdf386 
>   browsingbackends/localfiles/localvideos/localvideothumbnailprovider.h d485b11 
>   browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp d666ac4 
> 
> Diff: http://git.reviewboard.kde.org/r/111863/diff/
> 
> 
> Testing
> -------
> 
> Yes. Works fine.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/7aa3c545/attachment-0001.html>

From mgraesslin at kde.org  Tue Aug  6 12:25:41 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Tue, 06 Aug 2013 12:25:41 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
Message-ID: <20130806122541.5222.16387@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Description
-------

Add KConfigLoader from Plasma Framework to KConfigGui

The ConfigLoader is way to awesome to not be directly in KConfig.


Diffs
-----

  tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
  tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111908/diff/


Testing
-------


Thanks,

Martin Gr??lin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/c2277f8f/attachment.html>

From david at davidedmundson.co.uk  Tue Aug  6 14:52:16 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Tue, 06 Aug 2013 14:52:16 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130806122541.5222.16387@vidsolbach.de>
References: <20130806122541.5222.16387@vidsolbach.de>
Message-ID: <20130806145216.23350.89021@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37219
-----------------------------------------------------------


As a non-Plasma user of this class, I fully support it being here.



tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27526>

    This looks like it should be const
    
    I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now.



tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27527>

    const?
    See above.



tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27528>

    const?
    See above.


- David Edmundson


On Aug. 6, 2013, 12:25 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 12:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/c4ee1050/attachment.html>

From mgraesslin at kde.org  Tue Aug  6 15:06:16 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Tue, 06 Aug 2013 15:06:16 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130806145216.23350.89021@vidsolbach.de>
References: <20130806145216.23350.89021@vidsolbach.de>
Message-ID: <20130806150616.24530.4213@vidsolbach.de>



> On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.h, line 112
> > <http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112>
> >
> >     This looks like it should be const
> >     
> >     I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now.

please note that I just moved the code over and changed the name from Plasma::ConfigLoader to KConfigLoader. I did not change the code and I think it would be wrong to change the code in the same step. Because of that I drop the three issues, though it would probably make sense to do these changes after this review is merged.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37219
-----------------------------------------------------------


On Aug. 6, 2013, 2:25 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/ec40e1e3/attachment.html>

From aleixpol at kde.org  Tue Aug  6 17:04:54 2013
From: aleixpol at kde.org (Aleix Pol Gonzalez)
Date: Tue, 06 Aug 2013 17:04:54 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130806145216.23350.89021@vidsolbach.de>
References: <20130806145216.23350.89021@vidsolbach.de>
Message-ID: <20130806170454.11233.30914@vidsolbach.de>



> On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.h, line 112
> > <http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112>
> >
> >     This looks like it should be const
> >     
> >     I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now.
> 
> Martin Gr??lin wrote:
>     please note that I just moved the code over and changed the name from Plasma::ConfigLoader to KConfigLoader. I did not change the code and I think it would be wrong to change the code in the same step. Because of that I drop the three issues, though it would probably make sense to do these changes after this review is merged.

Make you can add a comment or warning?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37219
-----------------------------------------------------------


On Aug. 6, 2013, 12:25 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 12:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/641b83e3/attachment-0001.html>

From aacid at kde.org  Tue Aug  6 19:14:03 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Tue, 06 Aug 2013 19:14:03 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130806145216.23350.89021@vidsolbach.de>
References: <20130806145216.23350.89021@vidsolbach.de>
Message-ID: <20130806191403.10113.31308@vidsolbach.de>



> On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.h, line 112
> > <http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112>
> >
> >     This looks like it should be const
> >     
> >     I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now.
> 
> Martin Gr??lin wrote:
>     please note that I just moved the code over and changed the name from Plasma::ConfigLoader to KConfigLoader. I did not change the code and I think it would be wrong to change the code in the same step. Because of that I drop the three issues, though it would probably make sense to do these changes after this review is merged.
> 
> Aleix Pol Gonzalez wrote:
>     Make you can add a comment or warning?

What's the point of this review request if you're not going to accept any review? IOW what are you expecting people to say in this review request?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37219
-----------------------------------------------------------


On Aug. 6, 2013, 12:25 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 12:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/1a206777/attachment.html>

From mgraesslin at kde.org  Wed Aug  7 04:56:08 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Wed, 07 Aug 2013 04:56:08 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130806145216.23350.89021@vidsolbach.de>
References: <20130806145216.23350.89021@vidsolbach.de>
Message-ID: <20130807045608.3438.10599@vidsolbach.de>



> On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.h, line 112
> > <http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112>
> >
> >     This looks like it should be const
> >     
> >     I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now.
> 
> Martin Gr??lin wrote:
>     please note that I just moved the code over and changed the name from Plasma::ConfigLoader to KConfigLoader. I did not change the code and I think it would be wrong to change the code in the same step. Because of that I drop the three issues, though it would probably make sense to do these changes after this review is merged.
> 
> Aleix Pol Gonzalez wrote:
>     Make you can add a comment or warning?
> 
> Albert Astals Cid wrote:
>     What's the point of this review request if you're not going to accept any review? IOW what are you expecting people to say in this review request?

> IOW what are you expecting people to say in this review request?
That it's OK to move the code to this location.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37219
-----------------------------------------------------------


On Aug. 6, 2013, 2:25 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130807/38a6145a/attachment.html>

From mgraesslin at kde.org  Wed Aug  7 06:26:53 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Wed, 07 Aug 2013 06:26:53 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130806145216.23350.89021@vidsolbach.de>
References: <20130806145216.23350.89021@vidsolbach.de>
Message-ID: <20130807062653.2734.70943@vidsolbach.de>



> On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.h, line 112
> > <http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112>
> >
> >     This looks like it should be const
> >     
> >     I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now.
> 
> Martin Gr??lin wrote:
>     please note that I just moved the code over and changed the name from Plasma::ConfigLoader to KConfigLoader. I did not change the code and I think it would be wrong to change the code in the same step. Because of that I drop the three issues, though it would probably make sense to do these changes after this review is merged.
> 
> Aleix Pol Gonzalez wrote:
>     Make you can add a comment or warning?
> 
> Albert Astals Cid wrote:
>     What's the point of this review request if you're not going to accept any review? IOW what are you expecting people to say in this review request?
> 
> Martin Gr??lin wrote:
>     > IOW what are you expecting people to say in this review request?
>     That it's OK to move the code to this location.

or other put: I'm not willing to invest time into doing the changes before I know that it will overall be accepted. Because if it doesn't get accepted the changes David requested should be done to the code in Plasma Frameworks.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37219
-----------------------------------------------------------


On Aug. 6, 2013, 2:25 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130807/3b2ffd4d/attachment-0001.html>

From faure at kde.org  Wed Aug  7 15:41:41 2013
From: faure at kde.org (David Faure)
Date: Wed, 07 Aug 2013 15:41:41 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130806122541.5222.16387@vidsolbach.de>
References: <20130806122541.5222.16387@vidsolbach.de>
Message-ID: <20130807154141.31833.42677@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37284
-----------------------------------------------------------



tier1/kconfig/autotests/kconfigloadertest.cpp
<http://git.reviewboard.kde.org/r/111908/#comment27591>

    I have trouble understanding the purpose of this class. How is this different from
    
    QCOMPARE(configGroup.readEntry("DefaultBoolItem", true), true);
    
    ?
    
    OK the one difference is that the default value comes from the XML file instead of coming from the code, but apart from that?
    
    KConfigXT's entire purpose was to make things statically checked (compile-time), on top of the dynamic (string-based) KConfig. And now this is another layer on top, which makes things dynamic (string-based) again? I'm confused :-)
    
    Ah, is this actually only about introspecting KConfigXT xml files, to extract the defaults from it? But what would be the purpose of that? (isn't this accessible in the KConfigXT-generated code too?)
    
    Please expand the class documentation to make it clear for dummies like me, what is the actual purpose of the class, and in which case it should be used.
    


- David Faure


On Aug. 6, 2013, 12:25 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 12:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130807/f68d4a6d/attachment.html>

From mgraesslin at kde.org  Thu Aug  8 04:58:14 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Thu, 08 Aug 2013 04:58:14 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130807154141.31833.42677@vidsolbach.de>
References: <20130807154141.31833.42677@vidsolbach.de>
Message-ID: <20130808045814.17630.34068@vidsolbach.de>



> On Aug. 7, 2013, 5:41 p.m., David Faure wrote:
> > tier1/kconfig/autotests/kconfigloadertest.cpp, line 56
> > <http://git.reviewboard.kde.org/r/111908/diff/1/?file=176357#file176357line56>
> >
> >     I have trouble understanding the purpose of this class. How is this different from
> >     
> >     QCOMPARE(configGroup.readEntry("DefaultBoolItem", true), true);
> >     
> >     ?
> >     
> >     OK the one difference is that the default value comes from the XML file instead of coming from the code, but apart from that?
> >     
> >     KConfigXT's entire purpose was to make things statically checked (compile-time), on top of the dynamic (string-based) KConfig. And now this is another layer on top, which makes things dynamic (string-based) again? I'm confused :-)
> >     
> >     Ah, is this actually only about introspecting KConfigXT xml files, to extract the defaults from it? But what would be the purpose of that? (isn't this accessible in the KConfigXT-generated code too?)
> >     
> >     Please expand the class documentation to make it clear for dummies like me, what is the actual purpose of the class, and in which case it should be used.
> >

I think it's best explained to think of cases where you don't have any code in the first place. Examples are plasmoids or KWin scripts which just ship a kconfigxt file and a ui file and with the help of the KConfigLoader we are able to provide a working config interface dynamically loaded.

@Aaron: do you have a suggestion on how to improve the documentation?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37284
-----------------------------------------------------------


On Aug. 6, 2013, 2:25 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130808/eb35464d/attachment.html>

From mgraesslin at kde.org  Thu Aug  8 04:58:32 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Thu, 08 Aug 2013 04:58:32 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130806122541.5222.16387@vidsolbach.de>
References: <20130806122541.5222.16387@vidsolbach.de>
Message-ID: <20130808045832.17630.90464@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/
-----------------------------------------------------------

(Updated Aug. 8, 2013, 6:58 a.m.)


Review request for KDE Frameworks, Plasma and Aaron J. Seigo.


Changes
-------

Added Aaron to get some feedback


Description
-------

Add KConfigLoader from Plasma Framework to KConfigGui

The ConfigLoader is way to awesome to not be directly in KConfig.


Diffs
-----

  tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
  tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111908/diff/


Testing
-------


Thanks,

Martin Gr??lin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130808/4af7fda3/attachment.html>

From faure at kde.org  Thu Aug  8 08:23:10 2013
From: faure at kde.org (David Faure)
Date: Thu, 08 Aug 2013 08:23:10 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130807154141.31833.42677@vidsolbach.de>
References: <20130807154141.31833.42677@vidsolbach.de>
Message-ID: <20130808082310.9774.47902@vidsolbach.de>



> On Aug. 7, 2013, 3:41 p.m., David Faure wrote:
> > tier1/kconfig/autotests/kconfigloadertest.cpp, line 56
> > <http://git.reviewboard.kde.org/r/111908/diff/1/?file=176357#file176357line56>
> >
> >     I have trouble understanding the purpose of this class. How is this different from
> >     
> >     QCOMPARE(configGroup.readEntry("DefaultBoolItem", true), true);
> >     
> >     ?
> >     
> >     OK the one difference is that the default value comes from the XML file instead of coming from the code, but apart from that?
> >     
> >     KConfigXT's entire purpose was to make things statically checked (compile-time), on top of the dynamic (string-based) KConfig. And now this is another layer on top, which makes things dynamic (string-based) again? I'm confused :-)
> >     
> >     Ah, is this actually only about introspecting KConfigXT xml files, to extract the defaults from it? But what would be the purpose of that? (isn't this accessible in the KConfigXT-generated code too?)
> >     
> >     Please expand the class documentation to make it clear for dummies like me, what is the actual purpose of the class, and in which case it should be used.
> >
> 
> Martin Gr??lin wrote:
>     I think it's best explained to think of cases where you don't have any code in the first place. Examples are plasmoids or KWin scripts which just ship a kconfigxt file and a ui file and with the help of the KConfigLoader we are able to provide a working config interface dynamically loaded.
>     
>     @Aaron: do you have a suggestion on how to improve the documentation?

Ah, GUI generation, I see. A bit like KConfigDialog then, but you separated the parsing and the UI generation, and you don't need the compile-time generated KCoreConfigSkeleton).

So I was wrong, it's not on top of the KConfigXT-generated code, it's instead of that.

It just seems to me that KConfigLoader alone isn't really useful, but OK, it's a component in the overall architecture.
It definitely needs documentation about what it can be used for, and how.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37284
-----------------------------------------------------------


On Aug. 8, 2013, 4:58 a.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 4:58 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130808/af12ff84/attachment-0001.html>

From mgraesslin at kde.org  Thu Aug  8 12:56:15 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Thu, 08 Aug 2013 12:56:15 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130808045832.17630.90464@vidsolbach.de>
References: <20130808045832.17630.90464@vidsolbach.de>
Message-ID: <20130808125615.32577.31521@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/
-----------------------------------------------------------

(Updated Aug. 8, 2013, 2:56 p.m.)


Review request for KDE Frameworks, Plasma and Aaron J. Seigo.


Changes
-------

Extended the documentation to show how one can use this class.


Description
-------

Add KConfigLoader from Plasma Framework to KConfigGui

The ConfigLoader is way to awesome to not be directly in KConfig.


Diffs (updated)
-----

  tier1/kconfig/autotests/CMakeLists.txt c913da3 
  tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
  tier1/kconfig/src/gui/CMakeLists.txt 0913349 
  tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111908/diff/


Testing
-------


Thanks,

Martin Gr??lin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130808/ba1e7804/attachment.html>

From akshay_ratan at yahoo.com  Thu Aug  8 14:20:18 2013
From: akshay_ratan at yahoo.com (Akshay Ratan)
Date: Thu, 08 Aug 2013 14:20:18 -0000
Subject: Review Request 111863: Feature: Folder Preview in Local Pictures
 Browsing
In-Reply-To: <20130805163342.31306.78845@vidsolbach.de>
References: <20130805163342.31306.78845@vidsolbach.de>
Message-ID: <20130808142018.10951.75987@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111863/
-----------------------------------------------------------

(Updated Aug. 8, 2013, 2:20 p.m.)


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
-------

Fixed the issue which Sinny pointed out about the inability of high resolution pictures to be shown as a thumbnail.

Please test it once again and let me know if there are any changes required before pushing it in the separate branch:: akshay/preview ! 


Description
-------

Folder Contents(Images) are previewed when we browse the local directories for Pictures.


Diffs (updated)
-----

  browsingbackends/localfiles/localpictures/localpicturesmodel.cpp 6a1239c 

Diff: http://git.reviewboard.kde.org/r/111863/diff/


Testing
-------

Yes. Works fine.


Thanks,

Akshay Ratan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130808/51fe4f9e/attachment.html>

From akshay_ratan at yahoo.com  Thu Aug  8 14:30:31 2013
From: akshay_ratan at yahoo.com (Akshay Ratan)
Date: Thu, 08 Aug 2013 14:30:31 -0000
Subject: Review Request 111863: Feature: Folder Preview in Local Pictures
 Browsing
In-Reply-To: <20130808142018.10951.75987@vidsolbach.de>
References: <20130808142018.10951.75987@vidsolbach.de>
Message-ID: <20130808143031.19636.86073@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111863/
-----------------------------------------------------------

(Updated Aug. 8, 2013, 2:30 p.m.)


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
-------

Full diff output for the branch.


Description
-------

Folder Contents(Images) are previewed when we browse the local directories for Pictures.


Diffs (updated)
-----

  browsingbackends/localfiles/localpictures/CMakeLists.txt 2acbd59 
  browsingbackends/localfiles/localpictures/localpicturesmodel.h d61f2a3 
  browsingbackends/localfiles/localpictures/localpicturesmodel.cpp afb852f 
  browsingbackends/localfiles/localthumbnailprovider.h PRE-CREATION 
  browsingbackends/localfiles/localthumbnailprovider.cpp PRE-CREATION 
  browsingbackends/localfiles/localvideos/CMakeLists.txt 3cac82c 
  browsingbackends/localfiles/localvideos/localvideosmodel.h 3b4b668 
  browsingbackends/localfiles/localvideos/localvideosmodel.cpp 6bdf386 
  browsingbackends/localfiles/localvideos/localvideothumbnailprovider.h d485b11 
  browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp d666ac4 

Diff: http://git.reviewboard.kde.org/r/111863/diff/


Testing
-------

Yes. Works fine.


Thanks,

Akshay Ratan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130808/3899f3b5/attachment.html>

From ervin at kde.org  Thu Aug  8 15:51:37 2013
From: ervin at kde.org (Kevin Ottens)
Date: Thu, 08 Aug 2013 15:51:37 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130808125615.32577.31521@vidsolbach.de>
References: <20130808125615.32577.31521@vidsolbach.de>
Message-ID: <20130808155137.2959.79662@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37360
-----------------------------------------------------------


Totally makes sense to have that in KConfigGui. Still the issues raised by David E. should be addressed.


tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27642>

    Should be kconfiggui_export.h since you move it to KConfigGui.



tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27643>

    Should be KCONFIGGUI



tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27644>

    Insert an empty line before that one.


- Kevin Ottens


On Aug. 8, 2013, 12:56 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 12:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt c913da3 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt 0913349 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130808/5f74577a/attachment-0001.html>

From shantanu at kde.org  Thu Aug  8 18:18:41 2013
From: shantanu at kde.org (Shantanu Tushar)
Date: Thu, 08 Aug 2013 18:18:41 -0000
Subject: Review Request 111863: Feature: Folder Preview in Local Pictures
 Browsing
In-Reply-To: <20130808143031.19636.86073@vidsolbach.de>
References: <20130808143031.19636.86073@vidsolbach.de>
Message-ID: <20130808181841.12579.52405@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111863/#review37374
-----------------------------------------------------------

Ship it!


Works fine, just fix the little issues below and push


browsingbackends/localfiles/localpictures/localpicturesmodel.cpp
<http://git.reviewboard.kde.org/r/111863/#comment27652>

    if needs braces {}



browsingbackends/localfiles/localpictures/localpicturesmodel.cpp
<http://git.reviewboard.kde.org/r/111863/#comment27651>

    indentation needs to be fixed


- Shantanu Tushar


On Aug. 8, 2013, 2:30 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111863/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 2:30 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Description
> -------
> 
> Folder Contents(Images) are previewed when we browse the local directories for Pictures.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localpictures/CMakeLists.txt 2acbd59 
>   browsingbackends/localfiles/localpictures/localpicturesmodel.h d61f2a3 
>   browsingbackends/localfiles/localpictures/localpicturesmodel.cpp afb852f 
>   browsingbackends/localfiles/localthumbnailprovider.h PRE-CREATION 
>   browsingbackends/localfiles/localthumbnailprovider.cpp PRE-CREATION 
>   browsingbackends/localfiles/localvideos/CMakeLists.txt 3cac82c 
>   browsingbackends/localfiles/localvideos/localvideosmodel.h 3b4b668 
>   browsingbackends/localfiles/localvideos/localvideosmodel.cpp 6bdf386 
>   browsingbackends/localfiles/localvideos/localvideothumbnailprovider.h d485b11 
>   browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp d666ac4 
> 
> Diff: http://git.reviewboard.kde.org/r/111863/diff/
> 
> 
> Testing
> -------
> 
> Yes. Works fine.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130808/c23829fe/attachment.html>

From mgraesslin at kde.org  Fri Aug  9 05:20:52 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Fri, 09 Aug 2013 05:20:52 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130808125615.32577.31521@vidsolbach.de>
References: <20130808125615.32577.31521@vidsolbach.de>
Message-ID: <20130809052052.7356.99488@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/
-----------------------------------------------------------

(Updated Aug. 9, 2013, 7:20 a.m.)


Review request for KDE Frameworks, Plasma and Aaron J. Seigo.


Changes
-------

fixed the issues outlined by David E. and Kevin


Description
-------

Add KConfigLoader from Plasma Framework to KConfigGui

The ConfigLoader is way to awesome to not be directly in KConfig.


Diffs (updated)
-----

  tier1/kconfig/autotests/CMakeLists.txt c913da3 
  tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
  tier1/kconfig/src/gui/CMakeLists.txt 0913349 
  tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111908/diff/


Testing
-------


Thanks,

Martin Gr??lin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130809/48c10060/attachment.html>

From ervin at kde.org  Fri Aug  9 11:59:40 2013
From: ervin at kde.org (Kevin Ottens)
Date: Fri, 09 Aug 2013 11:59:40 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130809052052.7356.99488@vidsolbach.de>
References: <20130809052052.7356.99488@vidsolbach.de>
Message-ID: <20130809115940.17061.85582@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37410
-----------------------------------------------------------



tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27683>

    Didn't spot it the first time, sorry...
    
    We generally use KConfigGroup by value if I'm not mistaken. So should be a const ref instead of a pointer.


- Kevin Ottens


On Aug. 9, 2013, 5:20 a.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 5:20 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt c913da3 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt 0913349 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130809/830edb26/attachment-0001.html>

From mgraesslin at kde.org  Fri Aug  9 12:09:29 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Fri, 09 Aug 2013 14:09:29 +0200
Subject: Libtaskmanager ported to Qt5/KF5
Message-ID: <6883935.jgcEjcLMyN@martin-thinkpad>

Hi all,

on special request by Eike I looked into porting libtaskmanager to Qt5/KF5. 
And after a surprisingly easy port I just pushed to frameworks-scratch branch 
a commit which enables building of libtaskmanager again.

As a side effect I also had to port ksysguard/processcore.

Obviously I have not tested whether the code works but we should notice soon 
enough when the tasks applet gets ported ;-)

Cheers
Martin

From mgraesslin at kde.org  Fri Aug  9 12:38:15 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Fri, 09 Aug 2013 12:38:15 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130809052052.7356.99488@vidsolbach.de>
References: <20130809052052.7356.99488@vidsolbach.de>
Message-ID: <20130809123815.27040.19018@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/
-----------------------------------------------------------

(Updated Aug. 9, 2013, 2:38 p.m.)


Review request for KDE Frameworks, Plasma and Aaron J. Seigo.


Changes
-------

const ref instead of pointer


Description
-------

Add KConfigLoader from Plasma Framework to KConfigGui

The ConfigLoader is way to awesome to not be directly in KConfig.


Diffs (updated)
-----

  tier1/kconfig/autotests/CMakeLists.txt c913da3 
  tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
  tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
  tier1/kconfig/src/gui/CMakeLists.txt 0913349 
  tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
  tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111908/diff/


Testing
-------


Thanks,

Martin Gr??lin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130809/8cb50dac/attachment.html>

From sebas at kde.org  Fri Aug  9 13:13:14 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Fri, 09 Aug 2013 15:13:14 +0200
Subject: Branch review request
In-Reply-To: <1967303.8KXXA0zMFk@drako>
References: <1967303.8KXXA0zMFk@drako>
Message-ID: <2126645.EOmZGENg7g@miro.vizzzion.net>

On Saturday, August 03, 2013 19:34:32 Ivan ?uki? wrote:
> I've realized that it will be painful if I wait until everything is
> finished  to merge into master, and that there is not much reason for it to
> be so since the master is in a playground mode anyway.
> 
> One of the reasons for the request is that I'd like to do a few things in 
> parallel to the main work - cleaning up the whole plasma code, use allowed 
> levels of C++11 (and the 'spiffy' d-pointers as Aaron called them)...

Some comments:

src/declarativeimports/hardware/:
- this is solid material, Alex wants this in Solid, in fact he wants to make 
Solid "awesome to use from QML". Let's not introduce yet another wrapper that 
we have to maintain, but get it into Solid.

(You know this one, as you're already merging stuff to Solid, good!)

Changes to src/plasma:
- needs proper apidocs, arguments, @since, etc. It would also be nice to tell 
about race conditions, can someone, at any given moment just set another 
package? What is the expected behavior then?

src/platformstatus:
- single line conditional also get curly braces

src/utils:
- A custom d-pointer implementation? This seems like overkill and makes the 
code a lot less readable. Just remove this and use a QScopedPointer?


> *(2) The other thing I wanted to ask is can I rename org.kde.desktop to 
> org.kde.plasma.desktop?

How about org.kde.desktopshell? That would make it clearer what it is compared 
to containments.

This is not a full review, but some points that need addressing anyway.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From ivan.cukic at kde.org  Fri Aug  9 13:30:08 2013
From: ivan.cukic at kde.org (=?UTF-8?B?SXZhbiDEjHVracSH?=)
Date: Fri, 9 Aug 2013 15:30:08 +0200
Subject: Branch review request
In-Reply-To: <2126645.EOmZGENg7g@miro.vizzzion.net>
References: <1967303.8KXXA0zMFk@drako> <2126645.EOmZGENg7g@miro.vizzzion.net>
Message-ID: <CAFkAKBwFRjkE-Nj3i7nWuYvdv2Yo3UP13hLot=Ptd07C9k+peA@mail.gmail.com>

> - A custom d-pointer implementation? This seems like overkill and

To quote Aaron:
"would love to see all the dptrs move to your spiffy d_ptr smart
pointer as well."
after this blog post of mine:
http://ivan.fomentgroup.org/blog/2013/06/22/d-ptr-the-modern-way/

>> *(2) The other thing I wanted to ask is can I rename org.kde.desktop to
>> org.kde.plasma.desktop?
>
> How about org.kde.desktopshell? That would make it clearer what

Ok, though I wanted it to say plasma to advertise the project of kde
it belongs to.

From sebas at kde.org  Fri Aug  9 13:33:57 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Fri, 09 Aug 2013 15:33:57 +0200
Subject: Branch review request
In-Reply-To: <CAFkAKBwFRjkE-Nj3i7nWuYvdv2Yo3UP13hLot=Ptd07C9k+peA@mail.gmail.com>
References: <1967303.8KXXA0zMFk@drako> <2126645.EOmZGENg7g@miro.vizzzion.net>
 <CAFkAKBwFRjkE-Nj3i7nWuYvdv2Yo3UP13hLot=Ptd07C9k+peA@mail.gmail.com>
Message-ID: <7040054.vGMVU3JldC@miro.vizzzion.net>

On Friday, August 09, 2013 15:30:08 Ivan ?uki? wrote:
> > - A custom d-pointer implementation? This seems like overkill and
> 
> To quote Aaron:
> "would love to see all the dptrs move to your spiffy d_ptr smart
> pointer as well."
> after this blog post of mine:
> http://ivan.fomentgroup.org/blog/2013/06/22/d-ptr-the-modern-way/

It doesn't belong into plasma-framework, and you didn't answer my "why not 
QScopedPointer" question. :)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From sebas at kde.org  Fri Aug  9 13:34:28 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Fri, 09 Aug 2013 15:34:28 +0200
Subject: Libtaskmanager ported to Qt5/KF5
In-Reply-To: <6883935.jgcEjcLMyN@martin-thinkpad>
References: <6883935.jgcEjcLMyN@martin-thinkpad>
Message-ID: <1467844.N4HGVqxSQ5@miro.vizzzion.net>

On Friday, August 09, 2013 14:09:29 Martin Graesslin wrote:
> on special request by Eike I looked into porting libtaskmanager to Qt5/KF5. 
> And after a surprisingly easy port I just pushed to frameworks-scratch
> branch a commit which enables building of libtaskmanager again.
> 
> As a side effect I also had to port ksysguard/processcore.
> 
> Obviously I have not tested whether the code works but we should notice
> soon  enough when the tasks applet gets ported

Rocking! Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From ivan.cukic at kde.org  Fri Aug  9 13:49:33 2013
From: ivan.cukic at kde.org (=?UTF-8?B?SXZhbiDEjHVracSH?=)
Date: Fri, 9 Aug 2013 15:49:33 +0200
Subject: Branch review request
In-Reply-To: <7040054.vGMVU3JldC@miro.vizzzion.net>
References: <1967303.8KXXA0zMFk@drako> <2126645.EOmZGENg7g@miro.vizzzion.net>
 <CAFkAKBwFRjkE-Nj3i7nWuYvdv2Yo3UP13hLot=Ptd07C9k+peA@mail.gmail.com>
 <7040054.vGMVU3JldC@miro.vizzzion.net>
Message-ID: <CAFkAKBxQQDObVEnjJXVLvrqbvYeA+kxSwi+4HU_U8R4=PdJNzQ@mail.gmail.com>

> It doesn't belong into plasma-framework,

The original mail *was* about plasma-framework - the thread was
started when Kevin removed the add_definitions("-std=c++0x") from the
repo's top CMakeLists.txt
http://mail.kde.org/pipermail/plasma-devel/2013-June/025747.html

> and you didn't answer my "why not
> QScopedPointer" question. :)

It is not really about QSP or unique_ptr - they /can/ be used directly
for this. They don't have the same features though (btw, the
implementation does use unique_ptr in the back)

Features
- if SomeClass::Private has a no-argument constructor, you don't need
to initialize it at all
  SomeClass::SomeClass()
     // This:
     // : d(new Private())
     // becomes this:

  {

  }

- if it has arguments, for example Private(int, int)
  SomeClass::SomeClass()
     // This:
     // : d(new Private(2,3))
     // becomes:
     : d(2,3)
   {
   }

 - it is safe. You can't not accidentally screw up the pointer it
points to. You can't accidentally access the raw pointer. You can not
delete it etc. (the only way to access the raw pointer is to use
operator->() - and you can not do that accidentally :) )

  - it ensures that it points to something, you can not leave it empty
by accident.

So, in the same way QSP and u_p are improvements over a raw pointer,
this is an improvement over them - for *this* use-case - it is
tailored for this use-case.

-- 
Cheerio,
Ivan

--
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun

From ivan.cukic at kde.org  Fri Aug  9 13:51:32 2013
From: ivan.cukic at kde.org (=?UTF-8?B?SXZhbiDEjHVracSH?=)
Date: Fri, 9 Aug 2013 15:51:32 +0200
Subject: Branch review request
In-Reply-To: <CAFkAKBxQQDObVEnjJXVLvrqbvYeA+kxSwi+4HU_U8R4=PdJNzQ@mail.gmail.com>
References: <1967303.8KXXA0zMFk@drako> <2126645.EOmZGENg7g@miro.vizzzion.net>
 <CAFkAKBwFRjkE-Nj3i7nWuYvdv2Yo3UP13hLot=Ptd07C9k+peA@mail.gmail.com>
 <7040054.vGMVU3JldC@miro.vizzzion.net>
 <CAFkAKBxQQDObVEnjJXVLvrqbvYeA+kxSwi+4HU_U8R4=PdJNzQ@mail.gmail.com>
Message-ID: <CAFkAKBwA9CKA=pHr6+bjwVLmjG0jfDVR8BMT9=uWuX3UjDEYJw@mail.gmail.com>

p.s. I'm a bit of a safe-coding buff lately - if something removes
potential "stupid bugs" and doesn't introduce a performance overhead -
I'm all into it (like for vs foreach and similar).

From sebas at kde.org  Fri Aug  9 13:53:20 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Fri, 09 Aug 2013 15:53:20 +0200
Subject: Branch review request
In-Reply-To: <CAFkAKBxQQDObVEnjJXVLvrqbvYeA+kxSwi+4HU_U8R4=PdJNzQ@mail.gmail.com>
References: <1967303.8KXXA0zMFk@drako> <7040054.vGMVU3JldC@miro.vizzzion.net>
 <CAFkAKBxQQDObVEnjJXVLvrqbvYeA+kxSwi+4HU_U8R4=PdJNzQ@mail.gmail.com>
Message-ID: <1446809.3aKeaM8MNn@miro.vizzzion.net>

On Friday, August 09, 2013 15:49:33 Ivan ?uki? wrote:
> > It doesn't belong into plasma-framework,
> 
> The original mail *was* about plasma-framework - the thread was
> started when Kevin removed the add_definitions("-std=c++0x") from the
> repo's top CMakeLists.txt
> http://mail.kde.org/pipermail/plasma-devel/2013-June/025747.html

Well, my point is that this is too low level (or generally applicable if you 
wish :P) for plasma-framework.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From bruce.oy at gmail.com  Fri Aug  9 14:22:34 2013
From: bruce.oy at gmail.com (Bruce Ouyang)
Date: Fri, 09 Aug 2013 22:22:34 +0800
Subject: how to draw a transparent / semi-transparent area in plasma-qml
 =?iso-8859-1?Q?=3F?=
Message-ID: <d0aa4350-6b9b-44b1-8138-1b6a0c23b172@gmail.com>

i have tried rectrangle with opacity:0.5 and color:"transparent", but this doesn't work.
looking forward for your reply!
thanks advance!

From heena393 at gmail.com  Fri Aug  9 14:29:44 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Fri, 9 Aug 2013 14:29:44 +0000
Subject: how to draw a transparent / semi-transparent area in plasma-qml ?
In-Reply-To: <d0aa4350-6b9b-44b1-8138-1b6a0c23b172@gmail.com>
References: <d0aa4350-6b9b-44b1-8138-1b6a0c23b172@gmail.com>
Message-ID: <CAFCfA1-9oT+eBvojA_UCV+vzCgxoL5Kh8sB1WxvOzW+4bAz9QA@mail.gmail.com>

Ahem , no use of transparent rectangles ,we don't do that way.Anyways you
can play with opacity by behaviour on opacity also .
Regards



On Fri, Aug 9, 2013 at 2:22 PM, Bruce Ouyang <bruce.oy at gmail.com> wrote:

> i have tried rectrangle with opacity:0.5 and color:"transparent", but this
> doesn't work.
> looking forward for your reply!
> thanks advance!
> ______________________________**_________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/**listinfo/plasma-devel<https://mail.kde.org/mailman/listinfo/plasma-devel>
>



-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130809/f285d224/attachment.html>

From dantti12 at gmail.com  Fri Aug  9 14:31:15 2013
From: dantti12 at gmail.com (Daniel Nicoletti)
Date: Fri, 9 Aug 2013 11:31:15 -0300
Subject: how to draw a transparent / semi-transparent area in plasma-qml ?
In-Reply-To: <d0aa4350-6b9b-44b1-8138-1b6a0c23b172@gmail.com>
References: <d0aa4350-6b9b-44b1-8138-1b6a0c23b172@gmail.com>
Message-ID: <CACo8zOdtYuUVxu-Tvk0+-duBqNY7yFZFGYfHZGZJ8qADmbdKoA@mail.gmail.com>

a rectangle with color: "transparent" will be fully transparent
regardless of it's opacity,
though the opacity will be applied to all of it's children.
if you want something semi-transparent you can try color: "white" and
opacity: 0.5

2013/8/9 Bruce Ouyang <bruce.oy at gmail.com>:
> i have tried rectrangle with opacity:0.5 and color:"transparent", but this
> doesn't work.
> looking forward for your reply!
> thanks advance!
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel



-- 
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com

From sebas at kde.org  Fri Aug  9 14:43:45 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Fri, 09 Aug 2013 16:43:45 +0200
Subject: how to draw a transparent / semi-transparent area in plasma-qml ?
In-Reply-To: <d0aa4350-6b9b-44b1-8138-1b6a0c23b172@gmail.com>
References: <d0aa4350-6b9b-44b1-8138-1b6a0c23b172@gmail.com>
Message-ID: <2553544.EAUeI0L01O@miro.vizzzion.net>

On Friday, August 09, 2013 22:22:34 Bruce Ouyang wrote:
> i have tried rectrangle with opacity:0.5 and color:"transparent", but this
> doesn't work. looking forward for your reply!

If you could explain your usecase a bit more detailed, that'd help.

Otherwise, from the little info you give, PlasmaComponents.Highlight might be 
what you're looking for.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From david at davidedmundson.co.uk  Fri Aug  9 14:55:21 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 09 Aug 2013 14:55:21 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130809123815.27040.19018@vidsolbach.de>
References: <20130809123815.27040.19018@vidsolbach.de>
Message-ID: <20130809145521.13568.69836@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37413
-----------------------------------------------------------



tier1/kconfig/src/gui/kconfigloader.cpp
<http://git.reviewboard.kde.org/r/111908/#comment27684>

    This would be best with use of QLatin1String() thoughout this file. 
    
    


- David Edmundson


On Aug. 9, 2013, 12:38 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt c913da3 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt 0913349 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130809/c46da026/attachment.html>

From kde at privat.broulik.de  Fri Aug  9 15:04:29 2013
From: kde at privat.broulik.de (Kai Uwe Broulik)
Date: Fri, 09 Aug 2013 15:04:29 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130809145521.13568.69836@vidsolbach.de>
References: <20130809145521.13568.69836@vidsolbach.de>
Message-ID: <20130809150429.23997.73144@vidsolbach.de>



> On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.cpp, line 65
> > <http://git.reviewboard.kde.org/r/111908/diff/3/?file=177535#file177535line65>
> >
> >     This would be best with use of QLatin1String() thoughout this file. 
> >     
> >

QStringLiteral?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37413
-----------------------------------------------------------


On Aug. 9, 2013, 12:38 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt c913da3 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt 0913349 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130809/0ba9111a/attachment.html>

From david at davidedmundson.co.uk  Fri Aug  9 15:07:38 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 09 Aug 2013 15:07:38 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130809145521.13568.69836@vidsolbach.de>
References: <20130809145521.13568.69836@vidsolbach.de>
Message-ID: <20130809150738.27181.33488@vidsolbach.de>



> On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.cpp, line 65
> > <http://git.reviewboard.kde.org/r/111908/diff/3/?file=177535#file177535line65>
> >
> >     This would be best with use of QLatin1String() thoughout this file. 
> >     
> >
> 
> Kai Uwe Broulik wrote:
>     QStringLiteral?

No,  here we are only comparing a QString with a char* so we want to avoid creating a QString object and copying all the text just to do == on it.

QStringLiteral is for when you know you want to make a QString object at some point in the future.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37413
-----------------------------------------------------------


On Aug. 9, 2013, 12:38 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt c913da3 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt 0913349 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130809/41b1b0d3/attachment-0001.html>

From david at davidedmundson.co.uk  Fri Aug  9 15:08:33 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 09 Aug 2013 15:08:33 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130809145521.13568.69836@vidsolbach.de>
References: <20130809145521.13568.69836@vidsolbach.de>
Message-ID: <20130809150833.31694.22290@vidsolbach.de>



> On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.cpp, line 65
> > <http://git.reviewboard.kde.org/r/111908/diff/3/?file=177535#file177535line65>
> >
> >     This would be best with use of QLatin1String() thoughout this file. 
> >     
> >
> 
> Kai Uwe Broulik wrote:
>     QStringLiteral?
> 
> David Edmundson wrote:
>     No,  here we are only comparing a QString with a char* so we want to avoid creating a QString object and copying all the text just to do == on it.
>     
>     QStringLiteral is for when you know you want to make a QString object at some point in the future.

Edit: I'm happy with this being done after it's merged. No need to hold things up.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37413
-----------------------------------------------------------


On Aug. 9, 2013, 12:38 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt c913da3 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt 0913349 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130809/52521de2/attachment.html>

From faure at kde.org  Fri Aug  9 19:27:23 2013
From: faure at kde.org (David Faure)
Date: Fri, 09 Aug 2013 19:27:23 -0000
Subject: Review Request 111908: Add KConfigLoader from Plasma Framework to
 KConfigGui
In-Reply-To: <20130809123815.27040.19018@vidsolbach.de>
References: <20130809123815.27040.19018@vidsolbach.de>
Message-ID: <20130809192723.16448.12501@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37445
-----------------------------------------------------------



tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27699>

    I wonder if this should really derive from KConfigSkeleton, rather than encapsulate it.
    
    For instance it means you can't get a "core only" version of it (see KCoreConfigSkeleton).
    
    It doesn't reimplement any virtual methods, so this inheritance seems unnecessary. On the other hand I'm not sure how it would work by composition anyway; maybe the caller would have to create it themselves (which would be a bit cumbersome?).
    
    The use of QColor in the code makes core/gui separation difficult anyway, it would need to be provided by a runtime hook.
    
    Just an idea.
    Don't know how much core/gui separation is useful for this class.


- David Faure


On Aug. 9, 2013, 12:38 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt c913da3 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt 0913349 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130809/f0d73495/attachment.html>

From sebas at kde.org  Fri Aug  9 23:28:26 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Sat, 10 Aug 2013 01:28:26 +0200
Subject: Libtaskmanager ported to Qt5/KF5
In-Reply-To: <6883935.jgcEjcLMyN@martin-thinkpad>
References: <6883935.jgcEjcLMyN@martin-thinkpad>
Message-ID: <1543323.eP51yocMUY@monet>

On Friday, August 09, 2013 14:09:29 Martin Graesslin wrote:
> on special request by Eike I looked into porting libtaskmanager to Qt5/KF5. 
> And after a surprisingly easy port I just pushed to frameworks-scratch
> branch a commit which enables building of libtaskmanager again.
> 
> As a side effect I also had to port ksysguard/processcore.
> 
> Obviously I have not tested whether the code works but we should notice
> soon  enough when the tasks applet gets ported ;-)

.. or the tasks dataengine. :) I've just ported it, it builds, loads, reacts 
to "virtualDesktops", but not to "tasks". I haven't looked into it in more 
detail, but we can debug this from here, as plasmaengineexplorer is also 
ported (in plasmate[frameworks-scratch]).

Progress!
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From hein at kde.org  Sat Aug 10 00:13:56 2013
From: hein at kde.org (Eike Hein)
Date: Sat, 10 Aug 2013 02:13:56 +0200
Subject: Libtaskmanager ported to Qt5/KF5
In-Reply-To: <6883935.jgcEjcLMyN@martin-thinkpad>
References: <6883935.jgcEjcLMyN@martin-thinkpad>
Message-ID: <1513590.TuRnP4SBVJ@ehm1.ehn>

On Friday 09 August 2013 14:09:29 you wrote:
> Hi all,
> 
> on special request by Eike I looked into porting libtaskmanager to Qt5/KF5.
> And after a surprisingly easy port I just pushed to frameworks-scratch
> branch a commit which enables building of libtaskmanager again.

Thanks :)

Nice to hear it was that easy - I had hoped as much, there's
not really that much Xlib usage in there, but since you were
doing xcb porting on kwin already I figured it made sense to
tap into that knowledge :).


Cheers,
Eike

From null at kde.org  Sat Aug 10 13:10:22 2013
From: null at kde.org (Commit Hook)
Date: Sat, 10 Aug 2013 13:10:22 -0000
Subject: Review Request 110467: Plasma Wallpaper BackgroundListModel:
 Avoid using KFileMetaInfo
In-Reply-To: <20130517180300.28244.6876@vidsolbach.de>
References: <20130517180300.28244.6876@vidsolbach.de>
Message-ID: <20130810131022.11157.85938@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110467/#review37461
-----------------------------------------------------------


This review has been submitted with commit 13ebf3c4a2f47827d54f61a19b30cfe49b127ad4 by Hrvoje Senjan on behalf of Vishesh Handa to branch frameworks-scratch.

- Commit Hook


On May 17, 2013, 6:02 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110467/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 6:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
>     Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo
>     
>     1. The Xesam width and height properties are never returned by strigi
>     and haven't been returned for a very very long time. It currently
>     returns the nfo:width and nfo:height property instead.
>     
>     2. KFileMetadataWidget is blocking and blocks while it is calculating
>     the height and width. It is better to open the file and calculate it in
>     another thread as done by the ImageSizeFinder
>     
>     3. QImage in more reliable and actively maintained in contrast to
>     strigi.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/wallpapers/image/backgroundlistmodel.cpp c4093a7 
> 
> Diff: http://git.reviewboard.kde.org/r/110467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130810/235056d7/attachment.html>

From sebas at kde.org  Sun Aug 11 10:39:56 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Sun, 11 Aug 2013 12:39:56 +0200
Subject: Review Request 111992: Activity bar in QML.
In-Reply-To: <20130810171855.9101.84068@vidsolbach.de>
References: <20130810170400.7039.54207@vidsolbach.de>
 <20130810171855.9101.84068@vidsolbach.de>
Message-ID: <1842169.LUNnsqFlyY@miro.vizzzion.net>

Hi Bhushan,

[The right list for this discussion is plasma-devel at kde.org, I'm CC:ing this 
list, let's move the discussion there.]

On Saturday, August 10, 2013 17:18:55 Bhushan Shah wrote:
> Yes! I am showing all activities because if someone wants to switch to
> activity which is not running then he/she have to do it from activity
> manager. That don't make sense to me..

We usually do not just remove features, because we don't understand them. In 
the case of the activity bar, I can easily enlighten you, as I'm using it, and 
I'm relying on exactly that feature of not showing stopped activities. Likely, 
there are many others in the same situation.

I have about 20 Activities configured on this system, I usually use 2 to 3. 
The rest are all rather specific that I might use for a couple of days, and 
then will not use for weeks or months. Having to scan 20 items every time I 
switch between activities would make this very cumbersome.

Our usual and proven approach to porting widgets to QML is to port them 
feature-by-feature, wether we like and understand a feature, or we don't -- 
it's not about our understanding or preferences, it's about what is useful to 
the user.

Adding this "only show running Activities" back in is therefore essential for 
merging this widget.

There is another catch, however. kde-workspace 4.x is frozen, we are moving 
development to the new, Plasma 2 version. Now porting a widget to QML is a 
good intermediate step, from there it will be quite easy to port it to 
QtQuick2 and Plasma 2, but I thought I'd tell nevertheless.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From bhush94 at gmail.com  Sun Aug 11 10:59:42 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sun, 11 Aug 2013 16:29:42 +0530
Subject: Fwd: Review Request 111992: Activity bar in QML.
In-Reply-To: <CAGPcNU2_0EtReJpvJd_RZN9LMQianUU5Jz+9dJcdF_DcPTMKEg@mail.gmail.com>
References: <20130810170400.7039.54207@vidsolbach.de>
 <20130810171855.9101.84068@vidsolbach.de>
 <1842169.LUNnsqFlyY@miro.vizzzion.net>
 <CAGPcNU2_0EtReJpvJd_RZN9LMQianUU5Jz+9dJcdF_DcPTMKEg@mail.gmail.com>
Message-ID: <CAGPcNU2Vs1ugRxPTu0hFdQqkr5RKmKhAkm7ab1zShLdye6Y8Og@mail.gmail.com>

Hello,

On Sun, Aug 11, 2013 at 4:09 PM, Sebastian K?gler <sebas at kde.org> wrote:

> I have about 20 Activities configured on this system, I usually use 2 to 3.
> The rest are all rather specific that I might use for a couple of days, and
> then will not use for weeks or months. Having to scan 20 items every time I
> switch between activities would make this very cumbersome.
>

If that's user case then I am happy to use SortFilterModel instead of the
DataModel, Later we can add configuration option "Show all activities".

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130811/859cbcbf/attachment.html>

From heena393 at gmail.com  Sun Aug 11 15:02:31 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Sun, 11 Aug 2013 15:02:31 +0000
Subject: Libtaskmanager ported to Qt5/KF5
In-Reply-To: <1513590.TuRnP4SBVJ@ehm1.ehn>
References: <6883935.jgcEjcLMyN@martin-thinkpad> <1513590.TuRnP4SBVJ@ehm1.ehn>
Message-ID: <CAFCfA1_+=b40tHv1z-NwP-DeOnu3rbEJFL9DuR+cv5y3BmKcaw@mail.gmail.com>

Hi,
Does that mean now window-list can be ported to plasma2 (it requires tasks
data engine)..?
Regards


On Sat, Aug 10, 2013 at 12:13 AM, Eike Hein <hein at kde.org> wrote:

> On Friday 09 August 2013 14:09:29 you wrote:
> > Hi all,
> >
> > on special request by Eike I looked into porting libtaskmanager to
> Qt5/KF5.
> > And after a surprisingly easy port I just pushed to frameworks-scratch
> > branch a commit which enables building of libtaskmanager again.
>
> Thanks :)
>
> Nice to hear it was that easy - I had hoped as much, there's
> not really that much Xlib usage in there, but since you were
> doing xcb porting on kwin already I figured it made sense to
> tap into that knowledge :).
>
>
> Cheers,
> Eike
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130811/dcda14fd/attachment.html>

From esken at kde.org  Sun Aug 11 21:58:50 2013
From: esken at kde.org (Christian Esken)
Date: Sun, 11 Aug 2013 21:58:50 -0000
Subject: Review Request 6928: KMix Declarative Applet - First attempt
In-Reply-To: <20130726223042.16841.14778@vidsolbach.de>
References: <20130726223042.16841.14778@vidsolbach.de>
Message-ID: <20130811215850.28467.4923@vidsolbach.de>



> On July 26, 2013, 10:30 p.m., Christian Esken wrote:
> > I have not followed this request, but it looks like I have not receieved any followups on my last comment. I would like to know what to do with this review request. Diego, Igor? Diego, are you still following up on this. Care to contact Igor?
> 
> Diego Casella wrote:
>     Hi Christian, after hearing that someone else was working on it, I left the development of that plasmoid; I didnt' want to step over Igor's work.
>     Anyway, by looking at the current kmix status, it's still missing the conversion to a full kded service: otherwise there will be two entries in the tray: the "old" kmix, and its plasmoid counterpart. We also need to extend its dbus interface and add a method to pop-up the full kmix gui: in that way, the plasmoid can show the user interface, allowing the end-user to configure kmix properly.
>     As soon as those changes will be peformed (if you agree with it of course, and if you want to implement the new kmix as a qml plasmoid), I'd be happy to continue what I did so far :)

Commenting on:
   "if you want to implement the new kmix as a qml plasmoid"

Well, I have no knowledge in QML and no desire to learn it. If you still want to do so - focussing on the tray popup/plasmoid - then it should be much more functional than your prototype - especially: supporting multiple controls, adding Media player control like in todays KMix.
The KMix Mainwindow will surely always stay a normal application, everything else is a complete new application.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6928/#review11062
-----------------------------------------------------------


On March 28, 2012, 6:49 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6928/
> -----------------------------------------------------------
> 
> (Updated March 28, 2012, 6:49 p.m.)
> 
> 
> Review request for Plasma, Aaron Seigo, Christian Esken, and Marco Martin.
> 
> 
> Description
> -------
> 
> First attempt of making a declarative kmix applet for plasma.
> What the apple does right now:
> * modifies the volume level and the mute/unmute status of the master channel;
> * reacts to changes of the volume level/status (i.e. made with multimedia keys);
> * disables the slider if the channel gets muted, and enables it back as soon as the channel gets unmuted;
> * collapses gracefully in a popup icon when placed inside the panel.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdemultimedia/kmix/plasma/CMakeLists.txt 1287513 
>   trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/VerticalControl.qml PRE-CREATION 
>   trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/kmixapplet.qml PRE-CREATION 
>   trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/metadata.desktop PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6928/diff/
> 
> 
> Testing
> -------
> 
> Tested against r1287510. For basic audio management it works great imho.
> 
> However, there is a lot of room for improvements, but this is gonna need some extra work outside the kmix applet scope:
> * first of all, the applet need kmix executable to run in order to perform the dbus calls. You can of course disable KMix tray icon feature but, at every login, KMix mainwindow will be shown and the user must closeby hand. This is a kind of ugly behavior that should be avoided;
> * it will be great to great to add an action to allow the user to select the master channel (by reusing KMix "Select Master Channel" widget), but this will require tweaking KMix dbus interface;
> * as you noticed in the screenshots, the applet in the panel and in the desktop have different size even if it __is__ actually the same: something is going wrong when plasma shows the PopupApplet. This behavior was even worse when I started implementing a "flip" action to change the layout from horizontal to vertical and vice-versa, and for this reason I gave up and simply stick with the vertical layout.
> 
> Could this applet be shipped in the current status, or should we wait for all the aforementioned improvements?
> Comments/ideas/suggestions?
> 
> Cheers :)
> 
> 
> Screenshots
> -----------
> 
> Applet look in panel and desktop
>   http://svn.reviewboard.kde.org/r/6928/s/627/
> Applet look in panel and desktop - audio muted
>   http://svn.reviewboard.kde.org/r/6928/s/628/
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130811/4c2e1258/attachment.html>

From sebas at kde.org  Sun Aug 11 22:11:35 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Mon, 12 Aug 2013 00:11:35 +0200
Subject: Libtaskmanager ported to Qt5/KF5
In-Reply-To: <CAFCfA1_+=b40tHv1z-NwP-DeOnu3rbEJFL9DuR+cv5y3BmKcaw@mail.gmail.com>
References: <6883935.jgcEjcLMyN@martin-thinkpad> <1513590.TuRnP4SBVJ@ehm1.ehn>
 <CAFCfA1_+=b40tHv1z-NwP-DeOnu3rbEJFL9DuR+cv5y3BmKcaw@mail.gmail.com>
Message-ID: <7142615.YVMgdT9dZB@monet>

On Sunday, August 11, 2013 15:02:31 Heena Mahour wrote:
> Does that mean now window-list can be ported to plasma2 (it requires tasks
> data engine)..?

Yes, at least as far as the tasks engine in Plasma 2 works, I think it 
doesn't. (That'd then be the first thing to fix.)

For this you need kdelibs[frameworks], plasma-framework[master] and kde-
workspace[frameworks-scratch], optionally (two more wallpaper plugins) 
kdeplasma-addons[frameworks-scratch] and plasma[frameworks-scratch] for the 
engineexplorer.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From sebas at kde.org  Sun Aug 11 22:11:52 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Mon, 12 Aug 2013 00:11:52 +0200
Subject: Fwd: Review Request 111992: Activity bar in QML.
In-Reply-To: <CAGPcNU2Vs1ugRxPTu0hFdQqkr5RKmKhAkm7ab1zShLdye6Y8Og@mail.gmail.com>
References: <20130810170400.7039.54207@vidsolbach.de>
 <CAGPcNU2_0EtReJpvJd_RZN9LMQianUU5Jz+9dJcdF_DcPTMKEg@mail.gmail.com>
 <CAGPcNU2Vs1ugRxPTu0hFdQqkr5RKmKhAkm7ab1zShLdye6Y8Og@mail.gmail.com>
Message-ID: <1952866.9xbaRdiV0B@monet>

On Sunday, August 11, 2013 16:29:42 Bhushan Shah wrote:
> On Sun, Aug 11, 2013 at 4:09 PM, Sebastian K?gler <sebas at kde.org> wrote:
> I have about 20 Activities configured on this system, I usually use 2 to 3.
> The rest are all rather specific that I might use for a couple of days, and
> then will not use for weeks or months. Having to scan 20 items every time I
> switch between activities would make this very cumbersome.
> 
> If that's user case then I am happy to use SortFilterModel instead of the
> DataModel, Later we can add configuration option "Show all activities".

Okay, cool. :)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From sebas at kde.org  Sun Aug 11 22:12:46 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Mon, 12 Aug 2013 00:12:46 +0200
Subject: mondaily Plasma hangout at 12:00 Europe/Amsterdam
Message-ID: <2737004.p0jRpmrzXG@monet>

see subject, just a reminder. Pop up in #plasma on IRC if you want to join.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From polentino911 at gmail.com  Mon Aug 12 07:33:47 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Mon, 12 Aug 2013 07:33:47 -0000
Subject: Review Request 6928: KMix Declarative Applet - First attempt
In-Reply-To: <20130726223042.16841.14778@vidsolbach.de>
References: <20130726223042.16841.14778@vidsolbach.de>
Message-ID: <20130812073347.3612.99715@vidsolbach.de>



> On July 26, 2013, 10:30 p.m., Christian Esken wrote:
> > I have not followed this request, but it looks like I have not receieved any followups on my last comment. I would like to know what to do with this review request. Diego, Igor? Diego, are you still following up on this. Care to contact Igor?
> 
> Diego Casella wrote:
>     Hi Christian, after hearing that someone else was working on it, I left the development of that plasmoid; I didnt' want to step over Igor's work.
>     Anyway, by looking at the current kmix status, it's still missing the conversion to a full kded service: otherwise there will be two entries in the tray: the "old" kmix, and its plasmoid counterpart. We also need to extend its dbus interface and add a method to pop-up the full kmix gui: in that way, the plasmoid can show the user interface, allowing the end-user to configure kmix properly.
>     As soon as those changes will be peformed (if you agree with it of course, and if you want to implement the new kmix as a qml plasmoid), I'd be happy to continue what I did so far :)
> 
> Christian Esken wrote:
>     Commenting on:
>        "if you want to implement the new kmix as a qml plasmoid"
>     
>     Well, I have no knowledge in QML and no desire to learn it. If you still want to do so - focussing on the tray popup/plasmoid - then it should be much more functional than your prototype - especially: supporting multiple controls, adding Media player control like in todays KMix.
>     The KMix Mainwindow will surely always stay a normal application, everything else is a complete new application.

> Commenting on:
>   "if you want to implement the new kmix as a qml plasmoid"
>
> Well, I have no knowledge in QML and no desire to learn it.

Sorry, I meant to say "if you want me to implement the new kmix as a qml plasmoid", I though I was sufficiently clear since then I continued with "I'd be happy to continue[..]" :)

About multiple controls and Media player controls I agree: they are rather easy to implement, so I'll go for it.

> The KMix Mainwindow will surely always stay a normal application, everything else is a complete new application.

Okay, I guess then it will be modified to not show the tray icon by default - otherwise there will be its tray icon and the plasma applet, kinda confusing for the user -  right? There's this annoyance then: when KMix is set to not show the tray icon, at every login it will display its GUI. That should not happen, unless the user explicitly executes KMix or my applet calls it.
What do you think?

PS: since kmix moved to git and this review request is old, once we agreed on what should be done I'll start a brand new one and and link to this one as reference :)


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6928/#review11062
-----------------------------------------------------------


On March 28, 2012, 6:49 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6928/
> -----------------------------------------------------------
> 
> (Updated March 28, 2012, 6:49 p.m.)
> 
> 
> Review request for Plasma, Aaron Seigo, Christian Esken, and Marco Martin.
> 
> 
> Description
> -------
> 
> First attempt of making a declarative kmix applet for plasma.
> What the apple does right now:
> * modifies the volume level and the mute/unmute status of the master channel;
> * reacts to changes of the volume level/status (i.e. made with multimedia keys);
> * disables the slider if the channel gets muted, and enables it back as soon as the channel gets unmuted;
> * collapses gracefully in a popup icon when placed inside the panel.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdemultimedia/kmix/plasma/CMakeLists.txt 1287513 
>   trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/VerticalControl.qml PRE-CREATION 
>   trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/kmixapplet.qml PRE-CREATION 
>   trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/metadata.desktop PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6928/diff/
> 
> 
> Testing
> -------
> 
> Tested against r1287510. For basic audio management it works great imho.
> 
> However, there is a lot of room for improvements, but this is gonna need some extra work outside the kmix applet scope:
> * first of all, the applet need kmix executable to run in order to perform the dbus calls. You can of course disable KMix tray icon feature but, at every login, KMix mainwindow will be shown and the user must closeby hand. This is a kind of ugly behavior that should be avoided;
> * it will be great to great to add an action to allow the user to select the master channel (by reusing KMix "Select Master Channel" widget), but this will require tweaking KMix dbus interface;
> * as you noticed in the screenshots, the applet in the panel and in the desktop have different size even if it __is__ actually the same: something is going wrong when plasma shows the PopupApplet. This behavior was even worse when I started implementing a "flip" action to change the layout from horizontal to vertical and vice-versa, and for this reason I gave up and simply stick with the vertical layout.
> 
> Could this applet be shipped in the current status, or should we wait for all the aforementioned improvements?
> Comments/ideas/suggestions?
> 
> Cheers :)
> 
> 
> Screenshots
> -----------
> 
> Applet look in panel and desktop
>   http://svn.reviewboard.kde.org/r/6928/s/627/
> Applet look in panel and desktop - audio muted
>   http://svn.reviewboard.kde.org/r/6928/s/628/
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130812/821c268b/attachment-0001.html>

From mgraesslin at kde.org  Mon Aug 12 17:34:45 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Mon, 12 Aug 2013 17:34:45 -0000
Subject: Review Request 112033: Drop windowId property from PlasmaCore.Dialog
Message-ID: <20130812173445.10948.86699@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Description
-------

Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.


Diffs
-----

  src/declarativeimports/core/dialog.h 7392b71 
  src/declarativeimports/core/dialog.cpp eaf3dce 

Diff: http://git.reviewboard.kde.org/r/112033/diff/


Testing
-------

Yes, KWin's ThumnailItem is still working


Thanks,

Martin Gr??lin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130812/d3ffbafd/attachment.html>

From ivan.cukic at kde.org  Mon Aug 12 17:50:31 2013
From: ivan.cukic at kde.org (=?utf-8?b?SXZhbiDEjHVracSH?=)
Date: Mon, 12 Aug 2013 17:50:31 -0000
Subject: Review Request 112033: Drop windowId property from
 PlasmaCore.Dialog
In-Reply-To: <20130812173445.10948.86699@vidsolbach.de>
References: <20130812173445.10948.86699@vidsolbach.de>
Message-ID: <20130812175031.11937.37398@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review37602
-----------------------------------------------------------


Isn't it also used for reporting wid to share-like-connect (activity manager) in some applications?

- Ivan ?uki?


On Aug. 12, 2013, 5:34 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 5:34 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h 7392b71 
>   src/declarativeimports/core/dialog.cpp eaf3dce 
> 
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
> 
> 
> Testing
> -------
> 
> Yes, KWin's ThumnailItem is still working
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130812/ed8cc6a2/attachment.html>

From mgraesslin at kde.org  Mon Aug 12 18:53:56 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Mon, 12 Aug 2013 18:53:56 -0000
Subject: Review Request 112033: Drop windowId property from
 PlasmaCore.Dialog
In-Reply-To: <20130812175031.11937.37398@vidsolbach.de>
References: <20130812175031.11937.37398@vidsolbach.de>
Message-ID: <20130812185356.24351.22490@vidsolbach.de>



> On Aug. 12, 2013, 7:50 p.m., Ivan ?uki? wrote:
> > Isn't it also used for reporting wid to share-like-connect (activity manager) in some applications?

well it got introduced for KWin:

commit 52bc2bd662b0e82191922d8fc81b74cc2895d3c0
Author: Martin Gr??lin <mgraesslin at kde.org>
Date:   Sat Mar 24 10:51:12 2012 +0100

    Export WindowId on Plasma Dialog
    
    Exporting the window Id allows to use it in declarative KWin scripts
    to embedd window thumbnails on the dialog.
    
    REVIEW: 104393

---
do you have an example of how it is used? Because most likely it should be easy to port in that case, too.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review37602
-----------------------------------------------------------


On Aug. 12, 2013, 7:34 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 7:34 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h 7392b71 
>   src/declarativeimports/core/dialog.cpp eaf3dce 
> 
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
> 
> 
> Testing
> -------
> 
> Yes, KWin's ThumnailItem is still working
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130812/b6175786/attachment.html>

From ivan.cukic at kde.org  Mon Aug 12 18:59:27 2013
From: ivan.cukic at kde.org (=?utf-8?b?SXZhbiDEjHVracSH?=)
Date: Mon, 12 Aug 2013 18:59:27 -0000
Subject: Review Request 112033: Drop windowId property from
 PlasmaCore.Dialog
In-Reply-To: <20130812175031.11937.37398@vidsolbach.de>
References: <20130812175031.11937.37398@vidsolbach.de>
Message-ID: <20130812185927.24576.61988@vidsolbach.de>



> On Aug. 12, 2013, 5:50 p.m., Ivan ?uki? wrote:
> > Isn't it also used for reporting wid to share-like-connect (activity manager) in some applications?
> 
> Martin Gr??lin wrote:
>     well it got introduced for KWin:
>     
>     commit 52bc2bd662b0e82191922d8fc81b74cc2895d3c0
>     Author: Martin Gr??lin <mgraesslin at kde.org>
>     Date:   Sat Mar 24 10:51:12 2012 +0100
>     
>         Export WindowId on Plasma Dialog
>         
>         Exporting the window Id allows to use it in declarative KWin scripts
>         to embedd window thumbnails on the dialog.
>         
>         REVIEW: 104393
>     
>     ---
>     do you have an example of how it is used? Because most likely it should be easy to port in that case, too.
>

This was a question for Marco - sorry for not explicitely specifying it. I'm just wondering whther he used it in image viewer, web browser ect. of Plasma Active.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review37602
-----------------------------------------------------------


On Aug. 12, 2013, 5:34 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 5:34 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h 7392b71 
>   src/declarativeimports/core/dialog.cpp eaf3dce 
> 
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
> 
> 
> Testing
> -------
> 
> Yes, KWin's ThumnailItem is still working
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130812/8d3ea8d2/attachment.html>

From notmart at gmail.com  Mon Aug 12 21:59:42 2013
From: notmart at gmail.com (Marco Martin)
Date: Mon, 12 Aug 2013 21:59:42 -0000
Subject: Review Request 112033: Drop windowId property from
 PlasmaCore.Dialog
In-Reply-To: <20130812175031.11937.37398@vidsolbach.de>
References: <20130812175031.11937.37398@vidsolbach.de>
Message-ID: <20130812215942.10911.22546@vidsolbach.de>



> On Aug. 12, 2013, 5:50 p.m., Ivan ?uki? wrote:
> > Isn't it also used for reporting wid to share-like-connect (activity manager) in some applications?
> 
> Martin Gr??lin wrote:
>     well it got introduced for KWin:
>     
>     commit 52bc2bd662b0e82191922d8fc81b74cc2895d3c0
>     Author: Martin Gr??lin <mgraesslin at kde.org>
>     Date:   Sat Mar 24 10:51:12 2012 +0100
>     
>         Export WindowId on Plasma Dialog
>         
>         Exporting the window Id allows to use it in declarative KWin scripts
>         to embedd window thumbnails on the dialog.
>         
>         REVIEW: 104393
>     
>     ---
>     do you have an example of how it is used? Because most likely it should be easy to port in that case, too.
>
> 
> Ivan ?uki? wrote:
>     This was a question for Marco - sorry for not explicitely specifying it. I'm just wondering whther he used it in image viewer, web browser ect. of Plasma Active.

as far i know for slc in qml usually the resourceinstance component is used, that one fetches it from its c++ implementation


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review37602
-----------------------------------------------------------


On Aug. 12, 2013, 5:34 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 5:34 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h 7392b71 
>   src/declarativeimports/core/dialog.cpp eaf3dce 
> 
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
> 
> 
> Testing
> -------
> 
> Yes, KWin's ThumnailItem is still working
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130812/0e7c74a9/attachment-0001.html>

From notmart at gmail.com  Mon Aug 12 22:00:40 2013
From: notmart at gmail.com (Marco Martin)
Date: Mon, 12 Aug 2013 22:00:40 -0000
Subject: Review Request 112033: Drop windowId property from
 PlasmaCore.Dialog
In-Reply-To: <20130812173445.10948.86699@vidsolbach.de>
References: <20130812173445.10948.86699@vidsolbach.de>
Message-ID: <20130812220040.10984.4822@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review37620
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Aug. 12, 2013, 5:34 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 5:34 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h 7392b71 
>   src/declarativeimports/core/dialog.cpp eaf3dce 
> 
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
> 
> 
> Testing
> -------
> 
> Yes, KWin's ThumnailItem is still working
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130812/821f87ae/attachment.html>

From null at kde.org  Tue Aug 13 04:47:08 2013
From: null at kde.org (Commit Hook)
Date: Tue, 13 Aug 2013 04:47:08 -0000
Subject: Review Request 112033: Drop windowId property from
 PlasmaCore.Dialog
In-Reply-To: <20130812173445.10948.86699@vidsolbach.de>
References: <20130812173445.10948.86699@vidsolbach.de>
Message-ID: <20130813044708.8271.44162@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review37635
-----------------------------------------------------------


This review has been submitted with commit f50a5412ba83058dcbfa3acff4b602cc87675d9a by Martin Gr??lin to branch master.

- Commit Hook


On Aug. 12, 2013, 5:34 p.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 5:34 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h 7392b71 
>   src/declarativeimports/core/dialog.cpp eaf3dce 
> 
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
> 
> 
> Testing
> -------
> 
> Yes, KWin's ThumnailItem is still working
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/2f61924a/attachment.html>

From null at kde.org  Tue Aug 13 04:47:12 2013
From: null at kde.org (Commit Hook)
Date: Tue, 13 Aug 2013 04:47:12 -0000
Subject: Review Request 112033: Drop windowId property from
 PlasmaCore.Dialog
In-Reply-To: <20130812173445.10948.86699@vidsolbach.de>
References: <20130812173445.10948.86699@vidsolbach.de>
Message-ID: <20130813044712.8439.84592@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 4:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Description
-------

Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.


Diffs
-----

  src/declarativeimports/core/dialog.h 7392b71 
  src/declarativeimports/core/dialog.cpp eaf3dce 

Diff: http://git.reviewboard.kde.org/r/112033/diff/


Testing
-------

Yes, KWin's ThumnailItem is still working


Thanks,

Martin Gr??lin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/285dfade/attachment.html>

From david at davidedmundson.co.uk  Tue Aug 13 13:33:18 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Tue, 13 Aug 2013 13:33:18 -0000
Subject: Review Request 112058: Enable apps dataengine for KF5
Message-ID: <20130813133318.4737.96143@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112058/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Enable apps dataengine for KF5


Diffs
-----

  plasma/generic/dataengines/CMakeLists.txt 923a519bd6ee2c460968ac9de71550c126425ee8 
  plasma/generic/dataengines/apps/CMakeLists.txt 05d139cbfd306a2e2003f75280e09958af46dcf2 
  plasma/generic/dataengines/apps/appjob.cpp 3a91b1e4de6119e0f13013dd255b7e15415284bd 
  plasma/generic/dataengines/apps/appsengine.cpp 340705c05e091c75909665180f51a62cb69acb14 

Diff: http://git.reviewboard.kde.org/r/112058/diff/


Testing
-------

Checked it appeared in plasmaengineexplorer
I have not verified it shows apps as my kf5 build dir does not contains any.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/90b122b9/attachment.html>

From notmart at gmail.com  Tue Aug 13 13:39:28 2013
From: notmart at gmail.com (Marco Martin)
Date: Tue, 13 Aug 2013 13:39:28 -0000
Subject: Review Request 112058: Enable apps dataengine for KF5
In-Reply-To: <20130813133318.4737.96143@vidsolbach.de>
References: <20130813133318.4737.96143@vidsolbach.de>
Message-ID: <20130813133928.5551.66561@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112058/#review37692
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Aug. 13, 2013, 1:33 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112058/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 1:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Enable apps dataengine for KF5
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt 923a519bd6ee2c460968ac9de71550c126425ee8 
>   plasma/generic/dataengines/apps/CMakeLists.txt 05d139cbfd306a2e2003f75280e09958af46dcf2 
>   plasma/generic/dataengines/apps/appjob.cpp 3a91b1e4de6119e0f13013dd255b7e15415284bd 
>   plasma/generic/dataengines/apps/appsengine.cpp 340705c05e091c75909665180f51a62cb69acb14 
> 
> Diff: http://git.reviewboard.kde.org/r/112058/diff/
> 
> 
> Testing
> -------
> 
> Checked it appeared in plasmaengineexplorer
> I have not verified it shows apps as my kf5 build dir does not contains any.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/bfe26592/attachment.html>

From null at kde.org  Tue Aug 13 13:48:25 2013
From: null at kde.org (Commit Hook)
Date: Tue, 13 Aug 2013 13:48:25 -0000
Subject: Review Request 112058: Enable apps dataengine for KF5
In-Reply-To: <20130813133318.4737.96143@vidsolbach.de>
References: <20130813133318.4737.96143@vidsolbach.de>
Message-ID: <20130813134825.6122.74911@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112058/#review37693
-----------------------------------------------------------


This review has been submitted with commit 6b7471fcb032ef44f095dcd5c2927325e50b3afc by David Edmundson to branch frameworks-scratch.

- Commit Hook


On Aug. 13, 2013, 1:33 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112058/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 1:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Enable apps dataengine for KF5
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt 923a519bd6ee2c460968ac9de71550c126425ee8 
>   plasma/generic/dataengines/apps/CMakeLists.txt 05d139cbfd306a2e2003f75280e09958af46dcf2 
>   plasma/generic/dataengines/apps/appjob.cpp 3a91b1e4de6119e0f13013dd255b7e15415284bd 
>   plasma/generic/dataengines/apps/appsengine.cpp 340705c05e091c75909665180f51a62cb69acb14 
> 
> Diff: http://git.reviewboard.kde.org/r/112058/diff/
> 
> 
> Testing
> -------
> 
> Checked it appeared in plasmaengineexplorer
> I have not verified it shows apps as my kf5 build dir does not contains any.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/b205e26c/attachment.html>

From null at kde.org  Tue Aug 13 13:48:27 2013
From: null at kde.org (Commit Hook)
Date: Tue, 13 Aug 2013 13:48:27 -0000
Subject: Review Request 112058: Enable apps dataengine for KF5
In-Reply-To: <20130813133318.4737.96143@vidsolbach.de>
References: <20130813133318.4737.96143@vidsolbach.de>
Message-ID: <20130813134827.6099.6809@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112058/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 1:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

Enable apps dataengine for KF5


Diffs
-----

  plasma/generic/dataengines/CMakeLists.txt 923a519bd6ee2c460968ac9de71550c126425ee8 
  plasma/generic/dataengines/apps/CMakeLists.txt 05d139cbfd306a2e2003f75280e09958af46dcf2 
  plasma/generic/dataengines/apps/appjob.cpp 3a91b1e4de6119e0f13013dd255b7e15415284bd 
  plasma/generic/dataengines/apps/appsengine.cpp 340705c05e091c75909665180f51a62cb69acb14 

Diff: http://git.reviewboard.kde.org/r/112058/diff/


Testing
-------

Checked it appeared in plasmaengineexplorer
I have not verified it shows apps as my kf5 build dir does not contains any.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/80dab86e/attachment.html>

From david at davidedmundson.co.uk  Tue Aug 13 13:49:30 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Tue, 13 Aug 2013 13:49:30 -0000
Subject: Review Request 112059: Add reviewboardrc file
Message-ID: <20130813134930.6235.47936@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112059/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Add reviewboardrc file


Diffs
-----

  .reviewboardrc PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112059/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/828ec98e/attachment-0001.html>

From sebas at kde.org  Tue Aug 13 14:56:15 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Tue, 13 Aug 2013 14:56:15 -0000
Subject: Review Request 112059: Add reviewboardrc file
In-Reply-To: <20130813134930.6235.47936@vidsolbach.de>
References: <20130813134930.6235.47936@vidsolbach.de>
Message-ID: <20130813145615.19041.54650@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112059/#review37697
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian K?gler


On Aug. 13, 2013, 1:49 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112059/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 1:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add reviewboardrc file
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112059/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/d68fd9e8/attachment.html>

From heena393 at gmail.com  Tue Aug 13 16:26:08 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Tue, 13 Aug 2013 16:26:08 +0000
Subject: plasma-framework cmake error after git pull --rebase
Message-ID: <CAFCfA1-MTj2KkmuFr5x0RUN02UxxjDF7iVZkhnQUH83VYDtdcQ@mail.gmail.com>

Hi ,
In order to make use of data engine tasks in plasma 2 .I did git pull
--rebase in extra-cmake-module and kdelibs and rebuild it using runtime
setup .Then I did the same with plasma-framework .But getting cmake error
on plasma-framework http://pastebin.com/raw.php?i=d7apCJkn
Please help me out :p (plasma framework takes time ;) )

-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/653ac5de/attachment.html>

From notmart at gmail.com  Tue Aug 13 19:36:09 2013
From: notmart at gmail.com (Marco Martin)
Date: Tue, 13 Aug 2013 12:36:09 -0700 (PDT)
Subject: plasma-framework cmake error after git pull --rebase
In-Reply-To: <CAFCfA1-MTj2KkmuFr5x0RUN02UxxjDF7iVZkhnQUH83VYDtdcQ@mail.gmail.com>
References: <CAFCfA1-MTj2KkmuFr5x0RUN02UxxjDF7iVZkhnQUH83VYDtdcQ@mail.gmail.com>
Message-ID: <4110686.Uf8LMm1XLv@deimos.diaunet>

On Tuesday 13 August 2013 16:26:08 Heena Mahour wrote:
> Hi ,
> In order to make use of data engine tasks in plasma 2 .I did git pull
> --rebase in extra-cmake-module and kdelibs and rebuild it using runtime
> setup .Then I did the same with plasma-framework .But getting cmake error
> on plasma-framework http://pastebin.com/raw.php?i=d7apCJkn
> Please help me out :p (plasma framework takes time ;) )

try to add -DCMAKE_PREFIX_PATH=$KF5 to the cmake command line, should tell to 
actually search for kdelibs under $KF5 

-- 
Marco Martin

From null at kde.org  Tue Aug 13 20:11:44 2013
From: null at kde.org (Commit Hook)
Date: Tue, 13 Aug 2013 20:11:44 -0000
Subject: Review Request 112059: Add reviewboardrc file
In-Reply-To: <20130813134930.6235.47936@vidsolbach.de>
References: <20130813134930.6235.47936@vidsolbach.de>
Message-ID: <20130813201144.32200.8681@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112059/#review37724
-----------------------------------------------------------


This review has been submitted with commit 366d988f7d681cf52c741a8bec3bb22e2b7232b7 by David Edmundson to branch frameworks-scratch.

- Commit Hook


On Aug. 13, 2013, 1:49 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112059/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 1:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add reviewboardrc file
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112059/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/f00aaba5/attachment.html>

From null at kde.org  Tue Aug 13 20:11:47 2013
From: null at kde.org (Commit Hook)
Date: Tue, 13 Aug 2013 20:11:47 -0000
Subject: Review Request 112059: Add reviewboardrc file
In-Reply-To: <20130813134930.6235.47936@vidsolbach.de>
References: <20130813134930.6235.47936@vidsolbach.de>
Message-ID: <20130813201147.32208.19389@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112059/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 8:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

Add reviewboardrc file


Diffs
-----

  .reviewboardrc PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112059/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/2ae31aaa/attachment.html>

From hrvoje.senjan at gmail.com  Tue Aug 13 23:20:58 2013
From: hrvoje.senjan at gmail.com (Hrvoje Senjan)
Date: Tue, 13 Aug 2013 23:20:58 -0000
Subject: Review Request 112069: Call KPluginInfo::KPluginInfo with the resource
 argument
Message-ID: <20130813232058.23737.56418@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112069/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

>From the bug report:

"I have analyzed the crashed application in gdb, and I believe this code in Plasma::ThemePrivate::useCache() is the real culprit:

230             if (isRegularTheme) {
231                 const QString path = KStandardDirs::locate("data", "desktoptheme/" + themeName + "/metadata.desktop");
232                 const KPluginInfo pluginInfo(path);

Note that "path" is a relative path and KPluginInfo::KPluginInfo is called with only one argument. However, KPluginInfo constructor is declared as:

         * @param filename  The filename of the .desktop file.
         * @param resource  If filename is relative, you need to specify a resource type
         * (e.g. "service", "apps"... KStandardDirs). Otherwise,
         * resource isn't used.
         */
        explicit KPluginInfo( const QString & filename, const char* resource = 0 );

So, if you call it without the "resource" argument, the default value is used, which is NULL. This is invalid for a relative path, and indeed causes the crash further down the stack in KStandardDirs::saveLocation():

1499            if (dirs.isEmpty() && (
1500                    (strcmp(type, "socket") == 0) ||
1501                    (strcmp(type, "tmp") == 0) ||
1502                    (strcmp(type, "cache") == 0) ))

Unsurprisingly, calling strcmp(NULL, something) will cause a SIGSEGV."


Note that it's not my patch, but i feel it's a waste it's just sitting there in the report, and not here ;-)
Issue is triggered very easily by explcitly definining a plasma theme which does not exist (with e.g. adding 
[Theme]
name=fake-non-existant-theme
in plasmarc)


This addresses bugs 320855 and 322446.
    http://bugs.kde.org/show_bug.cgi?id=320855
    http://bugs.kde.org/show_bug.cgi?id=322446


Diffs
-----

  plasma/theme.cpp 4554de7 

Diff: http://git.reviewboard.kde.org/r/112069/diff/


Testing
-------

Tried the above example with the patch, plasma doesn't crash


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130813/7ed82154/attachment-0001.html>

From hrvoje.senjan at gmail.com  Wed Aug 14 00:01:17 2013
From: hrvoje.senjan at gmail.com (Hrvoje Senjan)
Date: Wed, 14 Aug 2013 00:01:17 -0000
Subject: Review Request 112073: Partially revert commit 83d3018
Message-ID: <20130814000117.13131.43688@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112073/
-----------------------------------------------------------

Review request for Plasma and David Faure.


Description
-------

While the commit may be technically correct, it breaks ksplash for 4.11 release...
I've changed unique to multi, if there is a better solution, please hint it ;-)
(maybe actually someone meant multi, when typing wait :-)


This addresses bug 321695.
    http://bugs.kde.org/show_bug.cgi?id=321695


Diffs
-----

  plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 

Diff: http://git.reviewboard.kde.org/r/112073/diff/


Testing
-------

Yes... starts "normally" as previously/ksplash isn't interupted


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/e9810206/attachment.html>

From mgraesslin at kde.org  Wed Aug 14 05:57:43 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Wed, 14 Aug 2013 07:57:43 +0200
Subject: Announcing kwindoweffectsplugin
Message-ID: <2154403.svqbvbK2BQ@martin-thinkpad>

Hi all,

to help me with working on KWindowEffects I decided to write a small qml plugin 
which exports all the methods of KWindowEffects to qml.

I just pushed this plugin to a personal scratch repository:
kde:scratch/graesslin/kwindoweffectsplugin [1]

It contains an example.qml which can be loaded in qmlscene and shows how to 
use the plugin and also is a nice example of what we can do with the 
KWindowEffects.

I am not sure whether this plugin is of use for more things than just an 
example. So feel free to do with it as you wish or tell me that it is useful 
and what I should do with it.

Cheers
Martin

[1] 
http://commits.kde.org/scratch/graesslin/kwindoweffectsplugin/edc6bbb6c23d1cde45362f8a5433a548a2651081
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/c2b26206/attachment.sig>

From bhush94 at gmail.com  Wed Aug 14 07:06:18 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Wed, 14 Aug 2013 12:36:18 +0530
Subject: Compiling QT5 for KF5
Message-ID: <CAGPcNU0KLv0=J1bobOhvKkn9viogtdPhqgKy89G9gNtOS9XBSQ@mail.gmail.com>

Hello,

I want to compile QT 5.2 for compiling kde-framework 5, So want to ask if I
can ignore some submodules to speedup compiling process? Like qt multimedia
package etc?

Which packages from Qt5 are required to build KF5?

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/8b15bac8/attachment.html>

From mgraesslin at kde.org  Wed Aug 14 07:33:53 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Wed, 14 Aug 2013 09:33:53 +0200
Subject: Compiling QT5 for KF5
In-Reply-To: <CAGPcNU0KLv0=J1bobOhvKkn9viogtdPhqgKy89G9gNtOS9XBSQ@mail.gmail.com>
References: <CAGPcNU0KLv0=J1bobOhvKkn9viogtdPhqgKy89G9gNtOS9XBSQ@mail.gmail.com>
Message-ID: <8100541.VleHKN6BFS@martin-thinkpad>

On Wednesday 14 August 2013 12:36:18 Bhushan Shah wrote:
> Hello,
> 
> I want to compile QT 5.2 for compiling kde-framework 5, So want to ask if I
> can ignore some submodules to speedup compiling process? Like qt multimedia
> package etc?
depending on your distribution there might be "daily" built packages of Qt 5.2 
available. So which distro are you using?

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/60f6c306/attachment.sig>

From bhush94 at gmail.com  Wed Aug 14 07:43:19 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Wed, 14 Aug 2013 13:13:19 +0530
Subject: Compiling QT5 for KF5
In-Reply-To: <8100541.VleHKN6BFS@martin-thinkpad>
References: <CAGPcNU0KLv0=J1bobOhvKkn9viogtdPhqgKy89G9gNtOS9XBSQ@mail.gmail.com>
 <8100541.VleHKN6BFS@martin-thinkpad>
Message-ID: <CAGPcNU2asNi6ycsZrQM+5pA2wOQ7DuREBagzi7uTrhN563+A2w@mail.gmail.com>

Hello, I am using Arch Linux i686. Thanks!

On 8/14/13, Martin Graesslin <mgraesslin at kde.org> wrote:
> On Wednesday 14 August 2013 12:36:18 Bhushan Shah wrote:
>> Hello,
>>
>> I want to compile QT 5.2 for compiling kde-framework 5, So want to ask if
>> I
>> can ignore some submodules to speedup compiling process? Like qt
>> multimedia
>> package etc?
> depending on your distribution there might be "daily" built packages of Qt
> 5.2
> available. So which distro are you using?
>
> Cheers
> Martin
>

From mgraesslin at kde.org  Wed Aug 14 08:44:37 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Wed, 14 Aug 2013 10:44:37 +0200
Subject: Compiling QT5 for KF5
In-Reply-To: <CAGPcNU2asNi6ycsZrQM+5pA2wOQ7DuREBagzi7uTrhN563+A2w@mail.gmail.com>
References: <CAGPcNU0KLv0=J1bobOhvKkn9viogtdPhqgKy89G9gNtOS9XBSQ@mail.gmail.com>
 <8100541.VleHKN6BFS@martin-thinkpad>
 <CAGPcNU2asNi6ycsZrQM+5pA2wOQ7DuREBagzi7uTrhN563+A2w@mail.gmail.com>
Message-ID: <1531398.4GBTIWfQFz@martin-thinkpad>

On Wednesday 14 August 2013 13:13:19 Bhushan Shah wrote:
> Hello, I am using Arch Linux i686. Thanks!
I'm not the Arch expert, but it seems like something exists: 
https://bbs.archlinux.org/viewtopic.php?id=164647

Cheers
Martin
> 
> On 8/14/13, Martin Graesslin <mgraesslin at kde.org> wrote:
> > On Wednesday 14 August 2013 12:36:18 Bhushan Shah wrote:
> >> Hello,
> >> 
> >> I want to compile QT 5.2 for compiling kde-framework 5, So want to ask if
> >> I
> >> can ignore some submodules to speedup compiling process? Like qt
> >> multimedia
> >> package etc?
> > 
> > depending on your distribution there might be "daily" built packages of Qt
> > 5.2
> > available. So which distro are you using?
> > 
> > Cheers
> > Martin
> 
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/a178e1a2/attachment.sig>

From bhush94 at gmail.com  Wed Aug 14 08:53:12 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Wed, 14 Aug 2013 14:23:12 +0530
Subject: Compiling QT5 for KF5
In-Reply-To: <1531398.4GBTIWfQFz@martin-thinkpad>
References: <CAGPcNU0KLv0=J1bobOhvKkn9viogtdPhqgKy89G9gNtOS9XBSQ@mail.gmail.com>
 <8100541.VleHKN6BFS@martin-thinkpad>
 <CAGPcNU2asNi6ycsZrQM+5pA2wOQ7DuREBagzi7uTrhN563+A2w@mail.gmail.com>
 <1531398.4GBTIWfQFz@martin-thinkpad>
Message-ID: <CAGPcNU3An+KSwUEcbdp_ZS3sWmPR7ox-tGFsK+0ODWsSLuraQQ@mail.gmail.com>

Hello,

On Wed, Aug 14, 2013 at 2:14 PM, Martin Graesslin <mgraesslin at kde.org>wrote:

> I'm not the Arch expert, but it seems like something exists:
> https://bbs.archlinux.org/viewtopic.php?id=164647
>
> Cheers
> Martin
>

Wish I could get PKGBUILDs, Its available for 64 bit only. I asked Andrea
Scarpino but no reply yet, May be different time zone! :-)

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/694a64d6/attachment.html>

From hrvoje.senjan at gmail.com  Wed Aug 14 10:56:33 2013
From: hrvoje.senjan at gmail.com (Hrvoje Senjan)
Date: Wed, 14 Aug 2013 10:56:33 -0000
Subject: Review Request 112069: Call KPluginInfo::KPluginInfo with the
 resource argument
In-Reply-To: <20130813232058.23737.56418@vidsolbach.de>
References: <20130813232058.23737.56418@vidsolbach.de>
Message-ID: <20130814105633.14143.82256@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112069/
-----------------------------------------------------------

(Updated Aug. 14, 2013, 10:56 a.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Description
-------

>From the bug report:

"I have analyzed the crashed application in gdb, and I believe this code in Plasma::ThemePrivate::useCache() is the real culprit:

230             if (isRegularTheme) {
231                 const QString path = KStandardDirs::locate("data", "desktoptheme/" + themeName + "/metadata.desktop");
232                 const KPluginInfo pluginInfo(path);

Note that "path" is a relative path and KPluginInfo::KPluginInfo is called with only one argument. However, KPluginInfo constructor is declared as:

         * @param filename  The filename of the .desktop file.
         * @param resource  If filename is relative, you need to specify a resource type
         * (e.g. "service", "apps"... KStandardDirs). Otherwise,
         * resource isn't used.
         */
        explicit KPluginInfo( const QString & filename, const char* resource = 0 );

So, if you call it without the "resource" argument, the default value is used, which is NULL. This is invalid for a relative path, and indeed causes the crash further down the stack in KStandardDirs::saveLocation():

1499            if (dirs.isEmpty() && (
1500                    (strcmp(type, "socket") == 0) ||
1501                    (strcmp(type, "tmp") == 0) ||
1502                    (strcmp(type, "cache") == 0) ))

Unsurprisingly, calling strcmp(NULL, something) will cause a SIGSEGV."


Note that it's not my patch, but i feel it's a waste it's just sitting there in the report, and not here ;-)
Issue is triggered very easily by explcitly definining a plasma theme which does not exist (with e.g. adding 
[Theme]
name=fake-non-existant-theme
in plasmarc)


This addresses bugs 320855 and 322446.
    http://bugs.kde.org/show_bug.cgi?id=320855
    http://bugs.kde.org/show_bug.cgi?id=322446


Diffs
-----

  plasma/theme.cpp 4554de7 

Diff: http://git.reviewboard.kde.org/r/112069/diff/


Testing
-------

Tried the above example with the patch, plasma doesn't crash


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/634adc35/attachment-0001.html>

From heena393 at gmail.com  Wed Aug 14 11:49:07 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Wed, 14 Aug 2013 11:49:07 +0000
Subject: plasma-framework cmake error after git pull --rebase
In-Reply-To: <4110686.Uf8LMm1XLv@deimos.diaunet>
References: <CAFCfA1-MTj2KkmuFr5x0RUN02UxxjDF7iVZkhnQUH83VYDtdcQ@mail.gmail.com>
 <4110686.Uf8LMm1XLv@deimos.diaunet>
Message-ID: <CAFCfA18ui845+fVySU54hQ446eOJWhtNA5FWYAd4cd47kE-iRA@mail.gmail.com>

I used  cmake -DCMAKE_INSTALL_PREFIX=$KF5 ..



On Tue, Aug 13, 2013 at 7:36 PM, Marco Martin <notmart at gmail.com> wrote:

> On Tuesday 13 August 2013 16:26:08 Heena Mahour wrote:
> > Hi ,
> > In order to make use of data engine tasks in plasma 2 .I did git pull
> > --rebase in extra-cmake-module and kdelibs and rebuild it using runtime
> > setup .Then I did the same with plasma-framework .But getting cmake error
> > on plasma-framework http://pastebin.com/raw.php?i=d7apCJkn
> > Please help me out :p (plasma framework takes time ;) )
>
> try to add -DCMAKE_PREFIX_PATH=$KF5 to the cmake command line, should tell
> to
> actually search for kdelibs under $KF5
>
> --
> Marco Martin
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/63cc214a/attachment.html>

From null at kde.org  Wed Aug 14 14:56:37 2013
From: null at kde.org (Commit Hook)
Date: Wed, 14 Aug 2013 14:56:37 -0000
Subject: Review Request 111899: Make QGuiPlatformPlugin react to
 iconChanges
In-Reply-To: <20130806070219.19310.95079@vidsolbach.de>
References: <20130806070219.19310.95079@vidsolbach.de>
Message-ID: <20130814145637.18071.54418@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111899/#review37767
-----------------------------------------------------------


This review has been submitted with commit e74a264325e8af834d800ee650c4bf208e1b2fb1 by ?lex Fiestas to branch KDE/4.11.

- Commit Hook


On Aug. 6, 2013, 7:02 a.m., ?lex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111899/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 7:02 a.m.)
> 
> 
> Review request for Plasma and Olivier Goffart.
> 
> 
> Description
> -------
> 
> When KDE changes the iconSize, send a StyleChange event to QToolbar and QMainWindow (this one is required for QToolBar that are children of it).
> 
> 
> Diffs
> -----
> 
>   qguiplatformplugin_kde/qguiplatformplugin_kde.cpp cc74dc0 
> 
> Diff: http://git.reviewboard.kde.org/r/111899/diff/
> 
> 
> Testing
> -------
> 
> Played a while with assistant, designer and quasselclient, seems to work fine.
> 
> 
> Thanks,
> 
> ?lex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/b2cdcf15/attachment.html>

From null at kde.org  Wed Aug 14 14:56:52 2013
From: null at kde.org (Commit Hook)
Date: Wed, 14 Aug 2013 14:56:52 -0000
Subject: Review Request 111899: Make QGuiPlatformPlugin react to
 iconChanges
In-Reply-To: <20130806070219.19310.95079@vidsolbach.de>
References: <20130806070219.19310.95079@vidsolbach.de>
Message-ID: <20130814145652.18093.34588@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111899/
-----------------------------------------------------------

(Updated Aug. 14, 2013, 2:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Olivier Goffart.


Description
-------

When KDE changes the iconSize, send a StyleChange event to QToolbar and QMainWindow (this one is required for QToolBar that are children of it).


Diffs
-----

  qguiplatformplugin_kde/qguiplatformplugin_kde.cpp cc74dc0 

Diff: http://git.reviewboard.kde.org/r/111899/diff/


Testing
-------

Played a while with assistant, designer and quasselclient, seems to work fine.


Thanks,

?lex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/315ce725/attachment.html>

From michael.bohlender at kdemail.net  Wed Aug 14 15:52:55 2013
From: michael.bohlender at kdemail.net (Michael Bohlender)
Date: Wed, 14 Aug 2013 15:52:55 -0000
Subject: Review Request 112088: active-about: add new Contributors for PA 4
Message-ID: <20130814155255.31553.41552@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112088/
-----------------------------------------------------------

Review request for Plasma and Ruediger Gad.


Description
-------

Adds rcg and myself to the contributors.
I still wait for a reply from rcg. maybe he does not want to get listed, or his name is really Ruediger and not R?diger. :)


Diffs
-----

  applications/about/package/contents/data/authors.html 1feb156 

Diff: http://git.reviewboard.kde.org/r/112088/diff/


Testing
-------


Thanks,

Michael Bohlender

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/b5c40384/attachment.html>

From heena393 at gmail.com  Wed Aug 14 19:21:40 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Wed, 14 Aug 2013 19:21:40 +0000
Subject: plasma-framework cmake error after git pull --rebase
In-Reply-To: <CAFCfA18ui845+fVySU54hQ446eOJWhtNA5FWYAd4cd47kE-iRA@mail.gmail.com>
References: <CAFCfA1-MTj2KkmuFr5x0RUN02UxxjDF7iVZkhnQUH83VYDtdcQ@mail.gmail.com>
 <4110686.Uf8LMm1XLv@deimos.diaunet>
 <CAFCfA18ui845+fVySU54hQ446eOJWhtNA5FWYAd4cd47kE-iRA@mail.gmail.com>
Message-ID: <CAFCfA1_kJFStTiuSQ3thnoSKdz8t+efrS1-hTdQN7Qn+6fqy3Q@mail.gmail.com>

This is my runtime set up http://pastebin.com/raw.php?i=hu9BfWmV .Please
suggest what I am missing out.
And this is output of $env http://pastebin.com/raw.php?i=9wRZyPg3
Regards


On Wed, Aug 14, 2013 at 11:49 AM, Heena Mahour <heena393 at gmail.com> wrote:

> I used  cmake -DCMAKE_INSTALL_PREFIX=$KF5 ..
>
>
>
> On Tue, Aug 13, 2013 at 7:36 PM, Marco Martin <notmart at gmail.com> wrote:
>
>> On Tuesday 13 August 2013 16:26:08 Heena Mahour wrote:
>> > Hi ,
>> > In order to make use of data engine tasks in plasma 2 .I did git pull
>> > --rebase in extra-cmake-module and kdelibs and rebuild it using runtime
>> > setup .Then I did the same with plasma-framework .But getting cmake
>> error
>> > on plasma-framework http://pastebin.com/raw.php?i=d7apCJkn
>> > Please help me out :p (plasma framework takes time ;) )
>>
>> try to add -DCMAKE_PREFIX_PATH=$KF5 to the cmake command line, should
>> tell to
>> actually search for kdelibs under $KF5
>>
>> --
>> Marco Martin
>> _______________________________________________
>> Plasma-devel mailing list
>> Plasma-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>
>
>
> --
> -Heena
> Season of kde'12 participant
> Google Summer of Code 2013
> Delhi College of Engineering(COE),India
> http://about.me/heena.mahour
> http://heenamahour.blogspot.in
>
>


-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/5cf90338/attachment.html>

From heena393 at gmail.com  Wed Aug 14 20:22:12 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Wed, 14 Aug 2013 20:22:12 +0000
Subject: plasma-framework cmake error after git pull --rebase
In-Reply-To: <CAFCfA1_kJFStTiuSQ3thnoSKdz8t+efrS1-hTdQN7Qn+6fqy3Q@mail.gmail.com>
References: <CAFCfA1-MTj2KkmuFr5x0RUN02UxxjDF7iVZkhnQUH83VYDtdcQ@mail.gmail.com>
 <4110686.Uf8LMm1XLv@deimos.diaunet>
 <CAFCfA18ui845+fVySU54hQ446eOJWhtNA5FWYAd4cd47kE-iRA@mail.gmail.com>
 <CAFCfA1_kJFStTiuSQ3thnoSKdz8t+efrS1-hTdQN7Qn+6fqy3Q@mail.gmail.com>
Message-ID: <CAFCfA1-nR+wMaZiZ3Lcrsn7MR_2n_1Wj_=zoK4-y1Mw2m9eaBQ@mail.gmail.com>

Now I am able to build but  on $plasma-shell I am getting this
http://pastebin.com/raw.php?i=ZeK1kquz ...


On Wed, Aug 14, 2013 at 7:21 PM, Heena Mahour <heena393 at gmail.com> wrote:

> This is my runtime set up http://pastebin.com/raw.php?i=hu9BfWmV .Please
> suggest what I am missing out.
> And this is output of $env http://pastebin.com/raw.php?i=9wRZyPg3
> Regards
>
>
> On Wed, Aug 14, 2013 at 11:49 AM, Heena Mahour <heena393 at gmail.com> wrote:
>
>> I used  cmake -DCMAKE_INSTALL_PREFIX=$KF5 ..
>>
>>
>>
>> On Tue, Aug 13, 2013 at 7:36 PM, Marco Martin <notmart at gmail.com> wrote:
>>
>>> On Tuesday 13 August 2013 16:26:08 Heena Mahour wrote:
>>> > Hi ,
>>> > In order to make use of data engine tasks in plasma 2 .I did git pull
>>> > --rebase in extra-cmake-module and kdelibs and rebuild it using runtime
>>> > setup .Then I did the same with plasma-framework .But getting cmake
>>> error
>>> > on plasma-framework http://pastebin.com/raw.php?i=d7apCJkn
>>> > Please help me out :p (plasma framework takes time ;) )
>>>
>>> try to add -DCMAKE_PREFIX_PATH=$KF5 to the cmake command line, should
>>> tell to
>>> actually search for kdelibs under $KF5
>>>
>>> --
>>> Marco Martin
>>> _______________________________________________
>>> Plasma-devel mailing list
>>> Plasma-devel at kde.org
>>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>>
>>
>>
>>
>> --
>> -Heena
>> Season of kde'12 participant
>> Google Summer of Code 2013
>> Delhi College of Engineering(COE),India
>> http://about.me/heena.mahour
>> http://heenamahour.blogspot.in
>>
>>
>
>
> --
> -Heena
> Season of kde'12 participant
> Google Summer of Code 2013
> Delhi College of Engineering(COE),India
> http://about.me/heena.mahour
> http://heenamahour.blogspot.in
>
>


-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130814/d42871ae/attachment-0001.html>

From terietor at gmail.com  Thu Aug 15 06:32:44 2013
From: terietor at gmail.com (Giorgos Tsiapaliokas)
Date: Thu, 15 Aug 2013 09:32:44 +0300
Subject: Compiling QT5 for KF5
In-Reply-To: <CAGPcNU3An+KSwUEcbdp_ZS3sWmPR7ox-tGFsK+0ODWsSLuraQQ@mail.gmail.com>
References: <CAGPcNU0KLv0=J1bobOhvKkn9viogtdPhqgKy89G9gNtOS9XBSQ@mail.gmail.com>
 <8100541.VleHKN6BFS@martin-thinkpad>
 <CAGPcNU2asNi6ycsZrQM+5pA2wOQ7DuREBagzi7uTrhN563+A2w@mail.gmail.com>
 <1531398.4GBTIWfQFz@martin-thinkpad>
 <CAGPcNU3An+KSwUEcbdp_ZS3sWmPR7ox-tGFsK+0ODWsSLuraQQ@mail.gmail.com>
Message-ID: <CAODYyLZUt8vyzSTV6Sv0VDNRZMs00MH0afoMdeBWXZwR_cFUeQ@mail.gmail.com>

On 14 August 2013 11:53, Bhushan Shah <bhush94 at gmail.com> wrote:
>
> Wish I could get PKGBUILDs, Its available for 64 bit only. I asked Andrea
> Scarpino but no reply yet, May be different time zone! :-)
>
> Thanks!
>


https://aur.archlinux.org/packages/?O=0&K=kf5

-- 
Giorgos Tsiapaliokas (terietor)

terietor.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/ab1fa8aa/attachment.html>

From bhush94 at gmail.com  Thu Aug 15 06:55:41 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Thu, 15 Aug 2013 12:25:41 +0530
Subject: Compiling QT5 for KF5
In-Reply-To: <CAODYyLZUt8vyzSTV6Sv0VDNRZMs00MH0afoMdeBWXZwR_cFUeQ@mail.gmail.com>
References: <CAGPcNU0KLv0=J1bobOhvKkn9viogtdPhqgKy89G9gNtOS9XBSQ@mail.gmail.com>
 <8100541.VleHKN6BFS@martin-thinkpad>
 <CAGPcNU2asNi6ycsZrQM+5pA2wOQ7DuREBagzi7uTrhN563+A2w@mail.gmail.com>
 <1531398.4GBTIWfQFz@martin-thinkpad>
 <CAGPcNU3An+KSwUEcbdp_ZS3sWmPR7ox-tGFsK+0ODWsSLuraQQ@mail.gmail.com>
 <CAODYyLZUt8vyzSTV6Sv0VDNRZMs00MH0afoMdeBWXZwR_cFUeQ@mail.gmail.com>
Message-ID: <CAGPcNU0OROAWwKsnRX8FJWhKV+0UHSzKTM-4ZcOBaaXvEPCXtw@mail.gmail.com>

So, that means, KF5 *compiled* PKGs are available on repo, and PKGBUILDs to
build it are available on AUR? Right?

On Thu, Aug 15, 2013 at 12:02 PM, Giorgos Tsiapaliokas
<terietor at gmail.com>wrote:

> https://aur.archlinux.org/packages/?O=0&K=kf5
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/a6e11474/attachment.html>

From sebas at kde.org  Thu Aug 15 12:12:21 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Thu, 15 Aug 2013 12:12:21 -0000
Subject: Review Request 112088: active-about: add new Contributors for PA 4
In-Reply-To: <20130814155255.31553.41552@vidsolbach.de>
References: <20130814155255.31553.41552@vidsolbach.de>
Message-ID: <20130815121221.20793.90431@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112088/#review37838
-----------------------------------------------------------

Ship it!


One R(?|ue)diger has answered, you can commit it.

- Sebastian K?gler


On Aug. 14, 2013, 3:52 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112088/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 3:52 p.m.)
> 
> 
> Review request for Plasma and Ruediger Gad.
> 
> 
> Description
> -------
> 
> Adds rcg and myself to the contributors.
> I still wait for a reply from rcg. maybe he does not want to get listed, or his name is really Ruediger and not R?diger. :)
> 
> 
> Diffs
> -----
> 
>   applications/about/package/contents/data/authors.html 1feb156 
> 
> Diff: http://git.reviewboard.kde.org/r/112088/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/34a6be24/attachment.html>

From kde at privat.broulik.de  Thu Aug 15 14:51:40 2013
From: kde at privat.broulik.de (Kai Uwe Broulik)
Date: Thu, 15 Aug 2013 16:51:40 +0200
Subject: Actual width of checkbox element
Message-ID: <2372011.FJYrJkaRds@kaiuwe-tragbar2>

Hi there,

I got a bug report [1] about that the popup width might get so small that the 
PM checkbox doesn't fit entirely.
Is there a way to determin the actual width of the checkbox including its 
label?
So I could do minimumWidth: Math.max( currentminimumwidth, checkboxwidth)
Or should I just use a fixed, say, 250px minimum width?

Best,
Kai Uwe

[1] https://bugs.kde.org/show_bug.cgi?id=323530


From dantti12 at gmail.com  Thu Aug 15 15:11:43 2013
From: dantti12 at gmail.com (Daniel Nicoletti)
Date: Thu, 15 Aug 2013 12:11:43 -0300
Subject: Actual width of checkbox element
In-Reply-To: <2372011.FJYrJkaRds@kaiuwe-tragbar2>
References: <2372011.FJYrJkaRds@kaiuwe-tragbar2>
Message-ID: <CACo8zOdVgbuBdamRwAmJLpdTiBuYphJNQ-gAc86NV2mKscrQTw@mail.gmail.com>

This is the reason in Apper updater the checkbox
doesn't use the text property, instead I have a checkbox
with no text and a Text  element next to it and eliding right.
I don't think you can do it other way as there is no
other properties exposed, but I might be wrong...

2013/8/15 Kai Uwe Broulik <kde at privat.broulik.de>:
> Hi there,
>
> I got a bug report [1] about that the popup width might get so small that the
> PM checkbox doesn't fit entirely.
> Is there a way to determin the actual width of the checkbox including its
> label?
> So I could do minimumWidth: Math.max( currentminimumwidth, checkboxwidth)
> Or should I just use a fixed, say, 250px minimum width?
>
> Best,
> Kai Uwe
>
> [1] https://bugs.kde.org/show_bug.cgi?id=323530
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel



-- 
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com

From notmart at gmail.com  Thu Aug 15 15:13:18 2013
From: notmart at gmail.com (Marco Martin)
Date: Thu, 15 Aug 2013 17:13:18 +0200
Subject: Actual width of checkbox element
In-Reply-To: <2372011.FJYrJkaRds@kaiuwe-tragbar2>
References: <2372011.FJYrJkaRds@kaiuwe-tragbar2>
Message-ID: <201308151713.19164.notmart@gmail.com>

On Thursday 15 August 2013, Kai Uwe Broulik wrote:
> Hi there,
> 
> I got a bug report [1] about that the popup width might get so small that
> the PM checkbox doesn't fit entirely.
> Is there a way to determin the actual width of the checkbox including its
> label?
> So I could do minimumWidth: Math.max( currentminimumwidth, checkboxwidth)
> Or should I just use a fixed, say, 250px minimum width?

its implicitWidth should return a proper value (if it doesn't means the 
component should be fixed ;)


-- 
Marco Martin

From heena393 at gmail.com  Thu Aug 15 15:32:18 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Thu, 15 Aug 2013 15:32:18 +0000
Subject: plasma-shell in plasma2
Message-ID: <CAFCfA18ScNtoiM_Mz5T7vkVMtMG-cgOYG6zaNrVbNgc2AB5dRg@mail.gmail.com>

Hey

I am getting http://picpaste.com/screen13-GNKwWhEy.png this on plasma-shell.
This is the output on terminal  http://pastebin.com/raw.php?i=zL2fMK8c
Could you suggest how I may load plasmoid in plasma-shell ?

Regards

-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/84b03759/attachment.html>

From notmart at gmail.com  Thu Aug 15 15:38:25 2013
From: notmart at gmail.com (Marco Martin)
Date: Thu, 15 Aug 2013 17:38:25 +0200
Subject: plasma-shell in plasma2
In-Reply-To: <CAFCfA18ScNtoiM_Mz5T7vkVMtMG-cgOYG6zaNrVbNgc2AB5dRg@mail.gmail.com>
References: <CAFCfA18ScNtoiM_Mz5T7vkVMtMG-cgOYG6zaNrVbNgc2AB5dRg@mail.gmail.com>
Message-ID: <201308151738.25492.notmart@gmail.com>

On Thursday 15 August 2013, Heena Mahour wrote:
> Hey
> 
> I am getting http://picpaste.com/screen13-GNKwWhEy.png this on
> plasma-shell. This is the output on terminal 
> http://pastebin.com/raw.php?i=zL2fMK8c Could you suggest how I may load
> plasmoid in plasma-shell ?
> 
> Regards
Q_PLUGIN_PATH and QML2_IMPORT_PATH are correct?

-- 
Marco Martin

From heena393 at gmail.com  Thu Aug 15 16:16:08 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Thu, 15 Aug 2013 16:16:08 +0000
Subject: plasma-shell in plasma2
In-Reply-To: <201308151738.25492.notmart@gmail.com>
References: <CAFCfA18ScNtoiM_Mz5T7vkVMtMG-cgOYG6zaNrVbNgc2AB5dRg@mail.gmail.com>
 <201308151738.25492.notmart@gmail.com>
Message-ID: <CAFCfA1_4eJHGoFV3aMpjShC0dzfpFj9c7UQjfzOgRJmb9=bMzQ@mail.gmail.com>

export
QT_PLUGIN_PATH=$KF5/lib/plugins:$KF5/lib64/plugins:$KF5/lib/i386-linux-gnu/plugins:$QTDIR/plugins#:$QT_PLUGIN_PATH
export
QML2_IMPORT_PATH=$KF5/lib/qml:$KF5/lib64/qml:$KF5/lib/i386-linux-gnu/qml:$QTDIR/qml
If I do echo $KF5/lib/plugins then it is giving /opt/kf5/lib/plugins
How can I be sure that the paths are correct ?



On Thu, Aug 15, 2013 at 3:38 PM, Marco Martin <notmart at gmail.com> wrote:

> On Thursday 15 August 2013, Heena Mahour wrote:
> > Hey
> >
> > I am getting http://picpaste.com/screen13-GNKwWhEy.png this on
> > plasma-shell. This is the output on terminal
> > http://pastebin.com/raw.php?i=zL2fMK8c Could you suggest how I may load
> > plasmoid in plasma-shell ?
> >
> > Regards
> Q_PLUGIN_PATH and QML2_IMPORT_PATH are correct?
>
> --
> Marco Martin
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/2b0dde7c/attachment-0001.html>

From heena393 at gmail.com  Thu Aug 15 16:40:46 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Thu, 15 Aug 2013 16:40:46 +0000
Subject: plasma-shell in plasma2
In-Reply-To: <CAFCfA1_4eJHGoFV3aMpjShC0dzfpFj9c7UQjfzOgRJmb9=bMzQ@mail.gmail.com>
References: <CAFCfA18ScNtoiM_Mz5T7vkVMtMG-cgOYG6zaNrVbNgc2AB5dRg@mail.gmail.com>
 <201308151738.25492.notmart@gmail.com>
 <CAFCfA1_4eJHGoFV3aMpjShC0dzfpFj9c7UQjfzOgRJmb9=bMzQ@mail.gmail.com>
Message-ID: <CAFCfA18Q=+y3VfFa2Ac8Qr+QopbBwQ4em2nu=1+QiZL5GAXmxA@mail.gmail.com>

okayy on deleting  ~/.config5/plasma-shellrc I got it .


On Thu, Aug 15, 2013 at 4:16 PM, Heena Mahour <heena393 at gmail.com> wrote:

> export
> QT_PLUGIN_PATH=$KF5/lib/plugins:$KF5/lib64/plugins:$KF5/lib/i386-linux-gnu/plugins:$QTDIR/plugins#:$QT_PLUGIN_PATH
> export
> QML2_IMPORT_PATH=$KF5/lib/qml:$KF5/lib64/qml:$KF5/lib/i386-linux-gnu/qml:$QTDIR/qml
> If I do echo $KF5/lib/plugins then it is giving /opt/kf5/lib/plugins
> How can I be sure that the paths are correct ?
>
>
>
> On Thu, Aug 15, 2013 at 3:38 PM, Marco Martin <notmart at gmail.com> wrote:
>
>> On Thursday 15 August 2013, Heena Mahour wrote:
>> > Hey
>> >
>> > I am getting http://picpaste.com/screen13-GNKwWhEy.png this on
>> > plasma-shell. This is the output on terminal
>> > http://pastebin.com/raw.php?i=zL2fMK8c Could you suggest how I may load
>> > plasmoid in plasma-shell ?
>> >
>> > Regards
>> Q_PLUGIN_PATH and QML2_IMPORT_PATH are correct?
>>
>> --
>> Marco Martin
>> _______________________________________________
>> Plasma-devel mailing list
>> Plasma-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>
>
>
> --
> -Heena
> Season of kde'12 participant
> Google Summer of Code 2013
> Delhi College of Engineering(COE),India
> http://about.me/heena.mahour
> http://heenamahour.blogspot.in
>
>


-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/db4d258f/attachment.html>

From heena393 at gmail.com  Thu Aug 15 17:18:38 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Thu, 15 Aug 2013 17:18:38 +0000
Subject: plasma-shell in plasma2
In-Reply-To: <CAFCfA18Q=+y3VfFa2Ac8Qr+QopbBwQ4em2nu=1+QiZL5GAXmxA@mail.gmail.com>
References: <CAFCfA18ScNtoiM_Mz5T7vkVMtMG-cgOYG6zaNrVbNgc2AB5dRg@mail.gmail.com>
 <201308151738.25492.notmart@gmail.com>
 <CAFCfA1_4eJHGoFV3aMpjShC0dzfpFj9c7UQjfzOgRJmb9=bMzQ@mail.gmail.com>
 <CAFCfA18Q=+y3VfFa2Ac8Qr+QopbBwQ4em2nu=1+QiZL5GAXmxA@mail.gmail.com>
Message-ID: <CAFCfA1_Keb8wJt7613OPcYvGCuoq5r5EnC=UZOUC76UBGFqNjA@mail.gmail.com>

However , the plasmoids appear on the desktop (plasma 2 ) momentary then it
shows an output plasma-shell(31515)/default onTriggered: Saved coordinates
for ToolBox in config: 992x992
plasma-shell(31515)/default qt_assert: ASSERT: "oldActiveFocusItem" in file
items/qquickwindow.cpp, line 735
Aborted (core dumped)
on terminal and terminates ..
so unable to test it out .


On Thu, Aug 15, 2013 at 4:40 PM, Heena Mahour <heena393 at gmail.com> wrote:

> okayy on deleting  ~/.config5/plasma-shellrc I got it .
>
>
> On Thu, Aug 15, 2013 at 4:16 PM, Heena Mahour <heena393 at gmail.com> wrote:
>
>> export
>> QT_PLUGIN_PATH=$KF5/lib/plugins:$KF5/lib64/plugins:$KF5/lib/i386-linux-gnu/plugins:$QTDIR/plugins#:$QT_PLUGIN_PATH
>> export
>> QML2_IMPORT_PATH=$KF5/lib/qml:$KF5/lib64/qml:$KF5/lib/i386-linux-gnu/qml:$QTDIR/qml
>> If I do echo $KF5/lib/plugins then it is giving /opt/kf5/lib/plugins
>> How can I be sure that the paths are correct ?
>>
>>
>>
>> On Thu, Aug 15, 2013 at 3:38 PM, Marco Martin <notmart at gmail.com> wrote:
>>
>>> On Thursday 15 August 2013, Heena Mahour wrote:
>>> > Hey
>>> >
>>> > I am getting http://picpaste.com/screen13-GNKwWhEy.png this on
>>> > plasma-shell. This is the output on terminal
>>> > http://pastebin.com/raw.php?i=zL2fMK8c Could you suggest how I may
>>> load
>>> > plasmoid in plasma-shell ?
>>> >
>>> > Regards
>>> Q_PLUGIN_PATH and QML2_IMPORT_PATH are correct?
>>>
>>> --
>>> Marco Martin
>>> _______________________________________________
>>> Plasma-devel mailing list
>>> Plasma-devel at kde.org
>>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>>
>>
>>
>>
>> --
>> -Heena
>> Season of kde'12 participant
>> Google Summer of Code 2013
>> Delhi College of Engineering(COE),India
>> http://about.me/heena.mahour
>> http://heenamahour.blogspot.in
>>
>>
>
>
> --
> -Heena
> Season of kde'12 participant
> Google Summer of Code 2013
> Delhi College of Engineering(COE),India
> http://about.me/heena.mahour
> http://heenamahour.blogspot.in
>
>


-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/f952a999/attachment.html>

From shantanu at kde.org  Thu Aug 15 17:49:12 2013
From: shantanu at kde.org (Shantanu Tushar)
Date: Thu, 15 Aug 2013 17:49:12 -0000
Subject: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent deletion
 of popped pages from PageStack
Message-ID: <20130815174912.11615.76044@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112105/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

In KDE 4.11, if you do not parent a page after popping it from PageStack, it will be deleted by QML's garbage collector. This creates erratic behavior such as stopping playback the moment the user presses back from media player.
This patch reparents the page to the root element (and hides it) to prevent the deletion.


Diffs
-----

  shells/newshell/package/contents/ui/mediacenter.qml 28ae8e6 

Diff: http://git.reviewboard.kde.org/r/112105/diff/


Testing
-------

Doesn't seem to affect any workflow. Things to look out are weird placements of the media elements (browser, player etc) due to the reparenting while going back/into some mode.


Thanks,

Shantanu Tushar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/c85dffb8/attachment.html>

From notmart at gmail.com  Thu Aug 15 18:14:09 2013
From: notmart at gmail.com (Marco Martin)
Date: Thu, 15 Aug 2013 18:14:09 -0000
Subject: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent
 deletion of popped pages from PageStack
In-Reply-To: <20130815174912.11615.76044@vidsolbach.de>
References: <20130815174912.11615.76044@vidsolbach.de>
Message-ID: <20130815181409.16545.51251@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112105/#review37870
-----------------------------------------------------------

Ship it!


meh, i changed it because some reported leaks since the expected way is that the stack owns and deletes the page apparently (the other implementations of pagestack, like qtcontrols, ubuntu and meego do this, so is also a porting issue)

so yeah, will have to use this workaround... (if there isn't a better idea)

- Marco Martin


On Aug. 15, 2013, 5:49 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112105/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 5:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In KDE 4.11, if you do not parent a page after popping it from PageStack, it will be deleted by QML's garbage collector. This creates erratic behavior such as stopping playback the moment the user presses back from media player.
> This patch reparents the page to the root element (and hides it) to prevent the deletion.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 28ae8e6 
> 
> Diff: http://git.reviewboard.kde.org/r/112105/diff/
> 
> 
> Testing
> -------
> 
> Doesn't seem to affect any workflow. Things to look out are weird placements of the media elements (browser, player etc) due to the reparenting while going back/into some mode.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/037b8030/attachment-0001.html>

From kde at privat.broulik.de  Thu Aug 15 18:33:04 2013
From: kde at privat.broulik.de (Kai Uwe Broulik)
Date: Thu, 15 Aug 2013 20:33:04 +0200
Subject: Actual width of checkbox element
In-Reply-To: <201308151713.19164.notmart@gmail.com>
References: <2372011.FJYrJkaRds@kaiuwe-tragbar2>
 <201308151713.19164.notmart@gmail.com>
Message-ID: <2133119.ov1jHK6aj1@kaiuwe-tragbar2>

Hi,

> its implicitWidth should return a proper value (if it doesn't means the
> component should be fixed ;)

implicitWidth seems to return 0 for the checkbox item.

(If I could've just kept the switch ? :P)




From ksinny at gmail.com  Thu Aug 15 18:50:05 2013
From: ksinny at gmail.com (Sinny Kumari)
Date: Thu, 15 Aug 2013 18:50:05 -0000
Subject: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent
 deletion of popped pages from PageStack
In-Reply-To: <20130815174912.11615.76044@vidsolbach.de>
References: <20130815174912.11615.76044@vidsolbach.de>
Message-ID: <20130815185005.18456.66049@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112105/#review37872
-----------------------------------------------------------

Ship it!


Thanks for noticing this issue on KDE 4.11. Works fine on KDE 4.10 too.

- Sinny Kumari


On Aug. 15, 2013, 5:49 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112105/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 5:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In KDE 4.11, if you do not parent a page after popping it from PageStack, it will be deleted by QML's garbage collector. This creates erratic behavior such as stopping playback the moment the user presses back from media player.
> This patch reparents the page to the root element (and hides it) to prevent the deletion.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 28ae8e6 
> 
> Diff: http://git.reviewboard.kde.org/r/112105/diff/
> 
> 
> Testing
> -------
> 
> Doesn't seem to affect any workflow. Things to look out are weird placements of the media elements (browser, player etc) due to the reparenting while going back/into some mode.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/8dd1cfc6/attachment.html>

From notmart at gmail.com  Thu Aug 15 19:52:03 2013
From: notmart at gmail.com (Marco Martin)
Date: Thu, 15 Aug 2013 21:52:03 +0200
Subject: Actual width of checkbox element
In-Reply-To: <2133119.ov1jHK6aj1@kaiuwe-tragbar2>
References: <2372011.FJYrJkaRds@kaiuwe-tragbar2>
 <201308151713.19164.notmart@gmail.com> <2133119.ov1jHK6aj1@kaiuwe-tragbar2>
Message-ID: <201308152152.04296.notmart@gmail.com>

On Thursday 15 August 2013, Kai Uwe Broulik wrote:
> Hi,
> 
> > its implicitWidth should return a proper value (if it doesn't means the
> > component should be fixed ;)
> 
> implicitWidth seems to return 0 for the checkbox item.

then needs to be fixed...

patches welcome ;)

-- 
Marco Martin

From kde at privat.broulik.de  Thu Aug 15 20:02:29 2013
From: kde at privat.broulik.de (Kai Uwe Broulik)
Date: Thu, 15 Aug 2013 22:02:29 +0200
Subject: Actual width of checkbox element
In-Reply-To: <201308152152.04296.notmart@gmail.com>
References: <2372011.FJYrJkaRds@kaiuwe-tragbar2>
 <2133119.ov1jHK6aj1@kaiuwe-tragbar2> <201308152152.04296.notmart@gmail.com>
Message-ID: <18866242.x3D0qdbTJY@kaiuwe-tragbar2>

> patches welcome ;)

Hmm, when I try to manually set the implicitWidth or route it somewhereelse it 
says "implicitWidth not available in QtQuick Item 1.0" (or so).


From notmart at gmail.com  Thu Aug 15 20:04:54 2013
From: notmart at gmail.com (Marco Martin)
Date: Thu, 15 Aug 2013 22:04:54 +0200
Subject: Actual width of checkbox element
In-Reply-To: <18866242.x3D0qdbTJY@kaiuwe-tragbar2>
References: <2372011.FJYrJkaRds@kaiuwe-tragbar2>
 <201308152152.04296.notmart@gmail.com> <18866242.x3D0qdbTJY@kaiuwe-tragbar2>
Message-ID: <201308152204.55238.notmart@gmail.com>

On Thursday 15 August 2013, Kai Uwe Broulik wrote:
> > patches welcome ;)
> 
> Hmm, when I try to manually set the implicitWidth or route it somewhereelse
> it says "implicitWidth not available in QtQuick Item 1.0" (or so).

implicitWidth is available only since 1.1, so across the component the import 
QtQuick 1.0 have to be changed in import QtQuick 1.1

-- 
Marco Martin

From kde at privat.broulik.de  Thu Aug 15 20:29:36 2013
From: kde at privat.broulik.de (Kai Uwe Broulik)
Date: Thu, 15 Aug 2013 22:29:36 +0200
Subject: Actual width of checkbox element
In-Reply-To: <201308152204.55238.notmart@gmail.com>
References: <2372011.FJYrJkaRds@kaiuwe-tragbar2>
 <18866242.x3D0qdbTJY@kaiuwe-tragbar2> <201308152204.55238.notmart@gmail.com>
Message-ID: <6857499.NQgcFn7EEn@kaiuwe-tragbar2>

Am Donnerstag, 15. August 2013, 22:04:54 schrieb Marco Martin:
> On Thursday 15 August 2013, Kai Uwe Broulik wrote:
> > > patches welcome ;)
> > 
> > Hmm, when I try to manually set the implicitWidth or route it
> > somewhereelse
> > it says "implicitWidth not available in QtQuick Item 1.0" (or so).
> 
> implicitWidth is available only since 1.1, so across the component the
> import QtQuick 1.0 have to be changed in import QtQuick 1.1

Oh, it was my fault :)

I tried to use the PowermanagementItem implicitWidth but the PMitem is not the 
checkbox itself, so I had to set its implicitWidth to use the checkbox 
implicitWidth and now all works without touching the plasma components \o/


From aacid at kde.org  Thu Aug 15 22:03:45 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Thu, 15 Aug 2013 22:03:45 -0000
Subject: Review Request 108325: LastNotificationPopup fix for closing not
 to move + add move button + better layout for 3 action buttons
In-Reply-To: <20130405161633.27215.86702@vidsolbach.de>
References: <20130405161633.27215.86702@vidsolbach.de>
Message-ID: <20130815220345.17501.54172@vidsolbach.de>



> On April 5, 2013, 4:16 p.m., Albert Astals Cid wrote:
> > Can you please attach the diff properly and not give ship its to yourself?
> > 
> > I'd suggest you discard this review that is already broken and start a new one where you attach the diff properly and you don't give you a ship it to yourself and then maybe others will have a look at it.
> 
> Leszek Lesner wrote:
>     If I would know hot to attach the diff properly I would have done it. It is just not recognizing the patch.
> 
> Albert Astals Cid wrote:
>     What error are you getting? How are you creating the patch?
> 
> Leszek Lesner wrote:
>     I got the error that this is not a patch or that the specified diff file is empty.
>     I created the patch with dpkg-source --commit and removed the description lines above.
> 
> Albert Astals Cid wrote:
>     dpkg-source --commit seems like a bad way to create a git compatible diff.
>     
>     Just do "git diff" on the git repo.
> 
> Leszek Lesner wrote:
>     Hmm... I did not have any git repo there. I just downloaded the sources directly. Maybe that was the whole mistake. 
>     But it is some month already ago that I created that patch and it should be mostly outdated now that we have 4.10.2 out. 
>     All in all I am a little bit unhappy that I posted this patch on the bug tracker and no one really cared about it and then posting it here only on someones advice and it was still not reviewed or integrated. 
>     And I can't imagine that it is all my fault.
>
> 
> Marco Martin wrote:
>     you should download it with git, and send the patch against master branch, see http://techbase.kde.org/Getting_Started and  http://www.youtube.com/watch?v=cqnNVmJocR4

I'm discarding this review, you gave a ship it to yourself and that was wrong. I gave you the pointers on how to do it right, i'm sorry if you find it hard.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108325/#review30476
-----------------------------------------------------------


On Jan. 10, 2013, 3:18 p.m., Leszek Lesner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108325/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 3:18 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Fixes the LastNotificationsPopup moving around when clicking on a button and adds a move button to freely place it all over the desktop. 
> Also this removes notifications jobs from the notification icon. (So clicking on X does not hide but really closes the notification and removes it)
> Also this fixes layout problems with 3 buttons displayed inside a notification (this caused the X button to overlap with the upper actionbutton).
> 
> As my original diff was not recognized as normal diff(don't know what I did wrong there) I attached the patch directly to this thread. 
> 
> 
> This addresses bug 311413.
>     http://bugs.kde.org/show_bug.cgi?id=311413
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/108325/diff/
> 
> 
> Testing
> -------
> 
> kdialog --passivepopup "bla"
> click on X, closes and removes job from notification Icon
> click and hold on move button moves the popup freely on the screen. 
> 
> 
> File Attachments
> ----------------
> 
> Patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/10/LastNotificationPopup_patch.diff
> 
> 
> Thanks,
> 
> Leszek Lesner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/94408197/attachment-0001.html>

From aacid at kde.org  Thu Aug 15 22:03:56 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Thu, 15 Aug 2013 22:03:56 -0000
Subject: Review Request 108325: LastNotificationPopup fix for closing not
 to move + add move button + better layout for 3 action buttons
In-Reply-To: <20130110151828.10250.90499@vidsolbach.de>
References: <20130110151828.10250.90499@vidsolbach.de>
Message-ID: <20130815220356.17501.17808@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108325/
-----------------------------------------------------------

(Updated Aug. 15, 2013, 10:03 p.m.)


Status
------

This change has been discarded.


Review request for Plasma and Marco Martin.


Description
-------

Fixes the LastNotificationsPopup moving around when clicking on a button and adds a move button to freely place it all over the desktop. 
Also this removes notifications jobs from the notification icon. (So clicking on X does not hide but really closes the notification and removes it)
Also this fixes layout problems with 3 buttons displayed inside a notification (this caused the X button to overlap with the upper actionbutton).

As my original diff was not recognized as normal diff(don't know what I did wrong there) I attached the patch directly to this thread. 


This addresses bug 311413.
    http://bugs.kde.org/show_bug.cgi?id=311413


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/108325/diff/


Testing
-------

kdialog --passivepopup "bla"
click on X, closes and removes job from notification Icon
click and hold on move button moves the popup freely on the screen. 


File Attachments
----------------

Patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/10/LastNotificationPopup_patch.diff


Thanks,

Leszek Lesner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/0e9c6fcf/attachment.html>

From aacid at kde.org  Thu Aug 15 22:05:11 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Thu, 15 Aug 2013 22:05:11 -0000
Subject: Review Request 110216: Rename Screen Locker screensaver KCM to
 Lock Screen
In-Reply-To: <20130427140950.22693.13320@vidsolbach.de>
References: <20130427140950.22693.13320@vidsolbach.de>
Message-ID: <20130815220511.17656.4152@vidsolbach.de>



> On April 27, 2013, 2:09 p.m., Marco Martin wrote:
> > Ship It!

Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110216/#review31682
-----------------------------------------------------------


On April 27, 2013, 11:37 a.m., Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110216/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 11:37 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> 'Screen Locker' sounds wrong, a locker is something you keep your books at school in.
> 
> 'Lock Screen' is currently frequently used in English on phones and is also used by Gnome Shell for their screensaver replacement.
> 
> 
> Diffs
> -----
> 
>   kcontrol/screensaver/screensaver.desktop d1f887a 
> 
> Diff: http://git.reviewboard.kde.org/r/110216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Will Stephenson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/2186de7b/attachment.html>

From aacid at kde.org  Thu Aug 15 22:10:00 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Thu, 15 Aug 2013 22:10:00 -0000
Subject: Review Request 110626: Overhaul sunxi kickstart generation into a
 generic way
In-Reply-To: <20130523215923.18015.95772@vidsolbach.de>
References: <20130523215923.18015.95772@vidsolbach.de>
Message-ID: <20130815221000.18266.61000@vidsolbach.de>



> On May 23, 2013, 9:59 p.m., Marco Martin wrote:
> > Ship It!

Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110626/#review33066
-----------------------------------------------------------


On May 23, 2013, 9:52 p.m., Maurice de la Fert? wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110626/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 9:52 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Also made some clean-ups and changed the adaptation repo
> 
> kickstart file generated via 'mer-kickstarter -e . -c releases/plasma-active-4.yaml -o plasma-active' could be found here (renamed):
> 
> ftp://5.9.162.110/plasma-active/coby/tablet/MID7042/mer/stable/armv7hl/weekly/plasma-active-coby-tablet-MID7042-mer-stable-armv7hl-weekly-20130523-2327.ks
> 
> 
> Diffs
> -----
> 
>   adaptations/sunxi-generic.yaml PRE-CREATION 
>   adaptations/sunxi.yaml d6483c8 
>   base.yaml 58f8f79 
>   generic/repos.yaml 245b7b4 
>   scripts/sunxi-generic-copy-boot-scr.post PRE-CREATION 
>   scripts/sunxi-generic-feed-some-modules.post PRE-CREATION 
>   scripts/sunxi-remove-swap-from-fstab-workaround.post PRE-CREATION 
>   scripts/sunxi.partition 200bf5d 
>   scripts/sunxi.post dbac4fa 
> 
> Diff: http://git.reviewboard.kde.org/r/110626/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maurice de la Fert?
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/adb65e31/attachment.html>

From aacid at kde.org  Thu Aug 15 22:11:48 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Thu, 15 Aug 2013 22:11:48 -0000
Subject: Review Request 110288: Checks if an optional field was
 instantiated before accessing it
In-Reply-To: <20130504091448.590.32834@vidsolbach.de>
References: <20130504091448.590.32834@vidsolbach.de>
Message-ID: <20130815221148.18990.39125@vidsolbach.de>



> On May 4, 2013, 9:14 a.m., Giorgos Tsiapaliokas wrote:
> > The patch is ok, it can go in.
> > 
> > Are you familiar with out git workflow policy?
> > 
> > http://community.kde.org/Plasma/IntegrationBranches/GeneralPolicy
> > 
> > If you have any questions don't hesitate to ask :)

Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110288/#review31994
-----------------------------------------------------------


On May 3, 2013, 8:38 p.m., Denis Falqueto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110288/
> -----------------------------------------------------------
> 
> (Updated May 3, 2013, 8:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The private field m_konsolewidget is initialized only on some specific cases, so it should be accessed with caution. But there are some places in witch it's being used without checking if it was instantiated or not. This patch fixes those accesses, by checking if it is instantiated or not.
> 
> 
> This addresses bug 319291.
>     http://bugs.kde.org/show_bug.cgi?id=319291
> 
> 
> Diffs
> -----
> 
>   plasmate/mainwindow.cpp 1ef5a81 
> 
> Diff: http://git.reviewboard.kde.org/r/110288/diff/
> 
> 
> Testing
> -------
> 
> I've created a data engine in python successfully.
> 
> 
> Thanks,
> 
> Denis Falqueto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/d3c82c4a/attachment.html>

From aacid at kde.org  Thu Aug 15 22:12:05 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Thu, 15 Aug 2013 22:12:05 -0000
Subject: Review Request 107908: Fix dismissing LastNotificationPopup often
 failing
In-Reply-To: <20130424185116.21356.40305@vidsolbach.de>
References: <20130424185116.21356.40305@vidsolbach.de>
Message-ID: <20130815221205.18990.23018@vidsolbach.de>



> On April 24, 2013, 6:51 p.m., Marco Martin wrote:
> > Ship It!

Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107908/#review31508
-----------------------------------------------------------


On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107908/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2012, 2:43 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch disables the setCustomNotification while a button (close, next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked event.
> Problem is more deep in Plasma but has been around since Plasma exists, so this should fix it for the notifications.
> 
> 
> This addresses bug 311413.
>     http://bugs.kde.org/show_bug.cgi?id=311413
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
> 
> Diff: http://git.reviewboard.kde.org/r/107908/diff/
> 
> 
> Testing
> -------
> 
> kdialog --passivepopup "bla"
> click, closes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/fd9ea239/attachment-0001.html>

From notmart at gmail.com  Thu Aug 15 22:20:22 2013
From: notmart at gmail.com (Marco Martin)
Date: Thu, 15 Aug 2013 22:20:22 -0000
Subject: Review Request 110626: Overhaul sunxi kickstart generation into a
 generic way
In-Reply-To: <20130523215923.18015.95772@vidsolbach.de>
References: <20130523215923.18015.95772@vidsolbach.de>
Message-ID: <20130815222022.19651.65528@vidsolbach.de>



> On May 23, 2013, 9:59 p.m., Marco Martin wrote:
> > Ship It!
> 
> Albert Astals Cid wrote:
>     Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?
>

it can be marked as submitted, yes


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110626/#review33066
-----------------------------------------------------------


On May 23, 2013, 9:52 p.m., Maurice de la Fert? wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110626/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 9:52 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Also made some clean-ups and changed the adaptation repo
> 
> kickstart file generated via 'mer-kickstarter -e . -c releases/plasma-active-4.yaml -o plasma-active' could be found here (renamed):
> 
> ftp://5.9.162.110/plasma-active/coby/tablet/MID7042/mer/stable/armv7hl/weekly/plasma-active-coby-tablet-MID7042-mer-stable-armv7hl-weekly-20130523-2327.ks
> 
> 
> Diffs
> -----
> 
>   adaptations/sunxi-generic.yaml PRE-CREATION 
>   adaptations/sunxi.yaml d6483c8 
>   base.yaml 58f8f79 
>   generic/repos.yaml 245b7b4 
>   scripts/sunxi-generic-copy-boot-scr.post PRE-CREATION 
>   scripts/sunxi-generic-feed-some-modules.post PRE-CREATION 
>   scripts/sunxi-remove-swap-from-fstab-workaround.post PRE-CREATION 
>   scripts/sunxi.partition 200bf5d 
>   scripts/sunxi.post dbac4fa 
> 
> Diff: http://git.reviewboard.kde.org/r/110626/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maurice de la Fert?
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/1e383c0b/attachment.html>

From notmart at gmail.com  Thu Aug 15 22:24:02 2013
From: notmart at gmail.com (Marco Martin)
Date: Thu, 15 Aug 2013 22:24:02 -0000
Subject: Review Request 110216: Rename Screen Locker screensaver KCM to
 Lock Screen
In-Reply-To: <20130427140950.22693.13320@vidsolbach.de>
References: <20130427140950.22693.13320@vidsolbach.de>
Message-ID: <20130815222402.19811.73683@vidsolbach.de>



> On April 27, 2013, 2:09 p.m., Marco Martin wrote:
> > Ship It!
> 
> Albert Astals Cid wrote:
>     Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?
>

should still be committed


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110216/#review31682
-----------------------------------------------------------


On April 27, 2013, 11:37 a.m., Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110216/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 11:37 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> 'Screen Locker' sounds wrong, a locker is something you keep your books at school in.
> 
> 'Lock Screen' is currently frequently used in English on phones and is also used by Gnome Shell for their screensaver replacement.
> 
> 
> Diffs
> -----
> 
>   kcontrol/screensaver/screensaver.desktop d1f887a 
> 
> Diff: http://git.reviewboard.kde.org/r/110216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Will Stephenson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/83b60862/attachment.html>

From bcooksley at kde.org  Thu Aug 15 22:41:55 2013
From: bcooksley at kde.org (Ben Cooksley)
Date: Thu, 15 Aug 2013 22:41:55 -0000
Subject: Review Request 110626: Overhaul sunxi kickstart generation into a
 generic way
In-Reply-To: <20130523215255.17572.53442@vidsolbach.de>
References: <20130523215255.17572.53442@vidsolbach.de>
Message-ID: <20130815224155.20722.52989@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110626/
-----------------------------------------------------------

(Updated Aug. 15, 2013, 10:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Description
-------

Also made some clean-ups and changed the adaptation repo

kickstart file generated via 'mer-kickstarter -e . -c releases/plasma-active-4.yaml -o plasma-active' could be found here (renamed):

ftp://5.9.162.110/plasma-active/coby/tablet/MID7042/mer/stable/armv7hl/weekly/plasma-active-coby-tablet-MID7042-mer-stable-armv7hl-weekly-20130523-2327.ks


Diffs
-----

  adaptations/sunxi-generic.yaml PRE-CREATION 
  adaptations/sunxi.yaml d6483c8 
  base.yaml 58f8f79 
  generic/repos.yaml 245b7b4 
  scripts/sunxi-generic-copy-boot-scr.post PRE-CREATION 
  scripts/sunxi-generic-feed-some-modules.post PRE-CREATION 
  scripts/sunxi-remove-swap-from-fstab-workaround.post PRE-CREATION 
  scripts/sunxi.partition 200bf5d 
  scripts/sunxi.post dbac4fa 

Diff: http://git.reviewboard.kde.org/r/110626/diff/


Testing
-------


Thanks,

Maurice de la Fert?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/65c8cf2a/attachment.html>

From aacid at kde.org  Thu Aug 15 22:43:23 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Thu, 15 Aug 2013 22:43:23 -0000
Subject: Review Request 110216: Rename Screen Locker screensaver KCM to
 Lock Screen
In-Reply-To: <20130427140950.22693.13320@vidsolbach.de>
References: <20130427140950.22693.13320@vidsolbach.de>
Message-ID: <20130815224323.20780.27041@vidsolbach.de>



> On April 27, 2013, 2:09 p.m., Marco Martin wrote:
> > Ship It!
> 
> Albert Astals Cid wrote:
>     Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?
>
> 
> Marco Martin wrote:
>     should still be committed

Want me to do it? Marco, Will? Note this introduces a string change, so frameworks branch only? Or request a i18n exception for 4.11.x?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110216/#review31682
-----------------------------------------------------------


On April 27, 2013, 11:37 a.m., Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110216/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 11:37 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> 'Screen Locker' sounds wrong, a locker is something you keep your books at school in.
> 
> 'Lock Screen' is currently frequently used in English on phones and is also used by Gnome Shell for their screensaver replacement.
> 
> 
> Diffs
> -----
> 
>   kcontrol/screensaver/screensaver.desktop d1f887a 
> 
> Diff: http://git.reviewboard.kde.org/r/110216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Will Stephenson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/9e2c1cc8/attachment.html>

From null at kde.org  Fri Aug 16 05:40:57 2013
From: null at kde.org (Commit Hook)
Date: Fri, 16 Aug 2013 05:40:57 -0000
Subject: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent
 deletion of popped pages from PageStack
In-Reply-To: <20130815174912.11615.76044@vidsolbach.de>
References: <20130815174912.11615.76044@vidsolbach.de>
Message-ID: <20130816054057.10245.88342@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112105/#review37914
-----------------------------------------------------------


This review has been submitted with commit 23f0363ba442f504e01cafe063eaf4f17789887b by Shantanu Tushar to branch master.

- Commit Hook


On Aug. 15, 2013, 5:49 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112105/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 5:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In KDE 4.11, if you do not parent a page after popping it from PageStack, it will be deleted by QML's garbage collector. This creates erratic behavior such as stopping playback the moment the user presses back from media player.
> This patch reparents the page to the root element (and hides it) to prevent the deletion.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 28ae8e6 
> 
> Diff: http://git.reviewboard.kde.org/r/112105/diff/
> 
> 
> Testing
> -------
> 
> Doesn't seem to affect any workflow. Things to look out are weird placements of the media elements (browser, player etc) due to the reparenting while going back/into some mode.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/9c5da61f/attachment-0001.html>

From null at kde.org  Fri Aug 16 05:41:00 2013
From: null at kde.org (Commit Hook)
Date: Fri, 16 Aug 2013 05:41:00 -0000
Subject: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent
 deletion of popped pages from PageStack
In-Reply-To: <20130815174912.11615.76044@vidsolbach.de>
References: <20130815174912.11615.76044@vidsolbach.de>
Message-ID: <20130816054100.10104.25471@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112105/
-----------------------------------------------------------

(Updated Aug. 16, 2013, 5:41 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

In KDE 4.11, if you do not parent a page after popping it from PageStack, it will be deleted by QML's garbage collector. This creates erratic behavior such as stopping playback the moment the user presses back from media player.
This patch reparents the page to the root element (and hides it) to prevent the deletion.


Diffs
-----

  shells/newshell/package/contents/ui/mediacenter.qml 28ae8e6 

Diff: http://git.reviewboard.kde.org/r/112105/diff/


Testing
-------

Doesn't seem to affect any workflow. Things to look out are weird placements of the media elements (browser, player etc) due to the reparenting while going back/into some mode.


Thanks,

Shantanu Tushar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/07e44f9f/attachment.html>

From bhush94 at gmail.com  Fri Aug 16 08:40:46 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Fri, 16 Aug 2013 14:10:46 +0530
Subject: How to build KDE Workspace on top of KF5?
Message-ID: <CAGPcNU0GAaomCSFSc5aAxmV3akGBDgXyGVe=1M8hSARBOHwZWA@mail.gmail.com>

Hello,

I have installed the project-neon5-session in my KUbuntu installation and
now want to build frameworks-scratch branch of the kde-workspace.

What are the next steps? Please someone give me guide to build it.

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/ab097d18/attachment.html>

From terietor at gmail.com  Fri Aug 16 08:51:56 2013
From: terietor at gmail.com (Giorgos Tsiapaliokas)
Date: Fri, 16 Aug 2013 08:51:56 -0000
Subject: Review Request 110288: Checks if an optional field was
 instantiated before accessing it
In-Reply-To: <20130504091448.590.32834@vidsolbach.de>
References: <20130504091448.590.32834@vidsolbach.de>
Message-ID: <20130816085156.32483.39915@vidsolbach.de>



> On May 4, 2013, 9:14 a.m., Giorgos Tsiapaliokas wrote:
> > The patch is ok, it can go in.
> > 
> > Are you familiar with out git workflow policy?
> > 
> > http://community.kde.org/Plasma/IntegrationBranches/GeneralPolicy
> > 
> > If you have any questions don't hesitate to ask :)
> 
> Albert Astals Cid wrote:
>     Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?
>

No this hasn't been submitted yet. I am waiting for the contributor.
I am aware of the existence of this review. If the contributor doesn't
show up I will submit it.


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110288/#review31994
-----------------------------------------------------------


On May 3, 2013, 8:38 p.m., Denis Falqueto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110288/
> -----------------------------------------------------------
> 
> (Updated May 3, 2013, 8:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The private field m_konsolewidget is initialized only on some specific cases, so it should be accessed with caution. But there are some places in witch it's being used without checking if it was instantiated or not. This patch fixes those accesses, by checking if it is instantiated or not.
> 
> 
> This addresses bug 319291.
>     http://bugs.kde.org/show_bug.cgi?id=319291
> 
> 
> Diffs
> -----
> 
>   plasmate/mainwindow.cpp 1ef5a81 
> 
> Diff: http://git.reviewboard.kde.org/r/110288/diff/
> 
> 
> Testing
> -------
> 
> I've created a data engine in python successfully.
> 
> 
> Thanks,
> 
> Denis Falqueto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/d76097a8/attachment.html>

From aacid at kde.org  Fri Aug 16 08:53:43 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Fri, 16 Aug 2013 08:53:43 -0000
Subject: Review Request 110288: Checks if an optional field was
 instantiated before accessing it
In-Reply-To: <20130504091448.590.32834@vidsolbach.de>
References: <20130504091448.590.32834@vidsolbach.de>
Message-ID: <20130816085343.32668.74943@vidsolbach.de>



> On May 4, 2013, 9:14 a.m., Giorgos Tsiapaliokas wrote:
> > The patch is ok, it can go in.
> > 
> > Are you familiar with out git workflow policy?
> > 
> > http://community.kde.org/Plasma/IntegrationBranches/GeneralPolicy
> > 
> > If you have any questions don't hesitate to ask :)
> 
> Albert Astals Cid wrote:
>     Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?
>
> 
> Giorgos Tsiapaliokas wrote:
>     No this hasn't been submitted yet. I am waiting for the contributor.
>     I am aware of the existence of this review. If the contributor doesn't
>     show up I will submit it.

FYI The contributor can't commit since he doesn't have a commiter account. You can wait all you want, it won't happen.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110288/#review31994
-----------------------------------------------------------


On May 3, 2013, 8:38 p.m., Denis Falqueto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110288/
> -----------------------------------------------------------
> 
> (Updated May 3, 2013, 8:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The private field m_konsolewidget is initialized only on some specific cases, so it should be accessed with caution. But there are some places in witch it's being used without checking if it was instantiated or not. This patch fixes those accesses, by checking if it is instantiated or not.
> 
> 
> This addresses bug 319291.
>     http://bugs.kde.org/show_bug.cgi?id=319291
> 
> 
> Diffs
> -----
> 
>   plasmate/mainwindow.cpp 1ef5a81 
> 
> Diff: http://git.reviewboard.kde.org/r/110288/diff/
> 
> 
> Testing
> -------
> 
> I've created a data engine in python successfully.
> 
> 
> Thanks,
> 
> Denis Falqueto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/b2bbd706/attachment.html>

From kde at privat.broulik.de  Fri Aug 16 09:57:00 2013
From: kde at privat.broulik.de (Kai Uwe Broulik)
Date: Fri, 16 Aug 2013 09:57:00 -0000
Subject: Review Request 107908: Fix dismissing LastNotificationPopup often
 failing
In-Reply-To: <20130424185116.21356.40305@vidsolbach.de>
References: <20130424185116.21356.40305@vidsolbach.de>
Message-ID: <20130816095700.7784.9732@vidsolbach.de>



> On April 24, 2013, 6:51 p.m., Marco Martin wrote:
> > Ship It!
> 
> Albert Astals Cid wrote:
>     Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?
>

Marco did some changes to that part in the meantime [1] and I cannot really reproduce the problem anymore for a long time now, seems the close signal is emitted even when you're dragging the popup on the button and then release.

[1] http://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=77a3bf4aca1e876fd234eaa15ad58f984b6b9d54


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107908/#review31508
-----------------------------------------------------------


On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107908/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2012, 2:43 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch disables the setCustomNotification while a button (close, next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked event.
> Problem is more deep in Plasma but has been around since Plasma exists, so this should fix it for the notifications.
> 
> 
> This addresses bug 311413.
>     http://bugs.kde.org/show_bug.cgi?id=311413
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
> 
> Diff: http://git.reviewboard.kde.org/r/107908/diff/
> 
> 
> Testing
> -------
> 
> kdialog --passivepopup "bla"
> click, closes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/4126ff54/attachment-0001.html>

From aacid at kde.org  Fri Aug 16 10:01:13 2013
From: aacid at kde.org (Albert Astals Cid)
Date: Fri, 16 Aug 2013 10:01:13 -0000
Subject: Review Request 107908: Fix dismissing LastNotificationPopup often
 failing
In-Reply-To: <20130424185116.21356.40305@vidsolbach.de>
References: <20130424185116.21356.40305@vidsolbach.de>
Message-ID: <20130816100113.8653.25835@vidsolbach.de>



> On April 24, 2013, 6:51 p.m., Marco Martin wrote:
> > Ship It!
> 
> Albert Astals Cid wrote:
>     Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?
>
> 
> Kai Uwe Broulik wrote:
>     Marco did some changes to that part in the meantime [1] and I cannot really reproduce the problem anymore for a long time now, seems the close signal is emitted even when you're dragging the popup on the button and then release.
>     
>     [1] http://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=77a3bf4aca1e876fd234eaa15ad58f984b6b9d54
>

So shall we discard this?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107908/#review31508
-----------------------------------------------------------


On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107908/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2012, 2:43 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch disables the setCustomNotification while a button (close, next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked event.
> Problem is more deep in Plasma but has been around since Plasma exists, so this should fix it for the notifications.
> 
> 
> This addresses bug 311413.
>     http://bugs.kde.org/show_bug.cgi?id=311413
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
> 
> Diff: http://git.reviewboard.kde.org/r/107908/diff/
> 
> 
> Testing
> -------
> 
> kdialog --passivepopup "bla"
> click, closes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/84f0817c/attachment.html>

From mgraesslin at kde.org  Fri Aug 16 10:07:20 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Fri, 16 Aug 2013 12:07:20 +0200
Subject: How to build KDE Workspace on top of KF5?
In-Reply-To: <CAGPcNU0GAaomCSFSc5aAxmV3akGBDgXyGVe=1M8hSARBOHwZWA@mail.gmail.com>
References: <CAGPcNU0GAaomCSFSc5aAxmV3akGBDgXyGVe=1M8hSARBOHwZWA@mail.gmail.com>
Message-ID: <1496364.U9dYM3tXQS@martin-thinkpad>

On Friday 16 August 2013 14:10:46 Bhushan Shah wrote:
> Hello,
> 
> I have installed the project-neon5-session in my KUbuntu installation and
> now want to build frameworks-scratch branch of the kde-workspace.
> 
> What are the next steps? Please someone give me guide to build it.
it's not really different. Just use kdesrc-build as instructed on 
https://community.kde.org/Frameworks/Building

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/8cd8f210/attachment.sig>

From bhush94 at gmail.com  Fri Aug 16 11:28:02 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Fri, 16 Aug 2013 16:58:02 +0530
Subject: How to build KDE Workspace on top of KF5?
In-Reply-To: <1496364.U9dYM3tXQS@martin-thinkpad>
References: <CAGPcNU0GAaomCSFSc5aAxmV3akGBDgXyGVe=1M8hSARBOHwZWA@mail.gmail.com>
 <1496364.U9dYM3tXQS@martin-thinkpad>
Message-ID: <CAGPcNU096Enob12OBkz+8pLYokT0gDToVv_Jy1C7R0cVmTQq+A@mail.gmail.com>

Hello,

On page it reads

qtdir /d/qt/5/kde/qtbase
source-dir /d/kde/src/5
build-dir /d/kde/build/5
kdedir /d/kde/inst/kde_frameworks

In this source-dir, build-dir and kdedir is easy to understand but what to
enter instead of qtdir? I have installed project-neon5-session. It
installed inside /opt/project-neon5.

Thanks!


On Fri, Aug 16, 2013 at 3:37 PM, Martin Graesslin <mgraesslin at kde.org>wrote:

> On Friday 16 August 2013 14:10:46 Bhushan Shah wrote:
> > Hello,
> >
> > I have installed the project-neon5-session in my KUbuntu installation and
> > now want to build frameworks-scratch branch of the kde-workspace.
> >
> > What are the next steps? Please someone give me guide to build it.
> it's not really different. Just use kdesrc-build as instructed on
> https://community.kde.org/Frameworks/Building
>
> Cheers
> Martin
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/53443040/attachment.html>

From terietor at gmail.com  Fri Aug 16 19:11:34 2013
From: terietor at gmail.com (Giorgos Tsiapaliokas)
Date: Fri, 16 Aug 2013 22:11:34 +0300
Subject: How to build KDE Workspace on top of KF5?
In-Reply-To: <CAGPcNU096Enob12OBkz+8pLYokT0gDToVv_Jy1C7R0cVmTQq+A@mail.gmail.com>
References: <CAGPcNU0GAaomCSFSc5aAxmV3akGBDgXyGVe=1M8hSARBOHwZWA@mail.gmail.com>
 <1496364.U9dYM3tXQS@martin-thinkpad>
 <CAGPcNU096Enob12OBkz+8pLYokT0gDToVv_Jy1C7R0cVmTQq+A@mail.gmail.com>
Message-ID: <CAODYyLafg9UWcxEus6FS84iwhbkQPDiOYhS0nRkMz61J49gJFw@mail.gmail.com>

On 16 August 2013 14:28, Bhushan Shah <bhush94 at gmail.com> wrote:
>
> In this source-dir, build-dir and kdedir is easy to understand but what to
> enter instead of qtdir? I have installed project-neon5-session. It
> installed inside /opt/project-neon5.
>

qtdir is path in which your qt5 are libraries are.
You can find this path from the command `qmake -v`.

In my machine it gives
$ qmake -v
QMake version 3.0
Using Qt version 5.2.0 in /home/tsiapaliokas/src/kf5/qt5/qtbase/lib

so in my kdesrc-buildrc I have this

qtdir /home/tsiapaliokas/src/kf5/qt5/build/qtbase/

-- 
Giorgos Tsiapaliokas (terietor)

terietor.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/362b2efa/attachment.html>

From david at davidedmundson.co.uk  Fri Aug 16 20:58:30 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 16 Aug 2013 20:58:30 -0000
Subject: Review Request 112127: Enable QML Debugger
Message-ID: <20130816205830.20958.91420@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112127/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Enable QML Debugger


Diffs
-----

  src/shell/main.cpp 18d381a0d3b76ef1c24b8585dc06047664a4cc55 

Diff: http://git.reviewboard.kde.org/r/112127/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/ad16ce29/attachment.html>

From jpwhiting at kde.org  Sat Aug 17 03:03:06 2013
From: jpwhiting at kde.org (Jeremy Paul Whiting)
Date: Sat, 17 Aug 2013 03:03:06 -0000
Subject: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually
 uninstall the theme.
Message-ID: <20130817030306.26981.9224@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112128/
-----------------------------------------------------------

Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K?gler.


Description
-------

Currently uninstallation of plasma themes is very broken for a couple of reasons. One reason is that the tar packages downloaded from kde-look and other kns services contain a subfolder with the theme name, that then contains the metadata.desktop file that plasma::PackageStructure looks for in order to uninstall or install a plugin. The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah fails.  This patch fixes the second issue. I'll upload another patch for review that fixes the first issue.


Diffs
-----

  plasma/tools/plasmapkg/main.cpp 6a2982b292ec9736710f4b41dcaa0cbff3986c46 

Diff: http://git.reviewboard.kde.org/r/112128/diff/


Testing
-------

Plasma themes correctly uninstall here with this and my other patch.


Thanks,

Jeremy Paul Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130817/fd0af250/attachment.html>

From jpwhiting at kde.org  Sat Aug 17 03:06:12 2013
From: jpwhiting at kde.org (Jeremy Paul Whiting)
Date: Sat, 17 Aug 2013 03:06:12 -0000
Subject: Review Request 112129: Make Plasma::PackageStructure look for
 metadata.desktop files in only subfolder of extracted plasmapkg archives
Message-ID: <20130817030612.27698.30183@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112129/
-----------------------------------------------------------

Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K?gler.


Description
-------

This is the other half of the fix for the listed bug.  I made Plasma::PackageStructure::metadata look in the only subdirectory of an extracted archive if there's only one subdirectory for the metadata.desktop file.


This addresses bug https://bugs.kde.org/show_bug.cgi?id=149479.
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479


Diffs
-----

  plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b 

Diff: http://git.reviewboard.kde.org/r/112129/diff/


Testing
-------

The bug is fixed here with this and my other patch. Any better ideas for getting the only subdirectory are welcome, it feels a bit kludgy as is.


Thanks,

Jeremy Paul Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130817/44eefcff/attachment.html>

From notmart at gmail.com  Sat Aug 17 08:26:15 2013
From: notmart at gmail.com (Marco Martin)
Date: Sat, 17 Aug 2013 08:26:15 -0000
Subject: Review Request 112129: Make Plasma::PackageStructure look for
 metadata.desktop files in only subfolder of extracted plasmapkg archives
In-Reply-To: <20130817030612.27698.30183@vidsolbach.de>
References: <20130817030612.27698.30183@vidsolbach.de>
Message-ID: <20130817082615.1679.17531@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112129/#review38015
-----------------------------------------------------------


Hmm, not sure about it, the packages were defined as archives with metadata.desktop in the root, this would basically allow a quirks mode, do we want to support malformed packages?

- Marco Martin


On Aug. 17, 2013, 3:06 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112129/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 3:06 a.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> This is the other half of the fix for the listed bug.  I made Plasma::PackageStructure::metadata look in the only subdirectory of an extracted archive if there's only one subdirectory for the metadata.desktop file.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=149479.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479
> 
> 
> Diffs
> -----
> 
>   plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b 
> 
> Diff: http://git.reviewboard.kde.org/r/112129/diff/
> 
> 
> Testing
> -------
> 
> The bug is fixed here with this and my other patch. Any better ideas for getting the only subdirectory are welcome, it feels a bit kludgy as is.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130817/6cf8aa01/attachment.html>

From bhush94 at gmail.com  Sat Aug 17 14:14:47 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sat, 17 Aug 2013 19:44:47 +0530
Subject: Need help to setup build environment of KF5
Message-ID: <CAGPcNU021uiwcAUYMNOOjOK3eF=W17N4L-JYg6HvJqdYCNqaGQ@mail.gmail.com>

Hello,

I want to setup build environment that can build frameworks-scratch
branch of kde-workspace and other projects on top of Qt 5.2. But I
could not figure out which packages I need to install?

Currently I have installed all packages listed on Getting
Started/Build/Distributions/Debian [1] techbase entry, Packages listed
on the Frameworks/Building [2] and Frameworks/Building/Details [3]
pages.

And still I am dealing with the different CMake Error messages.. I am
using KUbuntu 13.04 32 bit fresh installation (updated). It will be
good if someone can give me step by step method to setup build
environment.

[1] http://techbase.kde.org/Getting_Started/Build/Distributions/Debian
[2] http://community.kde.org/Frameworks/Building
[3] http://community.kde.org/Frameworks/Building/Details

Thanks!

From terietor at gmail.com  Sat Aug 17 18:25:22 2013
From: terietor at gmail.com (Giorgos Tsiapaliokas)
Date: Sat, 17 Aug 2013 21:25:22 +0300
Subject: Need help to setup build environment of KF5
In-Reply-To: <CAGPcNU021uiwcAUYMNOOjOK3eF=W17N4L-JYg6HvJqdYCNqaGQ@mail.gmail.com>
References: <CAGPcNU021uiwcAUYMNOOjOK3eF=W17N4L-JYg6HvJqdYCNqaGQ@mail.gmail.com>
Message-ID: <CAODYyLYpnw8RBGgF7cmzRTiyZhL=SNV2vmk74jT4zmVXTbqN9g@mail.gmail.com>

show us the cmake errors :)

-- 
Giorgos Tsiapaliokas (terietor)

terietor.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130817/cb6878e9/attachment.html>

From bhush94 at gmail.com  Sun Aug 18 04:20:48 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sun, 18 Aug 2013 09:50:48 +0530
Subject: Need help to setup build environment of KF5
In-Reply-To: <CAODYyLYpnw8RBGgF7cmzRTiyZhL=SNV2vmk74jT4zmVXTbqN9g@mail.gmail.com>
References: <CAGPcNU021uiwcAUYMNOOjOK3eF=W17N4L-JYg6HvJqdYCNqaGQ@mail.gmail.com>
 <CAODYyLYpnw8RBGgF7cmzRTiyZhL=SNV2vmk74jT4zmVXTbqN9g@mail.gmail.com>
Message-ID: <CAGPcNU046pDXqnPnWZ2XM9EvpkvLm70FeX1OQczh2CMidUMs0A@mail.gmail.com>

Hello,

On Sat, Aug 17, 2013 at 11:55 PM, Giorgos Tsiapaliokas
<terietor at gmail.com> wrote:
> show us the cmake errors :)

http://paste.kde.org/pd1e6e267/

I have XCB development library installed in my computer but still I am
getting this error..

Thanks!

From bhush94 at gmail.com  Sun Aug 18 12:03:46 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sun, 18 Aug 2013 12:03:46 -0000
Subject: Review Request 112143: Enable compilation of the executable
 DataEngine on KF5
In-Reply-To: <20130818115502.18351.40462@vidsolbach.de>
References: <20130818115502.18351.40462@vidsolbach.de>
Message-ID: <20130818120346.19499.75400@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112143/
-----------------------------------------------------------

(Updated Aug. 18, 2013, 12:03 p.m.)


Review request for Plasma.


Changes
-------

Fixed typo.


Description
-------

Enable compilation of the executable DataEngine on KF5


Diffs (updated)
-----

  plasma/generic/dataengines/CMakeLists.txt 901fa0a 
  plasma/generic/dataengines/executable/CMakeLists.txt 2baf1fa 
  plasma/generic/dataengines/executable/executable.h 52871d2 

Diff: http://git.reviewboard.kde.org/r/112143/diff/


Testing
-------

works


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130818/e0b4ed6e/attachment.html>

From david at davidedmundson.co.uk  Sun Aug 18 14:24:28 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Sun, 18 Aug 2013 14:24:28 -0000
Subject: Review Request 112143: Enable compilation of the executable
 DataEngine on KF5
In-Reply-To: <20130818120346.19499.75400@vidsolbach.de>
References: <20130818120346.19499.75400@vidsolbach.de>
Message-ID: <20130818142428.7042.17912@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112143/#review38071
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 18, 2013, 12:03 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112143/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 12:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Enable compilation of the executable DataEngine on KF5
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt 901fa0a 
>   plasma/generic/dataengines/executable/CMakeLists.txt 2baf1fa 
>   plasma/generic/dataengines/executable/executable.h 52871d2 
> 
> Diff: http://git.reviewboard.kde.org/r/112143/diff/
> 
> 
> Testing
> -------
> 
> works
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130818/cafc4351/attachment.html>

From david at davidedmundson.co.uk  Sun Aug 18 22:28:39 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Sun, 18 Aug 2013 22:28:39 -0000
Subject: Review Request 112150: Port analog clock to Plasma 2 (based on
 Viranch's branch)
Message-ID: <20130818222839.23234.51341@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112150/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock


Git log below
--

Restore config for clock applet

--

Remove calendar components.
Plasma will have it's own Calendar which should be shared

--

Scale clock hands to fit current clock size

--

Update copyright to reflect actual authors


--
Port analog clock to new dataengine + config scheme

Make the clock use the new PlasmaCore.Datasource to fetch the current
time

--

Update the analog clock to run on plasma 2

--

Enable generic/applets directory

--

Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch


Diffs
-----

  plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION 
  plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 
  plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a 
  plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b 
  plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 
  plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112150/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130818/e66798a6/attachment.html>

From david at davidedmundson.co.uk  Mon Aug 19 00:05:50 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Mon, 19 Aug 2013 01:05:50 +0100
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where applicable
Message-ID: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>

After discussions with a few people, I decided for an experiment to port
PlasmaComponents Button to use QtQuickControls [1] internally but use the
styles API [2] to make it look like the original PlasmaComponents button.

This is pushed in the plasma-frameworks branch davidedmundson/controls

Advantages:
 - considerably simpler code. We don't have to do our own mousearea and key
handling. It's all done for us. I reduced Button.qml to about 1/2 the
original size
 - consistent API with the configuration controls and other QML users
 - more code sharing is better
 - we get some features for "free". For buttons we get action support,
exclusiveGroups, tooltips

Downsides:
 - Source breakage
Although the API is very very similar, there are some differences.
For just button; icon -> iconName/iconSource, no font property
We /could/ bodge it with alias's. For other components this may be more
difficult
 - More work.
As a rough guide I ported Button in about 1 hour. It's not a perfect 1-1
port, but it's 90% there.

The approach I took was to make the PlasmaComponents.Button subclass the
QtQuickControls.Button and then set a style on it rather than make a full
plasma style for all QtQuickControls. This should allow us to make plasma
extensions to the API as well as keep most source compatibility as well as
keep the workload realistic.

Effectively the code for the new Button.qml is simply:

QtControls.Button
{
    style: QtControlsStyle.ButtonStyle {
        background: PlasmaCore.SvgItem {
                imagePath: "widgets/button"
        }
    }
}

but with a few more animations and hints to match the original.

Do we think it is worth porting all the items which can use controls to do
so?

I think given the current API changes it makes sense to use this
opportunity to make this change. I believe we will get better more stable
code for it. I can do most the changes.

Thoughts?

David Edmundson

[1]
http://doc-snapshot.qt-project.org/qt5-stable/qtquickcontrols/qmlmodule-qtquick-controls1-qtquick-controls-1-0.html
[2]
http://doc-snapshot.qt-project.org/qt5-stable/qtquickcontrolsstyles/qmlmodule-qtquick-controls-styles1-qtquick-controls-styles-1-0.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/4251a11e/attachment.html>

From ervin at kde.org  Mon Aug 19 05:40:11 2013
From: ervin at kde.org (Kevin Ottens)
Date: Mon, 19 Aug 2013 07:40:11 +0200
Subject: Need help to setup build environment of KF5
In-Reply-To: <CAGPcNU046pDXqnPnWZ2XM9EvpkvLm70FeX1OQczh2CMidUMs0A@mail.gmail.com>
References: <CAGPcNU021uiwcAUYMNOOjOK3eF=W17N4L-JYg6HvJqdYCNqaGQ@mail.gmail.com>
 <CAODYyLYpnw8RBGgF7cmzRTiyZhL=SNV2vmk74jT4zmVXTbqN9g@mail.gmail.com>
 <CAGPcNU046pDXqnPnWZ2XM9EvpkvLm70FeX1OQczh2CMidUMs0A@mail.gmail.com>
Message-ID: <2794790.C1NQzuuWk7@wintermute>

On Sunday 18 August 2013 09:50:48 Bhushan Shah wrote:
> Hello,
> 
> On Sat, Aug 17, 2013 at 11:55 PM, Giorgos Tsiapaliokas
> 
> <terietor at gmail.com> wrote:
> > show us the cmake errors :)
> 
> http://paste.kde.org/pd1e6e267/
> 
> I have XCB development library installed in my computer but still I am
> getting this error..

XCB packages are generally modularized by distros. Are you sure you have the 
devel packages for xcb keysyms and xcb xtest? Those two are reported as 
missing.

Regards.
-- 
K?vin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/569ee3a4/attachment.sig>

From bhush94 at gmail.com  Mon Aug 19 07:04:56 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Mon, 19 Aug 2013 12:34:56 +0530
Subject: Need help to setup build environment of KF5
In-Reply-To: <2794790.C1NQzuuWk7@wintermute>
References: <CAGPcNU021uiwcAUYMNOOjOK3eF=W17N4L-JYg6HvJqdYCNqaGQ@mail.gmail.com>
 <CAODYyLYpnw8RBGgF7cmzRTiyZhL=SNV2vmk74jT4zmVXTbqN9g@mail.gmail.com>
 <CAGPcNU046pDXqnPnWZ2XM9EvpkvLm70FeX1OQczh2CMidUMs0A@mail.gmail.com>
 <2794790.C1NQzuuWk7@wintermute>
Message-ID: <CAGPcNU15bORPVk0x3F25nA_V4zLMMzp0kbdMCX2Dp8uA40-GMQ@mail.gmail.com>

On Mon, Aug 19, 2013 at 11:10 AM, Kevin Ottens <ervin at kde.org> wrote:
> XCB packages are generally modularized by distros. Are you sure you have the
> devel packages for xcb keysyms and xcb xtest? Those two are reported as
> missing.


Yes! I am using KUbuntu. And tried installing libxcb*-dev packages,
xcb-proto and almost every *xcb* packages..

From mgraesslin at kde.org  Mon Aug 19 08:03:02 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Mon, 19 Aug 2013 10:03:02 +0200
Subject: Need help to setup build environment of KF5
In-Reply-To: <2794790.C1NQzuuWk7@wintermute>
References: <CAGPcNU021uiwcAUYMNOOjOK3eF=W17N4L-JYg6HvJqdYCNqaGQ@mail.gmail.com>
 <CAGPcNU046pDXqnPnWZ2XM9EvpkvLm70FeX1OQczh2CMidUMs0A@mail.gmail.com>
 <2794790.C1NQzuuWk7@wintermute>
Message-ID: <31297075.VqN8qG40of@martin-thinkpad>

On Monday 19 August 2013 07:40:11 Kevin Ottens wrote:
> On Sunday 18 August 2013 09:50:48 Bhushan Shah wrote:
> > Hello,
> > 
> > On Sat, Aug 17, 2013 at 11:55 PM, Giorgos Tsiapaliokas
> > 
> > <terietor at gmail.com> wrote:
> > > show us the cmake errors :)
> > 
> > http://paste.kde.org/pd1e6e267/
> > 
> > I have XCB development library installed in my computer but still I am
> > getting this error..
> 
> XCB packages are generally modularized by distros. Are you sure you have the
> devel packages for xcb keysyms and xcb xtest? Those two are reported as
> missing.
And to fix this problem I just split XCB into components: 
https://git.reviewboard.kde.org/r/112151/

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/1ed97d7c/attachment.sig>

From bhush94 at gmail.com  Mon Aug 19 08:07:41 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Mon, 19 Aug 2013 13:37:41 +0530
Subject: Need help to setup build environment of KF5
In-Reply-To: <31297075.VqN8qG40of@martin-thinkpad>
References: <CAGPcNU021uiwcAUYMNOOjOK3eF=W17N4L-JYg6HvJqdYCNqaGQ@mail.gmail.com>
 <CAGPcNU046pDXqnPnWZ2XM9EvpkvLm70FeX1OQczh2CMidUMs0A@mail.gmail.com>
 <2794790.C1NQzuuWk7@wintermute>
 <31297075.VqN8qG40of@martin-thinkpad>
Message-ID: <CAGPcNU348K1qA14-wQ25cn6++gPTtTG1O=XC-JPM_NgpLfF7Yw@mail.gmail.com>

Hello,

On Mon, Aug 19, 2013 at 1:33 PM, Martin Graesslin <mgraesslin at kde.org> wrote:
> And to fix this problem I just split XCB into components:
> https://git.reviewboard.kde.org/r/112151/

So this will require me to rebuild plasma-framework and then
kde-workspace.. okay but which xcb packages I need to install in
KUbuntu?

From aleixpol at kde.org  Mon Aug 19 08:33:22 2013
From: aleixpol at kde.org (Aleix Pol Gonzalez)
Date: Mon, 19 Aug 2013 08:33:22 -0000
Subject: Review Request 112033: Drop windowId property from
 PlasmaCore.Dialog
In-Reply-To: <20130813044712.8439.84592@vidsolbach.de>
References: <20130813044712.8439.84592@vidsolbach.de>
Message-ID: <20130819083322.16209.30621@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review38100
-----------------------------------------------------------


FWIW this is also being used in the KTp chat plasmoid, in a hack so the dialog doesn't appear in the tasks list.

- Aleix Pol Gonzalez


On Aug. 13, 2013, 4:47 a.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 4:47 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h 7392b71 
>   src/declarativeimports/core/dialog.cpp eaf3dce 
> 
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
> 
> 
> Testing
> -------
> 
> Yes, KWin's ThumnailItem is still working
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/bee74e0f/attachment.html>

From aleixpol at kde.org  Mon Aug 19 08:50:15 2013
From: aleixpol at kde.org (Aleix Pol)
Date: Mon, 19 Aug 2013 10:50:15 +0200
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
Message-ID: <CACcA1RpV5m26GgGzD3ndVaugKo5+SauGF0U5Mq6adm6gvhrgZQ@mail.gmail.com>

On Mon, Aug 19, 2013 at 2:05 AM, David Edmundson <david at davidedmundson.co.uk
> wrote:

> After discussions with a few people, I decided for an experiment to port
> PlasmaComponents Button to use QtQuickControls [1] internally but use the
> styles API [2] to make it look like the original PlasmaComponents button.
>
> This is pushed in the plasma-frameworks branch davidedmundson/controls
>
> Advantages:
>  - considerably simpler code. We don't have to do our own mousearea and
> key handling. It's all done for us. I reduced Button.qml to about 1/2 the
> original size
>  - consistent API with the configuration controls and other QML users
>  - more code sharing is better
>  - we get some features for "free". For buttons we get action support,
> exclusiveGroups, tooltips
>
> Downsides:
>  - Source breakage
> Although the API is very very similar, there are some differences.
> For just button; icon -> iconName/iconSource, no font property
> We /could/ bodge it with alias's. For other components this may be more
> difficult
>  - More work.
> As a rough guide I ported Button in about 1 hour. It's not a perfect 1-1
> port, but it's 90% there.
>
> The approach I took was to make the PlasmaComponents.Button subclass the
> QtQuickControls.Button and then set a style on it rather than make a full
> plasma style for all QtQuickControls. This should allow us to make plasma
> extensions to the API as well as keep most source compatibility as well as
> keep the workload realistic.
>
> Effectively the code for the new Button.qml is simply:
>
> QtControls.Button
> {
>     style: QtControlsStyle.ButtonStyle {
>         background: PlasmaCore.SvgItem {
>                 imagePath: "widgets/button"
>         }
>     }
> }
>
> but with a few more animations and hints to match the original.
>
> Do we think it is worth porting all the items which can use controls to do
> so?
>
> I think given the current API changes it makes sense to use this
> opportunity to make this change. I believe we will get better more stable
> code for it. I can do most the changes.
>
> Thoughts?
>
> David Edmundson
>
> [1]
> http://doc-snapshot.qt-project.org/qt5-stable/qtquickcontrols/qmlmodule-qtquick-controls1-qtquick-controls-1-0.html
> [2]
> http://doc-snapshot.qt-project.org/qt5-stable/qtquickcontrolsstyles/qmlmodule-qtquick-controls-styles1-qtquick-controls-styles-1-0.html
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
Hi David!
I'm so happy to see you working on this! Actually to be honest, I think
it's not really something up to discussion, Qt Controls is something we
want Plasma to be part of. The question is if it should be the official way
to write applets and stuff, but I'd rather look into it the other way
around.

For applications, we want to be able to write them in Qt Controls. For
instance, I'd really like to see Muon Discover working properly on PA, or
at least sharing most of the code base with the desktop version and Qt
Controls is the (only?) way to go for this. Furthermore, we'll want Ubuntu
apps to integrate with us. We want to support Qt Controls.

I'd say that whether it's the official API for writing plasmoids, will be
seen in the future, but it already is the official API for writing
applications in Qt Quick that can target more than 1 operating system or
even 1 Look&Feel.

Cheers!
Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/54d76cd1/attachment.html>

From mgraesslin at kde.org  Mon Aug 19 08:55:05 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Mon, 19 Aug 2013 08:55:05 -0000
Subject: Review Request 112033: Drop windowId property from
 PlasmaCore.Dialog
In-Reply-To: <20130819083322.16209.30621@vidsolbach.de>
References: <20130819083322.16209.30621@vidsolbach.de>
Message-ID: <20130819085505.19825.59989@vidsolbach.de>



> On Aug. 19, 2013, 10:33 a.m., Aleix Pol Gonzalez wrote:
> > FWIW this is also being used in the KTp chat plasmoid, in a hack so the dialog doesn't appear in the tasks list.

well that should be done differently. IIRC the PlasmaCore.Dialog already exposes a flags attribute, so we should make sure that also the SkipTaksbar|SkipPager flags are respected.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review38100
-----------------------------------------------------------


On Aug. 13, 2013, 6:47 a.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 6:47 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h 7392b71 
>   src/declarativeimports/core/dialog.cpp eaf3dce 
> 
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
> 
> 
> Testing
> -------
> 
> Yes, KWin's ThumnailItem is still working
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/5fc791dd/attachment-0001.html>

From faure at kde.org  Mon Aug 19 09:10:45 2013
From: faure at kde.org (David Faure)
Date: Mon, 19 Aug 2013 09:10:45 -0000
Subject: Review Request 112073: Partially revert commit 83d3018
In-Reply-To: <20130814000117.13131.43688@vidsolbach.de>
References: <20130814000117.13131.43688@vidsolbach.de>
Message-ID: <20130819091045.22863.68354@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112073/#review38112
-----------------------------------------------------------


This is ... extremely surprising.
plasma-desktop registers to DBus as "org.kde.plasma-desktop", doesn't it? That's what "unique" expects (while "multi" expects the PID appended).

In addition, I didn't experience any problems with startup and the splash screen...

Are you really sure this change fixes anything? I could be wrong, but I'm rather surprised.

- David Faure


On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112073/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 12:01 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Description
> -------
> 
> While the commit may be technically correct, it breaks ksplash for 4.11 release...
> I've changed unique to multi, if there is a better solution, please hint it ;-)
> (maybe actually someone meant multi, when typing wait :-)
> 
> 
> This addresses bug 321695.
>     http://bugs.kde.org/show_bug.cgi?id=321695
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 
> 
> Diff: http://git.reviewboard.kde.org/r/112073/diff/
> 
> 
> Testing
> -------
> 
> Yes... starts "normally" as previously/ksplash isn't interupted
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/c6589928/attachment.html>

From hein at kde.org  Mon Aug 19 09:41:46 2013
From: hein at kde.org (Eike Hein)
Date: Mon, 19 Aug 2013 11:41:46 +0200
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
Message-ID: <2565561.8U78hA6XFn@ehm1.ehn>

On Monday 19 August 2013 01:05:50 David Edmundson wrote: 
> I think given the current API changes it makes sense to use this
> opportunity to make this change. I believe we will get better more stable
> code for it. I can do most the changes.

I'm with you on this, and I'm really relieved it turned out that
theming the Controls doesn't require us to do something crazy like
writing a QStyle that renders the Plasma theme after all :).

I guess the question is, speaking to Aleix' concerns, working with
Controls, have you found any API that feels in appropriate for the
Plasmoid use case that'd have have to worry about exposing and
comitting too?


Cheers,
Eike


From notmart at gmail.com  Mon Aug 19 09:55:14 2013
From: notmart at gmail.com (Marco Martin)
Date: Mon, 19 Aug 2013 11:55:14 +0200
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
Message-ID: <201308191155.14566.notmart@gmail.com>

On Monday 19 August 2013, David Edmundson wrote:
> After discussions with a few people, I decided for an experiment to port
> PlasmaComponents Button to use QtQuickControls [1] internally but use the
> styles API [2] to make it look like the original PlasmaComponents button.
> 
> This is pushed in the plasma-frameworks branch davidedmundson/controls

I'm still seeing advantages and disadvantages, but i like the idea.

If this will be how we proceed, it shouldn't be done inline, but as a 
standalone style together the others.

so installed in qml/QtQuick/Controls/Styles/Plasma
(seems so far has to be there, even tough should be possible to put it 
somewhere else too, that would be better, maybe messing a bit with import 
paths)
at the moment seems to have to be either setting an environment variable

or (should be used for now i think)

style: Qt.createComponent("Plasma/ButtonStyle.qml", button)
instead of the default
style: Qt.createComponent(Settings.style + "/ButtonStyle.qml", button)

qquickcontrolsettings.cpp should be modified to be allowed to have a different 
style set per qqmlengine.
So using always qquickcontrols would give plasma style on the desktop/panel 
views, but the desktop style on the configuration windows (on plasma desktop, 
but plasma style in plasma active)

in general, from what i tried of qtcontrols there will be still a lot, a lot 
of work to be done in them to be remotely ready (probably a bit less work to 
be ready for plasma since we always wanted a limited set anyways)

for being able to do a decent desktop application (or even just the settings 
dialogs) some things are still needed, in part feature missing, in part making 
it play well with oxygen (and oxygen play well with them) since it's a qstyle 
infinitely more complicated than the very simple ones qt5 is shipped with.

> Advantages:
>  - considerably simpler code. We don't have to do our own mousearea and key
> handling. It's all done for us. I reduced Button.qml to about 1/2 the
> original size
>  - consistent API with the configuration controls and other QML users
>  - more code sharing is better
>  - we get some features for "free". For buttons we get action support,
> exclusiveGroups, tooltips

and more important, that qualifies both as advantage and disadvantage:
- qtquickcontrols will be beaten to their limit, hopefully getting implemented 
upstream what is still missing

> Downsides:
>  - Source breakage
> Although the API is very very similar, there are some differences.
> For just button; icon -> iconName/iconSource, no font property
> We /could/ bodge it with alias's. For other components this may be more
> difficult

what is really necessary should be done upstream (in the case of font, 
probably is not really necessary to have it, or at least not until there is a 
very valid use case)

for the icon, anyways the label component should be reimplemented anyways, for 
the color palette of the label, and for the icon itself, that should still 
prefer monochrome ones if icon name is defined (so icon in this case should 
again support both names and icons)

the biggest api roadblock i seen so far is the rename of some components:
PageStack -> StackView
ScrollArea -> ScrollView    (both with minimum changes in the api)
pretty nasty is TabBar, that is completely different with no relation 
whatsoever with the one we had (that i kinda prefer because the tabbar and the 
tab view are two separate entities)

>  - More work.
> As a rough guide I ported Button in about 1 hour. It's not a perfect 1-1
> port, but it's 90% there.
> 

yeah, not sure if this is underestimated

> I think given the current API changes it makes sense to use this
> opportunity to make this change. I believe we will get better more stable
> code for it. I can do most the changes.
> 
> Thoughts?

not 100% sold yet due the pain that will cause, but yes, in the future i would 
like to have plasma themed qtcontrols with our controls being purely 
extensions, controls that aren't available otherwise

-- 
Marco Martin

From david at davidedmundson.co.uk  Mon Aug 19 12:37:46 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Mon, 19 Aug 2013 13:37:46 +0100
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <201308191155.14566.notmart@gmail.com>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
 <201308191155.14566.notmart@gmail.com>
Message-ID: <CAGeFrHAkP9z4ZZw2_x9rac+zDW9zBmt6NkZwF05a9t2DH41jjQ@mail.gmail.com>

On Mon, Aug 19, 2013 at 10:55 AM, Marco Martin <notmart at gmail.com> wrote:

> On Monday 19 August 2013, David Edmundson wrote:
> > After discussions with a few people, I decided for an experiment to port
> > PlasmaComponents Button to use QtQuickControls [1] internally but use the
> > styles API [2] to make it look like the original PlasmaComponents button.
> >
> > This is pushed in the plasma-frameworks branch davidedmundson/controls
>
> I'm still seeing advantages and disadvantages, but i like the idea.
>
> If this will be how we proceed, it shouldn't be done inline, but as a
> standalone style together the others.
>


So there's 3 proposals being talked about here:
 - We keep Plasma Components as is
 - We create a proper QtQuick Controls style (which is what you and Aleix
suggest)
 - My half-way proposal in which we use QtQuickControls to do the heavy
lifting inside PlasmaComponents. Making the relevant style components, but
not actually exporting them as such.

I think we're all in agreement that option 2 is going to be needed at some
point in the future and should be a long term goal. However, there are
numerous drawbacks that make that difficult. We would need to commit to
making a large amount of changes, we have to edit a lot of plasma code and
we have to support the entire Controls library, not just parts of it... and
all the problems Marco stated.

This is why I came up with the proposal in my original email (which I
should have explained my rationale better) where we set the style
internally. (Though I agree I should split it into a separate
ButtonStyle.qml, ScrollBarStyle.qml etc. files)

We can work towards writing a controls style in small gradual parts. We can
get all the bug fixes that quick controls provides, but if there are any
regressions we can just use our existing code. We don't /need/ to change
the tab bar API, we can just use our current Plasma Components solution if
it's better. We can see what's missing in QtQuickControls, if anything,
without having regressions for the user.

When everything is finished ready and working we can then turn it into a
controls style (Plasma3?). This just makes that more gradual and IMHO safer.

I would be disappointed if this thread turns into "lets do this bigger
better thing instead.. but that's too big so lets not do anything".


> >  - More work.
> > As a rough guide I ported Button in about 1 hour. It's not a perfect 1-1
> > port, but it's 90% there.
> >

> yeah, not sure if this is underestimated

ok, it's 95% there then :P

David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/5a1f5d13/attachment.html>

From notmart at gmail.com  Mon Aug 19 12:43:42 2013
From: notmart at gmail.com (Marco Martin)
Date: Mon, 19 Aug 2013 14:43:42 +0200
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <CAGeFrHAkP9z4ZZw2_x9rac+zDW9zBmt6NkZwF05a9t2DH41jjQ@mail.gmail.com>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
 <201308191155.14566.notmart@gmail.com>
 <CAGeFrHAkP9z4ZZw2_x9rac+zDW9zBmt6NkZwF05a9t2DH41jjQ@mail.gmail.com>
Message-ID: <201308191443.42956.notmart@gmail.com>

On Monday 19 August 2013, David Edmundson wrote:
> > If this will be how we proceed, it shouldn't be done inline, but as a
> > standalone style together the others.
> 
> So there's 3 proposals being talked about here:
>  - We keep Plasma Components as is
>  - We create a proper QtQuick Controls style (which is what you and Aleix
> suggest)
>  - My half-way proposal in which we use QtQuickControls to do the heavy
> lifting inside PlasmaComponents. Making the relevant style components, but
> not actually exporting them as such.
> 
> I think we're all in agreement that option 2 is going to be needed at some
> point in the future and should be a long term goal. However, there are
> numerous drawbacks that make that difficult. We would need to commit to
> making a large amount of changes, we have to edit a lot of plasma code and
> we have to support the entire Controls library, not just parts of it... and
> all the problems Marco stated.

not necessarly, you can do the working qtcontrols theme (that works with plain 
qtcontrols) but still have a plasma button like

QtControls.Button
{
    style: Qt.createComponent("Plasma/ButtonStyle.qml", button)
}

as compatibility layer

-- 
Marco Martin

From hein at kde.org  Mon Aug 19 13:24:57 2013
From: hein at kde.org (Eike Hein)
Date: Mon, 19 Aug 2013 15:24:57 +0200
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <201308191155.14566.notmart@gmail.com>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
 <201308191155.14566.notmart@gmail.com>
Message-ID: <1419533.DVcpOA4vbd@ehm1.ehn>

On Monday 19 August 2013 11:55:14 Marco Martin wrote:
> for being able to do a decent desktop application (or even just the settings
> dialogs) some things are still needed, in part feature missing, in part
> making it play well with oxygen (and oxygen play well with them) since it's
> a qstyle infinitely more complicated than the very simple ones qt5 is
> shipped with.

I have real doubts a full-fidelity Oxygen for Controls is possible - it
does a number of things that are really heavily tied to QWidget, like
eventFilter trickery to install the background gradient and spawning
dummy widgets above scrollarea view ports to fill in the curves of the
rounded corners. It may be necessary to simplify the style visually to
hit a lowest common denominator between the two toolkits.


Cheers,
Eike

From notmart at gmail.com  Mon Aug 19 13:40:05 2013
From: notmart at gmail.com (Marco Martin)
Date: Mon, 19 Aug 2013 15:40:05 +0200
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <1419533.DVcpOA4vbd@ehm1.ehn>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
 <201308191155.14566.notmart@gmail.com> <1419533.DVcpOA4vbd@ehm1.ehn>
Message-ID: <201308191540.06364.notmart@gmail.com>

On Monday 19 August 2013, Eike Hein wrote:
> On Monday 19 August 2013 11:55:14 Marco Martin wrote:
> > for being able to do a decent desktop application (or even just the
> > settings dialogs) some things are still needed, in part feature missing,
> > in part making it play well with oxygen (and oxygen play well with them)
> > since it's a qstyle infinitely more complicated than the very simple
> > ones qt5 is shipped with.
> 
> I have real doubts a full-fidelity Oxygen for Controls is possible - it
> does a number of things that are really heavily tied to QWidget, like
> eventFilter trickery to install the background gradient and spawning
> dummy widgets above scrollarea view ports to fill in the curves of the
> rounded corners. It may be necessary to simplify the style visually to
> hit a lowest common denominator between the two toolkits.

may be necessary to simplify something and there will always be some details 
that look like fakery, but should be possible to do some of the needed 
things...
with some hacking i managed to make it paintthe window radial gradient, 
scrollview will be kind of an issue as well

-- 
Marco Martin

From david at davidedmundson.co.uk  Mon Aug 19 13:53:14 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Mon, 19 Aug 2013 14:53:14 +0100
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <201308191443.42956.notmart@gmail.com>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
 <201308191155.14566.notmart@gmail.com>
 <CAGeFrHAkP9z4ZZw2_x9rac+zDW9zBmt6NkZwF05a9t2DH41jjQ@mail.gmail.com>
 <201308191443.42956.notmart@gmail.com>
Message-ID: <CAGeFrHAB2TCgR_D=gdqaVj+PWS0LbE51CeHzXYgraOT2POEDKA@mail.gmail.com>

Right, that's basically what I had in mind when I said I can split things
into the style files.

The key thing I was trying to stress is that we don't need to implement a
whole style before we can start using it from some PlasmaComponents to get
benefits and that we don't need to port all the plasma applets to use
controls natively.

Anyway, so far things sound pretty positive. So I'll look at making
a scrollviewstyle in my branch and see if it fixes a lot of the bugs I have
with the current implementation.

David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/e701be1d/attachment.html>

From bhush94 at gmail.com  Mon Aug 19 13:54:02 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Mon, 19 Aug 2013 13:54:02 -0000
Subject: Review Request 112143: Enable compilation of the executable
 DataEngine on KF5
Message-ID: <20130819135402.18908.81896@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112143/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Enable compilation of the executable DataEngine on KF5


Diffs
-----

  plasma/generic/dataengines/CMakeLists.txt 901fa0a 
  plasma/generic/dataengines/executable/CMakeLists.txt 2baf1fa 
  plasma/generic/dataengines/executable/executable.h 52871d2 

Diff: http://git.reviewboard.kde.org/r/112143/diff/


Testing
-------

works


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/175b1b28/attachment.html>

From bhush94 at gmail.com  Mon Aug 19 14:15:59 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Mon, 19 Aug 2013 14:15:59 -0000
Subject: Review Request 112143: Enable compilation of the executable
 DataEngine on KF5
In-Reply-To: <20130819135402.18908.81896@vidsolbach.de>
References: <20130819135402.18908.81896@vidsolbach.de>
Message-ID: <20130819141559.29228.43172@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112143/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 2:15 p.m.)


Review request for Plasma.


Changes
-------

Final changes and will ship it. Uploading here in case.


Description
-------

Enable compilation of the executable DataEngine on KF5


Diffs (updated)
-----

  plasma/generic/dataengines/executable/executable.cpp 54216a4 
  plasma/generic/dataengines/executable/executable.h 52871d2 
  plasma/generic/dataengines/executable/CMakeLists.txt 2baf1fa 
  plasma/generic/dataengines/CMakeLists.txt 901fa0a 

Diff: http://git.reviewboard.kde.org/r/112143/diff/


Testing
-------

works


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/7e98e563/attachment-0001.html>

From bhush94 at gmail.com  Mon Aug 19 14:19:41 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Mon, 19 Aug 2013 14:19:41 -0000
Subject: Review Request 112143: Enable compilation of the executable
 DataEngine on KF5
In-Reply-To: <20130819141559.29228.43172@vidsolbach.de>
References: <20130819141559.29228.43172@vidsolbach.de>
Message-ID: <20130819141941.29623.4766@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112143/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 2:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

Enable compilation of the executable DataEngine on KF5


Diffs
-----

  plasma/generic/dataengines/executable/executable.cpp 54216a4 
  plasma/generic/dataengines/executable/executable.h 52871d2 
  plasma/generic/dataengines/executable/CMakeLists.txt 2baf1fa 
  plasma/generic/dataengines/CMakeLists.txt 901fa0a 

Diff: http://git.reviewboard.kde.org/r/112143/diff/


Testing
-------

works


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/52c2a4b1/attachment.html>

From terietor at gmail.com  Mon Aug 19 14:45:32 2013
From: terietor at gmail.com (Giorgos Tsiapaliokas)
Date: Mon, 19 Aug 2013 14:45:32 -0000
Subject: Review Request 112157: replace deprecated widgets
Message-ID: <20130819144532.3183.25735@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112157/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Hello,

* this replaces the deprecated widgets from the plasmaengineexplorer
* makes the serviceviewer.ui nicer( I have attached a screenshot) 


Diffs
-----

  engineexplorer/CMakeLists.txt 1466542 
  engineexplorer/engineexplorer.h 5c19fa6 
  engineexplorer/engineexplorer.cpp a3f2e1f 
  engineexplorer/engineexplorer.ui 65e70b4 
  engineexplorer/ktreeviewsearchline.cpp 734ef94 
  engineexplorer/main.cpp 8eae7a3 
  engineexplorer/serviceviewer.h dc0b36b 
  engineexplorer/serviceviewer.cpp d7e8e5a 
  engineexplorer/serviceviewer.ui b91b784 

Diff: http://git.reviewboard.kde.org/r/112157/diff/


Testing
-------

it is building/installing/working correctly. I have noticed any issue


File Attachments
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/b89b9c91/attachment.html>

From david at davidedmundson.co.uk  Mon Aug 19 15:21:05 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Mon, 19 Aug 2013 15:21:05 -0000
Subject: Review Request 112157: replace deprecated widgets
In-Reply-To: <20130819144532.3183.25735@vidsolbach.de>
References: <20130819144532.3183.25735@vidsolbach.de>
Message-ID: <20130819152105.17696.22672@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112157/#review38149
-----------------------------------------------------------

Ship it!


One comment below needs addressing.


engineexplorer/main.cpp
<http://git.reviewboard.kde.org/r/112157/#comment28200>

    This looks like it leaks.
    


- David Edmundson


On Aug. 19, 2013, 2:45 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112157/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 2:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> * this replaces the deprecated widgets from the plasmaengineexplorer
> * makes the serviceviewer.ui nicer( I have attached a screenshot) 
> 
> 
> Diffs
> -----
> 
>   engineexplorer/CMakeLists.txt 1466542 
>   engineexplorer/engineexplorer.h 5c19fa6 
>   engineexplorer/engineexplorer.cpp a3f2e1f 
>   engineexplorer/engineexplorer.ui 65e70b4 
>   engineexplorer/ktreeviewsearchline.cpp 734ef94 
>   engineexplorer/main.cpp 8eae7a3 
>   engineexplorer/serviceviewer.h dc0b36b 
>   engineexplorer/serviceviewer.cpp d7e8e5a 
>   engineexplorer/serviceviewer.ui b91b784 
> 
> Diff: http://git.reviewboard.kde.org/r/112157/diff/
> 
> 
> Testing
> -------
> 
> it is building/installing/working correctly. I have noticed any issue
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/76c746aa/attachment.html>

From jpwhiting at kde.org  Mon Aug 19 17:06:10 2013
From: jpwhiting at kde.org (Jeremy Paul Whiting)
Date: Mon, 19 Aug 2013 17:06:10 -0000
Subject: Review Request 112129: Make Plasma::PackageStructure look for
 metadata.desktop files in only subfolder of extracted plasmapkg archives
In-Reply-To: <20130817082615.1679.17531@vidsolbach.de>
References: <20130817082615.1679.17531@vidsolbach.de>
Message-ID: <20130819170610.9499.59083@vidsolbach.de>



> On Aug. 17, 2013, 2:26 a.m., Marco Martin wrote:
> > Hmm, not sure about it, the packages were defined as archives with metadata.desktop in the root, this would basically allow a quirks mode, do we want to support malformed packages?

Ok, I just tried repackaging Helium from kde-look.org with the contents directly in the .tar.xz rather than in a subfolder Helium. With my other plasmapkg patch that installs and uninstalls just fine. So the question then becomes are these themes on kde-look.org packaged with some tool? or just packaged by hand incorrectly? If it's a tool that's creating them, we ought to fix the tool, otherwise I guess I can go through the themes on kde-look.org and suggest they repackage them correctly.


- Jeremy Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112129/#review38015
-----------------------------------------------------------


On Aug. 16, 2013, 9:06 p.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112129/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2013, 9:06 p.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> This is the other half of the fix for the listed bug.  I made Plasma::PackageStructure::metadata look in the only subdirectory of an extracted archive if there's only one subdirectory for the metadata.desktop file.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=149479.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479
> 
> 
> Diffs
> -----
> 
>   plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b 
> 
> Diff: http://git.reviewboard.kde.org/r/112129/diff/
> 
> 
> Testing
> -------
> 
> The bug is fixed here with this and my other patch. Any better ideas for getting the only subdirectory are welcome, it feels a bit kludgy as is.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/4b7b8113/attachment-0001.html>

From bhush94 at gmail.com  Mon Aug 19 17:08:09 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Mon, 19 Aug 2013 22:38:09 +0530
Subject: Can not find XCB modules.
Message-ID: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>

Hello,

I am using project-neon5 on KUbuntu 13.04. I have every packages
installed on my computer which is required to build. I can not build
kwin, kstyles and powermanagement data engine so I have to disable it
for building kde-workspace.

CMake exits saying that XCB Libraries are not installed. [1] Well I
have every xcb* packages installed on my computer. And related library
files are present on my computer [2].

Invoking pkg-config with --debug prints that xcb packages are
installed. [3]. And here is my env output. I still can not figure out
what is wrong? My system? Project Neon 5? Extra cmake modules? Or
myself? :-|

Thanks!

[1] http://paste.kde.org/pd1e6e267/
[2] http://paste.kde.org/p5d03022c/
[3] http://paste.kde.org/p6dad5f16/

From mgraesslin at kde.org  Mon Aug 19 18:55:49 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Mon, 19 Aug 2013 20:55:49 +0200
Subject: Can not find XCB modules.
In-Reply-To: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
Message-ID: <2746813.sNrQiLSP2L@martin-thinkpad>

On Monday 19 August 2013 22:38:09 Bhushan Shah wrote:
> Hello,
> 
> I am using project-neon5 on KUbuntu 13.04. I have every packages
> installed on my computer which is required to build. I can not build
> kwin, kstyles and powermanagement data engine so I have to disable it
> for building kde-workspace.
> 
> CMake exits saying that XCB Libraries are not installed. [1] Well I
> have every xcb* packages installed on my computer. And related library
> files are present on my computer [2].
> 
> Invoking pkg-config with --debug prints that xcb packages are
> installed. [3]. And here is my env output. I still can not figure out
> what is wrong? My system? Project Neon 5? Extra cmake modules? Or
> myself? :-|
give a try to:
aptitude search xcb | grep dev

and compare to my output:
http://paste.kde.org/p23fb1d84/

I'm pretty sure that some dev package is missing and that they are available 
on Ubuntu otherwise project-neon could not compile 4.11 ;-)

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/56c6da64/attachment.sig>

From mgraesslin at kde.org  Mon Aug 19 19:07:57 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Mon, 19 Aug 2013 21:07:57 +0200
Subject: Can not find XCB modules.
In-Reply-To: <2746813.sNrQiLSP2L@martin-thinkpad>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <2746813.sNrQiLSP2L@martin-thinkpad>
Message-ID: <4151315.me33JgYRa7@martin-thinkpad>

On Monday 19 August 2013 20:55:49 Martin Graesslin wrote:
> On Monday 19 August 2013 22:38:09 Bhushan Shah wrote:
> > Hello,
> > 
> > I am using project-neon5 on KUbuntu 13.04. I have every packages
> > installed on my computer which is required to build. I can not build
> > kwin, kstyles and powermanagement data engine so I have to disable it
> > for building kde-workspace.
> > 
> > CMake exits saying that XCB Libraries are not installed. [1] Well I
> > have every xcb* packages installed on my computer. And related library
> > files are present on my computer [2].
> > 
> > Invoking pkg-config with --debug prints that xcb packages are
> > installed. [3]. And here is my env output. I still can not figure out
> > what is wrong? My system? Project Neon 5? Extra cmake modules? Or
> > myself? :-|
> 
> give a try to:
> aptitude search xcb | grep dev
> 
> and compare to my output:
> http://paste.kde.org/p23fb1d84/
> 
> I'm pretty sure that some dev package is missing and that they are available
> on Ubuntu otherwise project-neon could not compile 4.11 ;-)
and obviously you could just do:
apt-get build-dep kde-workspace

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/8b8fc57c/attachment.sig>

From aseigo at kde.org  Mon Aug 19 19:32:24 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Mon, 19 Aug 2013 21:32:24 +0200
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
Message-ID: <4307248.3PSIsHcoYp@freedom>

On Monday, August 19, 2013 01:05:50 David Edmundson wrote:
> After discussions with a few people, I decided for an experiment to port
> PlasmaComponents Button to use QtQuickControls [1] internally but use the
> styles API [2] to make it look like the original PlasmaComponents button.

the things such a change must deliver imo to be considered for mainline are:

* near zero changes to API and behaviour. if we have to port QML code we or 
others have already written .. that?s a deal breaker.

* stability. we can not do a release of PW2 that is visibly less stable or 
more buggy than what we have right now. that will be a disaster. the 5.x 
releases *must* come out shining or we squander huge opportunities that hinge 
on stability.

* remain usable across the device spectrum. if we end up with 50% of the code 
but have UIs that are useless outside the desktop, we lose. put another way: 
we need to make sure we?re not hitching Plasma Components to the QML 
equivalent of QWidget.

no matter how wonderful it is to have a single shared implementation upstream 
so we don?t have to do anything but implement applications, we have to hit the 
three points above.

in the end API, stability and device spectrum are what matters to 3rd party 
developers and our users.

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/1f0b3f81/attachment.sig>

From aseigo at kde.org  Mon Aug 19 19:56:35 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Mon, 19 Aug 2013 21:56:35 +0200
Subject: naming the next major release
Message-ID: <137711932.oj8iDjKShl@freedom>

Hi...

after seeing the Nth time that we don?t know if the next release will be 
called Plasma Workspaces 2 or something else, i?d like to find consensus on 
this point so we can move forward in communication with confidence.

the first point that we?ve all been around a million times, but i will cover 
again for completeness:

	Do we need a single name for all the bits that go into our desktop shell?

yes, we do.

a) the PR reason: it is impossible to communicate clearly about ?those 20 
things that fit together but which all have different (and kooky) names? and for 
that reason it is very hard for people to identify with or understand such a 
product.

b) the developers reason: it allows us to draw a clear line around the 
workspaces (desktop, netbook, active, etc.) and everything else KDE produces. 
this is key for broader use of our libraries (Frameworks 5) and our 
applications: when people don?t understand they aren?t connected to the 
?desktop platform? they don?t use our libraries or apps if they don?t use our 
desktop environment.

c) the community reason: as has been said a number of times, many of us yearn 
for a greater sense of belonging in the workspace efforts. whether that is stuff 
like bluetooth, network integration, desktop wallet, panels, desktop layers, 
window management .. it all really belongs together in that it is written to 
be used together. to be usable together we need to work together. to work 
together we are helped by having a common identity.

so we need a name we all share. the current working title has been ?Plasma 
Workspaces 2".

there are 3 parts to the PW2 name:

1. Plasma
2. Workspaces
3. ?2?

so, one at a time:

1. Plasma is a brand that has already received a good amount of investment, 
and we need a distinct nomenclature from ?KDE?. 

we can?t just use ?Workspace? either, with the idea of using ?KDE Workspaces? 
because then what do we call Desktop vs Netbook vs Tablet? if ?KDEK 
Workspaces? were the name, then we?d end up with KDE Tablet Workspace which 
sounds dreadful and is completely non-descript. KDE Workspace Tablet is 
grammatically awkward to the point of being wrong in English.

2. ?Workspaces?gives us a way to umbrella all the Plasma primary UX that we 
provide (desktop, netbook, mediacenter, tablet, ... whatever comes in future). 

that said, ?Workspaces? is the least meaningful bit of the 3 words. without it 
we have just KDE Plasma. the reason we added Workspaces was to differentiate 
between the user products and the underlying technology.  we do, however, 
refer to it as Plasma Desktop (no workspaces in there), Plasma Active, etc.

?Workspaces? is also a word that most people do not know / understand until it 
is explained. this contributes to the weakness of this part of the 
nomenclature.

it does allow us to say, however, things like ?KDE Plasma Workspaces includes 
Plasma Destkop, Plasma Active ..? which rolls off the tongue nicely. however, 
we could do the same without making Workspaces a proper part of the name and 
just use it a regular noun in conjuction with the name ?KDE Plasma?. this 
would result in phrasing like:

	?KDE?s Plasma workspaces come in Desktop, Netbook, Tablet and Mediacenter 
flavours...?

	?KDE?s Plasma provides user experiences for desktop, netbook, tablet, ..?

given that we are moving to a ?grand unified shell? approach where the different 
user experiences flow seamlessly from one to the next, it may make sense to 
drop the concept that there is such huge differentiation that they are the 
?Workspaces? and instead are just ?Plasma? which happens to morph to fit the 
device.

3. ?2? ... why ?two? if this is version 5? well, libplasma is actually going 
to be version 6 iirc, so it isn?t the library. i also am not a big believer in 
branding after version numbers. neither are any of our proprietary competitors 
who have a lot more marketing and communications savvy than we tend to. ;) 
what i like about 2 is:

* it communicates this is something after the first. it?s that whole ?two point 
oh? thing, though hopefully less hype than, say, ?web 2.0? ;)

* it?s simple and direct

* ?2? is a couple, and a couple is a nice human idea :) this is borne out by 
the ?1, 2, many? pattern in many ancient languages. we know 1, we know 2, 
after that it?s just an abstract concept.



Sooooooooooo ... here is my proposal:

	We call it Plasma 2 and use that as a rallying call to 
	focus on its unified user experience 
	across the spectrum of devices people use today.

as developers, it will remind us of our goals.

to our users, it will be the symbol of this idea of all these individual 
components that work together beautifully no matter what device you put it on.

yes, this means we drop ?Workspaces? as clumsy, hard to understand and no 
longer fully applicable.


Other proposals, ideas, tweaks to the above most welcome, but let?s try to 
come to a consensus on this matter before the end of this month.

then we can all move forward in confidence together, whatever it is we decide.

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/274d3e75/attachment.sig>

From sebas at kde.org  Mon Aug 19 20:13:57 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Mon, 19 Aug 2013 22:13:57 +0200
Subject: Mondaily meeting on Tuesday, 12:00
Message-ID: <2676979.JZ1ScF4min@miro.vizzzion.net>

Hey,

Due to a "party-induced incapacitation" this Monday, our weekly meeting is 
scheduled for Tuesday, 12:00 Europe/Amsterdam.

See you!
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From ivan.cukic at gmail.com  Mon Aug 19 20:17:43 2013
From: ivan.cukic at gmail.com (=?UTF-8?B?SXZhbiDEjHVracSH?=)
Date: Mon, 19 Aug 2013 22:17:43 +0200
Subject: Mondaily meeting on Tuesday, 12:00
In-Reply-To: <2676979.JZ1ScF4min@miro.vizzzion.net>
References: <2676979.JZ1ScF4min@miro.vizzzion.net>
Message-ID: <CAFkAKBzhMzJ8TQWX6GWGf_6-XJryDJ9Xe3KaanWb8bQ-JWAShg@mail.gmail.com>

Can we move it for Wednesday? I have a meeting tomorrow.

Cheers,
Ivan




On 19 August 2013 22:13, Sebastian K?gler <sebas at kde.org> wrote:

> Hey,
>
> Due to a "party-induced incapacitation" this Monday, our weekly meeting is
> scheduled for Tuesday, 12:00 Europe/Amsterdam.
>
> See you!
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/04980055/attachment.html>

From sebas at kde.org  Mon Aug 19 20:22:57 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Mon, 19 Aug 2013 22:22:57 +0200
Subject: Mondaily meeting on Tuesday, 12:00
In-Reply-To: <CAFkAKBzhMzJ8TQWX6GWGf_6-XJryDJ9Xe3KaanWb8bQ-JWAShg@mail.gmail.com>
References: <2676979.JZ1ScF4min@miro.vizzzion.net>
 <CAFkAKBzhMzJ8TQWX6GWGf_6-XJryDJ9Xe3KaanWb8bQ-JWAShg@mail.gmail.com>
Message-ID: <11289727.RZOfRnfCvB@miro.vizzzion.net>

On Monday, August 19, 2013 22:17:43 Ivan ?uki? wrote:
> Can we move it for Wednesday? I have a meeting tomorrow.

I have one on wednesday. :)

Let's just get over it, we can always talk off-meeting.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From sebas at kde.org  Mon Aug 19 20:24:55 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Mon, 19 Aug 2013 20:24:55 -0000
Subject: Review Request 112127: Enable QML Debugger
In-Reply-To: <20130816205830.20958.91420@vidsolbach.de>
References: <20130816205830.20958.91420@vidsolbach.de>
Message-ID: <20130819202455.14695.92410@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112127/#review38171
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian K?gler


On Aug. 16, 2013, 8:58 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112127/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2013, 8:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Enable QML Debugger
> 
> 
> Diffs
> -----
> 
>   src/shell/main.cpp 18d381a0d3b76ef1c24b8585dc06047664a4cc55 
> 
> Diff: http://git.reviewboard.kde.org/r/112127/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/dd03778a/attachment-0001.html>

From notmart at gmail.com  Mon Aug 19 20:31:24 2013
From: notmart at gmail.com (Marco Martin)
Date: Mon, 19 Aug 2013 22:31:24 +0200
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <4307248.3PSIsHcoYp@freedom>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
 <4307248.3PSIsHcoYp@freedom>
Message-ID: <201308192231.24598.notmart@gmail.com>

On Monday 19 August 2013, Aaron J. Seigo wrote:
> no matter how wonderful it is to have a single shared implementation
> upstream so we don?t have to do anything but implement applications, we
> have to hit the three points above.
> 
> in the end API, stability and device spectrum are what matters to 3rd party
> developers and our users.

There are some components that have very minimal change, unfortunately in many 
plasces there is a very small detail (like icon and iconName vs iconSource) 
that makes it not zero effort.
Some other are more different, like PageStack got renamed in StackView (but 
behaviourally seems pretty much untouched)

As I said, they are probably in the long term the way to go, should be 
possible quite some personalization per se, and if not enough the whole single 
component can still be replaced with a different implementation like we do 
now.

The catch is also that i would really like to see how much lie is the cake 
this time (we jumped on promising unfinished technologies by qt several times 
already, and not always ended up very well, remember)

* is to be tried, for sure, and see if some of the components can be replaced 
with an implementation that is completely drop in.

* adapting api may be an option, depends how much we want or can suffer (we 
have quite on our plate...)

* plasma style for qtquickcontrols has to be done anyways, since they can be 
used (well, technically at least) from plasmoids and people will use them (i 
guess in the future they may have more widgets, maybe some that we don't have 
in plasmacomponents, so they should play nice together)



-- 
Marco Martin

From dakerfp at gmail.com  Mon Aug 19 20:45:41 2013
From: dakerfp at gmail.com (Daker Fernandes Pinheiro)
Date: Mon, 19 Aug 2013 20:45:41 +0000
Subject: [RFC] Port PlasmaComponents to use QtQuick Controls where
 applicable
In-Reply-To: <201308192231.24598.notmart@gmail.com>
References: <CAGeFrHCo49G6o9rkm000vqyq=GYW1fiY5NcoxLBX7jyeJ3H0WA@mail.gmail.com>
 <4307248.3PSIsHcoYp@freedom> <201308192231.24598.notmart@gmail.com>
Message-ID: <CAHhpqgZLqUVKx2-_hgb0Q_jNRT=3ZkX0jqwi3mD0btqD8AfR9A@mail.gmail.com>

I agree with Marco,

Just would like to remark that building the styles for qtquickcontrols
should be top priority.


2013/8/19 Marco Martin <notmart at gmail.com>

> On Monday 19 August 2013, Aaron J. Seigo wrote:
> > no matter how wonderful it is to have a single shared implementation
> > upstream so we don?t have to do anything but implement applications, we
> > have to hit the three points above.
> >
> > in the end API, stability and device spectrum are what matters to 3rd
> party
> > developers and our users.
>
> There are some components that have very minimal change, unfortunately in
> many
> plasces there is a very small detail (like icon and iconName vs iconSource)
> that makes it not zero effort.
> Some other are more different, like PageStack got renamed in StackView (but
> behaviourally seems pretty much untouched)
>
> As I said, they are probably in the long term the way to go, should be
> possible quite some personalization per se, and if not enough the whole
> single
> component can still be replaced with a different implementation like we do
> now.
>
> The catch is also that i would really like to see how much lie is the cake
> this time (we jumped on promising unfinished technologies by qt several
> times
> already, and not always ended up very well, remember)
>
> * is to be tried, for sure, and see if some of the components can be
> replaced
> with an implementation that is completely drop in.
>
> * adapting api may be an option, depends how much we want or can suffer (we
> have quite on our plate...)
>
> * plasma style for qtquickcontrols has to be done anyways, since they can
> be
> used (well, technically at least) from plasmoids and people will use them
> (i
> guess in the future they may have more widgets, maybe some that we don't
> have
> in plasmacomponents, so they should play nice together)
>
>
>
> --
> Marco Martin
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
Daker Fernandes Pinheiro
http://codecereal.blogspot.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/b276b6d0/attachment.html>

From ervin at kde.org  Mon Aug 19 20:59:46 2013
From: ervin at kde.org (Kevin Ottens)
Date: Mon, 19 Aug 2013 22:59:46 +0200
Subject: naming the next major release
In-Reply-To: <137711932.oj8iDjKShl@freedom>
References: <137711932.oj8iDjKShl@freedom>
Message-ID: <1806508.nV4MXdyN7Y@wintermute>

On Monday 19 August 2013 21:56:35 Aaron J. Seigo wrote:
> 3. ?2? ... why ?two? if this is version 5? well, libplasma is actually going
> to be version 6 iirc, so it isn?t the library.

Not that its relevant for the rest of the discussion, but as the library 
number itself is concerned you can make it 5. And that's in fact my preference 
as I'd like all our library numbers to be in sync for a change. :-)

Regards.
-- 
K?vin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/db4e677c/attachment.sig>

From notmart at gmail.com  Mon Aug 19 21:08:15 2013
From: notmart at gmail.com (Marco Martin)
Date: Mon, 19 Aug 2013 23:08:15 +0200
Subject: naming the next major release
In-Reply-To: <1806508.nV4MXdyN7Y@wintermute>
References: <137711932.oj8iDjKShl@freedom> <1806508.nV4MXdyN7Y@wintermute>
Message-ID: <201308192308.16132.notmart@gmail.com>

On Monday 19 August 2013, Kevin Ottens wrote:
> On Monday 19 August 2013 21:56:35 Aaron J. Seigo wrote:
> > 3. ?2? ... why ?two? if this is version 5? well, libplasma is actually
> > going to be version 6 iirc, so it isn?t the library.
> 
> Not that its relevant for the rest of the discussion, but as the library
> number itself is concerned you can make it 5. And that's in fact my
> preference as I'd like all our library numbers to be in sync for a change.
> :-)
> 
> Regards.

yes, plasma2 has .so.5 atm, plasma1 is 4

-- 
Marco Martin

From ervin at kde.org  Mon Aug 19 21:28:35 2013
From: ervin at kde.org (Kevin Ottens)
Date: Mon, 19 Aug 2013 23:28:35 +0200
Subject: naming the next major release
In-Reply-To: <201308192308.16132.notmart@gmail.com>
References: <137711932.oj8iDjKShl@freedom> <1806508.nV4MXdyN7Y@wintermute>
 <201308192308.16132.notmart@gmail.com>
Message-ID: <2603977.kgdusEDDxG@wintermute>

On Monday 19 August 2013 23:08:15 Marco Martin wrote:
> On Monday 19 August 2013, Kevin Ottens wrote:
> > On Monday 19 August 2013 21:56:35 Aaron J. Seigo wrote:
> > > 3. ?2? ... why ?two? if this is version 5? well, libplasma is actually
> > > going to be version 6 iirc, so it isn?t the library.
> > 
> > Not that its relevant for the rest of the discussion, but as the library
> > number itself is concerned you can make it 5. And that's in fact my
> > preference as I'd like all our library numbers to be in sync for a change.
> > 
> > :-)
> > 
> > Regards.
> 
> yes, plasma2 has .so.5 atm, plasma1 is 4

Yep, only kdecore and kdeui were ahead because of a very old binary 
compatibility breakage during the KDE2 (IIRC) timeframe. But guess what? Those 
two are almost gone (I'll likely make the commits to clean them for good 
tomorrow). :-)

Regards.
-- 
K?vin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/0536bba9/attachment.sig>

From aseigo at kde.org  Mon Aug 19 23:26:44 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Tue, 20 Aug 2013 01:26:44 +0200
Subject: naming the next major release
In-Reply-To: <201308192308.16132.notmart@gmail.com>
References: <137711932.oj8iDjKShl@freedom> <1806508.nV4MXdyN7Y@wintermute>
 <201308192308.16132.notmart@gmail.com>
Message-ID: <6305177.O9VrXusP8c@freedom>

On Monday, August 19, 2013 23:08:15 Marco Martin wrote:
> On Monday 19 August 2013, Kevin Ottens wrote:
> > On Monday 19 August 2013 21:56:35 Aaron J. Seigo wrote:
> > > 3. ?2? ... why ?two? if this is version 5? well, libplasma is actually
> > > going to be version 6 iirc, so it isn?t the library.
> > 
> > Not that its relevant for the rest of the discussion, but as the library
> > number itself is concerned you can make it 5. And that's in fact my
> > preference as I'd like all our library numbers to be in sync for a change.
..
> yes, plasma2 has .so.5 atm, plasma1 is 4

Really? I?m getting this from master:

-- Installing: /opt/kde4/lib/libplasma.so.3.0.0

That?s also what I see in the openSuse packages.

So, yes, I got the # wrong .. it?s 3, not 5 currently .. so we?d end up with 4 
unless we skip it go to 5. Still, the ?number used in the name doesn?t match 
the version number of <insert component here>? comment remains

It?s also made more complex once we look at things like kscreen which seems to 
be at version 1.x; the more components we look at as part of the Plasma shell 
the more version variance there is. 

If we do end up using SDDM then it gets even more difficult as we don?t even 
control the versioning of all the software.

Basically, I?m suggesting that naming the product after the version of the 
software isn?t a necessity and may not even be possible unless we elevate one 
specific component to be the ?defining? component, which I don?t think we ought 
to do.

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/e5c96f27/attachment.sig>

From huzheng001 at gmail.com  Tue Aug 20 04:37:28 2013
From: huzheng001 at gmail.com (Hu Zheng)
Date: Tue, 20 Aug 2013 04:37:28 -0000
Subject: Review Request 111849: custom first week for plasmaclock.
In-Reply-To: <20130803033633.19898.17573@vidsolbach.de>
References: <20130803033633.19898.17573@vidsolbach.de>
Message-ID: <20130820043728.8828.21877@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/
-----------------------------------------------------------

(Updated Aug. 20, 2013, 4:37 a.m.)


Review request for Plasma.


Changes
-------

Another patch, which use custom config file.


Description
-------

In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/111849/diff/


Testing
-------

cd kde-workspace-4.10.5/libs/plasmaclock
patch -p1 < customfirstweek.patch

The save configuration codes are not very beautiful, but it works fine!


File Attachments (updated)
----------------

patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch
another patch, use custom config file.
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch


Thanks,

Hu Zheng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/f6570a10/attachment-0001.html>

From bhush94 at gmail.com  Tue Aug 20 04:51:21 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Tue, 20 Aug 2013 10:21:21 +0530
Subject: Can not find XCB modules.
In-Reply-To: <2746813.sNrQiLSP2L@martin-thinkpad>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <2746813.sNrQiLSP2L@martin-thinkpad>
Message-ID: <CAGPcNU2y6jTdRfFG1FFGzyA7RSdmcownxOp1zUm1g-fgBa7cuA@mail.gmail.com>

On Tue, Aug 20, 2013 at 12:25 AM, Martin Graesslin <mgraesslin at kde.org> wrote:
> I'm pretty sure that some dev package is missing and that they are available
> on Ubuntu otherwise project-neon could not compile 4.11 ;-)


So only thing I am missing is libxcb-cursor-dev and it is not
available for raring or saucy(?)... Can you check with available
libraries on my system? and also my env output?

From mgraesslin at kde.org  Tue Aug 20 05:06:10 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Tue, 20 Aug 2013 07:06:10 +0200
Subject: naming the next major release
In-Reply-To: <137711932.oj8iDjKShl@freedom>
References: <137711932.oj8iDjKShl@freedom>
Message-ID: <1433788.OvMntcx8Xk@martin-thinkpad>

On Monday 19 August 2013 21:56:35 Aaron J. Seigo wrote:
> 3. ?2? ... why ?two? if this is version 5? well, libplasma is actually going
> to be version 6 iirc, so it isn?t the library. i also am not a big believer
> in branding after version numbers. neither are any of our proprietary
> competitors who have a lot more marketing and communications savvy than we
> tend to. ;) what i like about 2 is:
> 
> * it communicates this is something after the first. it?s that whole ?two
> point oh? thing, though hopefully less hype than, say, ?web 2.0? ;)
> 
> * it?s simple and direct
> 
> * ?2? is a couple, and a couple is a nice human idea :) this is borne out by
> the ?1, 2, many? pattern in many ancient languages. we know 1, we know 2,
> after that it?s just an abstract concept.
I would like to get rid of version numbers in the traditional way. If the 
numbers are small, it's fine. But looking at many projects I am not able to get 
how old software is based on the number.

So instead I suggest that we go by year and numbering:
* 2014.1.4
* 2014.2.2
* 2014.3.1
-> year.major.minor

It would also prevent the confusion that several parts of our software has now 
different versions and especially that 4+1=2 :-)
> 
> 
> 
> Sooooooooooo ... here is my proposal:
> 
> 	We call it Plasma 2 and use that as a rallying call to
> 	focus on its unified user experience
> 	across the spectrum of devices people use today.
I do want to promote KWin for the usage in LXDE/Razor as in the next version 
we will hardly have any build-time dependencies from frameworks higher than 
tier1. I'm concerned that a generic name "Plasma" would work against that as 
it would be difficult to communicate that although being part of Plasma not 
being part of Plasma. If someone has a good idea on how to properly 
communicate this without being confusing (especially for users who want the 
lightweight aspect of LXDE and Plasma is for people in that user group 
unfortunately the definition of bloat) I consider this as a non-blocking issue 
for the naming.

We should also think about what the name would mean for bug reporting. We 
don't want that all bugs for everything what is in kde-workspaces nowadays 
ends up in the component plasma.

Cheers
Martin

P.S. Thanks for bringing the topic to the mailing list.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/60dbd7cc/attachment.sig>

From mgraesslin at kde.org  Tue Aug 20 05:09:04 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Tue, 20 Aug 2013 07:09:04 +0200
Subject: Can not find XCB modules.
In-Reply-To: <CAGPcNU2y6jTdRfFG1FFGzyA7RSdmcownxOp1zUm1g-fgBa7cuA@mail.gmail.com>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <2746813.sNrQiLSP2L@martin-thinkpad>
 <CAGPcNU2y6jTdRfFG1FFGzyA7RSdmcownxOp1zUm1g-fgBa7cuA@mail.gmail.com>
Message-ID: <1806231.aACuhb3Be9@martin-thinkpad>

On Tuesday 20 August 2013 10:21:21 Bhushan Shah wrote:
> On Tue, Aug 20, 2013 at 12:25 AM, Martin Graesslin <mgraesslin at kde.org> 
wrote:
> > I'm pretty sure that some dev package is missing and that they are
> > available on Ubuntu otherwise project-neon could not compile 4.11 ;-)
> 
> So only thing I am missing is libxcb-cursor-dev and it is not
> available for raring or saucy(?)
did you check what's installed and what not. Because libxcb-cursor-dev is 
marked as not-installed on the output I gave you (The "p" stands for available 
package, you have to look for the "i").

> ... Can you check with available
> libraries on my system? and also my env output?
I saw that output, but it didn't include any of the dev packages.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/d9f6b374/attachment.sig>

From bhush94 at gmail.com  Tue Aug 20 06:03:06 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Tue, 20 Aug 2013 11:33:06 +0530
Subject: Can not find XCB modules.
In-Reply-To: <1806231.aACuhb3Be9@martin-thinkpad>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <2746813.sNrQiLSP2L@martin-thinkpad>
 <CAGPcNU2y6jTdRfFG1FFGzyA7RSdmcownxOp1zUm1g-fgBa7cuA@mail.gmail.com>
 <1806231.aACuhb3Be9@martin-thinkpad>
Message-ID: <CAGPcNU3ssHasKNc3xmcPFjtyMC9VKMe1Busbp0fcDNdyJd7dPQ@mail.gmail.com>

Hello,

Now that's double annoying to me, I have more packages installed then you, still

bshah at kubuntu:~$ aptitude search xcb | grep dev
i   libx11-xcb-dev                  - Xlib/XCB interface library (development he
i   libxcb-composite0-dev           - X C Binding, composite extension, developm
i   libxcb-damage0-dev              - X C Binding, damage extension, development
i   libxcb-doc                      - X C Binding, development documentation
i   libxcb-dpms0-dev                - X C Binding, dpms extension, development f
i   libxcb-dri2-0-dev               - X C Binding, dri2 extension, development f
i   libxcb-ewmh-dev                 - utility libraries for X C Binding -- ewmh,
i   libxcb-glx0-dev                 - X C Binding, glx extension, development fi
i   libxcb-icccm4-dev               - utility libraries for X C Binding -- icccm
i   libxcb-image0-dev               - utility libraries for X C Binding -- image
i   libxcb-keysyms1-dev             - utility libraries for X C Binding -- keysy
i   libxcb-randr0-dev               - X C Binding, randr extension, development
i   libxcb-record0-dev              - X C Binding, record extension, development
i   libxcb-render-util0-dev         - utility libraries for X C Binding -- rende
i   libxcb-render0-dev              - X C Binding, render extension, development
i   libxcb-res0-dev                 - X C Binding, res extension, development fi
i   libxcb-screensaver0-dev         - X C Binding, screensaver extension, develo
i   libxcb-shape0-dev               - X C Binding, shape extension, development
i   libxcb-shm0-dev                 - X C Binding, shm extension, development fi
i   libxcb-sync0-dev                - X C Binding, sync extension, development f
i   libxcb-util0-dev                - utility libraries for X C Binding -- atom,
i   libxcb-xevie0-dev               - X C Binding, xevie extension, development
i   libxcb-xf86dri0-dev             - X C Binding, xf86dri extension, developmen
i   libxcb-xfixes0-dev              - X C Binding, xfixes extension, development
i   libxcb-xinerama0-dev            - X C Binding, xinerama extension, developme
i   libxcb-xprint0-dev              - X C Binding, xprint extension, development
i   libxcb-xtest0-dev               - X C Binding, xtest extension, development
i   libxcb-xv0-dev                  - X C Binding, xv extension, development fil
i   libxcb-xvmc0-dev                - X C Binding, xvmc extension, development f
i   libxcb1-dev                     - X C Binding, development files

Thanks.

On Tue, Aug 20, 2013 at 10:39 AM, Martin Graesslin <mgraesslin at kde.org> wrote:
> On Tuesday 20 August 2013 10:21:21 Bhushan Shah wrote:
>> On Tue, Aug 20, 2013 at 12:25 AM, Martin Graesslin <mgraesslin at kde.org>
> wrote:
>> > I'm pretty sure that some dev package is missing and that they are
>> > available on Ubuntu otherwise project-neon could not compile 4.11 ;-)
>>
>> So only thing I am missing is libxcb-cursor-dev and it is not
>> available for raring or saucy(?)
> did you check what's installed and what not. Because libxcb-cursor-dev is
> marked as not-installed on the output I gave you (The "p" stands for available
> package, you have to look for the "i").
>
>> ... Can you check with available
>> libraries on my system? and also my env output?
> I saw that output, but it didn't include any of the dev packages.
>
> Cheers
> Martin
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>

From bhush94 at gmail.com  Tue Aug 20 06:06:58 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Tue, 20 Aug 2013 11:36:58 +0530
Subject: Can not find XCB modules.
In-Reply-To: <CAGPcNU3ssHasKNc3xmcPFjtyMC9VKMe1Busbp0fcDNdyJd7dPQ@mail.gmail.com>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <2746813.sNrQiLSP2L@martin-thinkpad>
 <CAGPcNU2y6jTdRfFG1FFGzyA7RSdmcownxOp1zUm1g-fgBa7cuA@mail.gmail.com>
 <1806231.aACuhb3Be9@martin-thinkpad>
 <CAGPcNU3ssHasKNc3xmcPFjtyMC9VKMe1Busbp0fcDNdyJd7dPQ@mail.gmail.com>
Message-ID: <CAGPcNU1KzHhSZ5-qEVxZsgWz53T=yqrY6PE3WTd2=nKYrDEXMg@mail.gmail.com>

Hello,

Even I have tried with complete re installation of KUbuntu and fresh
clone of the kde-workspace, but something is still wrong. Here is what
I do to compile.

$ cd ~/kde-workspace
$ git checkout frameworks-scratch
$ mkdir build && cd build
$ neon5-env
$ neon5-cmake ..

and also

cmake ..

Thanks!

On Tue, Aug 20, 2013 at 11:33 AM, Bhushan Shah <bhush94 at gmail.com> wrote:
> Hello,
>
> Now that's double annoying to me, I have more packages installed then you, still
>
> bshah at kubuntu:~$ aptitude search xcb | grep dev
> i   libx11-xcb-dev                  - Xlib/XCB interface library (development he
> i   libxcb-composite0-dev           - X C Binding, composite extension, developm
> i   libxcb-damage0-dev              - X C Binding, damage extension, development
> i   libxcb-doc                      - X C Binding, development documentation
> i   libxcb-dpms0-dev                - X C Binding, dpms extension, development f
> i   libxcb-dri2-0-dev               - X C Binding, dri2 extension, development f
> i   libxcb-ewmh-dev                 - utility libraries for X C Binding -- ewmh,
> i   libxcb-glx0-dev                 - X C Binding, glx extension, development fi
> i   libxcb-icccm4-dev               - utility libraries for X C Binding -- icccm
> i   libxcb-image0-dev               - utility libraries for X C Binding -- image
> i   libxcb-keysyms1-dev             - utility libraries for X C Binding -- keysy
> i   libxcb-randr0-dev               - X C Binding, randr extension, development
> i   libxcb-record0-dev              - X C Binding, record extension, development
> i   libxcb-render-util0-dev         - utility libraries for X C Binding -- rende
> i   libxcb-render0-dev              - X C Binding, render extension, development
> i   libxcb-res0-dev                 - X C Binding, res extension, development fi
> i   libxcb-screensaver0-dev         - X C Binding, screensaver extension, develo
> i   libxcb-shape0-dev               - X C Binding, shape extension, development
> i   libxcb-shm0-dev                 - X C Binding, shm extension, development fi
> i   libxcb-sync0-dev                - X C Binding, sync extension, development f
> i   libxcb-util0-dev                - utility libraries for X C Binding -- atom,
> i   libxcb-xevie0-dev               - X C Binding, xevie extension, development
> i   libxcb-xf86dri0-dev             - X C Binding, xf86dri extension, developmen
> i   libxcb-xfixes0-dev              - X C Binding, xfixes extension, development
> i   libxcb-xinerama0-dev            - X C Binding, xinerama extension, developme
> i   libxcb-xprint0-dev              - X C Binding, xprint extension, development
> i   libxcb-xtest0-dev               - X C Binding, xtest extension, development
> i   libxcb-xv0-dev                  - X C Binding, xv extension, development fil
> i   libxcb-xvmc0-dev                - X C Binding, xvmc extension, development f
> i   libxcb1-dev                     - X C Binding, development files
>
> Thanks.
>
> On Tue, Aug 20, 2013 at 10:39 AM, Martin Graesslin <mgraesslin at kde.org> wrote:
>> On Tuesday 20 August 2013 10:21:21 Bhushan Shah wrote:
>>> On Tue, Aug 20, 2013 at 12:25 AM, Martin Graesslin <mgraesslin at kde.org>
>> wrote:
>>> > I'm pretty sure that some dev package is missing and that they are
>>> > available on Ubuntu otherwise project-neon could not compile 4.11 ;-)
>>>
>>> So only thing I am missing is libxcb-cursor-dev and it is not
>>> available for raring or saucy(?)
>> did you check what's installed and what not. Because libxcb-cursor-dev is
>> marked as not-installed on the output I gave you (The "p" stands for available
>> package, you have to look for the "i").
>>
>>> ... Can you check with available
>>> libraries on my system? and also my env output?
>> I saw that output, but it didn't include any of the dev packages.
>>
>> Cheers
>> Martin
>> _______________________________________________
>> Plasma-devel mailing list
>> Plasma-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>

From mgraesslin at kde.org  Tue Aug 20 06:22:07 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Tue, 20 Aug 2013 08:22:07 +0200
Subject: Can not find XCB modules.
In-Reply-To: <CAGPcNU1KzHhSZ5-qEVxZsgWz53T=yqrY6PE3WTd2=nKYrDEXMg@mail.gmail.com>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <CAGPcNU3ssHasKNc3xmcPFjtyMC9VKMe1Busbp0fcDNdyJd7dPQ@mail.gmail.com>
 <CAGPcNU1KzHhSZ5-qEVxZsgWz53T=yqrY6PE3WTd2=nKYrDEXMg@mail.gmail.com>
Message-ID: <1681106.WvKiZsfhyP@martin-thinkpad>

On Tuesday 20 August 2013 11:36:58 Bhushan Shah wrote:
> Hello,
> 
> Even I have tried with complete re installation of KUbuntu and fresh
> clone of the kde-workspace, but something is still wrong. Here is what
> I do to compile.
it looks fine. I'm out of ideas. Maybe talk to the neon devs on IRC (#kubuntu-
devel). The neon setup is able to compile it, so it just needs to be possible.

Cheers
Martin
> 
> $ cd ~/kde-workspace
> $ git checkout frameworks-scratch
> $ mkdir build && cd build
> $ neon5-env
> $ neon5-cmake ..
> 
> and also
> 
> cmake ..
> 
> Thanks!
> 
> On Tue, Aug 20, 2013 at 11:33 AM, Bhushan Shah <bhush94 at gmail.com> 
wrote:
> > Hello,
> > 
> > Now that's double annoying to me, I have more packages installed then you,
> > still
> > 
> > bshah at kubuntu:~$ aptitude search xcb | grep dev
> > i   libx11-xcb-dev                  - Xlib/XCB interface library
> > (development he i   libxcb-composite0-dev           - X C Binding,
> > composite extension, developm i   libxcb-damage0-dev              - X C
> > Binding, damage extension, development i   libxcb-doc                    
> >  - X C Binding, development documentation i   libxcb-dpms0-dev           
> >     - X C Binding, dpms extension, development f i   libxcb-dri2-0-dev   
> >            - X C Binding, dri2 extension, development f i  
> > libxcb-ewmh-dev                 - utility libraries for X C Binding --
> > ewmh, i   libxcb-glx0-dev                 - X C Binding, glx extension,
> > development fi i   libxcb-icccm4-dev               - utility libraries
> > for X C Binding -- icccm i   libxcb-image0-dev               - utility
> > libraries for X C Binding -- image i   libxcb-keysyms1-dev             -
> > utility libraries for X C Binding -- keysy i   libxcb-randr0-dev         
> >      - X C Binding, randr extension, development i   libxcb-record0-dev  
> >            - X C Binding, record extension, development i  
> > libxcb-render-util0-dev         - utility libraries for X C Binding --
> > rende i   libxcb-render0-dev              - X C Binding, render
> > extension, development i   libxcb-res0-dev                 - X C Binding,
> > res extension, development fi i   libxcb-screensaver0-dev         - X C
> > Binding, screensaver extension, develo i   libxcb-shape0-dev             
> >  - X C Binding, shape extension, development i   libxcb-shm0-dev         
> >        - X C Binding, shm extension, development fi i   libxcb-sync0-dev 
> >               - X C Binding, sync extension, development f i  
> > libxcb-util0-dev                - utility libraries for X C Binding --
> > atom, i   libxcb-xevie0-dev               - X C Binding, xevie extension,
> > development i   libxcb-xf86dri0-dev             - X C Binding, xf86dri
> > extension, developmen i   libxcb-xfixes0-dev              - X C Binding,
> > xfixes extension, development i   libxcb-xinerama0-dev            - X C
> > Binding, xinerama extension, developme i   libxcb-xprint0-dev            
> >  - X C Binding, xprint extension, development i   libxcb-xtest0-dev      
> >         - X C Binding, xtest extension, development i   libxcb-xv0-dev   
> >               - X C Binding, xv extension, development fil i  
> > libxcb-xvmc0-dev                - X C Binding, xvmc extension,
> > development f i   libxcb1-dev                     - X C Binding,
> > development files
> > 
> > Thanks.
> > 
> > On Tue, Aug 20, 2013 at 10:39 AM, Martin Graesslin <mgraesslin at kde.org> 
wrote:
> >> On Tuesday 20 August 2013 10:21:21 Bhushan Shah wrote:
> >>> On Tue, Aug 20, 2013 at 12:25 AM, Martin Graesslin 
<mgraesslin at kde.org>
> >> 
> >> wrote:
> >>> > I'm pretty sure that some dev package is missing and that they are
> >>> > available on Ubuntu otherwise project-neon could not compile 4.11 ;-)
> >>> 
> >>> So only thing I am missing is libxcb-cursor-dev and it is not
> >>> available for raring or saucy(?)
> >> 
> >> did you check what's installed and what not. Because libxcb-cursor-dev is
> >> marked as not-installed on the output I gave you (The "p" stands for
> >> available package, you have to look for the "i").
> >> 
> >>> ... Can you check with available
> >>> libraries on my system? and also my env output?
> >> 
> >> I saw that output, but it didn't include any of the dev packages.
> >> 
> >> Cheers
> >> Martin
> >> _______________________________________________
> >> Plasma-devel mailing list
> >> Plasma-devel at kde.org
> >> https://mail.kde.org/mailman/listinfo/plasma-devel
> 
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/07b9a338/attachment-0001.sig>

From bhush94 at gmail.com  Tue Aug 20 06:44:28 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Tue, 20 Aug 2013 12:14:28 +0530
Subject: Can not find XCB modules.
In-Reply-To: <1681106.WvKiZsfhyP@martin-thinkpad>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <CAGPcNU3ssHasKNc3xmcPFjtyMC9VKMe1Busbp0fcDNdyJd7dPQ@mail.gmail.com>
 <CAGPcNU1KzHhSZ5-qEVxZsgWz53T=yqrY6PE3WTd2=nKYrDEXMg@mail.gmail.com>
 <1681106.WvKiZsfhyP@martin-thinkpad>
Message-ID: <CAGPcNU24t+MXSUr9rDz-CDh7CGpbONx_m0vLNFWwjeB5Ow+WfA@mail.gmail.com>

Hello,

Here is relevant cmake --trace log, if that helps..
http://paste.kde.org/p48e12dc6/

Thanks

On Tue, Aug 20, 2013 at 11:52 AM, Martin Graesslin <mgraesslin at kde.org> wrote:
> On Tuesday 20 August 2013 11:36:58 Bhushan Shah wrote:
>> Hello,
>>
>> Even I have tried with complete re installation of KUbuntu and fresh
>> clone of the kde-workspace, but something is still wrong. Here is what
>> I do to compile.
> it looks fine. I'm out of ideas. Maybe talk to the neon devs on IRC (#kubuntu-
> devel). The neon setup is able to compile it, so it just needs to be possible.
>
> Cheers
> Martin
>>
>> $ cd ~/kde-workspace
>> $ git checkout frameworks-scratch
>> $ mkdir build && cd build
>> $ neon5-env
>> $ neon5-cmake ..
>>
>> and also
>>
>> cmake ..
>>
>> Thanks!
>>
>> On Tue, Aug 20, 2013 at 11:33 AM, Bhushan Shah <bhush94 at gmail.com>
> wrote:
>> > Hello,
>> >
>> > Now that's double annoying to me, I have more packages installed then you,
>> > still
>> >
>> > bshah at kubuntu:~$ aptitude search xcb | grep dev
>> > i   libx11-xcb-dev                  - Xlib/XCB interface library
>> > (development he i   libxcb-composite0-dev           - X C Binding,
>> > composite extension, developm i   libxcb-damage0-dev              - X C
>> > Binding, damage extension, development i   libxcb-doc
>> >  - X C Binding, development documentation i   libxcb-dpms0-dev
>> >     - X C Binding, dpms extension, development f i   libxcb-dri2-0-dev
>> >            - X C Binding, dri2 extension, development f i
>> > libxcb-ewmh-dev                 - utility libraries for X C Binding --
>> > ewmh, i   libxcb-glx0-dev                 - X C Binding, glx extension,
>> > development fi i   libxcb-icccm4-dev               - utility libraries
>> > for X C Binding -- icccm i   libxcb-image0-dev               - utility
>> > libraries for X C Binding -- image i   libxcb-keysyms1-dev             -
>> > utility libraries for X C Binding -- keysy i   libxcb-randr0-dev
>> >      - X C Binding, randr extension, development i   libxcb-record0-dev
>> >            - X C Binding, record extension, development i
>> > libxcb-render-util0-dev         - utility libraries for X C Binding --
>> > rende i   libxcb-render0-dev              - X C Binding, render
>> > extension, development i   libxcb-res0-dev                 - X C Binding,
>> > res extension, development fi i   libxcb-screensaver0-dev         - X C
>> > Binding, screensaver extension, develo i   libxcb-shape0-dev
>> >  - X C Binding, shape extension, development i   libxcb-shm0-dev
>> >        - X C Binding, shm extension, development fi i   libxcb-sync0-dev
>> >               - X C Binding, sync extension, development f i
>> > libxcb-util0-dev                - utility libraries for X C Binding --
>> > atom, i   libxcb-xevie0-dev               - X C Binding, xevie extension,
>> > development i   libxcb-xf86dri0-dev             - X C Binding, xf86dri
>> > extension, developmen i   libxcb-xfixes0-dev              - X C Binding,
>> > xfixes extension, development i   libxcb-xinerama0-dev            - X C
>> > Binding, xinerama extension, developme i   libxcb-xprint0-dev
>> >  - X C Binding, xprint extension, development i   libxcb-xtest0-dev
>> >         - X C Binding, xtest extension, development i   libxcb-xv0-dev
>> >               - X C Binding, xv extension, development fil i
>> > libxcb-xvmc0-dev                - X C Binding, xvmc extension,
>> > development f i   libxcb1-dev                     - X C Binding,
>> > development files
>> >
>> > Thanks.
>> >
>> > On Tue, Aug 20, 2013 at 10:39 AM, Martin Graesslin <mgraesslin at kde.org>
> wrote:
>> >> On Tuesday 20 August 2013 10:21:21 Bhushan Shah wrote:
>> >>> On Tue, Aug 20, 2013 at 12:25 AM, Martin Graesslin
> <mgraesslin at kde.org>
>> >>
>> >> wrote:
>> >>> > I'm pretty sure that some dev package is missing and that they are
>> >>> > available on Ubuntu otherwise project-neon could not compile 4.11 ;-)
>> >>>
>> >>> So only thing I am missing is libxcb-cursor-dev and it is not
>> >>> available for raring or saucy(?)
>> >>
>> >> did you check what's installed and what not. Because libxcb-cursor-dev is
>> >> marked as not-installed on the output I gave you (The "p" stands for
>> >> available package, you have to look for the "i").
>> >>
>> >>> ... Can you check with available
>> >>> libraries on my system? and also my env output?
>> >>
>> >> I saw that output, but it didn't include any of the dev packages.
>> >>
>> >> Cheers
>> >> Martin
>> >> _______________________________________________
>> >> Plasma-devel mailing list
>> >> Plasma-devel at kde.org
>> >> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>> _______________________________________________
>> Plasma-devel mailing list
>> Plasma-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>

From mgraesslin at kde.org  Tue Aug 20 06:53:07 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Tue, 20 Aug 2013 08:53:07 +0200
Subject: Can not find XCB modules.
In-Reply-To: <CAGPcNU24t+MXSUr9rDz-CDh7CGpbONx_m0vLNFWwjeB5Ow+WfA@mail.gmail.com>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <1681106.WvKiZsfhyP@martin-thinkpad>
 <CAGPcNU24t+MXSUr9rDz-CDh7CGpbONx_m0vLNFWwjeB5Ow+WfA@mail.gmail.com>
Message-ID: <1424941.Lty6EYXNAO@martin-thinkpad>

On Tuesday 20 August 2013 12:14:28 Bhushan Shah wrote:
> Hello,
> 
> Here is relevant cmake --trace log, if that helps..
> http://paste.kde.org/p48e12dc6/
wait, did you apply the patch from the review request I posted yesterday? 
Because that requires adjustments in kde-workspace, too.
> 
> Thanks
> 
> On Tue, Aug 20, 2013 at 11:52 AM, Martin Graesslin <mgraesslin at kde.org> 
wrote:
> > On Tuesday 20 August 2013 11:36:58 Bhushan Shah wrote:
> >> Hello,
> >> 
> >> Even I have tried with complete re installation of KUbuntu and fresh
> >> clone of the kde-workspace, but something is still wrong. Here is what
> >> I do to compile.
> > 
> > it looks fine. I'm out of ideas. Maybe talk to the neon devs on IRC
> > (#kubuntu- devel). The neon setup is able to compile it, so it just needs
> > to be possible.
> > 
> > Cheers
> > Martin
> > 
> >> $ cd ~/kde-workspace
> >> $ git checkout frameworks-scratch
> >> $ mkdir build && cd build
> >> $ neon5-env
> >> $ neon5-cmake ..
> >> 
> >> and also
> >> 
> >> cmake ..
> >> 
> >> Thanks!
> >> 
> >> On Tue, Aug 20, 2013 at 11:33 AM, Bhushan Shah <bhush94 at gmail.com>
> > 
> > wrote:
> >> > Hello,
> >> > 
> >> > Now that's double annoying to me, I have more packages installed then
> >> > you,
> >> > still
> >> > 
> >> > bshah at kubuntu:~$ aptitude search xcb | grep dev
> >> > i   libx11-xcb-dev                  - Xlib/XCB interface library
> >> > (development he i   libxcb-composite0-dev           - X C Binding,
> >> > composite extension, developm i   libxcb-damage0-dev              - X C
> >> > Binding, damage extension, development i   libxcb-doc
> >> > 
> >> >  - X C Binding, development documentation i   libxcb-dpms0-dev
> >> >  
> >> >     - X C Binding, dpms extension, development f i   libxcb-dri2-0-dev
> >> >     
> >> >            - X C Binding, dri2 extension, development f i
> >> > 
> >> > libxcb-ewmh-dev                 - utility libraries for X C Binding --
> >> > ewmh, i   libxcb-glx0-dev                 - X C Binding, glx extension,
> >> > development fi i   libxcb-icccm4-dev               - utility libraries
> >> > for X C Binding -- icccm i   libxcb-image0-dev               - utility
> >> > libraries for X C Binding -- image i   libxcb-keysyms1-dev            
> >> > -
> >> > utility libraries for X C Binding -- keysy i   libxcb-randr0-dev
> >> > 
> >> >      - X C Binding, randr extension, development i   libxcb-record0-dev
> >> >      
> >> >            - X C Binding, record extension, development i
> >> > 
> >> > libxcb-render-util0-dev         - utility libraries for X C Binding --
> >> > rende i   libxcb-render0-dev              - X C Binding, render
> >> > extension, development i   libxcb-res0-dev                 - X C
> >> > Binding,
> >> > res extension, development fi i   libxcb-screensaver0-dev         - X C
> >> > Binding, screensaver extension, develo i   libxcb-shape0-dev
> >> > 
> >> >  - X C Binding, shape extension, development i   libxcb-shm0-dev
> >> >  
> >> >        - X C Binding, shm extension, development fi i  
> >> >        libxcb-sync0-dev
> >> >        
> >> >               - X C Binding, sync extension, development f i
> >> > 
> >> > libxcb-util0-dev                - utility libraries for X C Binding --
> >> > atom, i   libxcb-xevie0-dev               - X C Binding, xevie
> >> > extension,
> >> > development i   libxcb-xf86dri0-dev             - X C Binding, xf86dri
> >> > extension, developmen i   libxcb-xfixes0-dev              - X C
> >> > Binding,
> >> > xfixes extension, development i   libxcb-xinerama0-dev            - X C
> >> > Binding, xinerama extension, developme i   libxcb-xprint0-dev
> >> > 
> >> >  - X C Binding, xprint extension, development i   libxcb-xtest0-dev
> >> >  
> >> >         - X C Binding, xtest extension, development i   libxcb-xv0-dev
> >> >         
> >> >               - X C Binding, xv extension, development fil i
> >> > 
> >> > libxcb-xvmc0-dev                - X C Binding, xvmc extension,
> >> > development f i   libxcb1-dev                     - X C Binding,
> >> > development files
> >> > 
> >> > Thanks.
> >> > 
> >> > On Tue, Aug 20, 2013 at 10:39 AM, Martin Graesslin 
<mgraesslin at kde.org>
> > 
> > wrote:
> >> >> On Tuesday 20 August 2013 10:21:21 Bhushan Shah wrote:
> >> >>> On Tue, Aug 20, 2013 at 12:25 AM, Martin Graesslin
> > 
> > <mgraesslin at kde.org>
> > 
> >> >> wrote:
> >> >>> > I'm pretty sure that some dev package is missing and that they are
> >> >>> > available on Ubuntu otherwise project-neon could not compile 4.11
> >> >>> > ;-)
> >> >>> 
> >> >>> So only thing I am missing is libxcb-cursor-dev and it is not
> >> >>> available for raring or saucy(?)
> >> >> 
> >> >> did you check what's installed and what not. Because libxcb-cursor-dev
> >> >> is
> >> >> marked as not-installed on the output I gave you (The "p" stands for
> >> >> available package, you have to look for the "i").
> >> >> 
> >> >>> ... Can you check with available
> >> >>> libraries on my system? and also my env output?
> >> >> 
> >> >> I saw that output, but it didn't include any of the dev packages.
> >> >> 
> >> >> Cheers
> >> >> Martin
> >> >> _______________________________________________
> >> >> Plasma-devel mailing list
> >> >> Plasma-devel at kde.org
> >> >> https://mail.kde.org/mailman/listinfo/plasma-devel
> >> 
> >> _______________________________________________
> >> Plasma-devel mailing list
> >> Plasma-devel at kde.org
> >> https://mail.kde.org/mailman/listinfo/plasma-devel
> > 
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
> 
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/5b5f84d7/attachment.sig>

From bhush94 at gmail.com  Tue Aug 20 06:53:50 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Tue, 20 Aug 2013 12:23:50 +0530
Subject: Can not find XCB modules.
In-Reply-To: <1424941.Lty6EYXNAO@martin-thinkpad>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <1681106.WvKiZsfhyP@martin-thinkpad>
 <CAGPcNU24t+MXSUr9rDz-CDh7CGpbONx_m0vLNFWwjeB5Ow+WfA@mail.gmail.com>
 <1424941.Lty6EYXNAO@martin-thinkpad>
Message-ID: <CAGPcNU2jmoKgqYyhFj2V+OciaokjcKaGBPTM9SpFYUqQ2XX7Zw@mail.gmail.com>

On Tue, Aug 20, 2013 at 12:23 PM, Martin Graesslin <mgraesslin at kde.org> wrote:
> wait, did you apply the patch from the review request I posted yesterday?
> Because that requires adjustments in kde-workspace, too.


Yes! I have applied patch to ECM.

From mgraesslin at kde.org  Tue Aug 20 07:18:22 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Tue, 20 Aug 2013 09:18:22 +0200
Subject: Can not find XCB modules.
In-Reply-To: <CAGPcNU2jmoKgqYyhFj2V+OciaokjcKaGBPTM9SpFYUqQ2XX7Zw@mail.gmail.com>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <1424941.Lty6EYXNAO@martin-thinkpad>
 <CAGPcNU2jmoKgqYyhFj2V+OciaokjcKaGBPTM9SpFYUqQ2XX7Zw@mail.gmail.com>
Message-ID: <1484534.r3K2qXYEyY@martin-thinkpad>

On Tuesday 20 August 2013 12:23:50 Bhushan Shah wrote:
> On Tue, Aug 20, 2013 at 12:23 PM, Martin Graesslin <mgraesslin at kde.org> 
wrote:
> > wait, did you apply the patch from the review request I posted yesterday?
> > Because that requires adjustments in kde-workspace, too.
> 
> Yes! I have applied patch to ECM.
try to remove it again. Sorry I should have mentioned that this needs 
adjustments to where it is used.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/379cb185/attachment.sig>

From bhush94 at gmail.com  Tue Aug 20 07:23:20 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Tue, 20 Aug 2013 12:53:20 +0530
Subject: Can not find XCB modules.
In-Reply-To: <1484534.r3K2qXYEyY@martin-thinkpad>
References: <CAGPcNU0QFq3MDYNCiJ5Uq_0H0zrsL4Yup0P9Fk60zx5fQa=5SQ@mail.gmail.com>
 <1424941.Lty6EYXNAO@martin-thinkpad>
 <CAGPcNU2jmoKgqYyhFj2V+OciaokjcKaGBPTM9SpFYUqQ2XX7Zw@mail.gmail.com>
 <1484534.r3K2qXYEyY@martin-thinkpad>
Message-ID: <CAGPcNU0M7y6WsV5q+otk_BYO0ZuByUdYD=2=4PrWPtFEZ42v5A@mail.gmail.com>

Hello,

On Tue, Aug 20, 2013 at 12:48 PM, Martin Graesslin <mgraesslin at kde.org> wrote:
> try to remove it again. Sorry I should have mentioned that this needs
> adjustments to where it is used.

No problem, now it finds XCB.. and yes I will be able to compile kwin! :D

Thanks!

From aseigo at kde.org  Tue Aug 20 07:56:59 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Tue, 20 Aug 2013 09:56:59 +0200
Subject: naming the next major release
In-Reply-To: <1433788.OvMntcx8Xk@martin-thinkpad>
References: <137711932.oj8iDjKShl@freedom> <1433788.OvMntcx8Xk@martin-thinkpad>
Message-ID: <4669690.bK3FeI9EhE@freedom>

On Tuesday, August 20, 2013 07:06:10 Martin Graesslin wrote:
> On Monday 19 August 2013 21:56:35 Aaron J. Seigo wrote:
> > 3. ???2??? ... why ???two??? if this is version 5? well, libplasma is 
actually
> > going to be version 6 iirc, so it isn???t the library. i also am not a big
> > believer in branding after version numbers. neither are any of our
> > proprietary competitors who have a lot more marketing and communications
> > savvy than we tend to. ;) what i like about 2 is:
> > 
> > * it communicates this is something after the first. it???s that whole 
???two
> > point oh??? thing, though hopefully less hype than, say, ???web 2.0??? ;)
> > 
> > * it???s simple and direct
> > 
> > * ???2??? is a couple, and a couple is a nice human idea :) this is borne 
out
> > by the ???1, 2, many??? pattern in many ancient languages. we know 1, we 
know
> > 2, after that it???s just an abstract concept.
> 
> I would like to get rid of version numbers in the traditional way. If the
> numbers are small, it's fine. But looking at many projects I am not able to
> get how old software is based on the number.
> 
> So instead I suggest that we go by year and numbering:
> * 2014.1.4
> * 2014.2.2
> * 2014.3.1
> -> year.major.minor
> 
> It would also prevent the confusion that several parts of our software has
> now different versions and especially that 4+1=2 :-)

for versioning, i agree.

?Plasma  2? (or whatever) will be a product name, not a version (in the 
technical sense of that word).

thinking about this overnight, i did run into some possible annoyances. we?ve 
been sort of taking this approach with Plasma Active. so now we have Plasma 
Active 4.

i?m unsure how that would work (poorly, i think) with ?Plasma 2? as the 
product name.

another approach is to not use a number at all and give it a proper name as we 
did with Plasma Active (which, iirc, was Sebas? brainchild of a name?). which 
would make the next major version ?Plasma <Something>? and this would replace 
Plasma Desktop, Netbook, Active (and perhaps Mediacenter?) as product names. 
they would of course remain buried in the technical details of our code to 
some extent (e.g. there may always be a plasma-mediacenter binary, though it 
would be cool if that went away too ..).

this would reflect even more clearly than my first proposal that we are 
harmonizing all the shells into one Thing(tm).

one tempting idea is to promote ?Plasma Active? up as the name used for all 
the workspaces ... 

the most minimalist thing would be to just call it all ?Plasma? and be done 
with it and not try at all to differentiate the new release from the old by the 
product name.

another approach would be to shift weight to ?Active? and drop ?Plasma? from 
the name, though ?KDE Active? is  not as google-able and we lose whatever 
value we?ve put into Plasma as a brand.

*sigh* this needs more thought :/

> I do want to promote KWin for the usage in LXDE/Razor as in the next version
> we will hardly have any build-time dependencies from frameworks higher than
> tier1. I'm concerned that a generic name "Plasma" would work against that
> as it would be difficult to communicate that although being part of Plasma
> not being part of Plasma.

i suppose it comes down to the following two things:

* do we feel we can communicate clearly, developer to developer, what Plasma 
is, and how components like KWin fit within that
* do we expect LXDE / Razor developers to be intelligent people who will 
understand technical communication

my experience with both of those things is ?yes?

the idea with having a name for this thing we?re making is to give the final 
product a name. consider that if we adopt SDDM as part of that ?complete 
product? that SDDM will be part of Plasma (the product), even though SDDM will 
obviously remain an independent project.

this is equally true with all components that are part of the Plasma product.

each component is its own living, breathing thing .. and we pull those 
components together to create an integrated, finished product called Plasma.

it?s the same as a screw that is used to hold together a dining room chair. it 
can also be used to hang a picture on a wall. even though it is part of the 
?chair? product, it can be used for other purposes as well.

that is what we need to communicate clearly to projects such as LXDE / Razor.

it?s also mindset i?m hoping people working on various components that make up 
Plasma will adopt as it accurately captures how we work together 
collaboratively yet with independence. 

> We should also think about what the name would mean for bug reporting. We
> don't want that all bugs for everything what is in kde-workspaces nowadays
> ends up in the component plasma.

we already get bug reports for kdelibs and Qt and all sorts of other things. 
this is, i?m afraid, unavoidable.

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/d62eb61a/attachment-0001.sig>

From mgraesslin at kde.org  Tue Aug 20 08:24:27 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Tue, 20 Aug 2013 10:24:27 +0200
Subject: naming the next major release
In-Reply-To: <4669690.bK3FeI9EhE@freedom>
References: <137711932.oj8iDjKShl@freedom>
 <1433788.OvMntcx8Xk@martin-thinkpad> <4669690.bK3FeI9EhE@freedom>
Message-ID: <2353715.2qqjfZCKSm@martin-thinkpad>

On Tuesday 20 August 2013 09:56:59 Aaron J. Seigo wrote:
> one tempting idea is to promote ?Plasma Active? up as the name used for all
> the workspaces ...
I would vote against "Plasma Active" as that might end up at the users (and 
media and they can get it wrong big times) as we drop the desktop system in 
favor of the tablet thingy. For many users Active is just the tablet shell.

I fear that this could end up being seen in exactly the opposite way as we 
want to achieve with the one device shell approach. If you want to get it 
wrong, you'll get it wrong and lately I have the feeling that the media is 
getting it wrong on purpose just to have more clicks.
> 
> the most minimalist thing would be to just call it all ?Plasma? and be done
> with it and not try at all to differentiate the new release from the old by
> the product name.
> 
> another approach would be to shift weight to ?Active? and drop ?Plasma? from
> the name, though ?KDE Active? is  not as google-able and we lose whatever
> value we?ve put into Plasma as a brand.
I agree that we should somehow keep Plasma in it.
> 
> *sigh* this needs more thought :/
> 
> > I do want to promote KWin for the usage in LXDE/Razor as in the next
> > version we will hardly have any build-time dependencies from frameworks
> > higher than tier1. I'm concerned that a generic name "Plasma" would work
> > against that as it would be difficult to communicate that although being
> > part of Plasma not being part of Plasma.
> 
> i suppose it comes down to the following two things:
> 
> * do we feel we can communicate clearly, developer to developer, what Plasma
> is, and how components like KWin fit within that
> * do we expect LXDE / Razor developers to be intelligent people who will
> understand technical communication
> 
> my experience with both of those things is ?yes?
I'm also not concerned with devs. I'm quite sure that this will be not of an 
issue. I'm more concerned about the users as they will have to choose OpenBox 
or KWin. If they think that with KWin they get the full "bloat" of Plasma on a 
lightweight desktop they will not use it out of principle. We already see that 
LXDE has to fight against the bloat perspective since they started using Qt - 
which is a pity.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/22747868/attachment.sig>

From notmart at gmail.com  Tue Aug 20 08:56:41 2013
From: notmart at gmail.com (Marco Martin)
Date: Tue, 20 Aug 2013 10:56:41 +0200
Subject: naming the next major release
In-Reply-To: <6305177.O9VrXusP8c@freedom>
References: <137711932.oj8iDjKShl@freedom>
 <201308192308.16132.notmart@gmail.com> <6305177.O9VrXusP8c@freedom>
Message-ID: <201308201056.41696.notmart@gmail.com>

On Tuesday 20 August 2013, Aaron J. Seigo wrote:

> 
> That?s also what I see in the openSuse packages.
> 
> So, yes, I got the # wrong .. it?s 3, not 5 currently .. so we?d end up
> with 4 unless we skip it go to 5. Still, the ?number used in the name
> doesn?t match the version number of <insert component here>? comment
> remains

uuh, right, build from master does a so.3..
hmm, wonder where the 4 is gone, if was ever "decided" or just done by 
mistake...
so do we go for .4 (until we have time?)

> Basically, I?m suggesting that naming the product after the version of the
> software isn?t a necessity and may not even be possible unless we elevate
> one specific component to be the ?defining? component, which I don?t think
> we ought to do.

yes, more and more evident that things like library versions are to be seen as 
a small implementation detail ;)

-- 
Marco Martin

From martin.sandsmark at kde.org  Tue Aug 20 09:00:03 2013
From: martin.sandsmark at kde.org (Martin Tobias Holmedahl Sandsmark)
Date: Tue, 20 Aug 2013 09:00:03 -0000
Subject: Review Request 111849: custom first week for plasmaclock.
In-Reply-To: <20130820043728.8828.21877@vidsolbach.de>
References: <20130820043728.8828.21877@vidsolbach.de>
Message-ID: <20130820090003.12422.74634@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/#review38188
-----------------------------------------------------------


isn't this duplicating the functionality in system settings ? locale ? country/region & language ? calendar ??first day of the week?

- Martin Tobias Holmedahl Sandsmark


On Aug. 20, 2013, 4:37 a.m., Hu Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111849/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 4:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/111849/diff/
> 
> 
> Testing
> -------
> 
> cd kde-workspace-4.10.5/libs/plasmaclock
> patch -p1 < customfirstweek.patch
> 
> The save configuration codes are not very beautiful, but it works fine!
> 
> 
> File Attachments
> ----------------
> 
> patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch
> another patch, use custom config file.
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch
> 
> 
> Thanks,
> 
> Hu Zheng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/2bd07bd3/attachment.html>

From sebas at kde.org  Tue Aug 20 09:03:18 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Tue, 20 Aug 2013 09:03:18 -0000
Subject: Review Request 111849: custom first week for plasmaclock.
In-Reply-To: <20130820043728.8828.21877@vidsolbach.de>
References: <20130820043728.8828.21877@vidsolbach.de>
Message-ID: <20130820090318.12890.50154@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/#review38189
-----------------------------------------------------------


* The patch is not correctly submitted, it's submitted as screenshot, not as patch, that makes it impossible to review
* You didn't attach a screenshot of the UI
* Checking wether a patch applies is not testing it
* The clock's config is not the right place for this, it should rather be a global calendar setting
* kde-workspace is frozen, this could, *at best* go into Plasma2 (which this patch is not about)

Please read and address my comments more carefully.

- Sebastian K?gler


On Aug. 20, 2013, 4:37 a.m., Hu Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111849/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 4:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/111849/diff/
> 
> 
> Testing
> -------
> 
> cd kde-workspace-4.10.5/libs/plasmaclock
> patch -p1 < customfirstweek.patch
> 
> The save configuration codes are not very beautiful, but it works fine!
> 
> 
> File Attachments
> ----------------
> 
> patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch
> another patch, use custom config file.
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch
> 
> 
> Thanks,
> 
> Hu Zheng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/a3b5d101/attachment.html>

From sebas at kde.org  Tue Aug 20 09:40:56 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Tue, 20 Aug 2013 09:40:56 -0000
Subject: Review Request 112129: Make Plasma::PackageStructure look for
 metadata.desktop files in only subfolder of extracted plasmapkg archives
In-Reply-To: <20130817082615.1679.17531@vidsolbach.de>
References: <20130817082615.1679.17531@vidsolbach.de>
Message-ID: <20130820094056.29218.94933@vidsolbach.de>



> On Aug. 17, 2013, 8:26 a.m., Marco Martin wrote:
> > Hmm, not sure about it, the packages were defined as archives with metadata.desktop in the root, this would basically allow a quirks mode, do we want to support malformed packages?
> 
> Jeremy Paul Whiting wrote:
>     Ok, I just tried repackaging Helium from kde-look.org with the contents directly in the .tar.xz rather than in a subfolder Helium. With my other plasmapkg patch that installs and uninstalls just fine. So the question then becomes are these themes on kde-look.org packaged with some tool? or just packaged by hand incorrectly? If it's a tool that's creating them, we ought to fix the tool, otherwise I guess I can go through the themes on kde-look.org and suggest they repackage them correctly.

It's at least not possible with plasmapkg, as this tool checks for metadata.desktop, and only if it exists in the to-package-directory, will actually work.

I suppose it's a hand-packaged package, done wrong.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112129/#review38015
-----------------------------------------------------------


On Aug. 17, 2013, 3:06 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112129/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 3:06 a.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> This is the other half of the fix for the listed bug.  I made Plasma::PackageStructure::metadata look in the only subdirectory of an extracted archive if there's only one subdirectory for the metadata.desktop file.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=149479.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479
> 
> 
> Diffs
> -----
> 
>   plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b 
> 
> Diff: http://git.reviewboard.kde.org/r/112129/diff/
> 
> 
> Testing
> -------
> 
> The bug is fixed here with this and my other patch. Any better ideas for getting the only subdirectory are welcome, it feels a bit kludgy as is.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/089eedff/attachment-0001.html>

From gnumdk at gmail.com  Tue Aug 20 10:40:24 2013
From: gnumdk at gmail.com (Cedric Bellegarde)
Date: Tue, 20 Aug 2013 10:40:24 -0000
Subject: Review Request 112073: Partially revert commit 83d3018
In-Reply-To: <20130819091045.22863.68354@vidsolbach.de>
References: <20130819091045.22863.68354@vidsolbach.de>
Message-ID: <20130820104024.20422.2406@vidsolbach.de>



> On Aug. 19, 2013, 9:10 a.m., David Faure wrote:
> > This is ... extremely surprising.
> > plasma-desktop registers to DBus as "org.kde.plasma-desktop", doesn't it? That's what "unique" expects (while "multi" expects the PID appended).
> > 
> > In addition, I didn't experience any problems with startup and the splash screen...
> > 
> > Are you really sure this change fixes anything? I could be wrong, but I'm rather surprised.
> 
> Hrvoje Senjan wrote:
>     Yes, see https://bugs.kde.org/show_bug.cgi?id=321695#c13 and c17. Or in c5 and c6 there's confirmation restoring to "wait" also works as expected/as was before. (In comment 2 there's video which illustrates the issue clearly). I've validated the issue and the "fix" also myself on two installs.
>     Tbh, i have also no idea why it breaks it, but looks it does...

Can confirm issue too and this patch fix it.


- Cedric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112073/#review38112
-----------------------------------------------------------


On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112073/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 12:01 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Description
> -------
> 
> While the commit may be technically correct, it breaks ksplash for 4.11 release...
> I've changed unique to multi, if there is a better solution, please hint it ;-)
> (maybe actually someone meant multi, when typing wait :-)
> 
> 
> This addresses bug 321695.
>     http://bugs.kde.org/show_bug.cgi?id=321695
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 
> 
> Diff: http://git.reviewboard.kde.org/r/112073/diff/
> 
> 
> Testing
> -------
> 
> Yes... starts "normally" as previously/ksplash isn't interupted
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/091ae143/attachment.html>

From faure at kde.org  Tue Aug 20 11:03:08 2013
From: faure at kde.org (David Faure)
Date: Tue, 20 Aug 2013 11:03:08 -0000
Subject: Review Request 112073: Partially revert commit 83d3018
In-Reply-To: <20130814000117.13131.43688@vidsolbach.de>
References: <20130814000117.13131.43688@vidsolbach.de>
Message-ID: <20130820110308.26748.11846@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112073/#review38201
-----------------------------------------------------------

Ship it!


OK. Weird, but I don't have time to debug it. Please commit.

- David Faure


On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112073/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 12:01 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Description
> -------
> 
> While the commit may be technically correct, it breaks ksplash for 4.11 release...
> I've changed unique to multi, if there is a better solution, please hint it ;-)
> (maybe actually someone meant multi, when typing wait :-)
> 
> 
> This addresses bug 321695.
>     http://bugs.kde.org/show_bug.cgi?id=321695
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 
> 
> Diff: http://git.reviewboard.kde.org/r/112073/diff/
> 
> 
> Testing
> -------
> 
> Yes... starts "normally" as previously/ksplash isn't interupted
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/2920ffbb/attachment.html>

From sebas at kde.org  Tue Aug 20 11:26:21 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Tue, 20 Aug 2013 11:26:21 -0000
Subject: Review Request 112157: replace deprecated widgets
In-Reply-To: <20130819144532.3183.25735@vidsolbach.de>
References: <20130819144532.3183.25735@vidsolbach.de>
Message-ID: <20130820112621.4292.70457@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112157/#review38202
-----------------------------------------------------------


Looking good, apart from the issue David pointed out, and small comments inline.

Once you've looked into these, feel free to commit.


engineexplorer/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112157/#comment28229>

    Can we now get rid of these, or either of them? (Just try a build without them, and see what can go away.)



engineexplorer/engineexplorer.h
<http://git.reviewboard.kde.org/r/112157/#comment28230>

    should move up now, to the other Qt includes


- Sebastian K?gler


On Aug. 19, 2013, 2:45 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112157/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 2:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> * this replaces the deprecated widgets from the plasmaengineexplorer
> * makes the serviceviewer.ui nicer( I have attached a screenshot) 
> 
> 
> Diffs
> -----
> 
>   engineexplorer/CMakeLists.txt 1466542 
>   engineexplorer/engineexplorer.h 5c19fa6 
>   engineexplorer/engineexplorer.cpp a3f2e1f 
>   engineexplorer/engineexplorer.ui 65e70b4 
>   engineexplorer/ktreeviewsearchline.cpp 734ef94 
>   engineexplorer/main.cpp 8eae7a3 
>   engineexplorer/serviceviewer.h dc0b36b 
>   engineexplorer/serviceviewer.cpp d7e8e5a 
>   engineexplorer/serviceviewer.ui b91b784 
> 
> Diff: http://git.reviewboard.kde.org/r/112157/diff/
> 
> 
> Testing
> -------
> 
> it is building/installing/working correctly. I have noticed any issue
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/3f266c08/attachment.html>

From sebas at kde.org  Tue Aug 20 11:30:32 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Tue, 20 Aug 2013 13:30:32 +0200
Subject: naming the next major release
In-Reply-To: <201308201056.41696.notmart@gmail.com>
References: <137711932.oj8iDjKShl@freedom> <6305177.O9VrXusP8c@freedom>
 <201308201056.41696.notmart@gmail.com>
Message-ID: <3258933.7rPYBNbdcI@miro.vizzzion.net>

On Tuesday, August 20, 2013 10:56:41 Marco Martin wrote:
> On Tuesday 20 August 2013, Aaron J. Seigo wrote:
> >
> > That?s also what I see in the openSuse packages.
> >
> > So, yes, I got the # wrong .. it?s 3, not 5 currently .. so we?d end up
> > with 4 unless we skip it go to 5. Still, the ?number used in the name
> > doesn?t match the version number of <insert component here>? comment
> > remains
> 
> uuh, right, build from master does a so.3..
> hmm, wonder where the 4 is gone, if was ever "decided" or just done by 
> mistake...
> so do we go for .4 (until we have time?)

Uhm, no, as ervin suggested, the so version should be 5, in line with other 
frameworks.

> > Basically, I?m suggesting that naming the product after the version of the
> > software isn?t a necessity and may not even be possible unless we elevate
> > one specific component to be the ?defining? component, which I don?t think
> > we ought to do.
> 
> yes, more and more evident that things like library versions are to be seen
> as  a small implementation detail

and indeed not affect our communication. :)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From null at kde.org  Tue Aug 20 11:37:11 2013
From: null at kde.org (Commit Hook)
Date: Tue, 20 Aug 2013 11:37:11 -0000
Subject: Review Request 112073: Partially revert commit 83d3018
In-Reply-To: <20130814000117.13131.43688@vidsolbach.de>
References: <20130814000117.13131.43688@vidsolbach.de>
Message-ID: <20130820113711.15734.53413@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112073/
-----------------------------------------------------------

(Updated Aug. 20, 2013, 11:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Faure.


Description
-------

While the commit may be technically correct, it breaks ksplash for 4.11 release...
I've changed unique to multi, if there is a better solution, please hint it ;-)
(maybe actually someone meant multi, when typing wait :-)


This addresses bug 321695.
    http://bugs.kde.org/show_bug.cgi?id=321695


Diffs
-----

  plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 

Diff: http://git.reviewboard.kde.org/r/112073/diff/


Testing
-------

Yes... starts "normally" as previously/ksplash isn't interupted


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/434ac4b2/attachment.html>

From null at kde.org  Tue Aug 20 13:23:54 2013
From: null at kde.org (Commit Hook)
Date: Tue, 20 Aug 2013 13:23:54 -0000
Subject: Review Request 112157: replace deprecated widgets
In-Reply-To: <20130819144532.3183.25735@vidsolbach.de>
References: <20130819144532.3183.25735@vidsolbach.de>
Message-ID: <20130820132354.21613.83142@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112157/#review38209
-----------------------------------------------------------


This review has been submitted with commit 274784121e862706118b7e8c787c27e9ff77a596 by Giorgos Tsiapaliokas to branch frameworks-scratch.

- Commit Hook


On Aug. 19, 2013, 2:45 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112157/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 2:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> * this replaces the deprecated widgets from the plasmaengineexplorer
> * makes the serviceviewer.ui nicer( I have attached a screenshot) 
> 
> 
> Diffs
> -----
> 
>   engineexplorer/CMakeLists.txt 1466542 
>   engineexplorer/engineexplorer.h 5c19fa6 
>   engineexplorer/engineexplorer.cpp a3f2e1f 
>   engineexplorer/engineexplorer.ui 65e70b4 
>   engineexplorer/ktreeviewsearchline.cpp 734ef94 
>   engineexplorer/main.cpp 8eae7a3 
>   engineexplorer/serviceviewer.h dc0b36b 
>   engineexplorer/serviceviewer.cpp d7e8e5a 
>   engineexplorer/serviceviewer.ui b91b784 
> 
> Diff: http://git.reviewboard.kde.org/r/112157/diff/
> 
> 
> Testing
> -------
> 
> it is building/installing/working correctly. I have noticed any issue
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/91428073/attachment.html>

From null at kde.org  Tue Aug 20 13:24:02 2013
From: null at kde.org (Commit Hook)
Date: Tue, 20 Aug 2013 13:24:02 -0000
Subject: Review Request 112157: replace deprecated widgets
In-Reply-To: <20130819144532.3183.25735@vidsolbach.de>
References: <20130819144532.3183.25735@vidsolbach.de>
Message-ID: <20130820132402.21713.22323@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112157/
-----------------------------------------------------------

(Updated Aug. 20, 2013, 1:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

Hello,

* this replaces the deprecated widgets from the plasmaengineexplorer
* makes the serviceviewer.ui nicer( I have attached a screenshot) 


Diffs
-----

  engineexplorer/CMakeLists.txt 1466542 
  engineexplorer/engineexplorer.h 5c19fa6 
  engineexplorer/engineexplorer.cpp a3f2e1f 
  engineexplorer/engineexplorer.ui 65e70b4 
  engineexplorer/ktreeviewsearchline.cpp 734ef94 
  engineexplorer/main.cpp 8eae7a3 
  engineexplorer/serviceviewer.h dc0b36b 
  engineexplorer/serviceviewer.cpp d7e8e5a 
  engineexplorer/serviceviewer.ui b91b784 

Diff: http://git.reviewboard.kde.org/r/112157/diff/


Testing
-------

it is building/installing/working correctly. I have noticed any issue


File Attachments
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/580f1cad/attachment.html>

From sebas at kde.org  Tue Aug 20 13:47:44 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Tue, 20 Aug 2013 13:47:44 -0000
Subject: Review Request 112150: Port analog clock to Plasma 2 (based on
 Viranch's branch)
In-Reply-To: <20130818222839.23234.51341@vidsolbach.de>
References: <20130818222839.23234.51341@vidsolbach.de>
Message-ID: <20130820134744.25044.37424@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112150/#review38211
-----------------------------------------------------------

Ship it!


A few minor comments, otherwise it looks good.


plasma/generic/applets/analog-clock/contents/ui/Hand.qml
<http://git.reviewboard.kde.org/r/112150/#comment28236>

    This and the copyright in the other files should include Marco as author



plasma/generic/applets/analog-clock/contents/ui/analogclock.qml
<http://git.reviewboard.kde.org/r/112150/#comment28237>

    should move to the end of the parent Item in the source file



plasma/generic/applets/analog-clock/contents/ui/analogclock.qml
<http://git.reviewboard.kde.org/r/112150/#comment28238>

    could this be made relative, i.e. z: secondHand.z + 1 ?


- Sebastian K?gler


On Aug. 18, 2013, 10:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112150/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 10:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock
> 
> 
> Git log below
> --
> 
> Restore config for clock applet
> 
> --
> 
> Remove calendar components.
> Plasma will have it's own Calendar which should be shared
> 
> --
> 
> Scale clock hands to fit current clock size
> 
> --
> 
> Update copyright to reflect actual authors
> 
> 
> --
> Port analog clock to new dataengine + config scheme
> 
> Make the clock use the new PlasmaCore.Datasource to fetch the current
> time
> 
> --
> 
> Update the analog clock to run on plasma 2
> 
> --
> 
> Enable generic/applets directory
> 
> --
> 
> Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION 
>   plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 
>   plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a 
>   plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b 
>   plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 
>   plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/e51c70c1/attachment.html>

From david at davidedmundson.co.uk  Tue Aug 20 14:03:56 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Tue, 20 Aug 2013 14:03:56 -0000
Subject: Review Request 112150: Port analog clock to Plasma 2 (based on
 Viranch's branch)
In-Reply-To: <20130818222839.23234.51341@vidsolbach.de>
References: <20130818222839.23234.51341@vidsolbach.de>
Message-ID: <20130820140356.30645.8999@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112150/#review38212
-----------------------------------------------------------



plasma/generic/applets/analog-clock/contents/ui/Hand.qml
<http://git.reviewboard.kde.org/r/112150/#comment28239>

    I did this because git log showed only Viranch as the author of this file.
    
    I guess it's better to be safe than sorry, I'll include it (unless Marco comments)
    


- David Edmundson


On Aug. 18, 2013, 10:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112150/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 10:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock
> 
> 
> Git log below
> --
> 
> Restore config for clock applet
> 
> --
> 
> Remove calendar components.
> Plasma will have it's own Calendar which should be shared
> 
> --
> 
> Scale clock hands to fit current clock size
> 
> --
> 
> Update copyright to reflect actual authors
> 
> 
> --
> Port analog clock to new dataengine + config scheme
> 
> Make the clock use the new PlasmaCore.Datasource to fetch the current
> time
> 
> --
> 
> Update the analog clock to run on plasma 2
> 
> --
> 
> Enable generic/applets directory
> 
> --
> 
> Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION 
>   plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 
>   plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a 
>   plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b 
>   plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 
>   plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/3d2c0c7d/attachment-0001.html>

From notmart at gmail.com  Tue Aug 20 14:29:40 2013
From: notmart at gmail.com (Marco Martin)
Date: Tue, 20 Aug 2013 14:29:40 -0000
Subject: Review Request 112150: Port analog clock to Plasma 2 (based on
 Viranch's branch)
In-Reply-To: <20130820134744.25044.37424@vidsolbach.de>
References: <20130820134744.25044.37424@vidsolbach.de>
Message-ID: <20130820142940.3596.91481@vidsolbach.de>



> On Aug. 20, 2013, 1:47 p.m., Sebastian K?gler wrote:
> > plasma/generic/applets/analog-clock/contents/ui/Hand.qml, line 2
> > <http://git.reviewboard.kde.org/r/112150/diff/1/?file=183341#file183341line2>
> >
> >     This and the copyright in the other files should include Marco as author

yes, that applet was done by both of us


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112150/#review38211
-----------------------------------------------------------


On Aug. 18, 2013, 10:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112150/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 10:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock
> 
> 
> Git log below
> --
> 
> Restore config for clock applet
> 
> --
> 
> Remove calendar components.
> Plasma will have it's own Calendar which should be shared
> 
> --
> 
> Scale clock hands to fit current clock size
> 
> --
> 
> Update copyright to reflect actual authors
> 
> 
> --
> Port analog clock to new dataengine + config scheme
> 
> Make the clock use the new PlasmaCore.Datasource to fetch the current
> time
> 
> --
> 
> Update the analog clock to run on plasma 2
> 
> --
> 
> Enable generic/applets directory
> 
> --
> 
> Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION 
>   plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 
>   plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a 
>   plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b 
>   plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 
>   plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/5e107693/attachment.html>

From null at kde.org  Tue Aug 20 16:28:15 2013
From: null at kde.org (Commit Hook)
Date: Tue, 20 Aug 2013 16:28:15 -0000
Subject: Review Request 112127: Enable QML Debugger
In-Reply-To: <20130816205830.20958.91420@vidsolbach.de>
References: <20130816205830.20958.91420@vidsolbach.de>
Message-ID: <20130820162815.13714.6645@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112127/#review38219
-----------------------------------------------------------


This review has been submitted with commit 0ddc59af24da8624d968c94fdf65612f64a513b2 by David Edmundson to branch master.

- Commit Hook


On Aug. 16, 2013, 8:58 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112127/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2013, 8:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Enable QML Debugger
> 
> 
> Diffs
> -----
> 
>   src/shell/main.cpp 18d381a0d3b76ef1c24b8585dc06047664a4cc55 
> 
> Diff: http://git.reviewboard.kde.org/r/112127/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/26dd25f5/attachment.html>

From null at kde.org  Tue Aug 20 16:28:17 2013
From: null at kde.org (Commit Hook)
Date: Tue, 20 Aug 2013 16:28:17 -0000
Subject: Review Request 112127: Enable QML Debugger
In-Reply-To: <20130816205830.20958.91420@vidsolbach.de>
References: <20130816205830.20958.91420@vidsolbach.de>
Message-ID: <20130820162817.13696.92487@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112127/
-----------------------------------------------------------

(Updated Aug. 20, 2013, 4:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

Enable QML Debugger


Diffs
-----

  src/shell/main.cpp 18d381a0d3b76ef1c24b8585dc06047664a4cc55 

Diff: http://git.reviewboard.kde.org/r/112127/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/29df1355/attachment.html>

From david at davidedmundson.co.uk  Tue Aug 20 17:13:47 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Tue, 20 Aug 2013 17:13:47 -0000
Subject: Review Request 112150: Port analog clock to Plasma 2 (based on
 Viranch's branch)
In-Reply-To: <20130820134744.25044.37424@vidsolbach.de>
References: <20130820134744.25044.37424@vidsolbach.de>
Message-ID: <20130820171347.10844.266@vidsolbach.de>



> On Aug. 20, 2013, 1:47 p.m., Sebastian K?gler wrote:
> > plasma/generic/applets/analog-clock/contents/ui/analogclock.qml, line 92
> > <http://git.reviewboard.kde.org/r/112150/diff/1/?file=183342#file183342line92>
> >
> >     could this be made relative, i.e. z: secondHand.z + 1 ?

I don't think we would gain anything in this case.

z on the second hand will still be the default 0 regardless of how many overlapping objects it is in front of. So this would always be the same as just z:1.
The only benefit we would get is if someone explicitly sets a z-index on secondHand, but doing that would be as bad as what I've done here.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112150/#review38211
-----------------------------------------------------------


On Aug. 18, 2013, 10:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112150/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 10:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock
> 
> 
> Git log below
> --
> 
> Restore config for clock applet
> 
> --
> 
> Remove calendar components.
> Plasma will have it's own Calendar which should be shared
> 
> --
> 
> Scale clock hands to fit current clock size
> 
> --
> 
> Update copyright to reflect actual authors
> 
> 
> --
> Port analog clock to new dataengine + config scheme
> 
> Make the clock use the new PlasmaCore.Datasource to fetch the current
> time
> 
> --
> 
> Update the analog clock to run on plasma 2
> 
> --
> 
> Enable generic/applets directory
> 
> --
> 
> Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION 
>   plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 
>   plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a 
>   plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b 
>   plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 
>   plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/be2f1ca1/attachment-0001.html>

From null at kde.org  Tue Aug 20 17:15:14 2013
From: null at kde.org (Commit Hook)
Date: Tue, 20 Aug 2013 17:15:14 -0000
Subject: Review Request 112150: Port analog clock to Plasma 2 (based on
 Viranch's branch)
In-Reply-To: <20130818222839.23234.51341@vidsolbach.de>
References: <20130818222839.23234.51341@vidsolbach.de>
Message-ID: <20130820171514.11037.24394@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112150/#review38222
-----------------------------------------------------------


This review has been submitted with commit c84b6017dee805cb38238b5155449f9f6f3553cb by David Edmundson to branch frameworks-scratch.

- Commit Hook


On Aug. 18, 2013, 10:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112150/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 10:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock
> 
> 
> Git log below
> --
> 
> Restore config for clock applet
> 
> --
> 
> Remove calendar components.
> Plasma will have it's own Calendar which should be shared
> 
> --
> 
> Scale clock hands to fit current clock size
> 
> --
> 
> Update copyright to reflect actual authors
> 
> 
> --
> Port analog clock to new dataengine + config scheme
> 
> Make the clock use the new PlasmaCore.Datasource to fetch the current
> time
> 
> --
> 
> Update the analog clock to run on plasma 2
> 
> --
> 
> Enable generic/applets directory
> 
> --
> 
> Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION 
>   plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 
>   plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a 
>   plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b 
>   plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 
>   plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/f50f6417/attachment.html>

From null at kde.org  Tue Aug 20 17:15:19 2013
From: null at kde.org (Commit Hook)
Date: Tue, 20 Aug 2013 17:15:19 -0000
Subject: Review Request 112150: Port analog clock to Plasma 2 (based on
 Viranch's branch)
In-Reply-To: <20130818222839.23234.51341@vidsolbach.de>
References: <20130818222839.23234.51341@vidsolbach.de>
Message-ID: <20130820171519.11054.90753@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112150/
-----------------------------------------------------------

(Updated Aug. 20, 2013, 5:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock


Git log below
--

Restore config for clock applet

--

Remove calendar components.
Plasma will have it's own Calendar which should be shared

--

Scale clock hands to fit current clock size

--

Update copyright to reflect actual authors


--
Port analog clock to new dataengine + config scheme

Make the clock use the new PlasmaCore.Datasource to fetch the current
time

--

Update the analog clock to run on plasma 2

--

Enable generic/applets directory

--

Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch


Diffs
-----

  plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION 
  plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 
  plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a 
  plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b 
  plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 
  plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112150/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/29e6e9b3/attachment.html>

From sebas at kde.org  Tue Aug 20 23:27:25 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Wed, 21 Aug 2013 01:27:25 +0200
Subject: naming the next major release
In-Reply-To: <137711932.oj8iDjKShl@freedom>
References: <137711932.oj8iDjKShl@freedom>
Message-ID: <3371748.o2mxHuvJRb@monet>

On Monday, August 19, 2013 21:56:35 Aaron J. Seigo wrote:
[ snipperdeesnip ]
> 	?KDE?s Plasma workspaces come in Desktop, Netbook, Tablet and Mediacenter
> flavours...?
> 
> 	?KDE?s Plasma provides user experiences for desktop, netbook, tablet, ..?
> 
> given that we are moving to a ?grand unified shell? approach where the
> different user experiences flow seamlessly from one to the next, it may
> make sense to drop the concept that there is such huge differentiation that
> they are the ?Workspaces? and instead are just ?Plasma? which happens to
> morph to fit the device.

Anecdotal supporting evidence: When we first interacted with the wider Mer and 
device community around Plasma Active, in casual communication, I often heard 
people calling "the UI" simply Plasma. That's an interesting target group, as 
it fits nicely into those that we probably want to sell our seamless 
experience to, and rather unbiased.

I think more or less radically drop the notion of devices (or rather, leaving 
that to the packagers, in terms of installation) makes the most sense, as we 
can nicely work two ways, from "Plasma, the Desktop Brand" and "Plasma" the 
device UI (and even Plasma Mediacenter) towards that morphing UI. Kind of the 
NetBSD of the modern age: "It even runs on a toaster".

> 3. ?2? ... why ?two? if this is version 5? well, libplasma is actually going
> to be version 6 iirc, so it isn?t the library. i also am not a big believer
> in branding after version numbers. neither are any of our proprietary
> competitors who have a lot more marketing and communications savvy than we
> tend to. ;) what i like about 2 is:
> 
> * it communicates this is something after the first. it?s that whole ?two
> point oh? thing, though hopefully less hype than, say, ?web 2.0? ;)
> 
> * it?s simple and direct
> 
> * ?2? is a couple, and a couple is a nice human idea :) this is borne out by
> the ?1, 2, many? pattern in many ancient languages. we know 1, we know 2,
> after that it?s just an abstract concept.

One option that crossed my mind was "Plasma 5". I agree with your findings 
regarding Plasma vs. Plasma Workspaces, etc., and my gut feeling tends to just 
Plasma. in that regard. As to the version, 5 gives some sense to continuation 
of what was earlier the KDE 4 series, and I think there is some attachment to 
this, as it also communicates a continuation of our experience and evolution 
in creating workspaces. 

The .so versioning should, indeed, be just an implementation detail, and as 
such in line with other frameworks. Incidentally, both, .so version and 
"communication version" would be the same though (but explicitely do not 
*have* to, we can care about that later, though).

So Plasma 5 would be the continuation of KDE Plasma Workspaces 4.x, and, 
accidentally also Plasma Active Four.

> Sooooooooooo ... here is my proposal:
> 
> 	We call it Plasma 2 and use that as a rallying call to
> 	focus on its unified user experience
> 	across the spectrum of devices people use today.
> 
> as developers, it will remind us of our goals.
> 
> to our users, it will be the symbol of this idea of all these individual
> components that work together beautifully no matter what device you put it
> on.
> 
> yes, this means we drop ?Workspaces? as clumsy, hard to understand and no
> longer fully applicable.
> 
> 
> Other proposals, ideas, tweaks to the above most welcome, but let?s try to
> come to a consensus on this matter before the end of this month.
> 
> then we can all move forward in confidence together, whatever it is we
> decide.

Otherwise, this strategy sounds fine to me.

Thoughts on the 5?
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From sebas at kde.org  Tue Aug 20 23:57:31 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Wed, 21 Aug 2013 01:57:31 +0200
Subject: naming the next major release
In-Reply-To: <137711932.oj8iDjKShl@freedom>
References: <137711932.oj8iDjKShl@freedom>
Message-ID: <1523138.2EnOUxKh6Z@monet>

On Monday, August 19, 2013 21:56:35 Aaron J. Seigo wrote:
> given that we are moving to a ?grand unified shell? approach where the
> different user experiences flow seamlessly from one to the next, it may
> make sense to drop the concept that there is such huge differentiation that
> they are the ?Workspaces? and instead are just ?Plasma? which happens to
> morph to fit the device.

Brainfart ahead.

We come up with a plan for a headless module for Plasma, that basically sets 
up a local server, installs kolab, owncloud, jabber, your own image sharing 
service, etc. and whatever else is needed to take the cloud private, and offer 
that as an option you can install on a random device, connect storage. (Could 
even be a mediacenter that is running both, plasma-mediacenter and the server 
packages. Such a relatively constrained target device could be made to work 
really well with the device, and provide the basic needs for circumventing a 
lot of privacy problems around centralized web services, targeting the 
increased needs for really private communication.

On the client side is entirely integrated in the UI through predefined setups 
for Kontact, KPeople and KTelepathy, a file sync client. Configuration and 
other metadata could possibly be synced across devices safely that way as 
well, and possibly even be rolled out to clients in more enterprise setups, or 
serve as a remote control channel for different devices (media playback, 
etc.).
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From huzheng001 at gmail.com  Tue Aug 20 04:43:10 2013
From: huzheng001 at gmail.com (Hu Zheng)
Date: Tue, 20 Aug 2013 12:43:10 +0800
Subject: Add custom first week support to KDE digital clock.
In-Reply-To: <2117394.I5ydiA5Mtz@monet>
References: <CAGoZsjj-VikaAh5dyFDfqz4tdfSrFXy8ELxBLUwQX_2Kfo7ckA@mail.gmail.com>
 <1543638.izhrCgAe5k@monet>
 <CAGoZsjgbyC3tO+hJFc2OkQ=+FHQvnOBOc-093gdYzbOrnor+4w@mail.gmail.com>
 <2117394.I5ydiA5Mtz@monet>
Message-ID: <CAGoZsjjpDf=eEbWEyo8uNKSrSC83r1K7mXeBFqD_O2CPt-Ds=w@mail.gmail.com>

Hi! https://git.reviewboard.kde.org/r/111849/ is updated, another patch is
there, which use custom config file!

Thanks everyone!

2013/8/4 Sebastian K?gler <sebas at kde.org>

> Hi Hu Zheng,
>
> On Saturday, August 03, 2013 11:42:22 Hu Zheng wrote:
> > Done! See:
> > https://git.reviewboard.kde.org/r/111849/
>
> Please submit the patch as patch on reviewboard, not as attachment. That
> way,
> it can be read easily from the web interface.
>
> Please also attach screenshots of any UI that has been changed.
>
> Thanks,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
>



-- 
http://www.huzheng.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/4fafc6c5/attachment.html>

From notmart at gmail.com  Wed Aug 21 09:49:03 2013
From: notmart at gmail.com (Marco Martin)
Date: Wed, 21 Aug 2013 11:49:03 +0200
Subject: naming the next major release
In-Reply-To: <137711932.oj8iDjKShl@freedom>
References: <137711932.oj8iDjKShl@freedom>
Message-ID: <201308211149.04329.notmart@gmail.com>

On Monday 19 August 2013, Aaron J. Seigo wrote:
> 
> Other proposals, ideas, tweaks to the above most welcome, but let?s try to
> come to a consensus on this matter before the end of this month.
> 
> then we can all move forward in confidence together, whatever it is we
> decide.

after thinking about it for a while, just few considerations

* we want to maintain the "kde is the community, not the software" mantra

* so a name for "the product workspace" is needed

* any descriptive name, sich as "workspace" "shell" "desktop" risks to be too 
narrow, nerdy and cold

* a name that sounds cool but doesn't really describe something is better, 
"plasma" or "plasma active" are (as the term "firefox" per se doesn't have 
anything to do with browser)

* Plasma has quite some luggage already, that may be an advantage or a 
disadvantage, i don't know (but we have years of climbing the googlability of 
the term already, that's quite an investment)

* Plasma Active may indeed cause a problem in perception and bogus articles 
like "kde is dropping the desktop for tablets". Paradoxically I think the 
place where instead would have a good effect is the internal developer 
community (for applications developers there is still a bit of "the active 
version is not my problem, i care only about desktop" feeling

* I'm not sure thinking about a completely different new name would come up 
with something that would work, but if someone can think about any, please 
speak ;)

My vote would go for Plasma.
hell, i would even go as far as changing the kickoff icon (no, not with the 
cashew, with something better :p)

About numbers, 2 or 5 i don't know, they may risk to dilute the catchiness?


Cheers,
Marco Martin

From dantti12 at gmail.com  Wed Aug 21 14:29:52 2013
From: dantti12 at gmail.com (Daniel Nicoletti)
Date: Wed, 21 Aug 2013 11:29:52 -0300
Subject: naming the next major release
In-Reply-To: <201308211149.04329.notmart@gmail.com>
References: <137711932.oj8iDjKShl@freedom>
 <201308211149.04329.notmart@gmail.com>
Message-ID: <CACo8zOefWFQpRotSJNiSfzqo0ynnbA94Dj9Mh=eaFkBQm=iD9Q@mail.gmail.com>

My 2c,

On KDE 4 aka KDE SC 4, plasma was always just plasma,
no user says I'm using the plasma shell (as there isn't another
KDE option).

I think even if Plasma is numbered after 2, users will still say
they have installed KDE 5 or KDE SC 5, the marketing imo
must go to the whole SC 5 and not to single components,
for example I go to dolphin look at it's version and I have 2.2
but my KDE is 4.10.5, when the user report bugs most of
the time they specify the whole KDE version and not the
component one.

Having KDE as just as people (bad thing imho) brings these
issues, do we install KDE software? Or would I install KDE people?

IMHO the core of the KDE is it's libraries/frameworks which will
be named at 5. One can write another KDE shell (iirc there is kor)
(and don't make it in SC) but that will still be a KDE shell.

enough talking to summarize I'd say we should go for
KDE SC 5 which includes 2nd gen of Plasma, 3rd gen of dolphin
and so on, some components happen to have survived since
KDE 1 (kwin/konqueror maybe?), naming Plasma as 5 doesn't
reflect it's real age.

Regards,

-- 
Daniel Nicoletti - http://dantti.wordpress.com

From notmart at gmail.com  Wed Aug 21 14:58:36 2013
From: notmart at gmail.com (Marco Martin)
Date: Wed, 21 Aug 2013 16:58:36 +0200
Subject: naming the next major release
In-Reply-To: <CACo8zOefWFQpRotSJNiSfzqo0ynnbA94Dj9Mh=eaFkBQm=iD9Q@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom>
 <201308211149.04329.notmart@gmail.com>
 <CACo8zOefWFQpRotSJNiSfzqo0ynnbA94Dj9Mh=eaFkBQm=iD9Q@mail.gmail.com>
Message-ID: <201308211658.36651.notmart@gmail.com>

On Wednesday 21 August 2013, Daniel Nicoletti wrote:
> My 2c,
> 
> On KDE 4 aka KDE SC 4, plasma was always just plasma,
> no user says I'm using the plasma shell (as there isn't another
> KDE option).

Incidently, the whole SC stuff, was never intended for marketing and public 
communication, but it ended up that way, and sure enough press reaction to SC 
was overwhelmingly negative.

-- 
Marco Martin

From dantti12 at gmail.com  Wed Aug 21 15:09:43 2013
From: dantti12 at gmail.com (Daniel Nicoletti)
Date: Wed, 21 Aug 2013 12:09:43 -0300
Subject: naming the next major release
In-Reply-To: <201308211658.36651.notmart@gmail.com>
References: <137711932.oj8iDjKShl@freedom>
 <201308211149.04329.notmart@gmail.com>
 <CACo8zOefWFQpRotSJNiSfzqo0ynnbA94Dj9Mh=eaFkBQm=iD9Q@mail.gmail.com>
 <201308211658.36651.notmart@gmail.com>
Message-ID: <CACo8zOfOiz-55iZyH50aoJ-jfzW6Lbh5Mph8mcmq2FiGkz26eA@mail.gmail.com>

2013/8/21 Marco Martin <notmart at gmail.com>:
> On Wednesday 21 August 2013, Daniel Nicoletti wrote:
>> My 2c,
>>
>> On KDE 4 aka KDE SC 4, plasma was always just plasma,
>> no user says I'm using the plasma shell (as there isn't another
>> KDE option).
>
> Incidently, the whole SC stuff, was never intended for marketing and public
> communication, but it ended up that way, and sure enough press reaction to SC
> was overwhelmingly negative.

Sure, just to clarify what I was trying to state is that most
users know the KDE version not the components of it.
For the SC maybe in 5 we could go back to
"we are KDE and KDE is also the software" I think people
can tell the difference without an "SC" :P but whatever that's
another (endless) discussion and off topic...

From mgraesslin at kde.org  Wed Aug 21 15:37:04 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Wed, 21 Aug 2013 17:37:04 +0200
Subject: naming the next major release
In-Reply-To: <CACo8zOefWFQpRotSJNiSfzqo0ynnbA94Dj9Mh=eaFkBQm=iD9Q@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom>
 <201308211149.04329.notmart@gmail.com>
 <CACo8zOefWFQpRotSJNiSfzqo0ynnbA94Dj9Mh=eaFkBQm=iD9Q@mail.gmail.com>
Message-ID: <2261448.5E7fb6EpYB@martin-thinkpad>

On Wednesday 21 August 2013 11:29:52 Daniel Nicoletti wrote:
> My 2c,
> 
> On KDE 4 aka KDE SC 4, plasma was always just plasma,
> no user says I'm using the plasma shell (as there isn't another
> KDE option).
this might change. Consider Razor/LXDE joining the KDE umbrella. What then? 
>From one day to another it would be obvious that using "the KDE desktop" is 
not working any more.

I'm in fact aware of at least three desktop shells by the KDE community. The 
only thing those three share is the window manager.

Given that we know that we want to open us for more projects and that we want 
to get our technologies into other Qt based desktops, it would be a really bad 
idea to ignore this fact when we do the planning for the next version.

> some components happen to have survived since
> KDE 1 (kwin/konqueror maybe?),
Just for the record: both KWin and Konqueror got introduced in KDE (SC) 2. The 
oldest to my knowledge still being developed application is KMail.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/03b4ea1f/attachment.sig>

From notmart at gmail.com  Wed Aug 21 16:22:02 2013
From: notmart at gmail.com (Marco Martin)
Date: Wed, 21 Aug 2013 16:22:02 -0000
Subject: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to
 actually uninstall the theme.
In-Reply-To: <20130817030306.26981.9224@vidsolbach.de>
References: <20130817030306.26981.9224@vidsolbach.de>
Message-ID: <20130821162202.32114.55957@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112128/#review38285
-----------------------------------------------------------

Ship it!


looks good to me

- Marco Martin


On Aug. 17, 2013, 3:03 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112128/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 3:03 a.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> Currently uninstallation of plasma themes is very broken for a couple of reasons. One reason is that the tar packages downloaded from kde-look and other kns services contain a subfolder with the theme name, that then contains the metadata.desktop file that plasma::PackageStructure looks for in order to uninstall or install a plugin. The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah fails.  This patch fixes the second issue. I'll upload another patch for review that fixes the first issue.
> 
> 
> Diffs
> -----
> 
>   plasma/tools/plasmapkg/main.cpp 6a2982b292ec9736710f4b41dcaa0cbff3986c46 
> 
> Diff: http://git.reviewboard.kde.org/r/112128/diff/
> 
> 
> Testing
> -------
> 
> Plasma themes correctly uninstall here with this and my other patch.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/25580a3b/attachment.html>

From null at kde.org  Wed Aug 21 16:50:32 2013
From: null at kde.org (Commit Hook)
Date: Wed, 21 Aug 2013 16:50:32 -0000
Subject: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to
 actually uninstall the theme.
In-Reply-To: <20130817030306.26981.9224@vidsolbach.de>
References: <20130817030306.26981.9224@vidsolbach.de>
Message-ID: <20130821165032.6540.26562@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112128/#review38287
-----------------------------------------------------------


This review has been submitted with commit ab7b64e3a9c788814bda5c2dd2fce1a676c8e1ea by Jeremy Whiting to branch master.

- Commit Hook


On Aug. 17, 2013, 3:03 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112128/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 3:03 a.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> Currently uninstallation of plasma themes is very broken for a couple of reasons. One reason is that the tar packages downloaded from kde-look and other kns services contain a subfolder with the theme name, that then contains the metadata.desktop file that plasma::PackageStructure looks for in order to uninstall or install a plugin. The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah fails.  This patch fixes the second issue. I'll upload another patch for review that fixes the first issue.
> 
> 
> Diffs
> -----
> 
>   plasma/tools/plasmapkg/main.cpp 6a2982b292ec9736710f4b41dcaa0cbff3986c46 
> 
> Diff: http://git.reviewboard.kde.org/r/112128/diff/
> 
> 
> Testing
> -------
> 
> Plasma themes correctly uninstall here with this and my other patch.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/bf047935/attachment.html>

From null at kde.org  Wed Aug 21 16:50:34 2013
From: null at kde.org (Commit Hook)
Date: Wed, 21 Aug 2013 16:50:34 -0000
Subject: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to
 actually uninstall the theme.
In-Reply-To: <20130817030306.26981.9224@vidsolbach.de>
References: <20130817030306.26981.9224@vidsolbach.de>
Message-ID: <20130821165034.6595.48218@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112128/
-----------------------------------------------------------

(Updated Aug. 21, 2013, 4:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K?gler.


Description
-------

Currently uninstallation of plasma themes is very broken for a couple of reasons. One reason is that the tar packages downloaded from kde-look and other kns services contain a subfolder with the theme name, that then contains the metadata.desktop file that plasma::PackageStructure looks for in order to uninstall or install a plugin. The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah fails.  This patch fixes the second issue. I'll upload another patch for review that fixes the first issue.


Diffs
-----

  plasma/tools/plasmapkg/main.cpp 6a2982b292ec9736710f4b41dcaa0cbff3986c46 

Diff: http://git.reviewboard.kde.org/r/112128/diff/


Testing
-------

Plasma themes correctly uninstall here with this and my other patch.


Thanks,

Jeremy Paul Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/b931e096/attachment-0001.html>

From dantti12 at gmail.com  Wed Aug 21 16:52:06 2013
From: dantti12 at gmail.com (Daniel Nicoletti)
Date: Wed, 21 Aug 2013 13:52:06 -0300
Subject: naming the next major release
In-Reply-To: <2261448.5E7fb6EpYB@martin-thinkpad>
References: <137711932.oj8iDjKShl@freedom>
 <201308211149.04329.notmart@gmail.com>
 <CACo8zOefWFQpRotSJNiSfzqo0ynnbA94Dj9Mh=eaFkBQm=iD9Q@mail.gmail.com>
 <2261448.5E7fb6EpYB@martin-thinkpad>
Message-ID: <CACo8zOf0s42+kbc12c4zss+Bspd=4XoOc-msNAobiwaQPE_E=g@mail.gmail.com>

2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
> On Wednesday 21 August 2013 11:29:52 Daniel Nicoletti wrote:
>> My 2c,
>>
>> On KDE 4 aka KDE SC 4, plasma was always just plasma,
>> no user says I'm using the plasma shell (as there isn't another
>> KDE option).
> this might change. Consider Razor/LXDE joining the KDE umbrella. What then?
> From one day to another it would be obvious that using "the KDE desktop" is
> not working any more.
In that case what we will end up is with just KDE libraries? I mean
people are used to "install/use KDE" which means the SC.

If we are going to drop the "KDE desktop" then imho it should
be better to put some marketing on the "Plasma desktop"
which uses KDE technology.

The same imho happens to Razor/LXDE, they will keep being
Razor/LXDE maybe using KDE pieces. At some point KDE
might vanish completely as the more things from the
frameworks are upstreamed (not that this is bad!).

This of course end up being completely ok with the new
KDE = comunity branding which to me is a shame that
the shell looses it's identity. I somehow imagine in the
future people talking about plasma people or lxde people
and the KDE name being left only for frameworks.

Of course I'm just supposing.


> I'm in fact aware of at least three desktop shells by the KDE community. The
> only thing those three share is the window manager.
But at some level "the" KDE shell is plasma, and if these others want
to be known
the have to do the promoting themselves.


> Given that we know that we want to open us for more projects and that we want
> to get our technologies into other Qt based desktops, it would be a really bad
> idea to ignore this fact when we do the planning for the next version.

No, I'm not saying to ignore this fact. It's just that imho
the idea of pushing Plasma to version 5 is bad for the
reasons I mentioned. If plasma will keep being included
into KDE SC the SC version is what users see.

An example is that when someone fill a bug against
say print-manager I care which KDE version they have
and not if p-m is at version 0.3, because I know which
version was included in that SC.

Best

From null at kde.org  Wed Aug 21 16:51:57 2013
From: null at kde.org (Commit Hook)
Date: Wed, 21 Aug 2013 16:51:57 -0000
Subject: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to
 actually uninstall the theme.
In-Reply-To: <20130821165034.6595.48218@vidsolbach.de>
References: <20130821165034.6595.48218@vidsolbach.de>
Message-ID: <20130821165157.6769.81796@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112128/#review38288
-----------------------------------------------------------


This review has been submitted with commit 64505f15b9725d3d213990c5fce7f1fc2e41acc7 by Jeremy Whiting to branch KDE/4.11.

- Commit Hook


On Aug. 21, 2013, 4:50 p.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112128/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 4:50 p.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> Currently uninstallation of plasma themes is very broken for a couple of reasons. One reason is that the tar packages downloaded from kde-look and other kns services contain a subfolder with the theme name, that then contains the metadata.desktop file that plasma::PackageStructure looks for in order to uninstall or install a plugin. The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah fails.  This patch fixes the second issue. I'll upload another patch for review that fixes the first issue.
> 
> 
> Diffs
> -----
> 
>   plasma/tools/plasmapkg/main.cpp 6a2982b292ec9736710f4b41dcaa0cbff3986c46 
> 
> Diff: http://git.reviewboard.kde.org/r/112128/diff/
> 
> 
> Testing
> -------
> 
> Plasma themes correctly uninstall here with this and my other patch.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/605e3919/attachment.html>

From mgraesslin at kde.org  Wed Aug 21 18:15:45 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Wed, 21 Aug 2013 20:15:45 +0200
Subject: naming the next major release
In-Reply-To: <CACo8zOf0s42+kbc12c4zss+Bspd=4XoOc-msNAobiwaQPE_E=g@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom> <2261448.5E7fb6EpYB@martin-thinkpad>
 <CACo8zOf0s42+kbc12c4zss+Bspd=4XoOc-msNAobiwaQPE_E=g@mail.gmail.com>
Message-ID: <1577746.gnZPbvCZlt@martin-thinkpad>

On Wednesday 21 August 2013 13:52:06 Daniel Nicoletti wrote:
> 2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
> > On Wednesday 21 August 2013 11:29:52 Daniel Nicoletti wrote:
> >> My 2c,
> >> 
> >> On KDE 4 aka KDE SC 4, plasma was always just plasma,
> >> no user says I'm using the plasma shell (as there isn't another
> >> KDE option).
> > 
> > this might change. Consider Razor/LXDE joining the KDE umbrella. What
> > then?
> > From one day to another it would be obvious that using "the KDE desktop"
> > is
> > not working any more.
> 
> In that case what we will end up is with just KDE libraries? I mean
> people are used to "install/use KDE" which means the SC.
no?!? I fail to see what you want to tell us, I cannot follow your thought. I 
guess it's based on you still think that KDE is not the community but all the 
software we tend to release once half a year.
> 
> If we are going to drop the "KDE desktop" then imho it should
> be better to put some marketing on the "Plasma desktop"
> which uses KDE technology.
We haven't marketed a "KDE desktop" for years now.
> 
> The same imho happens to Razor/LXDE, they will keep being
> Razor/LXDE maybe using KDE pieces. At some point KDE
> might vanish completely as the more things from the
> frameworks are upstreamed (not that this is bad!).
Why should KDE vanish if Razor uses frameworks? I fail to follow your 
reasoning.
> 
> This of course end up being completely ok with the new
> KDE = comunity branding which to me is a shame that
> the shell looses it's identity. I somehow imagine in the
> future people talking about plasma people or lxde people
> and the KDE name being left only for frameworks.
Why should they only talk about Plasma?
> 
> Of course I'm just supposing.
> 
> > I'm in fact aware of at least three desktop shells by the KDE community.
> > The only thing those three share is the window manager.
> 
> But at some level "the" KDE shell is plasma, and if these others want
> to be known
> the have to do the promoting themselves.
Just for the record: one of the three desktop shells I meant is Plasma :-) As 
far as I know the other shells don't want to be promoted, but they would get 
obviously the same level of promotion. The dot is open to every KDE project.
> 
> > Given that we know that we want to open us for more projects and that we
> > want to get our technologies into other Qt based desktops, it would be a
> > really bad idea to ignore this fact when we do the planning for the next
> > version.
> No, I'm not saying to ignore this fact. It's just that imho
> the idea of pushing Plasma to version 5 is bad for the
> reasons I mentioned. If plasma will keep being included
> into KDE SC the SC version is what users see.
I really have problems understanding your arguments. They seem to be centered 
around "I don't like the renaming of KDE, thus I do not like this". I think 
the renaming was a good step and reflects much better what we as a community 
do. I can only recommend to open up on it and see the positive aspects of it.
> 
> An example is that when someone fill a bug against
> say print-manager I care which KDE version they have
> and not if p-m is at version 0.3, because I know which
> version was included in that SC.
then you should fix this. In KWin we include also information about kdelibs 
version (compilation, runtime) and Qt. It helps a lot.

Personal remark: I sometimes have problems following your arguments and 
recently I had the feeling that you jump to wrong conclusions based on 
incorrect and incomplete data. I think this is also here the case. You jump 
directly to the conclusion but seem to miss the reasons and the good 
advantages of the renaming of KDE. Just look at the manifesto - without the 
renaming that would not have happened. As you have not been at Akademy I 
recommend to watch the recordings of Kevin's keynote.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/fd67ca03/attachment.sig>

From mgraesslin at kde.org  Wed Aug 21 18:38:05 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Wed, 21 Aug 2013 20:38:05 +0200
Subject: naming the next major release
In-Reply-To: <137711932.oj8iDjKShl@freedom>
References: <137711932.oj8iDjKShl@freedom>
Message-ID: <3797600.kjQm6yaDAE@martin-thinkpad>

On Monday 19 August 2013 21:56:35 Aaron J. Seigo wrote:
> Other proposals, ideas, tweaks to the above most welcome, but let?s try to
> come to a consensus on this matter before the end of this month.
another idea: let's drop the version number completely and only use it 
internally (bugtracker, libs, etc.).

Got that idea while reading a news that Cryengine 3 got renamed to Cryengine

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/52c04515/attachment.sig>

From dantti12 at gmail.com  Wed Aug 21 18:58:03 2013
From: dantti12 at gmail.com (Daniel Nicoletti)
Date: Wed, 21 Aug 2013 15:58:03 -0300
Subject: naming the next major release
In-Reply-To: <1577746.gnZPbvCZlt@martin-thinkpad>
References: <137711932.oj8iDjKShl@freedom> <2261448.5E7fb6EpYB@martin-thinkpad>
 <CACo8zOf0s42+kbc12c4zss+Bspd=4XoOc-msNAobiwaQPE_E=g@mail.gmail.com>
 <1577746.gnZPbvCZlt@martin-thinkpad>
Message-ID: <CACo8zOcNxOxCAHu+yNvB8cRP2jfnHaVE5gj=NgrnWqpM-YXS7Q@mail.gmail.com>

2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
> On Wednesday 21 August 2013 13:52:06 Daniel Nicoletti wrote:
>> 2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
>> > On Wednesday 21 August 2013 11:29:52 Daniel Nicoletti wrote:
>> > this might change. Consider Razor/LXDE joining the KDE umbrella. What
>> > then?
>> > From one day to another it would be obvious that using "the KDE desktop"
>> > is
>> > not working any more.
>>
>> In that case what we will end up is with just KDE libraries? I mean
>> people are used to "install/use KDE" which means the SC.
> no?!? I fail to see what you want to tell us, I cannot follow your thought. I
> guess it's based on you still think that KDE is not the community but all the
> software we tend to release once half a year.
Sorry if it's hard to understand, so I'll try to put it into another way:
* First I just wanted to say that I prefer Plasma 2 instead of 5, because it
   helps understanding the age and we have lots of other KDE components
   with different versions than 5.

* Second I'm saying that KDE is also the software because we do release a
   KDE Software Compilation which has the KDE name.

* I know we don't market the KDE desktop anymore, all the blog posts
   around KDE still talk about it as a DE. Lots of friends that use KDE SC
   don't even know what is plasma-desktop because for them it's KDE.

For example what happens if I want my own shell (no I didn't write one :P )
on the KDE SC?

The KDE community has to decide which will be the included, since plasma
got there first there isn't much chance for a replacement, then better
do like Razor.

I'm not against the KDE renaming, but I think we are getting
to a point that having an Software Compilation becomes a
problem. If Razor is now a KDE project they why only plasma
is included?

About print-manager the user can see it's version using the
about module of system-settings, but since KDE does the
branching/tagging it's easier to just rely on the KDE version,
the 0.3 vesion is something useless when on SC. But to me
as a developer tells me how much I change it, and since it's
mostly complete 4.10 has 0.3 and 4.11 has 0.3 because
most commits where just bugfixes. Also dpkg -l print-manager
shows the KDE SC version (so it does for dolphin).

PS I don't care much what plasma does as I'm mostly a user
of plasma shell and API, but as a user I just felt that jumping
into 5 just because the KDE FW is at 5 seems wrong, as after
all KDE is just the community.

From mgraesslin at kde.org  Wed Aug 21 19:35:37 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Wed, 21 Aug 2013 21:35:37 +0200
Subject: naming the next major release
In-Reply-To: <CACo8zOcNxOxCAHu+yNvB8cRP2jfnHaVE5gj=NgrnWqpM-YXS7Q@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom> <1577746.gnZPbvCZlt@martin-thinkpad>
 <CACo8zOcNxOxCAHu+yNvB8cRP2jfnHaVE5gj=NgrnWqpM-YXS7Q@mail.gmail.com>
Message-ID: <5741881.4XKZBSSENd@martin-thinkpad>

On Wednesday 21 August 2013 15:58:03 Daniel Nicoletti wrote:
> 2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
> > On Wednesday 21 August 2013 13:52:06 Daniel Nicoletti wrote:
> >> 2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
> >> > On Wednesday 21 August 2013 11:29:52 Daniel Nicoletti wrote:
> >> > this might change. Consider Razor/LXDE joining the KDE umbrella. What
> >> > then?
> >> > From one day to another it would be obvious that using "the KDE
> >> > desktop"
> >> > is
> >> > not working any more.
> >> 
> >> In that case what we will end up is with just KDE libraries? I mean
> >> people are used to "install/use KDE" which means the SC.
> > 
> > no?!? I fail to see what you want to tell us, I cannot follow your
> > thought. I guess it's based on you still think that KDE is not the
> > community but all the software we tend to release once half a year.
> 
> Sorry if it's hard to understand, so I'll try to put it into another way:
> * First I just wanted to say that I prefer Plasma 2 instead of 5, because it
> helps understanding the age and we have lots of other KDE components with
> different versions than 5.
> 
> * Second I'm saying that KDE is also the software because we do release a
>    KDE Software Compilation which has the KDE name.
ok, that I did not get at all :-) I personally also don't like 5 for the .0 
reason.
> 
> * I know we don't market the KDE desktop anymore, all the blog posts
>    around KDE still talk about it as a DE. Lots of friends that use KDE SC
>    don't even know what is plasma-desktop because for them it's KDE.
Yes I noticed that for example you still talk about KDE as software in your 
blog posts. To be honest I have to cringe if I read it, because it makes the 
task of everyone more difficult who tries to work on the repositioning of the 
brand.

It is important. If people from the outside think it's one coherent thing we 
wouldn't need efforts like frameworks to make it more attractive for 3rd party 
developers and it also makes any attempts to get KWin as the window manager 
for all Qt based shells much more difficult. Which is a reason why I do care 
about it.
> 
> For example what happens if I want my own shell (no I didn't write one :P )
> on the KDE SC?
> 
> The KDE community has to decide which will be the included, since plasma
> got there first there isn't much chance for a replacement, then better
> do like Razor.
does the KDE community have to decide? Did the community ever decide that 
there can only be one file manager in the SC? Also does software have to be in 
the SC? Or is software more blessed by being in the SC? Large part of the 
release announcement for 4.11 is about KScreen - to my knowledge it's not even 
released as part of the SC. What do you think is the more prominent music 
player by KDE? Amarok which is not part of the SC or juk which is part of the 
SC? Same for IM - kopete vs kpt.
> 
> I'm not against the KDE renaming, but I think we are getting
> to a point that having an Software Compilation becomes a
> problem. If Razor is now a KDE project they why only plasma
> is included?
Who said there will be a software compilation in the KF 5 world or that the 
Plasma Workspaces will be part of such a maybe existing software compilation? 
Please note that this has not yet been discussed, but I know that a few people 
in the Plasma team (me included) would favor to not have the SC anymore. The 
reasons you mention are a part of it. In fact the whole discussion highlights 
it. We would not need to think about a version number if Plasma would be part 
of the software compilation.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/1a6bcdf7/attachment-0001.sig>

From dantti12 at gmail.com  Wed Aug 21 20:12:10 2013
From: dantti12 at gmail.com (Daniel Nicoletti)
Date: Wed, 21 Aug 2013 17:12:10 -0300
Subject: naming the next major release
In-Reply-To: <5741881.4XKZBSSENd@martin-thinkpad>
References: <137711932.oj8iDjKShl@freedom> <1577746.gnZPbvCZlt@martin-thinkpad>
 <CACo8zOcNxOxCAHu+yNvB8cRP2jfnHaVE5gj=NgrnWqpM-YXS7Q@mail.gmail.com>
 <5741881.4XKZBSSENd@martin-thinkpad>
Message-ID: <CACo8zOfQCA5ttLKq0BsWiSOizLuJA2Zf_o9XOiVe=Wp2_HkZrA@mail.gmail.com>

2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
> Yes I noticed that for example you still talk about KDE as software in your
> blog posts. To be honest I have to cringe if I read it, because it makes the
> task of everyone more difficult who tries to work on the repositioning of the
> brand.
Well if I write an app using Qt people call it a Qt app, when you use KDE FW
it becomes a KDE app. So what should I call the software I write when using
KDE FW?


> It is important. If people from the outside think it's one coherent thing we
> wouldn't need efforts like frameworks to make it more attractive for 3rd party
> developers and it also makes any attempts to get KWin as the window manager
> for all Qt based shells much more difficult. Which is a reason why I do care
> about it.
Well re-branding is really hard, it's for a reason companies fight for names...
Clearly I'm not alone in not know how to properly brand things now.

>> The KDE community has to decide which will be the included, since plasma
>> got there first there isn't much chance for a replacement, then better
>> do like Razor.
> does the KDE community have to decide?
Yes, look at the old Oyranos vs colord-kde thread, in the end colord-kde
probably has more usage where KWin color correction only works
with Oyranos (I don't plan to fix this before we have wayland).
And Kolor-manager ended up in extragear...


> Did the community ever decide that
> there can only be one file manager in the SC?
The fact that Konqueror is also a file manager could be tagged as
historical reason imho.


> Also does software have to be in
> the SC? Or is software more blessed by being in the SC?
Sure it is, most distros have meta packages which installing
kde-utils brings a bunch of "utils" stuff, if your app is in there
it gets more attention.


> Large part of the
> release announcement for 4.11 is about KScreen - to my knowledge it's not even
> released as part of the SC.
Right, it got good promoting due to being an important thing
to many users, would a new clock applet (not part of the SC)
get on the announcement page?


> What do you think is the more prominent music
> player by KDE? Amarok which is not part of the SC or juk which is part of the
> SC? Same for IM - kopete vs kpt.
I do agree with you it's not needed to be in the SC,
but notice the core apps vs regular apps difference,
if I write another window manager that happens to
replace kwin in the SC would people still want to install
KWin? Sure if you promote it better (or have more quality)
downstream might use it as default.


> Who said there will be a software compilation in the KF 5 world or that the
> Plasma Workspaces will be part of such a maybe existing software compilation?
Nobody (afaik) said the opposite either :)


> Please note that this has not yet been discussed, but I know that a few people
> in the Plasma team (me included) would favor to not have the SC anymore. The
> reasons you mention are a part of it. In fact the whole discussion highlights
> it.
OK, then imho we could have modules SC ie kde utils/edu... SC,
the SC is good because it help with the coordination of small modules
that doesn't have to worry when to release their stuff.


> We would not need to think about a version number if Plasma would be part
> of the software compilation.
Well if that's the reason shouldn't the discussion about having/being part of SC
take place first?

From sebas at kde.org  Wed Aug 21 21:27:23 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Wed, 21 Aug 2013 23:27:23 +0200
Subject: naming the next major release
In-Reply-To: <CACo8zOfQCA5ttLKq0BsWiSOizLuJA2Zf_o9XOiVe=Wp2_HkZrA@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom> <5741881.4XKZBSSENd@martin-thinkpad>
 <CACo8zOfQCA5ttLKq0BsWiSOizLuJA2Zf_o9XOiVe=Wp2_HkZrA@mail.gmail.com>
Message-ID: <4253719.udmno3R1uI@miro.vizzzion.net>

On Wednesday, August 21, 2013 17:12:10 Daniel Nicoletti wrote:
> 2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
> > Yes I noticed that for example you still talk about KDE as software in
> > your
> > blog posts. To be honest I have to cringe if I read it, because it makes
> > the task of everyone more difficult who tries to work on the
> > repositioning of the brand.
> 
> Well if I write an app using Qt people call it a Qt app, when you use KDE FW
> it becomes a KDE app. So what should I call the software I write when using
> KDE FW?

Just to chime in here, this is clearly wrong. A KDE App (or project, if you 
will) is not defined by its technical dependencies, but by the people who 
write it, see manifesto.kde.org.

Daniel, I think you've gone a few years back in time, stuck your fingers 
firmly into your ears as to the reasoning of the whole rebranding, and are now 
trying to turn back the clocks for no good reason.

Would you mind giving the rebranding another try to actually understand it, 
and not work against what has been years of work, and not an easy, but very 
much necessary endeavour? Then we could actually move forward, instead of one 
step ahead, two steps back.

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From rickstockton at reno-computerhelp.com  Wed Aug 21 21:39:36 2013
From: rickstockton at reno-computerhelp.com (Rick Stockton)
Date: Wed, 21 Aug 2013 14:39:36 -0700
Subject: naming the next major release
In-Reply-To: <5741881.4XKZBSSENd@martin-thinkpad>
References: <137711932.oj8iDjKShl@freedom> <1577746.gnZPbvCZlt@martin-thinkpad>
 <CACo8zOcNxOxCAHu+yNvB8cRP2jfnHaVE5gj=NgrnWqpM-YXS7Q@mail.gmail.com>
 <5741881.4XKZBSSENd@martin-thinkpad>
Message-ID: <52153398.1090004@reno-computerhelp.com>

I wonder: If KDE will not define and Release an internally consistent 
'SC' anymore, then how should packagers differentiate between "Minor 
Version" and "Point Release Updates" for their end users?
I understand the use of an RPM or Deb name such as "Task-KDE-Plasma" 
used as a collection, defining multiple packages as a combined unit -- 
but if we off-load the definition of such packages to the Distros, I'm 
afraid that we might see a huge increase in Distro-specific Bugs - and 
they'd be bugs which we can't reproduce, because we've (possibly) made 
the definition of KDE contents too flexible, and don't have all of those 
configurations available to run ourselves.

IMO, it would be a Very-Bad-Thing(tm) if our first response to many bugs 
becomes a request to "clean up their package selection, and see if the 
probelm is still reproducible". A number of such requests to "elinimate 
weirdness", from bug triage persons, would basically be like the 
definition of an SC anyway. (But after the fact, and all of the 
misdirected packaging work, and aggravation of end Users). If we 
consider it a Good-Thing(tm) to avoid defining co-requisite KDE 
libraries at Release Time, does our own Release process (and that of all 
our "K" Softwares) have the time and facilities to test a large number 
of possible combinations? Or, is my worry resolved by 
already-in-progress refactoring?

BTW, as a (mostly) end-User, I'm fine (and prefer) Plasma-2. But KDE 
without "base" SC Releases will tend to fragment Distro content 
selection, right?

On 08/21/2013 12:35 PM, Martin Graesslin wrote:

<<big snip, not relevant to my questions>>
> On Wednesday 21 August 2013 15:58:03 Daniel Nicoletti wrote:
>> 2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
>>> On Wednesday 21 August 2013 13:52:06 Daniel Nicoletti wrote:
>>>> 2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
>>>>> On Wednesday 21 August 2013 11:29:52 Daniel Nicoletti wrote:
>>>>> this might change. Consider Razor/LXDE joining the KDE umbrella. What
>>>>> then?
>>>>>  From one day to another it would be obvious that using "the KDE
>>>>> desktop"
>>>>> is
>>>>> not working any more.
<< big snip of stuff not relevant to my questions >>
> Who said there will be a software compilation in the KF 5 world or 
> that the Plasma Workspaces will be part of such a maybe existing 
> software compilation? Please note that this has not yet been 
> discussed, but I know that a few people in the Plasma team (me 
> included) would favor to not have the SC anymore. The reasons you 
> mention are a part of it. In fact the whole discussion highlights it. 
> We would not need to think about a version number if Plasma would be 
> part of the software compilation. Cheers Martin 

-- 
GPG fingerprint: 597E 4CE5 6D56 A7C2 DA3A 26FF F21F F828 0C86 165A


From notmart at gmail.com  Wed Aug 21 22:27:06 2013
From: notmart at gmail.com (Marco Martin)
Date: Thu, 22 Aug 2013 00:27:06 +0200
Subject: naming the next major release
In-Reply-To: <52153398.1090004@reno-computerhelp.com>
References: <137711932.oj8iDjKShl@freedom>
 <5741881.4XKZBSSENd@martin-thinkpad> <52153398.1090004@reno-computerhelp.com>
Message-ID: <3941675.FgrNMeAM0v@deimos.diaunet>

On Wednesday 21 August 2013 14:39:36 Rick Stockton wrote:
> 
> BTW, as a (mostly) end-User, I'm fine (and prefer) Plasma-2. But KDE
> without "base" SC Releases will tend to fragment Distro content
> selection, right?

sorry, I have to be a bit tedious here :p
isn't this material for a completely different discussion? a bit OT..
how to call the desktop doesn't really affect the release cycle

Cheers,
Marco Martin

From dantti12 at gmail.com  Wed Aug 21 22:36:21 2013
From: dantti12 at gmail.com (Daniel Nicoletti)
Date: Wed, 21 Aug 2013 19:36:21 -0300
Subject: naming the next major release
In-Reply-To: <4253719.udmno3R1uI@miro.vizzzion.net>
References: <137711932.oj8iDjKShl@freedom> <5741881.4XKZBSSENd@martin-thinkpad>
 <CACo8zOfQCA5ttLKq0BsWiSOizLuJA2Zf_o9XOiVe=Wp2_HkZrA@mail.gmail.com>
 <4253719.udmno3R1uI@miro.vizzzion.net>
Message-ID: <CACo8zOeSmyeD0zpqvp6XTCfBY90rPa=Di3RG+i6wdEo7ZB6JKQ@mail.gmail.com>

2013/8/21 Sebastian K?gler <sebas at kde.org>:
> On Wednesday, August 21, 2013 17:12:10 Daniel Nicoletti wrote:
>> 2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
>> > Yes I noticed that for example you still talk about KDE as software in
>> > your
>> > blog posts. To be honest I have to cringe if I read it, because it makes
>> > the task of everyone more difficult who tries to work on the
>> > repositioning of the brand.
>>
>> Well if I write an app using Qt people call it a Qt app, when you use KDE FW
>> it becomes a KDE app. So what should I call the software I write when using
>> KDE FW?
>
> Just to chime in here, this is clearly wrong. A KDE App (or project, if you
> will) is not defined by its technical dependencies, but by the people who
> write it, see manifesto.kde.org.
Ok, then what am I doing wrong in calling my stuff KDE stuff?
http://manifesto.kde.org/benefits.html lists what I do on my
projects, I was arguing about Martin saying that I talk KDE as software
but KDE projects are mostly software no? This is too controversial,
I know the idea is the we KDE are a community, but it's a community
that have projects and software hence why am wrong in saying
KDE software? It's software made by KDE people.


> Daniel, I think you've gone a few years back in time, stuck your fingers
> firmly into your ears as to the reasoning of the whole rebranding, and are now
> trying to turn back the clocks for no good reason.
I never intended to question the rebranding thing, I really don't care about it,
KDE has always been a community just like Gnome and Linux are, making
sure KDE isn't more just a desktop isn't the point I'm making.

What I'm saying is that people still install distros choosing the "KDE desktop",
and not the Plasma desktop, and this is one of the reasons why I
believe Plasma 2,
is the right name, this way people can know what plasma shell is and use this.
In short don't you think the whole new 5 cycle needs more coordinating between
all parts, will it be an SC, will there be an official shell of course
if this is really
going to happen? As you said the rebranding happened years ago but somehow
I'm only seeing it affect software (as in releases) now.


> Would you mind giving the rebranding another try to actually understand it,
> and not work against what has been years of work, and not an easy, but very
> much necessary endeavour? Then we could actually move forward, instead of one
> step ahead, two steps back.
Just forget I mentioned KDE and SC, just take my +1 on Plasma 2, this
is becoming
an endless and unnecessary discussion, already regret for giving my 2c
please give
them back :P

From valorie.zimmerman at gmail.com  Thu Aug 22 03:40:09 2013
From: valorie.zimmerman at gmail.com (Valorie Zimmerman)
Date: Wed, 21 Aug 2013 20:40:09 -0700
Subject: naming the next major release
In-Reply-To: <137711932.oj8iDjKShl@freedom>
References: <137711932.oj8iDjKShl@freedom>
Message-ID: <CACpu0265mmx86Rib_r5zeAjVxnZSfT_n=74QKYN1fUkm-KYCUA@mail.gmail.com>

Hi Plasma folks,

This thread has been fascinating reading. I hope that after you reach a
tentative conclusion, that you make a proposal to a list with a wider KDE
audience, such as the KDE-Community list. KDE-devel, KDE-core-devel and
KDE-Promo are some of the other possibilities to at least ping about a such
an important conversation happening.

It's really true that names matter, and thus that branding matters.

Thanks so much for starting the discussion.

Valorie


On Mon, Aug 19, 2013 at 12:56 PM, Aaron J. Seigo <aseigo at kde.org> wrote:

> Hi...
>
> after seeing the Nth time that we don?t know if the next release will be
> called Plasma Workspaces 2 or something else, i?d like to find consensus on
> this point so we can move forward in communication with confidence.
>
> the first point that we?ve all been around a million times, but i will
> cover
> again for completeness:
>
>         Do we need a single name for all the bits that go into our desktop
> shell?
>
> yes, we do.



> :: giant snip::
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/ab948ed9/attachment.html>

From mgraesslin at kde.org  Thu Aug 22 06:38:11 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Thu, 22 Aug 2013 08:38:11 +0200
Subject: naming the next major release
In-Reply-To: <CACo8zOeSmyeD0zpqvp6XTCfBY90rPa=Di3RG+i6wdEo7ZB6JKQ@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom>
 <4253719.udmno3R1uI@miro.vizzzion.net>
 <CACo8zOeSmyeD0zpqvp6XTCfBY90rPa=Di3RG+i6wdEo7ZB6JKQ@mail.gmail.com>
Message-ID: <1450497.VDxKBS9BBQ@martin-thinkpad>

On Wednesday 21 August 2013 19:36:21 Daniel Nicoletti wrote:
> 2013/8/21 Sebastian K?gler <sebas at kde.org>:
> > On Wednesday, August 21, 2013 17:12:10 Daniel Nicoletti wrote:
> >> 2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
> >> > Yes I noticed that for example you still talk about KDE as software in
> >> > your
> >> > blog posts. To be honest I have to cringe if I read it, because it
> >> > makes
> >> > the task of everyone more difficult who tries to work on the
> >> > repositioning of the brand.
> >> 
> >> Well if I write an app using Qt people call it a Qt app, when you use KDE
> >> FW it becomes a KDE app. So what should I call the software I write when
> >> using KDE FW?
> > 
> > Just to chime in here, this is clearly wrong. A KDE App (or project, if
> > you
> > will) is not defined by its technical dependencies, but by the people who
> > write it, see manifesto.kde.org.
> 
> Ok, then what am I doing wrong in calling my stuff KDE stuff?
> http://manifesto.kde.org/benefits.html lists what I do on my
> projects, I was arguing about Martin saying that I talk KDE as software
> but KDE projects are mostly software no? This is too controversial,
> I know the idea is the we KDE are a community, but it's a community
> that have projects and software hence why am wrong in saying
> KDE software? It's software made by KDE people.
Look for example at your rant about switches. It's always saying "KDE 4.11", 
which is just wrong. That's what I meant. Just by scrolling down your blog I 
see two posts with "KDE 4.11" in the title. This is working against the 
rebranding. How are we supposed to have the media get it right, if even the 
developers continue to use the old wording.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/ef0c7903/attachment-0001.sig>

From matthias at tenstral.net  Thu Aug 22 07:00:41 2013
From: matthias at tenstral.net (Matthias Klumpp)
Date: Thu, 22 Aug 2013 00:00:41 -0700
Subject: naming the next major release
In-Reply-To: <1450497.VDxKBS9BBQ@martin-thinkpad>
References: <137711932.oj8iDjKShl@freedom>
 <4253719.udmno3R1uI@miro.vizzzion.net>
 <CACo8zOeSmyeD0zpqvp6XTCfBY90rPa=Di3RG+i6wdEo7ZB6JKQ@mail.gmail.com>
 <1450497.VDxKBS9BBQ@martin-thinkpad>
Message-ID: <CAKNHny93aQzNSeCmnnbUTvKTzcuR2BJ9dqVwr7B79JiGJ5nQkg@mail.gmail.com>

2013/8/21 Martin Graesslin <mgraesslin at kde.org>:
> On Wednesday 21 August 2013 19:36:21 Daniel Nicoletti wrote:
>> [...]
>> Ok, then what am I doing wrong in calling my stuff KDE stuff?
>> http://manifesto.kde.org/benefits.html lists what I do on my
>> projects, I was arguing about Martin saying that I talk KDE as software
>> but KDE projects are mostly software no? This is too controversial,
>> I know the idea is the we KDE are a community, but it's a community
>> that have projects and software hence why am wrong in saying
>> KDE software? It's software made by KDE people.
> Look for example at your rant about switches. It's always saying "KDE 4.11",
> which is just wrong. That's what I meant. Just by scrolling down your blog I
> see two posts with "KDE 4.11" in the title. This is working against the
> rebranding. How are we supposed to have the media get it right, if even the
> developers continue to use the old wording.
It is simply convenient to use "KDE" meaning the Frameworks,
Plasma-Workspaces etc. Saying "KDE" is much easier than distinguishing
between the different parts, and it has been used like this for years.
But I assume that this will change with the availability of KF 5 etc.
As soon as the stuff is released at different times and in different
packages, people will adapt to it and use the "right" names. (e.g.
"New features in Plasma" or "API will be available in KDE-Frameworks
5.4", etc.)
IMHO saying that "my software is part of KDE" is still correct, since
KDE can mean the community as well in this context, in the same way
Firefox is part of (the) Mozilla.
(Project).
Cheers,
    Matthias

From ivan.cukic at kde.org  Thu Aug 22 10:44:41 2013
From: ivan.cukic at kde.org (Ivan =?utf-8?B?xIx1a2nEhw==?=)
Date: Thu, 22 Aug 2013 12:44:41 +0200
Subject: Smart d-ptr in Plasma
Message-ID: <10281060.0jD9AZhZHb@drako>

Hi all,

Keep forgetting to write this mail for a while now. It is intended mostly for 
(in aplhabetical order) Aaron, Marco, Martin and Sebastian, but everybody is 
invited to chime in.

It is about the smart and safe d-pointer I have presented some time ago [1].

The question is should it be used in plasma and where?

Cons:
 - too low level to be in plasma-frameworks (sebas)
 - none else that I know of

Pros:
 - safety: no access to the raw pointer
 - safety: no accidental initialization errors or anything similar
 - safety: no possible leaks
 - convenience: forwarded constructor arguments (': d(1,2)' instead of ': 
d(new Private(1,2))')
 - convenience: default constructor works for no-arg Private constructor 
(nothing instead of 'd(new Private())')
 - convenience: no delete d;
 - they are spiffy (aaron) :)

Choices:
1. (a non-choice imo) Use raw pointers like in the old days everywhere
2. Use less safe and less convenient smart-pointers like std::unique_ptr or 
QScopedPointer
3. Use this d-ptr outside of the library, choose 1 or 2 for the library
4. Use it everywhere, but export the headers as if it were 1 or 2 (all should 
be binary compatible with a raw pointer)
5. Use it everywhere, and install the header file for the users to be able to 
use it as well. (it is a templated class, so it leaves no binary footprint by 
itself)

Cheerio,
Ivan

[1] http://ivan.fomentgroup.org/blog/2013/06/22/d-ptr-the-modern-way/


-- 
Science gathers knowledge faster than society gathers wisdom.
  -- Isaac Asimov


From ervin at kde.org  Thu Aug 22 11:29:05 2013
From: ervin at kde.org (Kevin Ottens)
Date: Thu, 22 Aug 2013 13:29:05 +0200
Subject: Smart d-ptr in Plasma
In-Reply-To: <10281060.0jD9AZhZHb@drako>
References: <10281060.0jD9AZhZHb@drako>
Message-ID: <8166230.a5KB2nsJuF@wintermute>

On Thursday 22 August 2013 12:44:41 Ivan ?uki? wrote:
> Hi all,
> 
> Keep forgetting to write this mail for a while now. It is intended mostly
> for (in aplhabetical order) Aaron, Marco, Martin and Sebastian, but
> everybody is invited to chime in.
> 
> It is about the smart and safe d-pointer I have presented some time ago [1].
> 
> The question is should it be used in plasma and where?
> 
> Cons:
>  - too low level to be in plasma-frameworks (sebas)
>  - none else that I know of

Well, I can add one more. They use variadic templates which are not in the 
list of C++11 features which can be used unconditionally in plasma-framework.
Can be spared if you loose the forwarded constructor arguments though.

> Pros:
>  - safety: no access to the raw pointer
>  - safety: no accidental initialization errors or anything similar
>  - safety: no possible leaks
>  - convenience: forwarded constructor arguments (': d(1,2)' instead of ':
> d(new Private(1,2))')
>  - convenience: default constructor works for no-arg Private constructor
> (nothing instead of 'd(new Private())')
>  - convenience: no delete d;
>  - they are spiffy (aaron) :)
> 
> Choices:
> 1. (a non-choice imo) Use raw pointers like in the old days everywhere
> 2. Use less safe and less convenient smart-pointers like std::unique_ptr or
> QScopedPointer
> 3. Use this d-ptr outside of the library, choose 1 or 2 for the library
> 4. Use it everywhere, but export the headers as if it were 1 or 2 (all
> should be binary compatible with a raw pointer)
> 5. Use it everywhere, and install the header file for the users to be able
> to use it as well. (it is a templated class, so it leaves no binary
> footprint by itself)
> 
> Cheerio,
> Ivan
> 
> [1] http://ivan.fomentgroup.org/blog/2013/06/22/d-ptr-the-modern-way/

Regards.
-- 
K?vin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/9c0e0662/attachment.sig>

From ivan.cukic at kde.org  Thu Aug 22 11:39:39 2013
From: ivan.cukic at kde.org (Ivan =?utf-8?B?xIx1a2nEhw==?=)
Date: Thu, 22 Aug 2013 13:39:39 +0200
Subject: Smart d-ptr in Plasma
In-Reply-To: <8166230.a5KB2nsJuF@wintermute>
References: <10281060.0jD9AZhZHb@drako> <8166230.a5KB2nsJuF@wintermute>
Message-ID: <3472631.ieChTnDJKM@drako>


> Well, I can add one more. They use variadic templates which are not in the
> list of C++11 features which can be used unconditionally in
> plasma-framework. Can be spared if you loose the forwarded constructor
> arguments though.

The older MSVC (which I guess is the problem for including variadics) supports 
IIRC up to n (where n is as low as around 12 arguments). This needs to be 
tested though by someone who has that compiler.

Anyhow, the private class constructors rarely have more than one argument. So, 
we could support most use-cases by providing fwd constructors for up to, for 
example, 5 args.

(I just like them too much :) )

Cheerio,
Ivan

-- 
There are no such things as applied sciences, only applications of science.
  -- Louis Pasteur


From ervin at kde.org  Thu Aug 22 12:23:57 2013
From: ervin at kde.org (Kevin Ottens)
Date: Thu, 22 Aug 2013 14:23:57 +0200
Subject: Smart d-ptr in Plasma
In-Reply-To: <3472631.ieChTnDJKM@drako>
References: <10281060.0jD9AZhZHb@drako> <8166230.a5KB2nsJuF@wintermute>
 <3472631.ieChTnDJKM@drako>
Message-ID: <2845685.rH1ZuGL1Pe@wintermute>

On Thursday 22 August 2013 13:39:39 Ivan ?uki? wrote:
> > Well, I can add one more. They use variadic templates which are not in the
> > list of C++11 features which can be used unconditionally in
> > plasma-framework. Can be spared if you loose the forwarded constructor
> > arguments though.
> 
> The older MSVC (which I guess is the problem for including variadics)
> supports IIRC up to n (where n is as low as around 12 arguments). This
> needs to be tested though by someone who has that compiler.
> 
> Anyhow, the private class constructors rarely have more than one argument.
> So, we could support most use-cases by providing fwd constructors for up
> to, for example, 5 args.
 
Yep, let's do that as fallback if Q_COMPILER_VARIADIC_TEMPLATES is not 
defined.

BTW, during lunch I thought about sebas comment, and maybe he got a point... 
That looks useful, so what about putting it in KCoreAddons? It wouldn't cost 
an extra dependency for plasma-framework which already uses it, and it'd give 
it more exposure. Of course means other tier 1 frameworks wouldn't use it, but 
that gives it more chance than plasma-framework already.

If you're interested please bring it up on k-f-d and we'll see where it goes.

Regards.
-- 
K?vin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/1ce42194/attachment.sig>

From polentino911 at gmail.com  Thu Aug 22 13:31:28 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Thu, 22 Aug 2013 13:31:28 -0000
Subject: Review Request 112208: KMix qml applet
Message-ID: <20130822133128.13050.1423@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
-----------------------------------------------------------

Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.


Description
-------

KMix qml applet.
As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
Differences from the old kmix tray:
* no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
* the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;

Known issues:
* there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
* no scroll events over the sliders too;
* if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
* resize doesn't work properly.


Diffs
-----

  plasma/CMakeLists.txt 5e1dc90 
  plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
  plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112208/diff/


Testing
-------

Tested against master and works fine.


File Attachments
----------------

Default look
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
Menu Actions
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
Applet Config Options
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
Vertical Control
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png


Thanks,

Diego Casella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/128299ae/attachment.html>

From sebas at kde.org  Thu Aug 22 14:34:40 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Thu, 22 Aug 2013 14:34:40 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822133128.13050.1423@vidsolbach.de>
References: <20130822133128.13050.1423@vidsolbach.de>
Message-ID: <20130822143440.22771.25603@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38344
-----------------------------------------------------------


Overall, it looks pretty good. There's a number of UI, code and coding style issues there, which will need sorting.

As to coding style, please have a look at http://community.kde.org/Plasma/QMLStyle
I've pointed some of the issues out, but overall, this needs going over the whole code and fixing.

Nice to see this coming together, btw.

One thing: kde-workspace is frozen, and even if this is in the kmix repo, it might be too late to replace it in Plasma Desktop. What are the concrete plans here?


File Attachment: Default look
<http://git.reviewboard.kde.org//r/112208/#fcomment65>
    this tooltip seems redundant, it's covering the exact same information it's showing, no?


File Attachment: Menu Actions
<http://git.reviewboard.kde.org//r/112208/#fcomment66>
    KMix and Phonon are jargon and have to go.
    
    Proposal:
    
    "Mixer Setup"
    "Audio Setup"
    
    Seems more in line with kmix


File Attachment: Menu Actions
<http://git.reviewboard.kde.org//r/112208/#fcomment67>
    jargon, see other comment


File Attachment: Menu Actions
<http://git.reviewboard.kde.org//r/112208/#fcomment68>
    Maybe we could align this in the same way as the batter applet does?


File Attachment: Applet Config Options
<http://git.reviewboard.kde.org//r/112208/#fcomment69>
    No groupboxes please for these rather single things.
    
    Use titles instead and get rid of the frames.
    
    The first title seems unnecessary, the options itself are way clear.


File Attachment: Vertical Control
<http://git.reviewboard.kde.org//r/112208/#fcomment70>
    Clipping


plasma/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112208/#comment28392>

    use the installPackage macro for this and the following line



plasma/kmix-applet-qml/contents/config/main.xml
<http://git.reviewboard.kde.org/r/112208/#comment28360>

    Why two values here? One bool seems enough?



plasma/kmix-applet-qml/contents/ui/ButtonBar.qml
<http://git.reviewboard.kde.org/r/112208/#comment28395>

    Any reason to not leave this out, defaults to UTF-8?



plasma/kmix-applet-qml/contents/ui/ButtonBar.qml
<http://git.reviewboard.kde.org/r/112208/#comment28361>

    Please add the year in the copyright notice



plasma/kmix-applet-qml/contents/ui/ButtonBar.qml
<http://git.reviewboard.kde.org/r/112208/#comment28362>

    no spaces inside (), also elsewhere



plasma/kmix-applet-qml/contents/ui/ButtonBar.qml
<http://git.reviewboard.kde.org/r/112208/#comment28396>

    Bad naming, I got confused while reading this, as it reads like "run this program".
    
    Maybe rename to something more descriptive?



plasma/kmix-applet-qml/contents/ui/ButtonBar.qml
<http://git.reviewboard.kde.org/r/112208/#comment28363>

    spaces inside parentheses should go



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28397>

    For all JS code in the applet, please don't forget the line-ending ;
    
    (will need to be fixed throughout)



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28365>

    Qt.Horizontal?



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28398>

    here, ; usage is even inconsistent



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28399>

    add context for translators



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28366>

    PlasmaCore.IconItem does this for you



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28400>

    not translatable this way:
    
    use condition ? i18n(...) : i18(...) instead



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28401>

    I wonder if this can't be done without the roundtrip, i.e. directly use the icon name?



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28368>

    if (_control.muted)



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28369>

    You're not actually doing anything with the return value here. Oversight?



plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml
<http://git.reviewboard.kde.org/r/112208/#comment28402>

    not needed here



plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml
<http://git.reviewboard.kde.org/r/112208/#comment28370>

    namespacing: ... as QtExtras



plasma/kmix-applet-qml/contents/ui/MixersList.qml
<http://git.reviewboard.kde.org/r/112208/#comment28403>

    namespace it as QtExtras



plasma/kmix-applet-qml/contents/ui/MixersList.qml
<http://git.reviewboard.kde.org/r/112208/#comment28404>

    Qt.Vertical



plasma/kmix-applet-qml/contents/ui/MixersList.qml
<http://git.reviewboard.kde.org/r/112208/#comment28371>

    Qt.Vertical



plasma/kmix-applet-qml/contents/ui/MixersList.qml
<http://git.reviewboard.kde.org/r/112208/#comment28372>

    whitespace



plasma/kmix-applet-qml/contents/ui/MixersList.qml
<http://git.reviewboard.kde.org/r/112208/#comment28405>

    ws



plasma/kmix-applet-qml/contents/ui/VerticalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28373>

    this will drive our translator nuts, unless there's a comment :)



plasma/kmix-applet-qml/contents/ui/VerticalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28374>

    Qt.Vertical



plasma/kmix-applet-qml/contents/ui/VerticalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28375>

    use PlasmaCore.IconItem



plasma/kmix-applet-qml/contents/ui/VerticalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28376>

    not translatable, try:
    
    condition ? i18n("...", bla) : i18n("...", bla2)



plasma/kmix-applet-qml/contents/ui/VerticalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28377>

    again, return value not used



plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml
<http://git.reviewboard.kde.org/r/112208/#comment28378>

    Seems unnecessary, could just be UTF-8? (also elsewhere)



plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml
<http://git.reviewboard.kde.org/r/112208/#comment28379>

    unused
    



plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml
<http://git.reviewboard.kde.org/r/112208/#comment28380>

    unused



plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml
<http://git.reviewboard.kde.org/r/112208/#comment28381>

    namespace QtExtras



plasma/kmix-applet-qml/contents/ui/kmixapplet.qml
<http://git.reviewboard.kde.org/r/112208/#comment28382>

    UTF-8



plasma/kmix-applet-qml/contents/ui/kmixapplet.qml
<http://git.reviewboard.kde.org/r/112208/#comment28383>

    add year



plasma/kmix-applet-qml/contents/ui/kmixapplet.qml
<http://git.reviewboard.kde.org/r/112208/#comment28384>

    not used



plasma/kmix-applet-qml/contents/ui/kmixapplet.qml
<http://git.reviewboard.kde.org/r/112208/#comment28385>

    should be in line with sizing in metadata.desktop?



plasma/kmix-applet-qml/contents/ui/kmixapplet.qml
<http://git.reviewboard.kde.org/r/112208/#comment28387>

    Qt.Horizontal, Qt.Vertical



plasma/kmix-applet-qml/contents/ui/kmixapplet.qml
<http://git.reviewboard.kde.org/r/112208/#comment28389>

    for (var i =...
    
    (whitespace)



plasma/kmix-applet-qml/contents/ui/kmixapplet.qml
<http://git.reviewboard.kde.org/r/112208/#comment28390>

    no jargon please



plasma/kmix-applet-qml/contents/ui/kmixapplet.qml
<http://git.reviewboard.kde.org/r/112208/#comment28391>

    no jargon please



plasma/kmix-applet-qml/metadata.desktop
<http://git.reviewboard.kde.org/r/112208/#comment28358>

    Explanation?
    
    Keywords would also be nice.



plasma/kmix-applet-qml/metadata.desktop
<http://git.reviewboard.kde.org/r/112208/#comment28357>

    --jargon



plasma/kmix-applet-qml/metadata.desktop
<http://git.reviewboard.kde.org/r/112208/#comment28359>

    Use "Multimedia" as category



plasma/kmix-applet-qml/metadata.desktop
<http://git.reviewboard.kde.org/r/112208/#comment28393>

    sync size with toplevel Item



plasma/kmix-applet-qml/metadata.desktop
<http://git.reviewboard.kde.org/r/112208/#comment28394>

    Just remove this one


- Sebastian K?gler


On Aug. 22, 2013, 1:31 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 1:31 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/CMakeLists.txt 5e1dc90 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/a792eaa8/attachment-0001.html>

From mgraesslin at kde.org  Thu Aug 22 17:11:09 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Thu, 22 Aug 2013 19:11:09 +0200
Subject: Smart d-ptr in Plasma
In-Reply-To: <2845685.rH1ZuGL1Pe@wintermute>
References: <10281060.0jD9AZhZHb@drako> <3472631.ieChTnDJKM@drako>
 <2845685.rH1ZuGL1Pe@wintermute>
Message-ID: <2310761.0GqEbvDB2V@martin-thinkpad>

On Thursday 22 August 2013 14:23:57 Kevin Ottens wrote:
> On Thursday 22 August 2013 13:39:39 Ivan ?uki? wrote:
> > > Well, I can add one more. They use variadic templates which are not in
> > > the
> > > list of C++11 features which can be used unconditionally in
> > > plasma-framework. Can be spared if you loose the forwarded constructor
> > > arguments though.
> > 
> > The older MSVC (which I guess is the problem for including variadics)
> > supports IIRC up to n (where n is as low as around 12 arguments). This
> > needs to be tested though by someone who has that compiler.
> > 
> > Anyhow, the private class constructors rarely have more than one argument.
> > So, we could support most use-cases by providing fwd constructors for up
> > to, for example, 5 args.
> 
> Yep, let's do that as fallback if Q_COMPILER_VARIADIC_TEMPLATES is not
> defined.
> 
> BTW, during lunch I thought about sebas comment, and maybe he got a point...
> That looks useful, so what about putting it in KCoreAddons? It wouldn't
> cost an extra dependency for plasma-framework which already uses it, and
> it'd give it more exposure. Of course means other tier 1 frameworks
> wouldn't use it, but that gives it more chance than plasma-framework
> already.
Maybe it would even be an idea for an own (tier 0) framework which could 
contain useful C++11 magic? I guess we will soon have more useful C++11 stuff 
which might make sense to be used in more places.
> 
> If you're interested please bring it up on k-f-d and we'll see where it
> goes.
yes, please :-)

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/dcea09ba/attachment.sig>

From ivan.cukic at kde.org  Thu Aug 22 17:14:41 2013
From: ivan.cukic at kde.org (Ivan =?utf-8?B?xIx1a2nEhw==?=)
Date: Thu, 22 Aug 2013 19:14:41 +0200
Subject: Smart d-ptr in Plasma
In-Reply-To: <2310761.0GqEbvDB2V@martin-thinkpad>
References: <10281060.0jD9AZhZHb@drako> <2845685.rH1ZuGL1Pe@wintermute>
 <2310761.0GqEbvDB2V@martin-thinkpad>
Message-ID: <1574028.pctifsNMp2@drako>


> > If you're interested please bring it up on k-f-d and we'll see where it
> > goes.

Posted on kfd.

Cheers

-- 
So remember when you're feeling very small and insecure
How amazingly unlikely is your birth
And pray that there's intelligent life somewhere up in space
Because there's bugger all down here on earth.
  -- Monty Python
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/aa90fed5/attachment.sig>

From terietor at gmail.com  Thu Aug 22 17:36:24 2013
From: terietor at gmail.com (Giorgos Tsiapaliokas)
Date: Thu, 22 Aug 2013 20:36:24 +0300
Subject: naming the next major release
In-Reply-To: <201308211149.04329.notmart@gmail.com>
References: <137711932.oj8iDjKShl@freedom>
 <201308211149.04329.notmart@gmail.com>
Message-ID: <CAODYyLYcv1T+TuRoBWjMf1udXBPNp8U8tKGayR+jqYMArB_J+A@mail.gmail.com>

Hello,


On 21 August 2013 12:49, Marco Martin <notmart at gmail.com> wrote:
>
> My vote would go for Plasma.
>

+1,  just "Plasma" without "KDE".

On 21 August 2013 21:38, Martin Graesslin <mgraesslin at kde.org> wrote:
>
> another idea: let's drop the version number completely and only use it
> internally (bugtracker, libs, etc.)
>

I was thinking this too. But when a new version comes out how could we
promote it?
Also if a product doesn't have a version then this could mean that it is
rolling.
Yes not always but this is the first thought that goes through the mind. No?

-- 
Giorgos Tsiapaliokas (terietor)

terietor.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/29460915/attachment.html>

From mgraesslin at kde.org  Thu Aug 22 17:47:22 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Thu, 22 Aug 2013 19:47:22 +0200
Subject: naming the next major release
In-Reply-To: <CAODYyLYcv1T+TuRoBWjMf1udXBPNp8U8tKGayR+jqYMArB_J+A@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom>
 <201308211149.04329.notmart@gmail.com>
 <CAODYyLYcv1T+TuRoBWjMf1udXBPNp8U8tKGayR+jqYMArB_J+A@mail.gmail.com>
Message-ID: <3637664.lGhuu0UqIF@martin-thinkpad>

On Thursday 22 August 2013 20:36:24 Giorgos Tsiapaliokas wrote:
> Hello,
> 
> On 21 August 2013 12:49, Marco Martin <notmart at gmail.com> wrote:
> > My vote would go for Plasma.
> 
> +1,  just "Plasma" without "KDE".
> 
> On 21 August 2013 21:38, Martin Graesslin <mgraesslin at kde.org> wrote:
> > another idea: let's drop the version number completely and only use it
> > internally (bugtracker, libs, etc.)
> 
> I was thinking this too. But when a new version comes out how could we
> promote it?
Quoting our release announcement for 4.11: "KDE is delighted to announce its 
latest set of releases, providing major updates to KDE Plasma Workspaces, KDE 
Applications, and the KDE Platform."
> Also if a product doesn't have a version then this could mean that it is
> rolling.
> Yes not always but this is the first thought that goes through the mind. No?
And a rolling release might have version numbers. I'm using a rolling distro 
and it has version numbers, but I never know which one it is. So that argument 
works in both direction. I think there is no real sign that rolling releases 
do not have a version number.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/d4e59d67/attachment.sig>

From mgraesslin at kde.org  Thu Aug 22 17:50:50 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Thu, 22 Aug 2013 19:50:50 +0200
Subject: naming the next major release
In-Reply-To: <3797600.kjQm6yaDAE@martin-thinkpad>
References: <137711932.oj8iDjKShl@freedom> <3797600.kjQm6yaDAE@martin-thinkpad>
Message-ID: <153025446.aq9xrvObfn@martin-thinkpad>

On Wednesday 21 August 2013 20:38:05 Martin Graesslin wrote:
> On Monday 19 August 2013 21:56:35 Aaron J. Seigo wrote:
> > Other proposals, ideas, tweaks to the above most welcome, but let?s try to
> > come to a consensus on this matter before the end of this month.
> 
> another idea: let's drop the version number completely and only use it
> internally (bugtracker, libs, etc.).
and yet another idea: code names instead of release numbers. And as we have 
such nice codenames all over our code base (hello Corona) I would suggest code 
names out of the field of Physics/Science e.g.
* Plasma Higgs-Boson

Cheers
Martin

P.S. and that would give us a wonderful opportunity to bike-shed about a name 
each other month ;-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/f235976f/attachment.sig>

From djurodrljaca at gmail.com  Thu Aug 22 18:04:25 2013
From: djurodrljaca at gmail.com (Djuro Drljaca)
Date: Thu, 22 Aug 2013 20:04:25 +0200
Subject: naming the next major release
In-Reply-To: <153025446.aq9xrvObfn@martin-thinkpad>
References: <137711932.oj8iDjKShl@freedom> <3797600.kjQm6yaDAE@martin-thinkpad>
 <153025446.aq9xrvObfn@martin-thinkpad>
Message-ID: <CALTgeGVo-1O6UW-Cc4e_nHQjBNKpSkOurfNZQL0iAJByzKSzpw@mail.gmail.com>

Hello,

with the "chaotic" nature of (future) release cycles for individual
components the "date version number" format (for example "2013.08") is
probably a good idea :)

If I am not mistaken it was actually you (Martin G.) who initially
suggested that :)


On Thu, Aug 22, 2013 at 7:50 PM, Martin Graesslin <mgraesslin at kde.org>wrote:

> On Wednesday 21 August 2013 20:38:05 Martin Graesslin wrote:
> > On Monday 19 August 2013 21:56:35 Aaron J. Seigo wrote:
> > > Other proposals, ideas, tweaks to the above most welcome, but let?s
> try to
> > > come to a consensus on this matter before the end of this month.
> >
> > another idea: let's drop the version number completely and only use it
> > internally (bugtracker, libs, etc.).
> and yet another idea: code names instead of release numbers. And as we have
> such nice codenames all over our code base (hello Corona) I would suggest
> code
> names out of the field of Physics/Science e.g.
> * Plasma Higgs-Boson
>
> Cheers
> Martin
>
> P.S. and that would give us a wonderful opportunity to bike-shed about a
> name
> each other month ;-)
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/629748c9/attachment.html>

From david at davidedmundson.co.uk  Thu Aug 22 18:26:58 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Thu, 22 Aug 2013 19:26:58 +0100
Subject: naming the next major release
In-Reply-To: <CACo8zOfQCA5ttLKq0BsWiSOizLuJA2Zf_o9XOiVe=Wp2_HkZrA@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom> <1577746.gnZPbvCZlt@martin-thinkpad>
 <CACo8zOcNxOxCAHu+yNvB8cRP2jfnHaVE5gj=NgrnWqpM-YXS7Q@mail.gmail.com>
 <5741881.4XKZBSSENd@martin-thinkpad>
 <CACo8zOfQCA5ttLKq0BsWiSOizLuJA2Zf_o9XOiVe=Wp2_HkZrA@mail.gmail.com>
Message-ID: <CAGeFrHDhu4_SgD8+oCXDgr_bfJ=ixfFmc=SyrV3A3bdT6+KPkg@mail.gmail.com>

My thoughts below.

- Dropping the term "workspace":
Seems sensible to me. It even seems this was the original intention [0].

- Calling it version 2.
This makes a lot of sense, having a software compilation of KDE Plasma 5.x
and KDE Applications 5.y, where x and y are different would be very very
confusing.

One thing that wasn't clear to me on the original proposals and has just
been mentioned by Giorgos is the prefix "KDE".

KDE is not just "the community" but also "an umbrella brand for the
technology created by the KDE community" [0].
I have heard other people make comments about how "Plasma is trying to
distance itself from the KDE community". I don't agree with those people,
but we shouldn't fuel that fire. Displaying that it is part of the KDE
umbrella is IMHO important.

[0] http://dot.kde.org/2009/11/24/repositioning-kde-brand
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/d8f9e375/attachment.html>

From terietor at gmail.com  Thu Aug 22 20:20:11 2013
From: terietor at gmail.com (Giorgos Tsiapaliokas)
Date: Thu, 22 Aug 2013 23:20:11 +0300
Subject: naming the next major release
In-Reply-To: <CAGeFrHDhu4_SgD8+oCXDgr_bfJ=ixfFmc=SyrV3A3bdT6+KPkg@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom> <1577746.gnZPbvCZlt@martin-thinkpad>
 <CACo8zOcNxOxCAHu+yNvB8cRP2jfnHaVE5gj=NgrnWqpM-YXS7Q@mail.gmail.com>
 <5741881.4XKZBSSENd@martin-thinkpad>
 <CACo8zOfQCA5ttLKq0BsWiSOizLuJA2Zf_o9XOiVe=Wp2_HkZrA@mail.gmail.com>
 <CAGeFrHDhu4_SgD8+oCXDgr_bfJ=ixfFmc=SyrV3A3bdT6+KPkg@mail.gmail.com>
Message-ID: <CAODYyLYthtWg_1Yj1E5f5nvvokSb-1w+AaS9JvCVYcaH34S8fQ@mail.gmail.com>

On 22 August 2013 21:26, David Edmundson <david at davidedmundson.co.uk> wrote:

> One thing that wasn't clear to me on the original proposals and has just
> been mentioned by Giorgos is the prefix "KDE".
>
> KDE is not just "the community" but also "an umbrella brand for the
> technology created by the KDE community" [0].
> I have heard other people make comments about how "Plasma is trying to
> distance itself from the KDE community". I don't agree with those people,
> but we shouldn't fuel that fire. Displaying that it is part of the KDE
> umbrella is IMHO important.
>

When I said lets remove the "KDE" from "KDE Plasma" was in order to
emphasize that KDE is the community.
TBH I don't believe that by removing the "KDE", plasma is taking some
distance from KDE. Also there are a lot of projects inside KDE
which aren't using the "KDE" word and they don't take any distance from
KDE, for instance the most references in plasma active are
"Plasma Active" and not "KDE Plasma Active", but PA doesn't have any
distance from KDE. I believe that projects take some distance
from "KDE" when they stop referring to it and not when they remove the
"KDE" word, but that is just me of course :)

-- 
Giorgos Tsiapaliokas (terietor)

terietor.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/32d728db/attachment-0001.html>

From aseigo at kde.org  Thu Aug 22 22:45:51 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Thu, 22 Aug 2013 22:45:51 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822143440.22771.25603@vidsolbach.de>
References: <20130822143440.22771.25603@vidsolbach.de>
Message-ID: <20130822224551.1720.30744@vidsolbach.de>



> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > Overall, it looks pretty good. There's a number of UI, code and coding style issues there, which will need sorting.
> > 
> > As to coding style, please have a look at http://community.kde.org/Plasma/QMLStyle
> > I've pointed some of the issues out, but overall, this needs going over the whole code and fixing.
> > 
> > Nice to see this coming together, btw.
> > 
> > One thing: kde-workspace is frozen, and even if this is in the kmix repo, it might be too late to replace it in Plasma Desktop. What are the concrete plans here?

if it is in the kmix repo, then it doesn't matter that kde-workspace is frozen. it would be pretty trivial to add a check in the systemtray to see if the kmix applet exists on the system and if it does then show it (and for kmix to drop its system tray icon in that particular case ..)

this reminds me of the "applet replaces systray icon" feature we have discussed in the past so that the application does not need to worry about this. sth for PW2, perhaps: an optional entry in the .desktop file that says "this applet replaces that systray icon", e.g.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38344
-----------------------------------------------------------


On Aug. 22, 2013, 1:31 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 1:31 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/CMakeLists.txt 5e1dc90 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/27aaa1e9/attachment.html>

From aseigo at kde.org  Thu Aug 22 22:45:58 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Thu, 22 Aug 2013 22:45:58 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822133128.13050.1423@vidsolbach.de>
References: <20130822133128.13050.1423@vidsolbach.de>
Message-ID: <20130822224558.1720.68795@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38390
-----------------------------------------------------------



File Attachment: Applet Config Options
<http://git.reviewboard.kde.org//r/112208/#fcomment71>
    Do we even really need horizontal/vertical orientation for the sliders as a configuration option? Other than "because we can" what is the actual end user value of that option?

- Aaron J. Seigo


On Aug. 22, 2013, 1:31 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 1:31 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/CMakeLists.txt 5e1dc90 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130822/b5f4e983/attachment.html>

From aseigo at kde.org  Thu Aug 22 23:22:14 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Fri, 23 Aug 2013 01:22:14 +0200
Subject: naming the next major release
In-Reply-To: <CACpu0265mmx86Rib_r5zeAjVxnZSfT_n=74QKYN1fUkm-KYCUA@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom>
 <CACpu0265mmx86Rib_r5zeAjVxnZSfT_n=74QKYN1fUkm-KYCUA@mail.gmail.com>
Message-ID: <3296793.leKlXjeYhh@freedom>

On Wednesday, August 21, 2013 20:40:09 Valorie Zimmerman wrote:
> audience, such as the KDE-Community list. KDE-devel, KDE-core-devel and
> KDE-Promo are some of the other possibilities to at least ping about a such
> an important conversation happening.

Yes, I have a purposeful habit of doing exactly that. We take very few Big 
Decisions of this sort without consulting the wider KDE community after we?ve 
had reasonable discussion here (so we sound like we know what we?re talking 
about ;) but before committing (publicly or to ourselves).

.. and I haven?t dropped this thread, I?ve just been stupid busy with Chinese 
hardware, Canadian sons and Swiss daughters this week :)

I?ll catch up with round 2 of my thoughts next week.

Thank you to everyone who has weighed in so far, I?m starting to see threads 
of consensus already and I resonate strongly with a  lot of what has been 
written by you already .. cool :)

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/c8a9ce8f/attachment-0001.sig>

From ervin at kde.org  Fri Aug 23 08:44:04 2013
From: ervin at kde.org (Kevin Ottens)
Date: Fri, 23 Aug 2013 10:44:04 +0200
Subject: Smart d-ptr in Plasma
In-Reply-To: <2310761.0GqEbvDB2V@martin-thinkpad>
References: <10281060.0jD9AZhZHb@drako> <2845685.rH1ZuGL1Pe@wintermute>
 <2310761.0GqEbvDB2V@martin-thinkpad>
Message-ID: <17659844.ZqUPKhx6NQ@wintermute>

On Thursday 22 August 2013 19:11:09 Martin Graesslin wrote:
> Maybe it would even be an idea for an own (tier 0) framework which could
> contain useful C++11 magic? I guess we will soon have more useful C++11
> stuff which might make sense to be used in more places.

Wouldn't solve much though. The tier 1 frameworks couldn't make use of it 
because we want 3rd parties to just be able to pick them and do stuff 
immediately with no extra dependency. So that'd make by construction for 
another tier 1 framework... I'm not sure we need more of those...

Regards.
-- 
K?vin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/5eac90e8/attachment.sig>

From notmart at gmail.com  Fri Aug 23 09:50:20 2013
From: notmart at gmail.com (Marco Martin)
Date: Fri, 23 Aug 2013 11:50:20 +0200
Subject: naming the next major release
In-Reply-To: <CAODYyLYthtWg_1Yj1E5f5nvvokSb-1w+AaS9JvCVYcaH34S8fQ@mail.gmail.com>
References: <137711932.oj8iDjKShl@freedom>
 <CAGeFrHDhu4_SgD8+oCXDgr_bfJ=ixfFmc=SyrV3A3bdT6+KPkg@mail.gmail.com>
 <CAODYyLYthtWg_1Yj1E5f5nvvokSb-1w+AaS9JvCVYcaH34S8fQ@mail.gmail.com>
Message-ID: <4407658.8sGEaQzegb@deimos.diaunet>

On Thursday 22 August 2013 23:20:11 Giorgos Tsiapaliokas wrote:
> KDE, for instance the most references in plasma active are
> "Plasma Active" and not "KDE Plasma Active", but PA doesn't have any
> distance from KDE. I believe that projects take some distance
> from "KDE" when they stop referring to it and not when they remove the
> "KDE" word, but that is just me of course :)

To me is the contrary,.. what is now plasma+kwin gets seenn by people as "the" 
KDE

if becomes just "Plasma", then become "a" desktop by KDE, not "the" KDE 
desktop, would be more a normal citizen,
making room for instance Razor+Lxde to become another desktop by KDE

-- 
Marco Martin

From igor.poboiko at gmail.com  Fri Aug 23 11:19:38 2013
From: igor.poboiko at gmail.com (Igor Poboiko)
Date: Fri, 23 Aug 2013 11:19:38 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822224558.1720.68795@vidsolbach.de>
References: <20130822224558.1720.68795@vidsolbach.de>
Message-ID: <20130823111938.22117.13524@vidsolbach.de>



> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
> > File Attachment: Applet Config Options
> > <http://git.reviewboard.kde.org/r/112208/#fcomment72>
> >
> >     Do we even really need horizontal/vertical orientation for the sliders as a configuration option? Other than "because we can" what is the actual end user value of that option?

AFAIK MacOS and Windows use vertical slider orientation, while Gnome&Ubuntu use horizontal sliders. Some people may be used to one of the variants and find another one inconvenient. So why not let them choose? There is not that many options in that applet anyways.


- Igor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38390
-----------------------------------------------------------


On Aug. 22, 2013, 1:31 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 1:31 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/CMakeLists.txt 5e1dc90 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/3dfb2813/attachment.html>

From notmart at gmail.com  Fri Aug 23 12:18:49 2013
From: notmart at gmail.com (Marco Martin)
Date: Fri, 23 Aug 2013 12:18:49 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822224558.1720.68795@vidsolbach.de>
References: <20130822224558.1720.68795@vidsolbach.de>
Message-ID: <20130823121849.19639.31841@vidsolbach.de>



> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
> > File Attachment: Applet Config Options
> > <http://git.reviewboard.kde.org/r/112208/#fcomment73>
> >
> >     Do we even really need horizontal/vertical orientation for the sliders as a configuration option? Other than "because we can" what is the actual end user value of that option?
> 
> Igor Poboiko wrote:
>     AFAIK MacOS and Windows use vertical slider orientation, while Gnome&Ubuntu use horizontal sliders. Some people may be used to one of the variants and find another one inconvenient. So why not let them choose? There is not that many options in that applet anyways.

i would prefer not having that as well, plasma appletswere designed to make easy for the user to change a plasmoid with another if they don't like it, rther than making the developer maintain many different code paths of which some combination will always go untested...

one thing without a config dialog that may be tried is adjusting horizontal or vertical how better suits the size of the config dialog at the moment...


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38390
-----------------------------------------------------------


On Aug. 22, 2013, 1:31 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 1:31 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/CMakeLists.txt 5e1dc90 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/e531b576/attachment.html>

From sebas at kde.org  Fri Aug 23 12:37:59 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Fri, 23 Aug 2013 12:37:59 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822224558.1720.68795@vidsolbach.de>
References: <20130822224558.1720.68795@vidsolbach.de>
Message-ID: <20130823123759.32331.91701@vidsolbach.de>



> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
> > File Attachment: Applet Config Options
> > <http://git.reviewboard.kde.org/r/112208/#fcomment74>
> >
> >     Do we even really need horizontal/vertical orientation for the sliders as a configuration option? Other than "because we can" what is the actual end user value of that option?
> 
> Igor Poboiko wrote:
>     AFAIK MacOS and Windows use vertical slider orientation, while Gnome&Ubuntu use horizontal sliders. Some people may be used to one of the variants and find another one inconvenient. So why not let them choose? There is not that many options in that applet anyways.
> 
> Marco Martin wrote:
>     i would prefer not having that as well, plasma appletswere designed to make easy for the user to change a plasmoid with another if they don't like it, rther than making the developer maintain many different code paths of which some combination will always go untested...
>     
>     one thing without a config dialog that may be tried is adjusting horizontal or vertical how better suits the size of the config dialog at the moment...

Case in point: The use of QtHorizontal and QtVertical throughout the code suggest to me that the horizontal case wasn't really tested in the submitted version. Kinda supports Marco's fear of untested code pathes. ;-)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38390
-----------------------------------------------------------


On Aug. 22, 2013, 1:31 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 1:31 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/CMakeLists.txt 5e1dc90 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/a872c4a4/attachment-0001.html>

From bhush94 at gmail.com  Fri Aug 23 12:56:25 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Fri, 23 Aug 2013 12:56:25 -0000
Subject: Review Request 112223: Enable FileBrowser DataEngine
Message-ID: <20130823125625.12187.32094@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112223/
-----------------------------------------------------------

Review request for kde-workspace and Plasma.


Description
-------

Enable FileBrowser DataEngine on top of KF5


Diffs
-----

  plasma/generic/dataengines/CMakeLists.txt 579e929 
  plasma/generic/dataengines/filebrowser/CMakeLists.txt 528414f 
  plasma/generic/dataengines/filebrowser/filebrowserengine.h 49819a9 
  plasma/generic/dataengines/filebrowser/filebrowserengine.cpp 2387bee 

Diff: http://git.reviewboard.kde.org/r/112223/diff/


Testing
-------

Compiles = check
Plasma Engine explorer = Check


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/2cb396cf/attachment.html>

From de.meyer.maarten at gmail.com  Fri Aug 23 13:00:09 2013
From: de.meyer.maarten at gmail.com (Maarten De Meyer)
Date: Fri, 23 Aug 2013 15:00:09 +0200
Subject: Smart d-ptr in Plasma
In-Reply-To: <17659844.ZqUPKhx6NQ@wintermute>
References: <10281060.0jD9AZhZHb@drako> <2845685.rH1ZuGL1Pe@wintermute>
 <2310761.0GqEbvDB2V@martin-thinkpad>
 <17659844.ZqUPKhx6NQ@wintermute>
Message-ID: <CAP2sfJM2yAOo-x3+pijYJCb6+8dXboa6KgiHk5Z1OxB3Kxsmgw@mail.gmail.com>

On 23 August 2013 10:44, Kevin Ottens <ervin at kde.org> wrote:
> On Thursday 22 August 2013 19:11:09 Martin Graesslin wrote:
>> Maybe it would even be an idea for an own (tier 0) framework which could
>> contain useful C++11 magic? I guess we will soon have more useful C++11
>> stuff which might make sense to be used in more places.
>
> Wouldn't solve much though. The tier 1 frameworks couldn't make use of it
> because we want 3rd parties to just be able to pick them and do stuff
> immediately with no extra dependency. So that'd make by construction for
> another tier 1 framework... I'm not sure we need more of those...

And what about putting it directly in Qt? I would like to use this in
non KDE projects.
Note: I'm not sure about the acceptance of c++11 code in Qt.

Maarten

From null at kde.org  Fri Aug 23 13:05:40 2013
From: null at kde.org (Commit Hook)
Date: Fri, 23 Aug 2013 13:05:40 -0000
Subject: Review Request 112223: Enable FileBrowser DataEngine
In-Reply-To: <20130823125625.12187.32094@vidsolbach.de>
References: <20130823125625.12187.32094@vidsolbach.de>
Message-ID: <20130823130540.20042.93428@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112223/#review38435
-----------------------------------------------------------


This review has been submitted with commit 82b3692a6854c61c89dce500e84593363ed8a9e1 by Bhushan Shah to branch frameworks-scratch.

- Commit Hook


On Aug. 23, 2013, 12:56 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112223/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 12:56 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Description
> -------
> 
> Enable FileBrowser DataEngine on top of KF5
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt 579e929 
>   plasma/generic/dataengines/filebrowser/CMakeLists.txt 528414f 
>   plasma/generic/dataengines/filebrowser/filebrowserengine.h 49819a9 
>   plasma/generic/dataengines/filebrowser/filebrowserengine.cpp 2387bee 
> 
> Diff: http://git.reviewboard.kde.org/r/112223/diff/
> 
> 
> Testing
> -------
> 
> Compiles = check
> Plasma Engine explorer = Check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/a949b11a/attachment.html>

From null at kde.org  Fri Aug 23 13:05:43 2013
From: null at kde.org (Commit Hook)
Date: Fri, 23 Aug 2013 13:05:43 -0000
Subject: Review Request 112223: Enable FileBrowser DataEngine
In-Reply-To: <20130823125625.12187.32094@vidsolbach.de>
References: <20130823125625.12187.32094@vidsolbach.de>
Message-ID: <20130823130543.20045.12909@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112223/
-----------------------------------------------------------

(Updated Aug. 23, 2013, 1:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for kde-workspace and Plasma.


Description
-------

Enable FileBrowser DataEngine on top of KF5


Diffs
-----

  plasma/generic/dataengines/CMakeLists.txt 579e929 
  plasma/generic/dataengines/filebrowser/CMakeLists.txt 528414f 
  plasma/generic/dataengines/filebrowser/filebrowserengine.h 49819a9 
  plasma/generic/dataengines/filebrowser/filebrowserengine.cpp 2387bee 

Diff: http://git.reviewboard.kde.org/r/112223/diff/


Testing
-------

Compiles = check
Plasma Engine explorer = Check


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/46a090e3/attachment.html>

From ervin at kde.org  Fri Aug 23 13:13:07 2013
From: ervin at kde.org (Kevin Ottens)
Date: Fri, 23 Aug 2013 15:13:07 +0200
Subject: Smart d-ptr in Plasma
In-Reply-To: <CAP2sfJM2yAOo-x3+pijYJCb6+8dXboa6KgiHk5Z1OxB3Kxsmgw@mail.gmail.com>
References: <10281060.0jD9AZhZHb@drako> <17659844.ZqUPKhx6NQ@wintermute>
 <CAP2sfJM2yAOo-x3+pijYJCb6+8dXboa6KgiHk5Z1OxB3Kxsmgw@mail.gmail.com>
Message-ID: <4871444.6MponFQoji@wintermute>

On Friday 23 August 2013 15:00:09 Maarten De Meyer wrote:
> On 23 August 2013 10:44, Kevin Ottens <ervin at kde.org> wrote:
> > On Thursday 22 August 2013 19:11:09 Martin Graesslin wrote:
> >> Maybe it would even be an idea for an own (tier 0) framework which could
> >> contain useful C++11 magic? I guess we will soon have more useful C++11
> >> stuff which might make sense to be used in more places.
> > 
> > Wouldn't solve much though. The tier 1 frameworks couldn't make use of it
> > because we want 3rd parties to just be able to pick them and do stuff
> > immediately with no extra dependency. So that'd make by construction for
> > another tier 1 framework... I'm not sure we need more of those...
> 
> And what about putting it directly in Qt? I would like to use this in
> non KDE projects.

KCoreAddons will be easily available to non KDE projects. :-)

> Note: I'm not sure about the acceptance of c++11 code in Qt.

I think this one would have slim chances, but yes that's another possibility 
indeed. I'd approach Thiago or Olivier to get their opinion first though.

Regards.
-- 
K?vin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/fb6dff45/attachment.sig>

From kok3rs at gmail.com  Fri Aug 23 18:27:12 2013
From: kok3rs at gmail.com (Antonis Tsiapaliokas)
Date: Fri, 23 Aug 2013 21:27:12 +0300
Subject: naming the next major release
In-Reply-To: <4407658.8sGEaQzegb@deimos.diaunet>
References: <137711932.oj8iDjKShl@freedom>
 <CAGeFrHDhu4_SgD8+oCXDgr_bfJ=ixfFmc=SyrV3A3bdT6+KPkg@mail.gmail.com>
 <CAODYyLYthtWg_1Yj1E5f5nvvokSb-1w+AaS9JvCVYcaH34S8fQ@mail.gmail.com>
 <4407658.8sGEaQzegb@deimos.diaunet>
Message-ID: <CAOpJKyy-A4LU04HVPL0mW5n9UVAbgFPvBw5-FEMoHLqvUp+PtQ@mail.gmail.com>

Hello to all,


> To me is the contrary,.. what is now plasma+kwin gets seenn by people as
> "the"
> KDE
>
> if becomes just "Plasma", then become "a" desktop by KDE, not "the" KDE
> desktop, would be more a normal citizen,
> making room for instance Razor+Lxde to become another desktop by KDE

+1

+1 for "Plasma", without "KDE".

Regards,
Antonis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/6162d129/attachment.html>

From huzheng001 at gmail.com  Sat Aug 24 07:36:43 2013
From: huzheng001 at gmail.com (Hu Zheng)
Date: Sat, 24 Aug 2013 07:36:43 -0000
Subject: Review Request 111849: custom first week for plasmaclock.
In-Reply-To: <20130820090003.12422.74634@vidsolbach.de>
References: <20130820090003.12422.74634@vidsolbach.de>
Message-ID: <20130824073643.5671.12993@vidsolbach.de>



> On Aug. 20, 2013, 9 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> > isn't this duplicating the functionality in system settings ? locale ? country/region & language ? calendar ??first day of the week?

No, them are different function!


- Hu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/#review38188
-----------------------------------------------------------


On Aug. 20, 2013, 4:37 a.m., Hu Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111849/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 4:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/111849/diff/
> 
> 
> Testing
> -------
> 
> cd kde-workspace-4.10.5/libs/plasmaclock
> patch -p1 < customfirstweek.patch
> 
> The save configuration codes are not very beautiful, but it works fine!
> 
> 
> File Attachments
> ----------------
> 
> patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch
> another patch, use custom config file.
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch
> 
> 
> Thanks,
> 
> Hu Zheng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/0ba82e03/attachment-0001.html>

From huzheng001 at gmail.com  Sat Aug 24 07:46:06 2013
From: huzheng001 at gmail.com (Hu Zheng)
Date: Sat, 24 Aug 2013 07:46:06 -0000
Subject: Review Request 111849: custom first week for plasmaclock.
In-Reply-To: <20130820090318.12890.50154@vidsolbach.de>
References: <20130820090318.12890.50154@vidsolbach.de>
Message-ID: <20130824074606.6651.7841@vidsolbach.de>



> On Aug. 20, 2013, 9:03 a.m., Sebastian K?gler wrote:
> > * The patch is not correctly submitted, it's submitted as screenshot, not as patch, that makes it impossible to review
> > * You didn't attach a screenshot of the UI
> > * Checking wether a patch applies is not testing it
> > * The clock's config is not the right place for this, it should rather be a global calendar setting
> > * kde-workspace is frozen, this could, *at best* go into Plasma2 (which this patch is not about)
> > 
> > Please read and address my comments more carefully.

If I submit it as a patch, it will need a Parent Diff, which I don't have in fact.
The screenshot is added!
You can see the new patch file, it changed to use custom config file.


- Hu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/#review38189
-----------------------------------------------------------


On Aug. 20, 2013, 4:37 a.m., Hu Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111849/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 4:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/111849/diff/
> 
> 
> Testing
> -------
> 
> cd kde-workspace-4.10.5/libs/plasmaclock
> patch -p1 < customfirstweek.patch
> 
> The save configuration codes are not very beautiful, but it works fine!
> 
> 
> File Attachments
> ----------------
> 
> patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch
> another patch, use custom config file.
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch
> 
> 
> Thanks,
> 
> Hu Zheng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/15ff7866/attachment.html>

From huzheng001 at gmail.com  Sat Aug 24 07:46:23 2013
From: huzheng001 at gmail.com (Hu Zheng)
Date: Sat, 24 Aug 2013 07:46:23 -0000
Subject: Review Request 111849: custom first week for plasmaclock.
In-Reply-To: <20130820043728.8828.21877@vidsolbach.de>
References: <20130820043728.8828.21877@vidsolbach.de>
Message-ID: <20130824074623.6651.54558@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/
-----------------------------------------------------------

(Updated Aug. 24, 2013, 7:46 a.m.)


Review request for Plasma.


Changes
-------

Screenshot.


Description
-------

In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/111849/diff/


Testing
-------

cd kde-workspace-4.10.5/libs/plasmaclock
patch -p1 < customfirstweek.patch

The save configuration codes are not very beautiful, but it works fine!


File Attachments (updated)
----------------

patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch
another patch, use custom config file.
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch
screenshot
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/customweek.png


Thanks,

Hu Zheng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/0e42fbbd/attachment.html>

From harald.hvaal at gmail.com  Sat Aug 24 09:52:21 2013
From: harald.hvaal at gmail.com (Harald Hvaal)
Date: Sat, 24 Aug 2013 09:52:21 -0000
Subject: Review Request 112236: krunner: Add the full name of completion
 matches to history
Message-ID: <20130824095221.18482.38867@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112236/
-----------------------------------------------------------

Review request for kde-workspace and Plasma.


Description
-------

Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.

This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
Exact matches are added as-is.

example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.


Diffs
-----

  krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 
  kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 

Diff: http://git.reviewboard.kde.org/r/112236/diff/


Testing
-------


Thanks,

Harald Hvaal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/3aa696dc/attachment.html>

From thomas.luebking at gmail.com  Sat Aug 24 10:08:58 2013
From: thomas.luebking at gmail.com (=?utf-8?q?Thomas_L=C3=BCbking?=)
Date: Sat, 24 Aug 2013 10:08:58 -0000
Subject: Review Request 112236: krunner: Add the full name of completion
 matches to history
In-Reply-To: <20130824095221.18482.38867@vidsolbach.de>
References: <20130824095221.18482.38867@vidsolbach.de>
Message-ID: <20130824100858.21472.49541@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112236/#review38466
-----------------------------------------------------------



kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/112236/#comment28473>

    ... ;-)


- Thomas L?bking


On Aug. 24, 2013, 9:52 a.m., Harald Hvaal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112236/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 9:52 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Description
> -------
> 
> Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.
> 
> This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
> Exact matches are added as-is.
> 
> example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.
> 
> 
> Diffs
> -----
> 
>   krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 
>   kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 
> 
> Diff: http://git.reviewboard.kde.org/r/112236/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/c5c66fda/attachment-0001.html>

From harald.hvaal at gmail.com  Sat Aug 24 10:17:01 2013
From: harald.hvaal at gmail.com (Harald Hvaal)
Date: Sat, 24 Aug 2013 10:17:01 -0000
Subject: Review Request 112236: krunner: Add the full name of completion
 matches to history
In-Reply-To: <20130824100858.21472.49541@vidsolbach.de>
References: <20130824100858.21472.49541@vidsolbach.de>
Message-ID: <20130824101701.22696.70907@vidsolbach.de>



> On Aug. 24, 2013, 10:08 a.m., Thomas L?bking wrote:
> > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274
> > <http://git.reviewboard.kde.org/r/112236/diff/1/?file=184315#file184315line274>
> >
> >     ... ;-)

yeah, not sure what happened with post-review here, but it's definitely not part of the actual commit :)


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112236/#review38466
-----------------------------------------------------------


On Aug. 24, 2013, 9:52 a.m., Harald Hvaal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112236/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 9:52 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Description
> -------
> 
> Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.
> 
> This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
> Exact matches are added as-is.
> 
> example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.
> 
> 
> Diffs
> -----
> 
>   krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 
>   kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 
> 
> Diff: http://git.reviewboard.kde.org/r/112236/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/e5c6d41c/attachment.html>

From mgraesslin at kde.org  Sat Aug 24 11:14:17 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Sat, 24 Aug 2013 11:14:17 -0000
Subject: Review Request 112236: krunner: Add the full name of completion
 matches to history
In-Reply-To: <20130824100858.21472.49541@vidsolbach.de>
References: <20130824100858.21472.49541@vidsolbach.de>
Message-ID: <20130824111417.6290.58019@vidsolbach.de>



> On Aug. 24, 2013, 12:08 p.m., Thomas L?bking wrote:
> > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274
> > <http://git.reviewboard.kde.org/r/112236/diff/1/?file=184315#file184315line274>
> >
> >     ... ;-)
> 
> Harald Hvaal wrote:
>     yeah, not sure what happened with post-review here, but it's definitely not part of the actual commit :)

post-review happily includes any changes you have in a tree. Always do git stash before using it ;-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112236/#review38466
-----------------------------------------------------------


On Aug. 24, 2013, 11:52 a.m., Harald Hvaal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112236/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 11:52 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Description
> -------
> 
> Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.
> 
> This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
> Exact matches are added as-is.
> 
> example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.
> 
> 
> Diffs
> -----
> 
>   krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 
>   kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 
> 
> Diff: http://git.reviewboard.kde.org/r/112236/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/6b13c23c/attachment.html>

From bhush94 at gmail.com  Sat Aug 24 14:00:29 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sat, 24 Aug 2013 14:00:29 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running" option in
 taskbar widget
Message-ID: <20130824140029.24210.31883@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/
-----------------------------------------------------------

Review request for kde-workspace, Plasma and Eike Hein.


Description
-------

Fix the crash in plasma-desktop caused by newer QML taskbar widget.

Simple steps to reproduce this crash.

1) Pin any task/application to taskbar using "show launcher when not running" option.
2) Close application.
3) Desktop crashes.

Reason :

1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 

  -> pointer to task is not null
  -> taskItem itself is not null
  -> scene is not null

2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.

Patch :

This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.


Diffs
-----

  plasma/desktop/applets/tasks/tasks.cpp c4aef4b 

Diff: http://git.reviewboard.kde.org/r/112241/diff/


Testing
-------

Testing

compilation - check
installation - check
plasmoidviewer - check
in panel - check
independently - check


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/3d780213/attachment.html>

From polentino911 at gmail.com  Sat Aug 24 15:07:08 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Sat, 24 Aug 2013 15:07:08 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822133128.13050.1423@vidsolbach.de>
References: <20130822133128.13050.1423@vidsolbach.de>
Message-ID: <20130824150708.30587.88172@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
-----------------------------------------------------------

(Updated Aug. 24, 2013, 3:07 p.m.)


Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.


Changes
-------

Update diff according to (almost all) the observations made so far.
Moved portions of code to be plasma-qml-style compliant :)


Description
-------

KMix qml applet.
As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
Differences from the old kmix tray:
* no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
* the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;

Known issues:
* there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
* no scroll events over the sliders too;
* if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
* resize doesn't work properly.


Diffs (updated)
-----

  plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
  plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112208/diff/


Testing
-------

Tested against master and works fine.


File Attachments
----------------

Default look
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
Menu Actions
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
Applet Config Options
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
Vertical Control
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png


Thanks,

Diego Casella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/e55de89c/attachment.html>

From polentino911 at gmail.com  Sat Aug 24 15:12:00 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Sat, 24 Aug 2013 15:12:00 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130824150708.30587.88172@vidsolbach.de>
References: <20130824150708.30587.88172@vidsolbach.de>
Message-ID: <20130824151200.32256.88319@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
-----------------------------------------------------------

(Updated Aug. 24, 2013, 3:11 p.m.)


Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.


Changes
-------

sorry, forgot to add a screenshot for the updated version.


Description
-------

KMix qml applet.
As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
Differences from the old kmix tray:
* no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
* the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;

Known issues:
* there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
* no scroll events over the sliders too;
* if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
* resize doesn't work properly.


Diffs
-----

  plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
  plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112208/diff/


Testing
-------

Tested against master and works fine.


File Attachments (updated)
----------------

Default look
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
Menu Actions
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
Applet Config Options
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
Vertical Control
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
ToolButton label and Config page after updates
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png


Thanks,

Diego Casella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/c4dc9679/attachment-0001.html>

From hein at kde.org  Sat Aug 24 15:17:26 2013
From: hein at kde.org (Eike Hein)
Date: Sat, 24 Aug 2013 15:17:26 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running"
 option in taskbar widget
In-Reply-To: <20130824140029.24210.31883@vidsolbach.de>
References: <20130824140029.24210.31883@vidsolbach.de>
Message-ID: <20130824151726.32727.94953@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/#review38481
-----------------------------------------------------------


Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint.

Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause.

- Eike Hein


On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112241/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 2 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> Fix the crash in plasma-desktop caused by newer QML taskbar widget.
> 
> Simple steps to reproduce this crash.
> 
> 1) Pin any task/application to taskbar using "show launcher when not running" option.
> 2) Close application.
> 3) Desktop crashes.
> 
> Reason :
> 
> 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 
> 
>   -> pointer to task is not null
>   -> taskItem itself is not null
>   -> scene is not null
> 
> 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
> 
> Patch :
> 
> This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/tasks.cpp c4aef4b 
> 
> Diff: http://git.reviewboard.kde.org/r/112241/diff/
> 
> 
> Testing
> -------
> 
> Testing
> 
> compilation - check
> installation - check
> plasmoidviewer - check
> in panel - check
> independently - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/539d0dcc/attachment.html>

From bhush94 at gmail.com  Sat Aug 24 15:22:01 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sat, 24 Aug 2013 15:22:01 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running"
 option in taskbar widget
In-Reply-To: <20130824151726.32727.94953@vidsolbach.de>
References: <20130824151726.32727.94953@vidsolbach.de>
Message-ID: <20130824152201.418.46554@vidsolbach.de>



> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint.
> > 
> > Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause.

Are you sure that this happens on 32 bit only?


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/#review38481
-----------------------------------------------------------


On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112241/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 2 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> Fix the crash in plasma-desktop caused by newer QML taskbar widget.
> 
> Simple steps to reproduce this crash.
> 
> 1) Pin any task/application to taskbar using "show launcher when not running" option.
> 2) Close application.
> 3) Desktop crashes.
> 
> Reason :
> 
> 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 
> 
>   -> pointer to task is not null
>   -> taskItem itself is not null
>   -> scene is not null
> 
> 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
> 
> Patch :
> 
> This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/tasks.cpp c4aef4b 
> 
> Diff: http://git.reviewboard.kde.org/r/112241/diff/
> 
> 
> Testing
> -------
> 
> Testing
> 
> compilation - check
> installation - check
> plasmoidviewer - check
> in panel - check
> independently - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/8580caf8/attachment.html>

From hein at kde.org  Sat Aug 24 15:28:03 2013
From: hein at kde.org (Eike Hein)
Date: Sat, 24 Aug 2013 15:28:03 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running"
 option in taskbar widget
In-Reply-To: <20130824151726.32727.94953@vidsolbach.de>
References: <20130824151726.32727.94953@vidsolbach.de>
Message-ID: <20130824152803.588.7577@vidsolbach.de>



> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint.
> > 
> > Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause.
> 
> Bhushan Shah wrote:
>     Are you sure that this happens on 32 bit only?

No, I'm not - except I can't reproduce it on any of my 64 bit machines, and I have to assume if it were a widespread bug, the number of reports we'd be getting would be much, much higher. Note that we didn't even get any reports through any of the pre-releases about this, AFAIR.

I'm typing this from a cellphone right now, but I hope when I get home tonight I'll finally get around to setting up a 32 bit VM, and I'm hoping it'll crash there so I can throw all the gdb/valgrind/asan at it we got :).


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/#review38481
-----------------------------------------------------------


On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112241/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 2 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> Fix the crash in plasma-desktop caused by newer QML taskbar widget.
> 
> Simple steps to reproduce this crash.
> 
> 1) Pin any task/application to taskbar using "show launcher when not running" option.
> 2) Close application.
> 3) Desktop crashes.
> 
> Reason :
> 
> 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 
> 
>   -> pointer to task is not null
>   -> taskItem itself is not null
>   -> scene is not null
> 
> 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
> 
> Patch :
> 
> This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/tasks.cpp c4aef4b 
> 
> Diff: http://git.reviewboard.kde.org/r/112241/diff/
> 
> 
> Testing
> -------
> 
> Testing
> 
> compilation - check
> installation - check
> plasmoidviewer - check
> in panel - check
> independently - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/f0dcf8da/attachment.html>

From thomas.luebking at gmail.com  Sat Aug 24 15:30:38 2013
From: thomas.luebking at gmail.com (=?utf-8?q?Thomas_L=C3=BCbking?=)
Date: Sat, 24 Aug 2013 15:30:38 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running"
 option in taskbar widget
In-Reply-To: <20130824151726.32727.94953@vidsolbach.de>
References: <20130824151726.32727.94953@vidsolbach.de>
Message-ID: <20130824153038.907.20883@vidsolbach.de>



> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint.
> > 
> > Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause.
> 
> Bhushan Shah wrote:
>     Are you sure that this happens on 32 bit only?
> 
> Eike Hein wrote:
>     No, I'm not - except I can't reproduce it on any of my 64 bit machines, and I have to assume if it were a widespread bug, the number of reports we'd be getting would be much, much higher. Note that we didn't even get any reports through any of the pre-releases about this, AFAIR.
>     
>     I'm typing this from a cellphone right now, but I hope when I get home tonight I'll finally get around to setting up a 32 bit VM, and I'm hoping it'll crash there so I can throw all the gdb/valgrind/asan at it we got :).

What bug and is "WId" involved?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/#review38481
-----------------------------------------------------------


On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112241/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 2 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> Fix the crash in plasma-desktop caused by newer QML taskbar widget.
> 
> Simple steps to reproduce this crash.
> 
> 1) Pin any task/application to taskbar using "show launcher when not running" option.
> 2) Close application.
> 3) Desktop crashes.
> 
> Reason :
> 
> 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 
> 
>   -> pointer to task is not null
>   -> taskItem itself is not null
>   -> scene is not null
> 
> 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
> 
> Patch :
> 
> This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/tasks.cpp c4aef4b 
> 
> Diff: http://git.reviewboard.kde.org/r/112241/diff/
> 
> 
> Testing
> -------
> 
> Testing
> 
> compilation - check
> installation - check
> plasmoidviewer - check
> in panel - check
> independently - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/229c7601/attachment-0001.html>

From bhush94 at gmail.com  Sat Aug 24 15:32:16 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sat, 24 Aug 2013 15:32:16 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running"
 option in taskbar widget
In-Reply-To: <20130824151726.32727.94953@vidsolbach.de>
References: <20130824151726.32727.94953@vidsolbach.de>
Message-ID: <20130824153216.1186.67524@vidsolbach.de>



> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint.
> > 
> > Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause.
> 
> Bhushan Shah wrote:
>     Are you sure that this happens on 32 bit only?
> 
> Eike Hein wrote:
>     No, I'm not - except I can't reproduce it on any of my 64 bit machines, and I have to assume if it were a widespread bug, the number of reports we'd be getting would be much, much higher. Note that we didn't even get any reports through any of the pre-releases about this, AFAIR.
>     
>     I'm typing this from a cellphone right now, but I hope when I get home tonight I'll finally get around to setting up a 32 bit VM, and I'm hoping it'll crash there so I can throw all the gdb/valgrind/asan at it we got :).
> 
> Thomas L?bking wrote:
>     What bug and is "WId" involved?

https://bugs.kde.org/show_bug.cgi?id=322283


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/#review38481
-----------------------------------------------------------


On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112241/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 2 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> Fix the crash in plasma-desktop caused by newer QML taskbar widget.
> 
> Simple steps to reproduce this crash.
> 
> 1) Pin any task/application to taskbar using "show launcher when not running" option.
> 2) Close application.
> 3) Desktop crashes.
> 
> Reason :
> 
> 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 
> 
>   -> pointer to task is not null
>   -> taskItem itself is not null
>   -> scene is not null
> 
> 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
> 
> Patch :
> 
> This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/tasks.cpp c4aef4b 
> 
> Diff: http://git.reviewboard.kde.org/r/112241/diff/
> 
> 
> Testing
> -------
> 
> Testing
> 
> compilation - check
> installation - check
> plasmoidviewer - check
> in panel - check
> independently - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/0f432f1d/attachment.html>

From hrvoje.senjan at gmail.com  Sat Aug 24 15:32:19 2013
From: hrvoje.senjan at gmail.com (Hrvoje Senjan)
Date: Sat, 24 Aug 2013 15:32:19 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running"
 option in taskbar widget
In-Reply-To: <20130824151726.32727.94953@vidsolbach.de>
References: <20130824151726.32727.94953@vidsolbach.de>
Message-ID: <20130824153219.1189.1938@vidsolbach.de>



> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint.
> > 
> > Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause.
> 
> Bhushan Shah wrote:
>     Are you sure that this happens on 32 bit only?
> 
> Eike Hein wrote:
>     No, I'm not - except I can't reproduce it on any of my 64 bit machines, and I have to assume if it were a widespread bug, the number of reports we'd be getting would be much, much higher. Note that we didn't even get any reports through any of the pre-releases about this, AFAIR.
>     
>     I'm typing this from a cellphone right now, but I hope when I get home tonight I'll finally get around to setting up a 32 bit VM, and I'm hoping it'll crash there so I can throw all the gdb/valgrind/asan at it we got :).
> 
> Thomas L?bking wrote:
>     What bug and is "WId" involved?
> 
> Bhushan Shah wrote:
>     https://bugs.kde.org/show_bug.cgi?id=322283

@Thomas
bug#322283


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/#review38481
-----------------------------------------------------------


On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112241/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 2 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> Fix the crash in plasma-desktop caused by newer QML taskbar widget.
> 
> Simple steps to reproduce this crash.
> 
> 1) Pin any task/application to taskbar using "show launcher when not running" option.
> 2) Close application.
> 3) Desktop crashes.
> 
> Reason :
> 
> 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 
> 
>   -> pointer to task is not null
>   -> taskItem itself is not null
>   -> scene is not null
> 
> 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
> 
> Patch :
> 
> This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/tasks.cpp c4aef4b 
> 
> Diff: http://git.reviewboard.kde.org/r/112241/diff/
> 
> 
> Testing
> -------
> 
> Testing
> 
> compilation - check
> installation - check
> plasmoidviewer - check
> in panel - check
> independently - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/782aafe4/attachment.html>

From polentino911 at gmail.com  Sat Aug 24 16:11:27 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Sat, 24 Aug 2013 16:11:27 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822224558.1720.68795@vidsolbach.de>
References: <20130822224558.1720.68795@vidsolbach.de>
Message-ID: <20130824161127.5455.28491@vidsolbach.de>



> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
> > File Attachment: Applet Config Options
> > <http://git.reviewboard.kde.org/r/112208/#fcomment77>
> >
> >     Do we even really need horizontal/vertical orientation for the sliders as a configuration option? Other than "because we can" what is the actual end user value of that option?
> 
> Igor Poboiko wrote:
>     AFAIK MacOS and Windows use vertical slider orientation, while Gnome&Ubuntu use horizontal sliders. Some people may be used to one of the variants and find another one inconvenient. So why not let them choose? There is not that many options in that applet anyways.
> 
> Marco Martin wrote:
>     i would prefer not having that as well, plasma appletswere designed to make easy for the user to change a plasmoid with another if they don't like it, rther than making the developer maintain many different code paths of which some combination will always go untested...
>     
>     one thing without a config dialog that may be tried is adjusting horizontal or vertical how better suits the size of the config dialog at the moment...
> 
> Sebastian K?gler wrote:
>     Case in point: The use of QtHorizontal and QtVertical throughout the code suggest to me that the horizontal case wasn't really tested in the submitted version. Kinda supports Marco's fear of untested code pathes. ;-)

I've tried to keep compatibility with the "old" KMix interface, which lets you choose whether you want horizontal or vertical sliders.

@Marco You are completely right, but we don't want to end with two applets like "KMix with horizontal sliders" and "KMix with vertical sliders" right? We should try to get a reliable procedure to retrieve the size of the elements in the listview, which is the root of my issues with the applet resize.

@Sebas Care to explain? Both the cases have been tested.


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38390
-----------------------------------------------------------


On Aug. 24, 2013, 3:11 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 3:11 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/1f8a0156/attachment-0001.html>

From polentino911 at gmail.com  Sat Aug 24 16:12:06 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Sat, 24 Aug 2013 16:12:06 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822143440.22771.25603@vidsolbach.de>
References: <20130822143440.22771.25603@vidsolbach.de>
Message-ID: <20130824161206.5455.95160@vidsolbach.de>



> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > File Attachment: Menu Actions
> > <http://git.reviewboard.kde.org/r/112208/#fcomment75>
> >
> >     Maybe we could align this in the same way as the batter applet does?

The menu comes from a right-click from within the widget -not the applet icon in the panel-, but i forgot to check the "include mouse pointer" option when I took that screenshot :)


> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > File Attachment: Vertical Control
> > <http://git.reviewboard.kde.org/r/112208/#fcomment76>
> >
> >     Clipping

This falls in the "known issues -> resizing" stuff: it is kinda hard to get the sizes right but the applet itself is resizeable so, until we get this right, the user can expand it as much as needed to fix it. That operation needs to be done only once because then plasma keeps track of it, so it would be a single-time hassle.. what do you think?


> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > plasma/CMakeLists.txt, line 2
> > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183950#file183950line2>
> >
> >     use the installPackage macro for this and the following line

First it needs to be exported, since it lives inside kde-workspace/plasma/CMakeLists.txt ;)


> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > plasma/kmix-applet-qml/contents/ui/ButtonBar.qml, line 77
> > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183952#file183952line77>
> >
> >     Bad naming, I got confused while reading this, as it reads like "run this program".
> >     
> >     Maybe rename to something more descriptive?

It does run an external program indeed. Changed the name, I hope this one is more descriptive.


> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 80
> > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line80>
> >
> >     PlasmaCore.IconItem does this for you

Hmm are you sure? PlasmaCore.Svg is a non graphical item which is used to get svg elements and then to forward them to the applet popup icon and tooltip, while PlasmaCore.IconItem creates a graphical item, which is not needed here.


> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 105
> > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line105>
> >
> >     I wonder if this can't be done without the roundtrip, i.e. directly use the icon name?

Tooltips removed, anyway that code is used few lines below to set the popup applet icon and its tooltip.
Now the interesting part: I've managed to remove the temporary QIcon() creation when setting the popup icon tooltip data, but I couldn't do the same with the popup icon because otherwise the icon wont work ... Something broken in libplasma perhaps?


> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > plasma/kmix-applet-qml/contents/ui/VerticalControl.qml, line 79
> > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183956#file183956line79>
> >
> >     use PlasmaCore.IconItem

See the comment above.


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38344
-----------------------------------------------------------


On Aug. 24, 2013, 3:11 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 3:11 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/205765a1/attachment.html>

From sebas at kde.org  Sat Aug 24 17:57:57 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Sat, 24 Aug 2013 17:57:57 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822224558.1720.68795@vidsolbach.de>
References: <20130822224558.1720.68795@vidsolbach.de>
Message-ID: <20130824175757.21436.38495@vidsolbach.de>



> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
> > File Attachment: Applet Config Options
> > <http://git.reviewboard.kde.org/r/112208/#fcomment78>
> >
> >     Do we even really need horizontal/vertical orientation for the sliders as a configuration option? Other than "because we can" what is the actual end user value of that option?
> 
> Igor Poboiko wrote:
>     AFAIK MacOS and Windows use vertical slider orientation, while Gnome&Ubuntu use horizontal sliders. Some people may be used to one of the variants and find another one inconvenient. So why not let them choose? There is not that many options in that applet anyways.
> 
> Marco Martin wrote:
>     i would prefer not having that as well, plasma appletswere designed to make easy for the user to change a plasmoid with another if they don't like it, rther than making the developer maintain many different code paths of which some combination will always go untested...
>     
>     one thing without a config dialog that may be tried is adjusting horizontal or vertical how better suits the size of the config dialog at the moment...
> 
> Sebastian K?gler wrote:
>     Case in point: The use of QtHorizontal and QtVertical throughout the code suggest to me that the horizontal case wasn't really tested in the submitted version. Kinda supports Marco's fear of untested code pathes. ;-)
> 
> Diego Casella wrote:
>     I've tried to keep compatibility with the "old" KMix interface, which lets you choose whether you want horizontal or vertical sliders.
>     
>     @Marco You are completely right, but we don't want to end with two applets like "KMix with horizontal sliders" and "KMix with vertical sliders" right? We should try to get a reliable procedure to retrieve the size of the elements in the listview, which is the root of my issues with the applet resize.
>     
>     @Sebas Care to explain? Both the cases have been tested.

sure, QtVertical and QtHorizontal do not exist, that's a syntax error. I don't see how that could work, other than by complete accident.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38390
-----------------------------------------------------------


On Aug. 24, 2013, 3:11 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 3:11 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/957de8ce/attachment-0001.html>

From polentino911 at gmail.com  Sat Aug 24 18:34:42 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Sat, 24 Aug 2013 18:34:42 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822224558.1720.68795@vidsolbach.de>
References: <20130822224558.1720.68795@vidsolbach.de>
Message-ID: <20130824183442.26609.28203@vidsolbach.de>



> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
> > File Attachment: Applet Config Options
> > <http://git.reviewboard.kde.org/r/112208/#fcomment79>
> >
> >     Do we even really need horizontal/vertical orientation for the sliders as a configuration option? Other than "because we can" what is the actual end user value of that option?
> 
> Igor Poboiko wrote:
>     AFAIK MacOS and Windows use vertical slider orientation, while Gnome&Ubuntu use horizontal sliders. Some people may be used to one of the variants and find another one inconvenient. So why not let them choose? There is not that many options in that applet anyways.
> 
> Marco Martin wrote:
>     i would prefer not having that as well, plasma appletswere designed to make easy for the user to change a plasmoid with another if they don't like it, rther than making the developer maintain many different code paths of which some combination will always go untested...
>     
>     one thing without a config dialog that may be tried is adjusting horizontal or vertical how better suits the size of the config dialog at the moment...
> 
> Sebastian K?gler wrote:
>     Case in point: The use of QtHorizontal and QtVertical throughout the code suggest to me that the horizontal case wasn't really tested in the submitted version. Kinda supports Marco's fear of untested code pathes. ;-)
> 
> Diego Casella wrote:
>     I've tried to keep compatibility with the "old" KMix interface, which lets you choose whether you want horizontal or vertical sliders.
>     
>     @Marco You are completely right, but we don't want to end with two applets like "KMix with horizontal sliders" and "KMix with vertical sliders" right? We should try to get a reliable procedure to retrieve the size of the elements in the listview, which is the root of my issues with the applet resize.
>     
>     @Sebas Care to explain? Both the cases have been tested.
> 
> Sebastian K?gler wrote:
>     sure, QtVertical and QtHorizontal do not exist, that's a syntax error. I don't see how that could work, other than by complete accident.

Maybe hose enums were kept for backwards compatibilty, because they still do exists. Right here:
https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/plasma/scriptengines/javascript/plasmoid/appletinterface.h#L156

Since my very first draft of the kmix applet is litteraly *years* old, even though I heavily refactored/modified/dropped the code, the QtVertical enums is something iI never checked if they were still valid or not, since they always worked fine :)


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38390
-----------------------------------------------------------


On Aug. 24, 2013, 3:11 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 3:11 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/827911bf/attachment.html>

From sebas at kde.org  Sat Aug 24 19:02:41 2013
From: sebas at kde.org (=?utf-8?q?Sebastian_K=C3=BCgler?=)
Date: Sat, 24 Aug 2013 19:02:41 -0000
Subject: Review Request 111849: custom first week for plasmaclock.
In-Reply-To: <20130820090318.12890.50154@vidsolbach.de>
References: <20130820090318.12890.50154@vidsolbach.de>
Message-ID: <20130824190241.31530.94335@vidsolbach.de>



> On Aug. 20, 2013, 9:03 a.m., Sebastian K?gler wrote:
> > * The patch is not correctly submitted, it's submitted as screenshot, not as patch, that makes it impossible to review
> > * You didn't attach a screenshot of the UI
> > * Checking wether a patch applies is not testing it
> > * The clock's config is not the right place for this, it should rather be a global calendar setting
> > * kde-workspace is frozen, this could, *at best* go into Plasma2 (which this patch is not about)
> > 
> > Please read and address my comments more carefully.
> 
> Hu Zheng wrote:
>     If I submit it as a patch, it will need a Parent Diff, which I don't have in fact.
>     The screenshot is added!
>     You can see the new patch file, it changed to use custom config file.

The parent diff is optional. Please also address my other comments.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/#review38189
-----------------------------------------------------------


On Aug. 24, 2013, 7:46 a.m., Hu Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111849/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 7:46 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/111849/diff/
> 
> 
> Testing
> -------
> 
> cd kde-workspace-4.10.5/libs/plasmaclock
> patch -p1 < customfirstweek.patch
> 
> The save configuration codes are not very beautiful, but it works fine!
> 
> 
> File Attachments
> ----------------
> 
> patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch
> another patch, use custom config file.
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch
> screenshot
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/customweek.png
> 
> 
> Thanks,
> 
> Hu Zheng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/611848ac/attachment.html>

From thomas.luebking at gmail.com  Sat Aug 24 20:15:02 2013
From: thomas.luebking at gmail.com (=?utf-8?q?Thomas_L=C3=BCbking?=)
Date: Sat, 24 Aug 2013 20:15:02 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running"
 option in taskbar widget
In-Reply-To: <20130824151726.32727.94953@vidsolbach.de>
References: <20130824151726.32727.94953@vidsolbach.de>
Message-ID: <20130824201502.9170.35663@vidsolbach.de>



> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint.
> > 
> > Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause.
> 
> Bhushan Shah wrote:
>     Are you sure that this happens on 32 bit only?
> 
> Eike Hein wrote:
>     No, I'm not - except I can't reproduce it on any of my 64 bit machines, and I have to assume if it were a widespread bug, the number of reports we'd be getting would be much, much higher. Note that we didn't even get any reports through any of the pre-releases about this, AFAIR.
>     
>     I'm typing this from a cellphone right now, but I hope when I get home tonight I'll finally get around to setting up a 32 bit VM, and I'm hoping it'll crash there so I can throw all the gdb/valgrind/asan at it we got :).
> 
> Thomas L?bking wrote:
>     What bug and is "WId" involved?
> 
> Bhushan Shah wrote:
>     https://bugs.kde.org/show_bug.cgi?id=322283
> 
> Hrvoje Senjan wrote:
>     @Thomas
>     bug#322283

Thanks.

>From a brief review of libtaskmanager, TaskGroup::getMemberById(int id) returns AbstractGroupableItem* which could be (reimplemented)
- TaskGroup*
- LauncherItem*
- TaskItem*
but is happily static_cast'ed to TaskItem* and then accessed.

The fact(?) that itemType returns LauncherItemType indicates that there can very well be different returns and then you're accessing random memory portions - it does absolutely not matter that the function pointer for ::task() points into garbage when the item is actually a Launcher - the garbage is still rather not null, there's no guarantee that this basic deref somehow would crash or fail (virtual ::task() needed to be moved to AbstractGroupableItem then)

To know whether or why this has different implications on different architectures:
Valgrind will tell you.

For the moment
- either ::getMemberById() is supposed to return different types than TaskItem here, then static_cast needs to be qobject_cast or dynamic_cast (pending on linkage)
- or and ::getMemberById() that is *not* TaskItem must be considered a bug, then i'd start by adding an Q_ASSERT(!static_cast<TaskManager::AbstractGroupableItem*>(taskItem->itemType() == TaskManager::TaskItemType))


I don't really know, but as this thing seems to manage all kinds of items, but only updating rects for TaskItem's (and actually *every* grouped TaskItem for a TaskGroupType return ... so we don't get more bugs on "windows don't minimize to proper icon ;-P") makes sense, the correct solution is probably indeed:

AbstractGroupableItem *item = rootGroup()->getMemberById(id);

if (item->itemType() == TaskManager::LauncherItemType)
   return; // launchers have no windows, we just cause X11 errors and with a little luck a stupid gobject abort
if (item->itemType() == TaskManager::TaskGroupType) {
   // build a WId list of all grouped Items
   ...
} else //if (item->itemType() == TaskManager::TaskItemType) {
   tasks << static_cast<TaskManager::TaskItem*>(taskItem)->task(); 
}

// search parrent and other juggling to figure the proper rectangle
...


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/#review38481
-----------------------------------------------------------


On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112241/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 2 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> Fix the crash in plasma-desktop caused by newer QML taskbar widget.
> 
> Simple steps to reproduce this crash.
> 
> 1) Pin any task/application to taskbar using "show launcher when not running" option.
> 2) Close application.
> 3) Desktop crashes.
> 
> Reason :
> 
> 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 
> 
>   -> pointer to task is not null
>   -> taskItem itself is not null
>   -> scene is not null
> 
> 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
> 
> Patch :
> 
> This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/tasks.cpp c4aef4b 
> 
> Diff: http://git.reviewboard.kde.org/r/112241/diff/
> 
> 
> Testing
> -------
> 
> Testing
> 
> compilation - check
> installation - check
> plasmoidviewer - check
> in panel - check
> independently - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/d34c659c/attachment-0001.html>

From bhush94 at gmail.com  Sun Aug 25 10:01:01 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sun, 25 Aug 2013 15:31:01 +0530
Subject: Seeking mentor and project for SoK
Message-ID: <CAGPcNU3XBx5RQeL0REj0GGj7nt7qQwqPjeSAUPGNEVEfcg8eyQ@mail.gmail.com>

Hello there!

I want to apply for the Season of KDE 2013. Now I am seeking for a
good project. There are no projects of plasma listed on the SoK ideas
page [1]. So I thought of porting 2-3 data engines and plasmoids to
KF5 to participate in Season of KDE 2013. I want to know if its good
idea or what?

Recently I have ported some *very* basic DataEngines to KF5 which
required changes in cmake macros. Also I am porting KGet widget to
QML[2] and have ported Activity Bar widget to QML.

Also If someone wants to mentor me that will be awesome. I know C,
C++, HTML, CSS3, PHP and have basic knowledge of Qt, QML. If someone
will mentor me it will be great opportunity for me to learn stuffs and
advance in them. Later I want to apply for GSoC 2014 and this
experience will help me.

Thanks!

[1] http://community.kde.org/SoK/Ideas/2013
[2] https://projects.kde.org/projects/kde/kdenetwork/kget/repository/show?rev=qmlwidget

From hein at kde.org  Sun Aug 25 14:11:58 2013
From: hein at kde.org (Eike Hein)
Date: Sun, 25 Aug 2013 14:11:58 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running"
 option in taskbar widget
In-Reply-To: <20130824151726.32727.94953@vidsolbach.de>
References: <20130824151726.32727.94953@vidsolbach.de>
Message-ID: <20130825141158.18921.88433@vidsolbach.de>



> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the library somewhere ... but then it still wouldn't crash on translating a QPoint.
> > 
> > Thank you for the patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause.
> 
> Bhushan Shah wrote:
>     Are you sure that this happens on 32 bit only?
> 
> Eike Hein wrote:
>     No, I'm not - except I can't reproduce it on any of my 64 bit machines, and I have to assume if it were a widespread bug, the number of reports we'd be getting would be much, much higher. Note that we didn't even get any reports through any of the pre-releases about this, AFAIR.
>     
>     I'm typing this from a cellphone right now, but I hope when I get home tonight I'll finally get around to setting up a 32 bit VM, and I'm hoping it'll crash there so I can throw all the gdb/valgrind/asan at it we got :).
> 
> Thomas L?bking wrote:
>     What bug and is "WId" involved?
> 
> Bhushan Shah wrote:
>     https://bugs.kde.org/show_bug.cgi?id=322283
> 
> Hrvoje Senjan wrote:
>     @Thomas
>     bug#322283
> 
> Thomas L?bking wrote:
>     Thanks.
>     
>     From a brief review of libtaskmanager, TaskGroup::getMemberById(int id) returns AbstractGroupableItem* which could be (reimplemented)
>     - TaskGroup*
>     - LauncherItem*
>     - TaskItem*
>     but is happily static_cast'ed to TaskItem* and then accessed.
>     
>     The fact(?) that itemType returns LauncherItemType indicates that there can very well be different returns and then you're accessing random memory portions - it does absolutely not matter that the function pointer for ::task() points into garbage when the item is actually a Launcher - the garbage is still rather not null, there's no guarantee that this basic deref somehow would crash or fail (virtual ::task() needed to be moved to AbstractGroupableItem then)
>     
>     To know whether or why this has different implications on different architectures:
>     Valgrind will tell you.
>     
>     For the moment
>     - either ::getMemberById() is supposed to return different types than TaskItem here, then static_cast needs to be qobject_cast or dynamic_cast (pending on linkage)
>     - or and ::getMemberById() that is *not* TaskItem must be considered a bug, then i'd start by adding an Q_ASSERT(!static_cast<TaskManager::AbstractGroupableItem*>(taskItem->itemType() == TaskManager::TaskItemType))
>     
>     
>     
>     I don't really know, but as this thing seems to manage all kinds of items, but only updating rects for TaskItem's (and actually *every* grouped TaskItem for a TaskGroupType return ... so we don't get more bugs on "windows don't minimize to proper icon ;-P") makes sense, the correct solution is probably indeed:
>     
>     AbstractGroupableItem *item = rootGroup()->getMemberById(id);
>     
>     if (item->itemType() == TaskManager::LauncherItemType)
>        return; // launchers have no windows, we just cause X11 errors and with a little luck a stupid gobject abort
>     if (item->itemType() == TaskManager::TaskGroupType) {
>        // build a WId list of all grouped Items
>        ...
>     } else //if (item->itemType() == TaskManager::TaskItemType) {
>        tasks << static_cast<TaskManager::TaskItem*>(taskItem)->task(); 
>     }
>     
>     // search parrent and other juggling to figure the proper rectangle
>     ...

Thomas: Building the list of group child windows is already done (the traversal happens on the QML side).


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/#review38481
-----------------------------------------------------------


On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112241/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 2 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> Fix the crash in plasma-desktop caused by newer QML taskbar widget.
> 
> Simple steps to reproduce this crash.
> 
> 1) Pin any task/application to taskbar using "show launcher when not running" option.
> 2) Close application.
> 3) Desktop crashes.
> 
> Reason :
> 
> 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 
> 
>   -> pointer to task is not null
>   -> taskItem itself is not null
>   -> scene is not null
> 
> 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
> 
> Patch :
> 
> This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/tasks.cpp c4aef4b 
> 
> Diff: http://git.reviewboard.kde.org/r/112241/diff/
> 
> 
> Testing
> -------
> 
> Testing
> 
> compilation - check
> installation - check
> plasmoidviewer - check
> in panel - check
> independently - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130825/bf453b47/attachment.html>

From hein at kde.org  Sun Aug 25 14:44:11 2013
From: hein at kde.org (Eike Hein)
Date: Sun, 25 Aug 2013 14:44:11 -0000
Subject: Review Request 112241: Fix "Show Launcher when not running"
 option in taskbar widget
In-Reply-To: <20130824140029.24210.31883@vidsolbach.de>
References: <20130824140029.24210.31883@vidsolbach.de>
Message-ID: <20130825144411.22195.27426@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/
-----------------------------------------------------------

(Updated Aug. 25, 2013, 2:44 p.m.)


Status
------

This change has been discarded.


Review request for kde-workspace, Plasma and Eike Hein.


Description
-------

Fix the crash in plasma-desktop caused by newer QML taskbar widget.

Simple steps to reproduce this crash.

1) Pin any task/application to taskbar using "show launcher when not running" option.
2) Close application.
3) Desktop crashes.

Reason :

1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 

  -> pointer to task is not null
  -> taskItem itself is not null
  -> scene is not null

2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.

Patch :

This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.


Diffs
-----

  plasma/desktop/applets/tasks/tasks.cpp c4aef4b 

Diff: http://git.reviewboard.kde.org/r/112241/diff/


Testing
-------

Testing

compilation - check
installation - check
plasmoidviewer - check
in panel - check
independently - check


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130825/1bedeb23/attachment.html>

From bugseagull at gmail.com  Wed Aug 21 16:17:18 2013
From: bugseagull at gmail.com (bug seagull)
Date: Wed, 21 Aug 2013 17:17:18 +0100
Subject: Help to display custom settings dialog in plasma widget (Python)
Message-ID: <CACVV-Hxjr07J_Xy8bW2ji09nNzbE5PqVKEM6K874sSLBEB=oKQ@mail.gmail.com>

Hello Everyone

I am creating a plasma widget that displays certain elements of an rss feed
. It requires a string from the user in order to set the widget up. To get
this input I made a dialog using qt designer and converted it to python
code and imported it. I am unable to get this dialog to show up however
when I click the widget settings.

Basically when the user selects the widget settings I would like to present
them with a KInputDialog and get a string . This is my first attempt at a
plasma widget and I have tried to search as much as possible for this issue
before consulting you all. The python plasma tutorials don't cover settings
configuration for example.

If anybody could help me I would greatly appreciate it.

The code can be found here
http://stackoverflow.com/questions/18322783/python-display-custom-plasmoid-settings-ui

Regards Bug
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/4b490871/attachment-0001.html>

From nekstedt at gmail.com  Fri Aug 23 21:40:06 2013
From: nekstedt at gmail.com (Niclas Ekstedt)
Date: Fri, 23 Aug 2013 23:40:06 +0200
Subject: My first plasmoid
Message-ID: <CAMBZssuEAFpaeeXpj2jGUHoBxgMv+zwoqY8+NHSkH26misvPaA@mail.gmail.com>

I'm a total newbie when it comes to developing for KDE. I've done som
coding mostly in Python in the past and to some extent in javascript.

I have this idea for a plasmoid that I would like to start out with. What I
want to achieve is a basic plasmoid MailBoxBiff, sitting in the system
tray, only to become visible (like the software updater icon) whenever a
mail is delivered to my local mbox.
Once that's done I can enhance it to actually work like KDE wrapper for the
'mail' command. Allowing me to read and work with my emails through a very
basic mail reader.

I've read the http://techbase.kde.org/Development/Tutorials/Plasma and have
understood as
much as QML and javascript is the recommended way to go. I'd like to think
that it would
be possible to do what I want with just QML and javascript or maybe even
with just QML.

I'm thinking that perhaps using akonadi as a datasource I could avoid
having to write quite a lot of code.

So what do you guys think. Would this be possible to do? And are there any
examples available that would help me along?

Thanks guys.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130823/a3583732/attachment-0001.html>

From sebas at kde.org  Mon Aug 26 12:46:28 2013
From: sebas at kde.org (Sebastian =?ISO-8859-1?Q?K=FCgler?=)
Date: Mon, 26 Aug 2013 14:46:28 +0200
Subject: Seeking mentor and project for SoK
In-Reply-To: <CAGPcNU3XBx5RQeL0REj0GGj7nt7qQwqPjeSAUPGNEVEfcg8eyQ@mail.gmail.com>
References: <CAGPcNU3XBx5RQeL0REj0GGj7nt7qQwqPjeSAUPGNEVEfcg8eyQ@mail.gmail.com>
Message-ID: <1537335.6KOuqYMCFU@miro.vizzzion.net>

Hi Bhushan,

On Sunday, August 25, 2013 15:31:01 Bhushan Shah wrote:
> I want to apply for the Season of KDE 2013. Now I am seeking for a
> good project. There are no projects of plasma listed on the SoK ideas
> page [1]. So I thought of porting 2-3 data engines and plasmoids to
> KF5 to participate in Season of KDE 2013. I want to know if its good
> idea or what?

Jep, fits perfectly. You're already getting into it with the ports you've done 
already, so I think that's a nice project.

> Recently I have ported some *very* basic DataEngines to KF5 which
> required changes in cmake macros. Also I am porting KGet widget to
> QML[2] and have ported Activity Bar widget to QML.
> 
> Also If someone wants to mentor me that will be awesome. I know C,
> C++, HTML, CSS3, PHP and have basic knowledge of Qt, QML. If someone
> will mentor me it will be great opportunity for me to learn stuffs and
> advance in them. Later I want to apply for GSoC 2014 and this
> experience will help me.

I can mentor you.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

From martin.klapetek at gmail.com  Mon Aug 26 13:03:16 2013
From: martin.klapetek at gmail.com (Martin Klapetek)
Date: Mon, 26 Aug 2013 13:03:16 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822143440.22771.25603@vidsolbach.de>
References: <20130822143440.22771.25603@vidsolbach.de>
Message-ID: <20130826130316.30073.13766@vidsolbach.de>



> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > File Attachment: Menu Actions
> > <http://git.reviewboard.kde.org/r/112208/#fcomment80>
> >
> >     KMix and Phonon are jargon and have to go.
> >     
> >     Proposal:
> >     
> >     "Mixer Setup"
> >     "Audio Setup"
> >     
> >     Seems more in line with kmix

Plus it should use elipsis on the end, eg. "Mixer Setup..." and "Audio Setup...".


> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > File Attachment: Menu Actions
> > <http://git.reviewboard.kde.org/r/112208/#fcomment81>
> >
> >     Maybe we could align this in the same way as the batter applet does?
> 
> Diego Casella wrote:
>     The menu comes from a right-click from within the widget -not the applet icon in the panel-, but i forgot to check the "include mouse pointer" option when I took that screenshot :)

(the comment was about the plasmoid stuff alignment, not the menu ;)

I'd agree with aligning it the same way as battery plasmoid - put the app icon on the left, make it span over two rows and discard the speaker icon. Also the text should be aligned to left then instead of centered, looks a bit chaotic imho.

That way we'll have consistent look in two important parts of the workspace, which I believe is very important.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38344
-----------------------------------------------------------


On Aug. 24, 2013, 3:11 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 3:11 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130826/d76f9ceb/attachment.html>

From bhush94 at gmail.com  Mon Aug 26 13:05:08 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Mon, 26 Aug 2013 18:35:08 +0530
Subject: Seeking mentor and project for SoK
In-Reply-To: <1537335.6KOuqYMCFU@miro.vizzzion.net>
References: <CAGPcNU3XBx5RQeL0REj0GGj7nt7qQwqPjeSAUPGNEVEfcg8eyQ@mail.gmail.com>
 <1537335.6KOuqYMCFU@miro.vizzzion.net>
Message-ID: <CAGPcNU1sjzusL=SGQdKv-ohoweBME1K+XVYFj+st__DWAb1gyw@mail.gmail.com>

Hello,

On Mon, Aug 26, 2013 at 6:16 PM, Sebastian K?gler <sebas at kde.org> wrote:
> I can mentor you.

Thank you very much! :D Here is my proposal on SoK site
http://season.kde.org/?q=view_projects&prg=26&p=122

Thanks!

From polentino911 at gmail.com  Tue Aug 27 08:13:10 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Tue, 27 Aug 2013 08:13:10 -0000
Subject: Review Request 112208: KMix qml applet
Message-ID: <20130827081310.30840.94909@vidsolbach.de>



> On Aug. 26, 2013, 3:38 p.m., Igor Poboiko wrote:
> > File Attachment: Vertical Control
> > <http://git.reviewboard.kde.org/r/112208/#fcomment83>
> >
> >     Do we need it? 
> >     
> >     (there is volume level percentage under the tooltip)
> >     
> >     It isn't consistent with horizontal view where there is no such label. Also it duplicates the information from slider. And also it reacts pretty slow to the changes when user moves the slider (due to slowness of the chain plasma->dbus->kmix->backend->kmix->dbus->plasma), which is pretty frustrating.
> >     
> >     A label (or a tooltip maybe?) with device name would be nice, because it is pretty hard to decide what volume am I changing when there are multiple cards (or just input and output sliders like in PulseAudio).

tooltpis are gone in rev2, see sebas comment ;)
The reason I didn't used a label with this layout is that it would take sooo much space but sure, this is an issue that must be addressed because the user must know which control he/she's going to modify ... I'll try to play with some wrapMode Label properties and see if I can get something usable and good looking.


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38661
-----------------------------------------------------------


On Aug. 24, 2013, 3:11 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 3:11 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130827/832524db/attachment-0001.html>

From polentino911 at gmail.com  Tue Aug 27 08:16:41 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Tue, 27 Aug 2013 08:16:41 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822143440.22771.25603@vidsolbach.de>
References: <20130822143440.22771.25603@vidsolbach.de>
Message-ID: <20130827081641.31226.45498@vidsolbach.de>



> On Aug. 22, 2013, 2:34 p.m., Sebastian K?gler wrote:
> > File Attachment: Menu Actions
> > <http://git.reviewboard.kde.org/r/112208/#fcomment84>
> >
> >     Maybe we could align this in the same way as the batter applet does?
> 
> Diego Casella wrote:
>     The menu comes from a right-click from within the widget -not the applet icon in the panel-, but i forgot to check the "include mouse pointer" option when I took that screenshot :)
> 
> Martin Klapetek wrote:
>     (the comment was about the plasmoid stuff alignment, not the menu ;)
>     
>     I'd agree with aligning it the same way as battery plasmoid - put the app icon on the left, make it span over two rows and discard the speaker icon. Also the text should be aligned to left then instead of centered, looks a bit chaotic imho.
>     
>     That way we'll have consistent look in two important parts of the workspace, which I believe is very important.

I see, my bad.
Pretty easy fix, will submit the update in a min ;)


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38344
-----------------------------------------------------------


On Aug. 24, 2013, 3:11 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 3:11 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/config/main.xml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/ButtonBar.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/MixersList.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/config.ui PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/kmixapplet.qml PRE-CREATION 
>   plasma/kmix-applet-qml/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130827/ea617103/attachment.html>

From polentino911 at gmail.com  Tue Aug 27 08:39:24 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Tue, 27 Aug 2013 08:39:24 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130824151200.32256.88319@vidsolbach.de>
References: <20130824151200.32256.88319@vidsolbach.de>
Message-ID: <20130827083924.32388.51761@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 8:39 a.m.)


Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.


Changes
-------

Layout icon and control label on the left as david suggested


Description
-------

KMix qml applet.
As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
Differences from the old kmix tray:
* no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
* the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;

Known issues:
* there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
* no scroll events over the sliders too;
* if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
* resize doesn't work properly.


Diffs (updated)
-----

  plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112208/diff/


Testing
-------

Tested against master and works fine.


File Attachments
----------------

Default look
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
Menu Actions
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
Applet Config Options
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
Vertical Control
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
ToolButton label and Config page after updates
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png


Thanks,

Diego Casella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130827/0abe5b15/attachment.html>

From polentino911 at gmail.com  Tue Aug 27 08:40:38 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Tue, 27 Aug 2013 08:40:38 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130827083924.32388.51761@vidsolbach.de>
References: <20130827083924.32388.51761@vidsolbach.de>
Message-ID: <20130827084038.32515.6095@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 8:40 a.m.)


Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.


Description
-------

KMix qml applet.
As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
Differences from the old kmix tray:
* no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
* the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;

Known issues:
* there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
* no scroll events over the sliders too;
* if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
* resize doesn't work properly.


Diffs
-----

  plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
  plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112208/diff/


Testing
-------

Tested against master and works fine.


File Attachments (updated)
----------------

Default look
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
Menu Actions
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
Applet Config Options
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
Vertical Control
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
ToolButton label and Config page after updates
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
Control Icon and Label left aligned
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png


Thanks,

Diego Casella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130827/b4a5111d/attachment-0001.html>

From martin.klapetek at gmail.com  Tue Aug 27 10:57:29 2013
From: martin.klapetek at gmail.com (Martin Klapetek)
Date: Tue, 27 Aug 2013 10:57:29 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130827084038.32515.6095@vidsolbach.de>
References: <20130827084038.32515.6095@vidsolbach.de>
Message-ID: <20130827105729.14716.95378@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38727
-----------------------------------------------------------



File Attachment: Control Icon and Label left aligned
<http://git.reviewboard.kde.org//r/112208/#fcomment85>
    I wonder if we still need the speaker icons. The way I see it they represent two things - one is "how loud is this sound" (higher the volume is, more arcs the icon has). This is also represented by the slider and then by the percentage string too, so the "volume" information is there 3 times. The second thing it does is saying "this is a volume control". This on the other hand is quite important I think, although if you popup kmix applet (which has the speaker icon again), I guess one expects the sliders to be volume adjusting sliders. Dunno, I think the plasmoid would be clearer without the speaker icons.
    
    Either way, looks good when left aligned, good job!

- Martin Klapetek


On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> Control Icon and Label left aligned
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130827/5adda55d/attachment.html>

From christoph at maxiom.de  Tue Aug 27 11:57:00 2013
From: christoph at maxiom.de (Christoph Feck)
Date: Tue, 27 Aug 2013 13:57:00 +0200
Subject: Questions about models in NotificationDelegate.qml
Message-ID: <201308271357.00488.christoph@maxiom.de>

Hi,

Looking at the NotificationDelegate.qml file, I see several lines that 
say "notificationsModel.remove(index)", fired from timers, running 
animations etc.

Do QML models automatically make sure the index is still valid, in 
other words, when e.g. the timer fires delayed, and another item has 
been added or removed in the meantime, is the index updated 
accordingly? Or worse, if the item has been removed for other reasons, 
is the timer/animation automatically cancelled so that remove() is not 
called again?

Christoph Feck (kdepepo)

From polentino911 at gmail.com  Tue Aug 27 16:23:21 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Tue, 27 Aug 2013 16:23:21 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130827105729.14716.95378@vidsolbach.de>
References: <20130827105729.14716.95378@vidsolbach.de>
Message-ID: <20130827162321.30779.69336@vidsolbach.de>



> On Aug. 27, 2013, 10:57 a.m., Martin Klapetek wrote:
> > File Attachment: Control Icon and Label left aligned
> > <http://git.reviewboard.kde.org/r/112208/#fcomment86>
> >
> >     I wonder if we still need the speaker icons. The way I see it they represent two things - one is "how loud is this sound" (higher the volume is, more arcs the icon has). This is also represented by the slider and then by the percentage string too, so the "volume" information is there 3 times. The second thing it does is saying "this is a volume control". This on the other hand is quite important I think, although if you popup kmix applet (which has the speaker icon again), I guess one expects the sliders to be volume adjusting sliders. Dunno, I think the plasmoid would be clearer without the speaker icons.
> >     
> >     Either way, looks good when left aligned, good job!

That is a plain Plasma ToolButton, not a simple icon, which does the same as the button you can find in the "old" KMix interface does. If you click it, the corresponding channel will be muted. If it's already muted, it will be un-muted :)
imho the label gives a more concise/precise info about the actual volume level, which the slider cannot offer because of its nature.


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38727
-----------------------------------------------------------


On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> Control Icon and Label left aligned
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130827/04021df4/attachment.html>

From heena393 at gmail.com  Tue Aug 27 19:56:16 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Tue, 27 Aug 2013 19:56:16 +0000
Subject: kcmodule under kf5
Message-ID: <CAFCfA1--s_wDrsLkt1Swxbkdw4wFT1nW4_Kgo+JVwkzoh6RQew@mail.gmail.com>

Hi,
I am getting an error while porting kioslave/trash under kf5 that
?componentData?
is not a member of ?KCMTrashConfigFactory?
Also ,so I looked at the kcmodule.h and used KAboutData instead like this

TrashConfigModule::TrashConfigModule( QWidget* parent, const QVariantList& )
    : KCModule( parent ), trashInitialize( false )
{
    KAboutData *about = new KAboutData(
        "kcmtrash", 0, ki18n( "trash" ),
        KDE_VERSION_STRING, KLocalizedString(), KAboutData::License_GPL,
        ki18n( "Copyright 2013 Heena Mahour " ) );
        about->addAuthor( ki18n("Heena Mahour") ,KLocalizedString(), "
heena393 at gmail.com" );
        setAboutData( about );
}

but that is also giving following errors :
http://pastebin.com/raw.php?i=C5qePwbt

-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130827/2edaacc7/attachment.html>

From heena393 at gmail.com  Tue Aug 27 20:05:14 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Tue, 27 Aug 2013 20:05:14 +0000
Subject: kcmodule under kf5
In-Reply-To: <CAFCfA1--s_wDrsLkt1Swxbkdw4wFT1nW4_Kgo+JVwkzoh6RQew@mail.gmail.com>
References: <CAFCfA1--s_wDrsLkt1Swxbkdw4wFT1nW4_Kgo+JVwkzoh6RQew@mail.gmail.com>
Message-ID: <CAFCfA1_XWUvxyZLytd8erkyFbywJ5zU+ZyNoXXLpU+xgCg4yhA@mail.gmail.com>

I am referring to kcmtrash.cpp



On Tue, Aug 27, 2013 at 7:56 PM, Heena Mahour <heena393 at gmail.com> wrote:

> Hi,
> I am getting an error while porting kioslave/trash under kf5 that ?componentData?
> is not a member of ?KCMTrashConfigFactory?
> Also ,so I looked at the kcmodule.h and used KAboutData instead like this
>
> TrashConfigModule::TrashConfigModule( QWidget* parent, const QVariantList&
> )
>     : KCModule( parent ), trashInitialize( false )
> {
>     KAboutData *about = new KAboutData(
>         "kcmtrash", 0, ki18n( "trash" ),
>         KDE_VERSION_STRING, KLocalizedString(), KAboutData::License_GPL,
>         ki18n( "Copyright 2013 Heena Mahour " ) );
>         about->addAuthor( ki18n("Heena Mahour") ,KLocalizedString(), "
> heena393 at gmail.com" );
>         setAboutData( about );
> }
>
> but that is also giving following errors :
> http://pastebin.com/raw.php?i=C5qePwbt
>
> --
> -Heena
> Season of kde'12 participant
> Google Summer of Code 2013
> Delhi College of Engineering(COE),India
> http://about.me/heena.mahour
> http://heenamahour.blogspot.in
>
>


-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130827/73f28509/attachment-0001.html>

From mgraesslin at kde.org  Wed Aug 28 06:54:27 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Wed, 28 Aug 2013 08:54:27 +0200
Subject: kcmodule under kf5
In-Reply-To: <CAFCfA1--s_wDrsLkt1Swxbkdw4wFT1nW4_Kgo+JVwkzoh6RQew@mail.gmail.com>
References: <CAFCfA1--s_wDrsLkt1Swxbkdw4wFT1nW4_Kgo+JVwkzoh6RQew@mail.gmail.com>
Message-ID: <4241369.E8GNJ3BTuR@martin-thinkpad>

On Tuesday 27 August 2013 19:56:16 Heena Mahour wrote:
> but that is also giving following errors :
> http://pastebin.com/raw.php?i=C5qePwbt
this looks like some includes are missing. KDE_VERSION_STRING is deprecated 
AFAIK but still available (used in KWin). Just add:
#include <kdeversion.h>

KAboutData is more difficult. As I guess that's code you are porting you have to 
rename it to K4AboutData to get it compile again and include the appropriate 
header.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/feffd344/attachment.sig>

From polentino911 at gmail.com  Wed Aug 28 07:31:28 2013
From: polentino911 at gmail.com (Diego Casella)
Date: Wed, 28 Aug 2013 07:31:28 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130822224558.1720.68795@vidsolbach.de>
References: <20130822224558.1720.68795@vidsolbach.de>
Message-ID: <20130828073128.13705.39492@vidsolbach.de>



> On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
> > File Attachment: Applet Config Options
> > <http://git.reviewboard.kde.org/r/112208/#fcomment87>
> >
> >     Do we even really need horizontal/vertical orientation for the sliders as a configuration option? Other than "because we can" what is the actual end user value of that option?
> 
> Igor Poboiko wrote:
>     AFAIK MacOS and Windows use vertical slider orientation, while Gnome&Ubuntu use horizontal sliders. Some people may be used to one of the variants and find another one inconvenient. So why not let them choose? There is not that many options in that applet anyways.
> 
> Marco Martin wrote:
>     i would prefer not having that as well, plasma appletswere designed to make easy for the user to change a plasmoid with another if they don't like it, rther than making the developer maintain many different code paths of which some combination will always go untested...
>     
>     one thing without a config dialog that may be tried is adjusting horizontal or vertical how better suits the size of the config dialog at the moment...
> 
> Sebastian K?gler wrote:
>     Case in point: The use of QtHorizontal and QtVertical throughout the code suggest to me that the horizontal case wasn't really tested in the submitted version. Kinda supports Marco's fear of untested code pathes. ;-)
> 
> Diego Casella wrote:
>     I've tried to keep compatibility with the "old" KMix interface, which lets you choose whether you want horizontal or vertical sliders.
>     
>     @Marco You are completely right, but we don't want to end with two applets like "KMix with horizontal sliders" and "KMix with vertical sliders" right? We should try to get a reliable procedure to retrieve the size of the elements in the listview, which is the root of my issues with the applet resize.
>     
>     @Sebas Care to explain? Both the cases have been tested.
> 
> Sebastian K?gler wrote:
>     sure, QtVertical and QtHorizontal do not exist, that's a syntax error. I don't see how that could work, other than by complete accident.
> 
> Diego Casella wrote:
>     Maybe hose enums were kept for backwards compatibilty, because they still do exists. Right here:
>     https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/plasma/scriptengines/javascript/plasmoid/appletinterface.h#L156
>     
>     Since my very first draft of the kmix applet is litteraly *years* old, even though I heavily refactored/modified/dropped the code, the QtVertical enums is something iI never checked if they were still valid or not, since they always worked fine :)

Out of curiosity: can you now confirm rev1 is working even if it isn't supposed to, because somehow QtVertical/QtHorizontal are still defined in qml when they shouldn't?

Do you want to keep the possibility to change the orientation of the mixer controls?


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38390
-----------------------------------------------------------


On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> Control Icon and Label left aligned
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/1494f87b/attachment.html>

From david at davidedmundson.co.uk  Wed Aug 28 12:34:27 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Wed, 28 Aug 2013 12:34:27 +0000
Subject: kcmodule under kf5
In-Reply-To: <4241369.E8GNJ3BTuR@martin-thinkpad>
References: <CAFCfA1--s_wDrsLkt1Swxbkdw4wFT1nW4_Kgo+JVwkzoh6RQew@mail.gmail.com>
 <4241369.E8GNJ3BTuR@martin-thinkpad>
Message-ID: <CAGeFrHC99V0XJbdib3kZF8bpXJ1EJ0ZJfRrSit7rkYvRKNnmiA@mail.gmail.com>

For questions like this be sure to read the KDE5PORTING.html
in kdelibs-frameworks.

Should this file be missing anything please let someone in frameworks
development know so we can add it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/a29fddf9/attachment.html>

From heena393 at gmail.com  Wed Aug 28 15:22:14 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Wed, 28 Aug 2013 15:22:14 +0000
Subject: Kinterprocesslock->kioslave/trash error
Message-ID: <CAFCfA19Fa8VwGMfe1Cf68Eoowh+hjsor3QjzNqxc9GFNEmgfWQ@mail.gmail.com>

Hey ,
While  porting kioslave/trash  I encountered
two errors , one is /kioslave/trash/kinterprocesslock.h:110:15: error:
forward declaration of ?struct KInterProcessLock::Private?
 I tried adding class Private; above the class KInterProcessLock {} among
many other things but that is not working here .The same code has no such
syntax problem in plasma 1 .
And second error is kinterprocesslock.cpp:78:22: error: invalid use of
incomplete type ?struct KInterProcessLock::Private?
Please suggest something
http://pastebin.com/raw.php?i=Sm4WpWSj
http://pastebin.com/raw.php?i=ZSWzq1fN
Regards
-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/8964c029/attachment.html>

From david at davidedmundson.co.uk  Wed Aug 28 15:44:08 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Wed, 28 Aug 2013 15:44:08 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in group
 box drawing
Message-ID: <20130828154408.23027.5155@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Check widget validity in group box drawing

Widget is an optional parameter and may be 0.
This currently causes a crash when GroupBox is used by QtQuickControls

--

Not sure which group to set, please reassign if plasma is wrong.


Diffs
-----

  kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 

Diff: http://git.reviewboard.kde.org/r/112329/diff/


Testing
-------

Created QML test app to recreate some of OxygenDemo
No longer crashes \o/


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/eadd5137/attachment.html>

From heena393 at gmail.com  Wed Aug 28 16:35:39 2013
From: heena393 at gmail.com (Heena Mahour)
Date: Wed, 28 Aug 2013 16:35:39 +0000
Subject: macro_add_compile_flags under kf5
Message-ID: <CAFCfA1_yv=OZpbGxqjYkMG6YDO8kesURrqGwZ_GJhqkFjTETJw@mail.gmail.com>

 Hi ,
I am getting Unknown CMake command "macro_add_compile_flags". in kioclient
cmake under kf5 .
I found out that it is not to be used under kf5 as
macro_optional_find_package is replaced to find_package in a recent commit
Could you suggest how could I fix it ?
Regards

-- 
-Heena
Season of kde'12 participant
Google Summer of Code 2013
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/e5c76950/attachment.html>

From david at davidedmundson.co.uk  Wed Aug 28 17:24:34 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Wed, 28 Aug 2013 17:24:34 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in
 group box drawing
In-Reply-To: <20130828154408.23027.5155@vidsolbach.de>
References: <20130828154408.23027.5155@vidsolbach.de>
Message-ID: <20130828172434.20816.63336@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/
-----------------------------------------------------------

(Updated Aug. 28, 2013, 5:24 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Description
-------

Check widget validity in group box drawing

Widget is an optional parameter and may be 0.
This currently causes a crash when GroupBox is used by QtQuickControls

--

Not sure which group to set, please reassign if plasma is wrong.


Diffs
-----

  kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 

Diff: http://git.reviewboard.kde.org/r/112329/diff/


Testing
-------

Created QML test app to recreate some of OxygenDemo
No longer crashes \o/


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/1fd6937c/attachment.html>

From hugo at oxygen-icons.org  Wed Aug 28 20:46:13 2013
From: hugo at oxygen-icons.org (Hugo Pereira Da Costa)
Date: Wed, 28 Aug 2013 20:46:13 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in
 group box drawing
In-Reply-To: <20130828172434.20816.63336@vidsolbach.de>
References: <20130828172434.20816.63336@vidsolbach.de>
Message-ID: <20130828204613.12654.28552@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/#review38810
-----------------------------------------------------------

Ship it!


Ship It!

- Hugo Pereira Da Costa


On Aug. 28, 2013, 5:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112329/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 5:24 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Check widget validity in group box drawing
> 
> Widget is an optional parameter and may be 0.
> This currently causes a crash when GroupBox is used by QtQuickControls
> 
> --
> 
> Not sure which group to set, please reassign if plasma is wrong.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 
> 
> Diff: http://git.reviewboard.kde.org/r/112329/diff/
> 
> 
> Testing
> -------
> 
> Created QML test app to recreate some of OxygenDemo
> No longer crashes \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/ae2730ab/attachment-0001.html>

From hugo at oxygen-icons.org  Wed Aug 28 20:47:11 2013
From: hugo at oxygen-icons.org (Hugo Pereira Da Costa)
Date: Wed, 28 Aug 2013 20:47:11 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in
 group box drawing
In-Reply-To: <20130828204613.12654.28552@vidsolbach.de>
References: <20130828204613.12654.28552@vidsolbach.de>
Message-ID: <20130828204711.12664.6210@vidsolbach.de>



> On Aug. 28, 2013, 8:46 p.m., Hugo Pereira Da Costa wrote:
> > Ship It!

perfectly sane on my side
(in fact there must be other places in the long long oxygenstyle code, where similar tests would help)


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/#review38810
-----------------------------------------------------------


On Aug. 28, 2013, 5:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112329/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 5:24 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Check widget validity in group box drawing
> 
> Widget is an optional parameter and may be 0.
> This currently causes a crash when GroupBox is used by QtQuickControls
> 
> --
> 
> Not sure which group to set, please reassign if plasma is wrong.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 
> 
> Diff: http://git.reviewboard.kde.org/r/112329/diff/
> 
> 
> Testing
> -------
> 
> Created QML test app to recreate some of OxygenDemo
> No longer crashes \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/5c871b71/attachment.html>

From wengxt at gmail.com  Wed Aug 28 21:00:00 2013
From: wengxt at gmail.com (Xuetian Weng)
Date: Wed, 28 Aug 2013 21:00:00 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130827084038.32515.6095@vidsolbach.de>
References: <20130827084038.32515.6095@vidsolbach.de>
Message-ID: <20130828210000.13500.76552@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38812
-----------------------------------------------------------



File Attachment: Control Icon and Label left aligned
<http://git.reviewboard.kde.org//r/112208/#fcomment88>
    It would be nice to have a line here.
    
    svg: widgets/line and element horizontal-line would work here
    

- Xuetian Weng


On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> Control Icon and Label left aligned
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/83da1d2b/attachment.html>

From wengxt at gmail.com  Wed Aug 28 21:10:16 2013
From: wengxt at gmail.com (Xuetian Weng)
Date: Wed, 28 Aug 2013 21:10:16 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130827084038.32515.6095@vidsolbach.de>
References: <20130827084038.32515.6095@vidsolbach.de>
Message-ID: <20130828211016.15447.7663@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38813
-----------------------------------------------------------



plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
<http://git.reviewboard.kde.org/r/112208/#comment28679>

    if volume is changed from kmix, not from the applet, this would issue a duplicate service call to dataengine.
    
    my solution is to add a bool protector to disable this signal if the data change is not from user.


- Xuetian Weng


On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> Control Icon and Label left aligned
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/54661fe1/attachment-0001.html>

From wengxt at gmail.com  Wed Aug 28 21:12:57 2013
From: wengxt at gmail.com (Xuetian Weng)
Date: Wed, 28 Aug 2013 21:12:57 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130828211016.15447.7663@vidsolbach.de>
References: <20130828211016.15447.7663@vidsolbach.de>
Message-ID: <20130828211257.17034.92836@vidsolbach.de>



> On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote:
> > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55
> > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55>
> >
> >     if volume is changed from kmix, not from the applet, this would issue a duplicate service call to dataengine.
> >     
> >     my solution is to add a bool protector to disable this signal if the data change is not from user.

sorry for noise, maybe you should try onSliderMoved signal instead.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38813
-----------------------------------------------------------


On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> Control Icon and Label left aligned
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/624540c5/attachment.html>

From null at kde.org  Wed Aug 28 21:36:30 2013
From: null at kde.org (Commit Hook)
Date: Wed, 28 Aug 2013 21:36:30 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in
 group box drawing
In-Reply-To: <20130828172434.20816.63336@vidsolbach.de>
References: <20130828172434.20816.63336@vidsolbach.de>
Message-ID: <20130828213630.19505.45655@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/#review38815
-----------------------------------------------------------


This review has been submitted with commit d10c8c77e5b897acdd713439a5cc650466ae4bd9 by David Edmundson to branch frameworks-scratch.

- Commit Hook


On Aug. 28, 2013, 5:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112329/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 5:24 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Check widget validity in group box drawing
> 
> Widget is an optional parameter and may be 0.
> This currently causes a crash when GroupBox is used by QtQuickControls
> 
> --
> 
> Not sure which group to set, please reassign if plasma is wrong.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 
> 
> Diff: http://git.reviewboard.kde.org/r/112329/diff/
> 
> 
> Testing
> -------
> 
> Created QML test app to recreate some of OxygenDemo
> No longer crashes \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/3eaed275/attachment.html>

From null at kde.org  Wed Aug 28 21:36:33 2013
From: null at kde.org (Commit Hook)
Date: Wed, 28 Aug 2013 21:36:33 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in
 group box drawing
In-Reply-To: <20130828172434.20816.63336@vidsolbach.de>
References: <20130828172434.20816.63336@vidsolbach.de>
Message-ID: <20130828213633.19586.91719@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/
-----------------------------------------------------------

(Updated Aug. 28, 2013, 9:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Hugo Pereira Da Costa.


Description
-------

Check widget validity in group box drawing

Widget is an optional parameter and may be 0.
This currently causes a crash when GroupBox is used by QtQuickControls

--

Not sure which group to set, please reassign if plasma is wrong.


Diffs
-----

  kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 

Diff: http://git.reviewboard.kde.org/r/112329/diff/


Testing
-------

Created QML test app to recreate some of OxygenDemo
No longer crashes \o/


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/ae4d1477/attachment.html>

From null at kde.org  Thu Aug 29 00:14:37 2013
From: null at kde.org (Commit Hook)
Date: Thu, 29 Aug 2013 00:14:37 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in
 group box drawing
In-Reply-To: <20130828213633.19586.91719@vidsolbach.de>
References: <20130828213633.19586.91719@vidsolbach.de>
Message-ID: <20130829001437.8391.15876@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/#review38821
-----------------------------------------------------------


This review has been submitted with commit 8fd2e80e0fee4de9596835adb8620624c7e00f58 by Sebastian K?gler on behalf of David Edmundson to branch sebas/systray.

- Commit Hook


On Aug. 28, 2013, 9:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112329/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 9:36 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Check widget validity in group box drawing
> 
> Widget is an optional parameter and may be 0.
> This currently causes a crash when GroupBox is used by QtQuickControls
> 
> --
> 
> Not sure which group to set, please reassign if plasma is wrong.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 
> 
> Diff: http://git.reviewboard.kde.org/r/112329/diff/
> 
> 
> Testing
> -------
> 
> Created QML test app to recreate some of OxygenDemo
> No longer crashes \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130829/44f478ee/attachment-0001.html>

From bhush94 at gmail.com  Thu Aug 29 04:05:29 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Thu, 29 Aug 2013 04:05:29 -0000
Subject: Review Request 112208: KMix qml applet
In-Reply-To: <20130827084038.32515.6095@vidsolbach.de>
References: <20130827084038.32515.6095@vidsolbach.de>
Message-ID: <20130829040529.6025.39776@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38823
-----------------------------------------------------------


Can't we have it in branch or hosted somewhere on git?

- Bhushan Shah


On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> Control Icon and Label left aligned
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130829/c747a99b/attachment.html>

From mgraesslin at kde.org  Thu Aug 29 05:00:26 2013
From: mgraesslin at kde.org (Martin Graesslin)
Date: Thu, 29 Aug 2013 07:00:26 +0200
Subject: macro_add_compile_flags under kf5
In-Reply-To: <CAFCfA1_yv=OZpbGxqjYkMG6YDO8kesURrqGwZ_GJhqkFjTETJw@mail.gmail.com>
References: <CAFCfA1_yv=OZpbGxqjYkMG6YDO8kesURrqGwZ_GJhqkFjTETJw@mail.gmail.com>
Message-ID: <105983331.j7xJHkRy22@martin-thinkpad>

On Wednesday 28 August 2013 16:35:39 Heena Mahour wrote:
>  Hi ,
> I am getting Unknown CMake command "macro_add_compile_flags". in kioclient
> cmake under kf5 .
> I found out that it is not to be used under kf5 as
> macro_optional_find_package is replaced to find_package in a recent commit
> Could you suggest how could I fix it ?
Have a look at http://techbase.kde.org/Development/ECM_SourceIncompatChanges
which explains what to do for the changes.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130829/1d819dd5/attachment.sig>

From null at kde.org  Thu Aug 29 07:53:57 2013
From: null at kde.org (Commit Hook)
Date: Thu, 29 Aug 2013 07:53:57 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in
 group box drawing
In-Reply-To: <20130828213633.19586.91719@vidsolbach.de>
References: <20130828213633.19586.91719@vidsolbach.de>
Message-ID: <20130829075357.18293.61219@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/#review38824
-----------------------------------------------------------


This review has been submitted with commit e0331584551d8e4bebe4767bd971a5a828966851 by Hugo Pereira Da Costa on behalf of David Edmundson to branch master.

- Commit Hook


On Aug. 28, 2013, 9:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112329/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 9:36 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Check widget validity in group box drawing
> 
> Widget is an optional parameter and may be 0.
> This currently causes a crash when GroupBox is used by QtQuickControls
> 
> --
> 
> Not sure which group to set, please reassign if plasma is wrong.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 
> 
> Diff: http://git.reviewboard.kde.org/r/112329/diff/
> 
> 
> Testing
> -------
> 
> Created QML test app to recreate some of OxygenDemo
> No longer crashes \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130829/4f97d00d/attachment.html>

From null at kde.org  Thu Aug 29 07:54:30 2013
From: null at kde.org (Commit Hook)
Date: Thu, 29 Aug 2013 07:54:30 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in
 group box drawing
In-Reply-To: <20130828213633.19586.91719@vidsolbach.de>
References: <20130828213633.19586.91719@vidsolbach.de>
Message-ID: <20130829075430.18234.27727@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/#review38825
-----------------------------------------------------------


This review has been submitted with commit 1ccf3214d246721ed03935b848e7aa7e875c5deb by Hugo Pereira Da Costa on behalf of David Edmundson to branch KDE/4.11.

- Commit Hook


On Aug. 28, 2013, 9:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112329/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 9:36 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Check widget validity in group box drawing
> 
> Widget is an optional parameter and may be 0.
> This currently causes a crash when GroupBox is used by QtQuickControls
> 
> --
> 
> Not sure which group to set, please reassign if plasma is wrong.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 
> 
> Diff: http://git.reviewboard.kde.org/r/112329/diff/
> 
> 
> Testing
> -------
> 
> Created QML test app to recreate some of OxygenDemo
> No longer crashes \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130829/363244b8/attachment.html>

From hugo at oxygen-icons.org  Thu Aug 29 07:56:04 2013
From: hugo at oxygen-icons.org (Hugo Pereira Da Costa)
Date: Thu, 29 Aug 2013 07:56:04 -0000
Subject: Review Request 112329: Oxygen Style: Check widget validity in
 group box drawing
In-Reply-To: <20130828213633.19586.91719@vidsolbach.de>
References: <20130828213633.19586.91719@vidsolbach.de>
Message-ID: <20130829075604.19777.27809@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/#review38826
-----------------------------------------------------------


Side note:
I have also cherry-picked the change to master (not sure what's the status of this branch, though) and KDE/4.11 since it is considered a bug.

Hugo

- Hugo Pereira Da Costa


On Aug. 28, 2013, 9:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112329/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 9:36 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Check widget validity in group box drawing
> 
> Widget is an optional parameter and may be 0.
> This currently causes a crash when GroupBox is used by QtQuickControls
> 
> --
> 
> Not sure which group to set, please reassign if plasma is wrong.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 
> 
> Diff: http://git.reviewboard.kde.org/r/112329/diff/
> 
> 
> Testing
> -------
> 
> Created QML test app to recreate some of OxygenDemo
> No longer crashes \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130829/354f7600/attachment-0001.html>

From notmart at gmail.com  Thu Aug 29 13:30:18 2013
From: notmart at gmail.com (Marco Martin)
Date: Thu, 29 Aug 2013 13:30:18 -0000
Subject: Review Request 112142: QQuick item for live updating window
 thumbnails
In-Reply-To: <20130818082204.20405.33374@vidsolbach.de>
References: <20130818082204.20405.33374@vidsolbach.de>
Message-ID: <20130829133018.27539.70016@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112142/#review38855
-----------------------------------------------------------

Ship it!


purely from an api pov, i would like setWinId not being a slot, then it's perfect

- Marco Martin


On Aug. 18, 2013, 8:22 a.m., Martin Gr??lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112142/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 8:22 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> New qquick item in PlasmaCore to render a live updating window
> thumbnail. The implementation uses XCB to redirect the specified
> window using the composite extension. This means a running compositor
> is not required. Through the damage extension the item tracks changes
> to the window and triggers updates of the texture. Furthermore the
> item tracks geometry changes of the window to recreate the window
> pixmap.
>     
> If the pixmap of the window is valid, a texture is generated from it
> using the glx texture from pixmap extension. For this a new optional
> dependency for glx is added. On platform where glx is not available
> (e.g. Windows, Linux with OpenGL ES) this will not get compiled and
> the window's icon is used instead as a fallback.
> 
> ====
> For more info see also the documentation of the item in the header file.
> 
> I plan to also add an egl variant (which is magnitudes easier) once I figure out how to compile Qt to use egl instead of glx for the xcb platform plugin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 781c56f 
>   src/declarativeimports/core/CMakeLists.txt 75b52b3 
>   src/declarativeimports/core/corebindingsplugin.cpp ae4788e 
>   src/declarativeimports/core/windowthumbnail.h PRE-CREATION 
>   src/declarativeimports/core/windowthumbnail.cpp PRE-CREATION 
>   src/plasma/config-plasma.h.cmake f2da235 
> 
> Diff: http://git.reviewboard.kde.org/r/112142/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Window and it's thumbnail
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/18/windowthumbnail.png
> 
> 
> Thanks,
> 
> Martin Gr??lin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130829/1471c913/attachment.html>

From bhush94 at gmail.com  Thu Aug 29 13:47:15 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Thu, 29 Aug 2013 13:47:15 -0000
Subject: Review Request 112360: Enable mouse DataEngine on KF5
Message-ID: <20130829134715.7293.38864@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112360/
-----------------------------------------------------------

Review request for Plasma and Sebastian K?gler.


Description
-------

Enabling mouse DataEngine on KF5. Disabling cursor notification handler support for *now*. Some wired compilation errors.


Diffs
-----

  plasma/generic/dataengines/CMakeLists.txt f08b3b0 
  plasma/generic/dataengines/mouse/CMakeLists.txt 86d7acc 
  plasma/generic/dataengines/mouse/mouseengine.h d55565d 
  plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7 

Diff: http://git.reviewboard.kde.org/r/112360/diff/


Testing
-------

Compiles - check without cursor notification handler
Links - check
Installs - check
Works - check


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130829/123b11d9/attachment.html>

From david at davidedmundson.co.uk  Fri Aug 30 11:01:49 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 30 Aug 2013 11:01:49 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
Message-ID: <20130830110149.22910.31011@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/
-----------------------------------------------------------

Review request for Plasma and Hugo Pereira Da Costa.


Description
-------

Use a single frame width for all PM_DefaultFrameWidth

The current code sets a width of 3 for all line edits, combo boxes
and frames, otherwise it returns a width of 1.

The QtQuickControls engine cannot qobject_cast() the widget so always
return a frame width of 1 for qtquickcontrol line edits and combo boxes.

This simplifies the code and solves that issue.

I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.

Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.


Diffs
-----

  kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
  kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 

Diff: http://git.reviewboard.kde.org/r/112375/diff/


Testing
-------


File Attachments
----------------

QML After
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
QML_Before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
Normal oxygen demo
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/06cf1101/attachment.html>

From david at davidedmundson.co.uk  Fri Aug 30 11:11:47 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 30 Aug 2013 11:11:47 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830110149.22910.31011@vidsolbach.de>
References: <20130830110149.22910.31011@vidsolbach.de>
Message-ID: <20130830111147.26996.30198@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/
-----------------------------------------------------------

(Updated Aug. 30, 2013, 11:11 a.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Description
-------

Use a single frame width for all PM_DefaultFrameWidth

The current code sets a width of 3 for all line edits, combo boxes
and frames, otherwise it returns a width of 1.

The QtQuickControls engine cannot qobject_cast() the widget so always
return a frame width of 1 for qtquickcontrol line edits and combo boxes.

This simplifies the code and solves that issue.

I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.

Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.


Diffs (updated)
-----

  kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
  kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 

Diff: http://git.reviewboard.kde.org/r/112375/diff/


Testing
-------


File Attachments
----------------

QML After
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
QML_Before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
Normal oxygen demo
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/6675de08/attachment-0001.html>

From hugo at oxygen-icons.org  Fri Aug 30 12:43:13 2013
From: hugo at oxygen-icons.org (Hugo Pereira Da Costa)
Date: Fri, 30 Aug 2013 12:43:13 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830111147.26996.30198@vidsolbach.de>
References: <20130830111147.26996.30198@vidsolbach.de>
Message-ID: <20130830124313.8892.86518@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


I respectfully disagree with the change.

If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?

The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).

That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 

Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.

Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...


- Hugo Pereira Da Costa


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/72813032/attachment.html>

From david at davidedmundson.co.uk  Fri Aug 30 13:21:05 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 30 Aug 2013 13:21:05 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830124313.8892.86518@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
Message-ID: <20130830132105.13130.30515@vidsolbach.de>



> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote:
> > I respectfully disagree with the change.
> > 
> > If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?
> > 
> > The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).
> > 
> > That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 
> > 
> > Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.
> > 
> > Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...
> >

I expected this to be a review which started a discussion :)
It's one that sets precedent for a few other things.

The thing that matters is for QtQuick to get the same width as QLineEdits get. This happens to be FRAME_FRAMEWIDTH now.

The reason I removed the LineEdit_FrameWidth is that if someone later does decide to change the LineEdit_FrameWidth the QtQuickControls will become broken again not matching the desktop counterpart. I'm deliberately taking away that option.

The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets.

I appreciate this is a very sucky situation to be in, but if we don't we will we see a very clear discrepancy in the UI depending on which technology happens to be used. I don't think we want that.

By only other options are:
--
I could try to add PM_LineEdit and PM_ComboBox into Qt5.2? It would solve this particular issue.
The base implementation of QStyle can then just call PM_DefaultFrameWidth for backwards compatibility. I'm not sure it would get in as it relies on all styles calling the base implementation for enum values they don't support.
--
We make a QML Oxygen theme from 'scratch' a bit like how we have an Oxygen GTK theme.. different tech that happens to look the same. 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/95ef7a30/attachment.html>

From david at davidedmundson.co.uk  Fri Aug 30 13:23:24 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 30 Aug 2013 13:23:24 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830124313.8892.86518@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
Message-ID: <20130830132324.13391.7315@vidsolbach.de>



> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote:
> > I respectfully disagree with the change.
> > 
> > If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?
> > 
> > The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).
> > 
> > That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 
> > 
> > Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.
> > 
> > Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...
> >
> 
> David Edmundson wrote:
>     I expected this to be a review which started a discussion :)
>     It's one that sets precedent for a few other things.
>     
>     The thing that matters is for QtQuick to get the same width as QLineEdits get. This happens to be FRAME_FRAMEWIDTH now.
>     
>     The reason I removed the LineEdit_FrameWidth is that if someone later does decide to change the LineEdit_FrameWidth the QtQuickControls will become broken again not matching the desktop counterpart. I'm deliberately taking away that option.
>     
>     The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets.
>     
>     I appreciate this is a very sucky situation to be in, but if we don't we will we see a very clear discrepancy in the UI depending on which technology happens to be used. I don't think we want that.
>     
>     By only other options are:
>     --
>     I could try to add PM_LineEdit and PM_ComboBox into Qt5.2? It would solve this particular issue.
>     The base implementation of QStyle can then just call PM_DefaultFrameWidth for backwards compatibility. I'm not sure it would get in as it relies on all styles calling the base implementation for enum values they don't support.
>     --
>     We make a QML Oxygen theme from 'scratch' a bit like how we have an Oxygen GTK theme.. different tech that happens to look the same.

s/By/My


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/0b3e0b54/attachment-0001.html>

From christoph at maxiom.de  Fri Aug 30 13:38:52 2013
From: christoph at maxiom.de (Christoph Feck)
Date: Fri, 30 Aug 2013 13:38:52 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830124313.8892.86518@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
Message-ID: <20130830133852.14316.98228@vidsolbach.de>



> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote:
> > I respectfully disagree with the change.
> > 
> > If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?
> > 
> > The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).
> > 
> > That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 
> > 
> > Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.
> > 
> > Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...
> >
> 
> David Edmundson wrote:
>     I expected this to be a review which started a discussion :)
>     It's one that sets precedent for a few other things.
>     
>     The thing that matters is for QtQuick to get the same width as QLineEdits get. This happens to be FRAME_FRAMEWIDTH now.
>     
>     The reason I removed the LineEdit_FrameWidth is that if someone later does decide to change the LineEdit_FrameWidth the QtQuickControls will become broken again not matching the desktop counterpart. I'm deliberately taking away that option.
>     
>     The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets.
>     
>     I appreciate this is a very sucky situation to be in, but if we don't we will we see a very clear discrepancy in the UI depending on which technology happens to be used. I don't think we want that.
>     
>     By only other options are:
>     --
>     I could try to add PM_LineEdit and PM_ComboBox into Qt5.2? It would solve this particular issue.
>     The base implementation of QStyle can then just call PM_DefaultFrameWidth for backwards compatibility. I'm not sure it would get in as it relies on all styles calling the base implementation for enum values they don't support.
>     --
>     We make a QML Oxygen theme from 'scratch' a bit like how we have an Oxygen GTK theme.. different tech that happens to look the same.
> 
> David Edmundson wrote:
>     s/By/My

Why do QtQuickControls need pixelMetric() for line edits? To find out, how much margin there is around a styled line edit, it should simply use sizeFromContents() and subElementRect().


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/1375d62e/attachment.html>

From hugo at oxygen-icons.org  Fri Aug 30 13:44:35 2013
From: hugo at oxygen-icons.org (Hugo Pereira Da Costa)
Date: Fri, 30 Aug 2013 13:44:35 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830124313.8892.86518@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
Message-ID: <20130830134435.14653.72072@vidsolbach.de>



> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote:
> > I respectfully disagree with the change.
> > 
> > If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?
> > 
> > The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).
> > 
> > That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 
> > 
> > Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.
> > 
> > Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...
> >
> 
> David Edmundson wrote:
>     I expected this to be a review which started a discussion :)
>     It's one that sets precedent for a few other things.
>     
>     The thing that matters is for QtQuick to get the same width as QLineEdits get. This happens to be FRAME_FRAMEWIDTH now.
>     
>     The reason I removed the LineEdit_FrameWidth is that if someone later does decide to change the LineEdit_FrameWidth the QtQuickControls will become broken again not matching the desktop counterpart. I'm deliberately taking away that option.
>     
>     The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets.
>     
>     I appreciate this is a very sucky situation to be in, but if we don't we will we see a very clear discrepancy in the UI depending on which technology happens to be used. I don't think we want that.
>     
>     By only other options are:
>     --
>     I could try to add PM_LineEdit and PM_ComboBox into Qt5.2? It would solve this particular issue.
>     The base implementation of QStyle can then just call PM_DefaultFrameWidth for backwards compatibility. I'm not sure it would get in as it relies on all styles calling the base implementation for enum values they don't support.
>     --
>     We make a QML Oxygen theme from 'scratch' a bit like how we have an Oxygen GTK theme.. different tech that happens to look the same.
> 
> David Edmundson wrote:
>     s/By/My
> 
> Christoph Feck wrote:
>     Why do QtQuickControls need pixelMetric() for line edits? To find out, how much margin there is around a styled line edit, it should simply use sizeFromContents() and subElementRect().

"The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets."

Two things: this is no hacking. QWidget is an argument passed to the method (though it can be zero), there is no hack in using it, casting it, etc, as far as I can tell. This is a correct use of Qt's API.

Second: "support the lowest common denominator of QStyle that they both follow even"
I disagree, and besides, I believe this will simply not work. It 'sort of does' in this specific case, but then q_object_cast is used all over the place in oxygen, to, for instance, install event filters, setup/trigger animation, enable mouse-grabbing in empty areas, enable hover on some items for which it was not allowed primarily, etc. Bottomline: I fear that the smallest common denominator that would work identical between QtQuick and QWidget, will be _very_ small, to the point it becomes quite unacceptable; and I 'a priori' do not want to follow this path (especially after all the hours invested in the above). 

I aknowledge the will to make QtQuick look identical to QWidgets via oxygen, but imho it must not be done by introducing regressions to the QWidget's rendering. Animations for instance are an interesting case: it is built-in qt quick (if I understand right), while it is enforced via oxygen for widgets. If you drop it from oxygen (for the sake of the common denominator), then you actually introduce inconsistencies between the two. 

So that I can see:

1/ add decent fallbacks (for QtQuick) so that it looks "good enough", and fix them whenever this gets broken (the case you mentionned)
2/ implement missing features in QtQuick so that it allows one to look "identical" to what we can do with QWidgets. Naively, I can imagine passing "properties" to the QtQuick widgets, that one can test alongside the failing q_object_cast in oxygen
3/ as you say: clone oxygen for QtQuick. But I really would not advocate for this, since it is a pain to maintain, and does not solve anything with respect to solution 1/ concerning fixing things that get broken (inconsitent). 

Note that your patch also drops ComboBox_FrameWidth, the latter being also used in a separate enum (PM_ComboBoxFrameWidth).


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/e7c54bf3/attachment-0001.html>

From david at davidedmundson.co.uk  Fri Aug 30 13:58:54 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 30 Aug 2013 13:58:54 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830124313.8892.86518@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
Message-ID: <20130830135854.18216.99106@vidsolbach.de>



> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote:
> > I respectfully disagree with the change.
> > 
> > If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?
> > 
> > The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).
> > 
> > That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 
> > 
> > Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.
> > 
> > Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...
> >
> 
> David Edmundson wrote:
>     I expected this to be a review which started a discussion :)
>     It's one that sets precedent for a few other things.
>     
>     The thing that matters is for QtQuick to get the same width as QLineEdits get. This happens to be FRAME_FRAMEWIDTH now.
>     
>     The reason I removed the LineEdit_FrameWidth is that if someone later does decide to change the LineEdit_FrameWidth the QtQuickControls will become broken again not matching the desktop counterpart. I'm deliberately taking away that option.
>     
>     The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets.
>     
>     I appreciate this is a very sucky situation to be in, but if we don't we will we see a very clear discrepancy in the UI depending on which technology happens to be used. I don't think we want that.
>     
>     By only other options are:
>     --
>     I could try to add PM_LineEdit and PM_ComboBox into Qt5.2? It would solve this particular issue.
>     The base implementation of QStyle can then just call PM_DefaultFrameWidth for backwards compatibility. I'm not sure it would get in as it relies on all styles calling the base implementation for enum values they don't support.
>     --
>     We make a QML Oxygen theme from 'scratch' a bit like how we have an Oxygen GTK theme.. different tech that happens to look the same.
> 
> David Edmundson wrote:
>     s/By/My
> 
> Christoph Feck wrote:
>     Why do QtQuickControls need pixelMetric() for line edits? To find out, how much margin there is around a styled line edit, it should simply use sizeFromContents() and subElementRect().
> 
> Hugo Pereira Da Costa wrote:
>     "The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets."
>     
>     Two things: this is no hacking. QWidget is an argument passed to the method (though it can be zero), there is no hack in using it, casting it, etc, as far as I can tell. This is a correct use of Qt's API.
>     
>     Second: "support the lowest common denominator of QStyle that they both follow even"
>     I disagree, and besides, I believe this will simply not work. It 'sort of does' in this specific case, but then q_object_cast is used all over the place in oxygen, to, for instance, install event filters, setup/trigger animation, enable mouse-grabbing in empty areas, enable hover on some items for which it was not allowed primarily, etc. Bottomline: I fear that the smallest common denominator that would work identical between QtQuick and QWidget, will be _very_ small, to the point it becomes quite unacceptable; and I 'a priori' do not want to follow this path (especially after all the hours invested in the above). 
>     
>     I aknowledge the will to make QtQuick look identical to QWidgets via oxygen, but imho it must not be done by introducing regressions to the QWidget's rendering. Animations for instance are an interesting case: it is built-in qt quick (if I understand right), while it is enforced via oxygen for widgets. If you drop it from oxygen (for the sake of the common denominator), then you actually introduce inconsistencies between the two. 
>     
>     So that I can see:
>     
>     1/ add decent fallbacks (for QtQuick) so that it looks "good enough", and fix them whenever this gets broken (the case you mentionned)
>     2/ implement missing features in QtQuick so that it allows one to look "identical" to what we can do with QWidgets. Naively, I can imagine passing "properties" to the QtQuick widgets, that one can test alongside the failing q_object_cast in oxygen
>     3/ as you say: clone oxygen for QtQuick. But I really would not advocate for this, since it is a pain to maintain, and does not solve anything with respect to solution 1/ concerning fixing things that get broken (inconsitent). 
>     
>     Note that your patch also drops ComboBox_FrameWidth, the latter being also used in a separate enum (PM_ComboBoxFrameWidth).

@Cristoph
sizeFromContents takes the frame as a parameter which oxygen uses. The frame lineWidth comes from the pixel metric for frames.
This must also happen for QWidgets as otherwise we wouldn't have a test for QLineEdits inside the pixelMetric function.

>From qquickstyleitem.cpp for LineEdits:
            QStyleOptionFrame frame;
            frame.state = m_styleoption->state;
            frame.lineWidth = qApp->style()->pixelMetric(QStyle::PM_DefaultFrameWidth, m_styleoption, 0);
            frame.rect = m_styleoption->rect;
            size = qApp->style()->sizeFromContents(QStyle::CT_LineEdit, &frame, QSize(width, height));


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/4a370180/attachment.html>

From notmart at gmail.com  Fri Aug 30 13:59:57 2013
From: notmart at gmail.com (Marco Martin)
Date: Fri, 30 Aug 2013 15:59:57 +0200
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830134435.14653.72072@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
 <20130830134435.14653.72072@vidsolbach.de>
Message-ID: <2030089.oQf0lYOHvs@deimos.diaunet>

On Friday 30 August 2013 13:44:35 Hugo Pereira Da Costa wrote:
> Second: "support the lowest common denominator of QStyle that they both
> follow even" I disagree, and besides, I believe this will simply not work.
> It 'sort of does' in this specific case, but then q_object_cast is used all
> over the place in oxygen, to, for instance, install event filters,
> setup/trigger animation, enable mouse-grabbing in empty areas, enable hover
> on some items for which it was not allowed primarily, etc. Bottomline: I
> fear that the smallest common denominator that would work identical between
> QtQuick and QWidget, will be _very_ small, to the point it becomes quite

Related to this, the following is an impression i encountered working on 
qtquickcontrols..

i think in the end is likely we'll end up with a separate qtquickcontrols 
style (different from Desktop, still using qstyle based primitives), to 
reimplement in qml what can't be done otherwise (like, animations in some 
cases, and i fear even frames with white background and borders rendered over 
the contents)

this is perfectly supported and probably at some point we'll hit a wall that 
pretty much requires that.
As last resort, ie putting in upstream qtcontrols what is possible, but 
still...

Cheers,
Marco Martin

From hugo at oxygen-icons.org  Fri Aug 30 14:13:03 2013
From: hugo at oxygen-icons.org (Hugo Pereira Da Costa)
Date: Fri, 30 Aug 2013 14:13:03 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830124313.8892.86518@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
Message-ID: <20130830141303.20853.58212@vidsolbach.de>



> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote:
> > I respectfully disagree with the change.
> > 
> > If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?
> > 
> > The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).
> > 
> > That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 
> > 
> > Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.
> > 
> > Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...
> >
> 
> David Edmundson wrote:
>     I expected this to be a review which started a discussion :)
>     It's one that sets precedent for a few other things.
>     
>     The thing that matters is for QtQuick to get the same width as QLineEdits get. This happens to be FRAME_FRAMEWIDTH now.
>     
>     The reason I removed the LineEdit_FrameWidth is that if someone later does decide to change the LineEdit_FrameWidth the QtQuickControls will become broken again not matching the desktop counterpart. I'm deliberately taking away that option.
>     
>     The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets.
>     
>     I appreciate this is a very sucky situation to be in, but if we don't we will we see a very clear discrepancy in the UI depending on which technology happens to be used. I don't think we want that.
>     
>     By only other options are:
>     --
>     I could try to add PM_LineEdit and PM_ComboBox into Qt5.2? It would solve this particular issue.
>     The base implementation of QStyle can then just call PM_DefaultFrameWidth for backwards compatibility. I'm not sure it would get in as it relies on all styles calling the base implementation for enum values they don't support.
>     --
>     We make a QML Oxygen theme from 'scratch' a bit like how we have an Oxygen GTK theme.. different tech that happens to look the same.
> 
> David Edmundson wrote:
>     s/By/My
> 
> Christoph Feck wrote:
>     Why do QtQuickControls need pixelMetric() for line edits? To find out, how much margin there is around a styled line edit, it should simply use sizeFromContents() and subElementRect().
> 
> Hugo Pereira Da Costa wrote:
>     "The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets."
>     
>     Two things: this is no hacking. QWidget is an argument passed to the method (though it can be zero), there is no hack in using it, casting it, etc, as far as I can tell. This is a correct use of Qt's API.
>     
>     Second: "support the lowest common denominator of QStyle that they both follow even"
>     I disagree, and besides, I believe this will simply not work. It 'sort of does' in this specific case, but then q_object_cast is used all over the place in oxygen, to, for instance, install event filters, setup/trigger animation, enable mouse-grabbing in empty areas, enable hover on some items for which it was not allowed primarily, etc. Bottomline: I fear that the smallest common denominator that would work identical between QtQuick and QWidget, will be _very_ small, to the point it becomes quite unacceptable; and I 'a priori' do not want to follow this path (especially after all the hours invested in the above). 
>     
>     I aknowledge the will to make QtQuick look identical to QWidgets via oxygen, but imho it must not be done by introducing regressions to the QWidget's rendering. Animations for instance are an interesting case: it is built-in qt quick (if I understand right), while it is enforced via oxygen for widgets. If you drop it from oxygen (for the sake of the common denominator), then you actually introduce inconsistencies between the two. 
>     
>     So that I can see:
>     
>     1/ add decent fallbacks (for QtQuick) so that it looks "good enough", and fix them whenever this gets broken (the case you mentionned)
>     2/ implement missing features in QtQuick so that it allows one to look "identical" to what we can do with QWidgets. Naively, I can imagine passing "properties" to the QtQuick widgets, that one can test alongside the failing q_object_cast in oxygen
>     3/ as you say: clone oxygen for QtQuick. But I really would not advocate for this, since it is a pain to maintain, and does not solve anything with respect to solution 1/ concerning fixing things that get broken (inconsitent). 
>     
>     Note that your patch also drops ComboBox_FrameWidth, the latter being also used in a separate enum (PM_ComboBoxFrameWidth).
> 
> David Edmundson wrote:
>     @Cristoph
>     sizeFromContents takes the frame as a parameter which oxygen uses. The frame lineWidth comes from the pixel metric for frames.
>     This must also happen for QWidgets as otherwise we wouldn't have a test for QLineEdits inside the pixelMetric function.
>     
>     From qquickstyleitem.cpp for LineEdits:
>                 QStyleOptionFrame frame;
>                 frame.state = m_styleoption->state;
>                 frame.lineWidth = qApp->style()->pixelMetric(QStyle::PM_DefaultFrameWidth, m_styleoption, 0);
>                 frame.rect = m_styleoption->rect;
>                 size = qApp->style()->sizeFromContents(QStyle::CT_LineEdit, &frame, QSize(width, height));
>     
>

@David, 
reading this code, I understand 
- that my "fears" above might be overstated. ;)
- that this is code you do not have control on, unless committing to Qt directly.
May I suggest to reformulate the patch to change the existing enums (in oxygenpixelmetrics.h) to 
LineEdit_FrameWidth = Frame_FrameWidth; 
(and same for the others; + add a comment that changing this will breack QtQuickControl)
so that the "properties" idea is not easily applicable. 
- leave the q_object_cast and enumerations
- change the default return value to Fram_FrameWidth.

This way, you don't remove functionality, but warn developpers that bad things will happen if they get use (and that discussion should be triggered)


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/d56fe5f5/attachment-0001.html>

From hein at kde.org  Fri Aug 30 14:17:36 2013
From: hein at kde.org (Eike Hein)
Date: Fri, 30 Aug 2013 14:17:36 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830124313.8892.86518@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
Message-ID: <20130830141736.24028.53561@vidsolbach.de>



> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote:
> > I respectfully disagree with the change.
> > 
> > If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?
> > 
> > The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).
> > 
> > That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 
> > 
> > Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.
> > 
> > Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...
> >
> 
> David Edmundson wrote:
>     I expected this to be a review which started a discussion :)
>     It's one that sets precedent for a few other things.
>     
>     The thing that matters is for QtQuick to get the same width as QLineEdits get. This happens to be FRAME_FRAMEWIDTH now.
>     
>     The reason I removed the LineEdit_FrameWidth is that if someone later does decide to change the LineEdit_FrameWidth the QtQuickControls will become broken again not matching the desktop counterpart. I'm deliberately taking away that option.
>     
>     The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets.
>     
>     I appreciate this is a very sucky situation to be in, but if we don't we will we see a very clear discrepancy in the UI depending on which technology happens to be used. I don't think we want that.
>     
>     By only other options are:
>     --
>     I could try to add PM_LineEdit and PM_ComboBox into Qt5.2? It would solve this particular issue.
>     The base implementation of QStyle can then just call PM_DefaultFrameWidth for backwards compatibility. I'm not sure it would get in as it relies on all styles calling the base implementation for enum values they don't support.
>     --
>     We make a QML Oxygen theme from 'scratch' a bit like how we have an Oxygen GTK theme.. different tech that happens to look the same.
> 
> David Edmundson wrote:
>     s/By/My
> 
> Christoph Feck wrote:
>     Why do QtQuickControls need pixelMetric() for line edits? To find out, how much margin there is around a styled line edit, it should simply use sizeFromContents() and subElementRect().
> 
> Hugo Pereira Da Costa wrote:
>     "The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets."
>     
>     Two things: this is no hacking. QWidget is an argument passed to the method (though it can be zero), there is no hack in using it, casting it, etc, as far as I can tell. This is a correct use of Qt's API.
>     
>     Second: "support the lowest common denominator of QStyle that they both follow even"
>     I disagree, and besides, I believe this will simply not work. It 'sort of does' in this specific case, but then q_object_cast is used all over the place in oxygen, to, for instance, install event filters, setup/trigger animation, enable mouse-grabbing in empty areas, enable hover on some items for which it was not allowed primarily, etc. Bottomline: I fear that the smallest common denominator that would work identical between QtQuick and QWidget, will be _very_ small, to the point it becomes quite unacceptable; and I 'a priori' do not want to follow this path (especially after all the hours invested in the above). 
>     
>     I aknowledge the will to make QtQuick look identical to QWidgets via oxygen, but imho it must not be done by introducing regressions to the QWidget's rendering. Animations for instance are an interesting case: it is built-in qt quick (if I understand right), while it is enforced via oxygen for widgets. If you drop it from oxygen (for the sake of the common denominator), then you actually introduce inconsistencies between the two. 
>     
>     So that I can see:
>     
>     1/ add decent fallbacks (for QtQuick) so that it looks "good enough", and fix them whenever this gets broken (the case you mentionned)
>     2/ implement missing features in QtQuick so that it allows one to look "identical" to what we can do with QWidgets. Naively, I can imagine passing "properties" to the QtQuick widgets, that one can test alongside the failing q_object_cast in oxygen
>     3/ as you say: clone oxygen for QtQuick. But I really would not advocate for this, since it is a pain to maintain, and does not solve anything with respect to solution 1/ concerning fixing things that get broken (inconsitent). 
>     
>     Note that your patch also drops ComboBox_FrameWidth, the latter being also used in a separate enum (PM_ComboBoxFrameWidth).
> 
> David Edmundson wrote:
>     @Cristoph
>     sizeFromContents takes the frame as a parameter which oxygen uses. The frame lineWidth comes from the pixel metric for frames.
>     This must also happen for QWidgets as otherwise we wouldn't have a test for QLineEdits inside the pixelMetric function.
>     
>     From qquickstyleitem.cpp for LineEdits:
>                 QStyleOptionFrame frame;
>                 frame.state = m_styleoption->state;
>                 frame.lineWidth = qApp->style()->pixelMetric(QStyle::PM_DefaultFrameWidth, m_styleoption, 0);
>                 frame.rect = m_styleoption->rect;
>                 size = qApp->style()->sizeFromContents(QStyle::CT_LineEdit, &frame, QSize(width, height));
>     
>
> 
> Hugo Pereira Da Costa wrote:
>     @David, 
>     reading this code, I understand 
>     - that my "fears" above might be overstated. ;)
>     - that this is code you do not have control on, unless committing to Qt directly.
>     May I suggest to reformulate the patch to change the existing enums (in oxygenpixelmetrics.h) to 
>     LineEdit_FrameWidth = Frame_FrameWidth; 
>     (and same for the others; + add a comment that changing this will breack QtQuickControl)
>     so that the "properties" idea is not easily applicable. 
>     - leave the q_object_cast and enumerations
>     - change the default return value to Fram_FrameWidth.
>     
>     This way, you don't remove functionality, but warn developpers that bad things will happen if they get use (and that discussion should be triggered)
>

It's hard for me to come up with a general opinion on this, I think it probably needs case-by-case examination in a lot of, well, cases. Generally speaking though I don't think we should be dropping features from Oxygen at this time until we've exhausted attempts at upstream solutions. It's unlikely we'll manage to make Controls styling regression-free that way in the 5.2 timeframe of course, but improving Controls for our use cases has to be a long-term goal anyway.

When it comes to lowest common denominator styling, I don't think Oxygen is a good candidate for that. The more similar it looks, the more will feature and visual regressions be felt. If we do want to go with lowest common denominator styling, I think we might need to come up with a new, simplified visual design to go along with it.

As for the specific case, I think the ability to set widget-specific frame widths is actually fairly important to do a good job at form styling. Oxygen doesn't really do much there right now, but I think it's a concern that upstream should answer somehow. So I think the code should probably stay and agree with Hugo on the short-term band-aid of syncing up the default return value ...


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/db3f5628/attachment.html>

From david at davidedmundson.co.uk  Fri Aug 30 15:11:14 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 30 Aug 2013 15:11:14 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830124313.8892.86518@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
Message-ID: <20130830151114.29875.54608@vidsolbach.de>



> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote:
> > I respectfully disagree with the change.
> > 
> > If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?
> > 
> > The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).
> > 
> > That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 
> > 
> > Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.
> > 
> > Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...
> >
> 
> David Edmundson wrote:
>     I expected this to be a review which started a discussion :)
>     It's one that sets precedent for a few other things.
>     
>     The thing that matters is for QtQuick to get the same width as QLineEdits get. This happens to be FRAME_FRAMEWIDTH now.
>     
>     The reason I removed the LineEdit_FrameWidth is that if someone later does decide to change the LineEdit_FrameWidth the QtQuickControls will become broken again not matching the desktop counterpart. I'm deliberately taking away that option.
>     
>     The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets.
>     
>     I appreciate this is a very sucky situation to be in, but if we don't we will we see a very clear discrepancy in the UI depending on which technology happens to be used. I don't think we want that.
>     
>     By only other options are:
>     --
>     I could try to add PM_LineEdit and PM_ComboBox into Qt5.2? It would solve this particular issue.
>     The base implementation of QStyle can then just call PM_DefaultFrameWidth for backwards compatibility. I'm not sure it would get in as it relies on all styles calling the base implementation for enum values they don't support.
>     --
>     We make a QML Oxygen theme from 'scratch' a bit like how we have an Oxygen GTK theme.. different tech that happens to look the same.
> 
> David Edmundson wrote:
>     s/By/My
> 
> Christoph Feck wrote:
>     Why do QtQuickControls need pixelMetric() for line edits? To find out, how much margin there is around a styled line edit, it should simply use sizeFromContents() and subElementRect().
> 
> Hugo Pereira Da Costa wrote:
>     "The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets."
>     
>     Two things: this is no hacking. QWidget is an argument passed to the method (though it can be zero), there is no hack in using it, casting it, etc, as far as I can tell. This is a correct use of Qt's API.
>     
>     Second: "support the lowest common denominator of QStyle that they both follow even"
>     I disagree, and besides, I believe this will simply not work. It 'sort of does' in this specific case, but then q_object_cast is used all over the place in oxygen, to, for instance, install event filters, setup/trigger animation, enable mouse-grabbing in empty areas, enable hover on some items for which it was not allowed primarily, etc. Bottomline: I fear that the smallest common denominator that would work identical between QtQuick and QWidget, will be _very_ small, to the point it becomes quite unacceptable; and I 'a priori' do not want to follow this path (especially after all the hours invested in the above). 
>     
>     I aknowledge the will to make QtQuick look identical to QWidgets via oxygen, but imho it must not be done by introducing regressions to the QWidget's rendering. Animations for instance are an interesting case: it is built-in qt quick (if I understand right), while it is enforced via oxygen for widgets. If you drop it from oxygen (for the sake of the common denominator), then you actually introduce inconsistencies between the two. 
>     
>     So that I can see:
>     
>     1/ add decent fallbacks (for QtQuick) so that it looks "good enough", and fix them whenever this gets broken (the case you mentionned)
>     2/ implement missing features in QtQuick so that it allows one to look "identical" to what we can do with QWidgets. Naively, I can imagine passing "properties" to the QtQuick widgets, that one can test alongside the failing q_object_cast in oxygen
>     3/ as you say: clone oxygen for QtQuick. But I really would not advocate for this, since it is a pain to maintain, and does not solve anything with respect to solution 1/ concerning fixing things that get broken (inconsitent). 
>     
>     Note that your patch also drops ComboBox_FrameWidth, the latter being also used in a separate enum (PM_ComboBoxFrameWidth).
> 
> David Edmundson wrote:
>     @Cristoph
>     sizeFromContents takes the frame as a parameter which oxygen uses. The frame lineWidth comes from the pixel metric for frames.
>     This must also happen for QWidgets as otherwise we wouldn't have a test for QLineEdits inside the pixelMetric function.
>     
>     From qquickstyleitem.cpp for LineEdits:
>                 QStyleOptionFrame frame;
>                 frame.state = m_styleoption->state;
>                 frame.lineWidth = qApp->style()->pixelMetric(QStyle::PM_DefaultFrameWidth, m_styleoption, 0);
>                 frame.rect = m_styleoption->rect;
>                 size = qApp->style()->sizeFromContents(QStyle::CT_LineEdit, &frame, QSize(width, height));
>     
>
> 
> Hugo Pereira Da Costa wrote:
>     @David, 
>     reading this code, I understand 
>     - that my "fears" above might be overstated. ;)
>     - that this is code you do not have control on, unless committing to Qt directly.
>     May I suggest to reformulate the patch to change the existing enums (in oxygenpixelmetrics.h) to 
>     LineEdit_FrameWidth = Frame_FrameWidth; 
>     (and same for the others; + add a comment that changing this will breack QtQuickControl)
>     so that the "properties" idea is not easily applicable. 
>     - leave the q_object_cast and enumerations
>     - change the default return value to Fram_FrameWidth.
>     
>     This way, you don't remove functionality, but warn developpers that bad things will happen if they get use (and that discussion should be triggered)
>
> 
> Eike Hein wrote:
>     It's hard for me to come up with a general opinion on this, I think it probably needs case-by-case examination in a lot of, well, cases. Generally speaking though I don't think we should be dropping features from Oxygen at this time until we've exhausted attempts at upstream solutions. It's unlikely we'll manage to make Controls styling regression-free that way in the 5.2 timeframe of course, but improving Controls for our use cases has to be a long-term goal anyway.
>     
>     When it comes to lowest common denominator styling, I don't think Oxygen is a good candidate for that. The more similar it looks, the more will feature and visual regressions be felt. If we do want to go with lowest common denominator styling, I think we might need to come up with a new, simplified visual design to go along with it.
>     
>     As for the specific case, I think the ability to set widget-specific frame widths is actually fairly important to do a good job at form styling. Oxygen doesn't really do much there right now, but I think it's a concern that upstream should answer somehow. So I think the code should probably stay and agree with Hugo on the short-term band-aid of syncing up the default return value ...

Ignore all my original patch.

I can get access to the QML type being used in the theme.

option->styleObject is a QQuickStyleItem. Whilst this is private, it has exported the useful part as a property.

I can get it wtih.

if (option && option->styleObject) {
 qDebug() << option->styleObject->property("elementType");
}


This produces output like "spinbox" "edit", "checkbox". etc. I can do this alongside the qobject_cast code to get work out which hints to use.

It slightly complicates the oxygen code, but it means we can fix this without any regressions.

\o/


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/593986e0/attachment-0001.html>

From hein at kde.org  Fri Aug 30 15:18:44 2013
From: hein at kde.org (Eike Hein)
Date: Fri, 30 Aug 2013 15:18:44 -0000
Subject: Review Request 112375: Use a single frame width for all
 PM_DefaultFrameWidth
In-Reply-To: <20130830124313.8892.86518@vidsolbach.de>
References: <20130830124313.8892.86518@vidsolbach.de>
Message-ID: <20130830151844.31033.3520@vidsolbach.de>



> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote:
> > I respectfully disagree with the change.
> > 
> > If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?
> > 
> > The other enumerations, (LineEdit_FrameWidth, ComboBox_FrameWidth, etc.) must stay: even if they have the same values at the moment, this might change in the future (in the near future in fact, since nuno and I want to revisit the metrics, make them more dpi independent, etc.).
> > 
> > That the cast wont work for QtQuick is not a good reason to remove it, with all (non quick) applications around, and for which such casts work. 
> > 
> > Now as for the change needed for QtQuick, this will (must) break (that is: change) all applications that render a frame and don't fall in the cathegories above (think custom widgets). I too have no example of this (but I'm sure there are), and since these are "custom" things, it is normal that they don't show up in oxygen-demo.
> > 
> > Please update the change to the "minimal" (namely -> change the default value returned for PM_DefaultFrameWidth), and then, well, we'll need to test ...
> >
> 
> David Edmundson wrote:
>     I expected this to be a review which started a discussion :)
>     It's one that sets precedent for a few other things.
>     
>     The thing that matters is for QtQuick to get the same width as QLineEdits get. This happens to be FRAME_FRAMEWIDTH now.
>     
>     The reason I removed the LineEdit_FrameWidth is that if someone later does decide to change the LineEdit_FrameWidth the QtQuickControls will become broken again not matching the desktop counterpart. I'm deliberately taking away that option.
>     
>     The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets.
>     
>     I appreciate this is a very sucky situation to be in, but if we don't we will we see a very clear discrepancy in the UI depending on which technology happens to be used. I don't think we want that.
>     
>     By only other options are:
>     --
>     I could try to add PM_LineEdit and PM_ComboBox into Qt5.2? It would solve this particular issue.
>     The base implementation of QStyle can then just call PM_DefaultFrameWidth for backwards compatibility. I'm not sure it would get in as it relies on all styles calling the base implementation for enum values they don't support.
>     --
>     We make a QML Oxygen theme from 'scratch' a bit like how we have an Oxygen GTK theme.. different tech that happens to look the same.
> 
> David Edmundson wrote:
>     s/By/My
> 
> Christoph Feck wrote:
>     Why do QtQuickControls need pixelMetric() for line edits? To find out, how much margin there is around a styled line edit, it should simply use sizeFromContents() and subElementRect().
> 
> Hugo Pereira Da Costa wrote:
>     "The only way we can support QtQuickControls is to support the lowest common denominator of QStyle that they both follow even if it makes the desktop worse (or at least different). 
>     This basically means supporting only values in QStyle, and not hacking in our own extra granularity determined by casting widgets."
>     
>     Two things: this is no hacking. QWidget is an argument passed to the method (though it can be zero), there is no hack in using it, casting it, etc, as far as I can tell. This is a correct use of Qt's API.
>     
>     Second: "support the lowest common denominator of QStyle that they both follow even"
>     I disagree, and besides, I believe this will simply not work. It 'sort of does' in this specific case, but then q_object_cast is used all over the place in oxygen, to, for instance, install event filters, setup/trigger animation, enable mouse-grabbing in empty areas, enable hover on some items for which it was not allowed primarily, etc. Bottomline: I fear that the smallest common denominator that would work identical between QtQuick and QWidget, will be _very_ small, to the point it becomes quite unacceptable; and I 'a priori' do not want to follow this path (especially after all the hours invested in the above). 
>     
>     I aknowledge the will to make QtQuick look identical to QWidgets via oxygen, but imho it must not be done by introducing regressions to the QWidget's rendering. Animations for instance are an interesting case: it is built-in qt quick (if I understand right), while it is enforced via oxygen for widgets. If you drop it from oxygen (for the sake of the common denominator), then you actually introduce inconsistencies between the two. 
>     
>     So that I can see:
>     
>     1/ add decent fallbacks (for QtQuick) so that it looks "good enough", and fix them whenever this gets broken (the case you mentionned)
>     2/ implement missing features in QtQuick so that it allows one to look "identical" to what we can do with QWidgets. Naively, I can imagine passing "properties" to the QtQuick widgets, that one can test alongside the failing q_object_cast in oxygen
>     3/ as you say: clone oxygen for QtQuick. But I really would not advocate for this, since it is a pain to maintain, and does not solve anything with respect to solution 1/ concerning fixing things that get broken (inconsitent). 
>     
>     Note that your patch also drops ComboBox_FrameWidth, the latter being also used in a separate enum (PM_ComboBoxFrameWidth).
> 
> David Edmundson wrote:
>     @Cristoph
>     sizeFromContents takes the frame as a parameter which oxygen uses. The frame lineWidth comes from the pixel metric for frames.
>     This must also happen for QWidgets as otherwise we wouldn't have a test for QLineEdits inside the pixelMetric function.
>     
>     From qquickstyleitem.cpp for LineEdits:
>                 QStyleOptionFrame frame;
>                 frame.state = m_styleoption->state;
>                 frame.lineWidth = qApp->style()->pixelMetric(QStyle::PM_DefaultFrameWidth, m_styleoption, 0);
>                 frame.rect = m_styleoption->rect;
>                 size = qApp->style()->sizeFromContents(QStyle::CT_LineEdit, &frame, QSize(width, height));
>     
>
> 
> Hugo Pereira Da Costa wrote:
>     @David, 
>     reading this code, I understand 
>     - that my "fears" above might be overstated. ;)
>     - that this is code you do not have control on, unless committing to Qt directly.
>     May I suggest to reformulate the patch to change the existing enums (in oxygenpixelmetrics.h) to 
>     LineEdit_FrameWidth = Frame_FrameWidth; 
>     (and same for the others; + add a comment that changing this will breack QtQuickControl)
>     so that the "properties" idea is not easily applicable. 
>     - leave the q_object_cast and enumerations
>     - change the default return value to Fram_FrameWidth.
>     
>     This way, you don't remove functionality, but warn developpers that bad things will happen if they get use (and that discussion should be triggered)
>
> 
> Eike Hein wrote:
>     It's hard for me to come up with a general opinion on this, I think it probably needs case-by-case examination in a lot of, well, cases. Generally speaking though I don't think we should be dropping features from Oxygen at this time until we've exhausted attempts at upstream solutions. It's unlikely we'll manage to make Controls styling regression-free that way in the 5.2 timeframe of course, but improving Controls for our use cases has to be a long-term goal anyway.
>     
>     When it comes to lowest common denominator styling, I don't think Oxygen is a good candidate for that. The more similar it looks, the more will feature and visual regressions be felt. If we do want to go with lowest common denominator styling, I think we might need to come up with a new, simplified visual design to go along with it.
>     
>     As for the specific case, I think the ability to set widget-specific frame widths is actually fairly important to do a good job at form styling. Oxygen doesn't really do much there right now, but I think it's a concern that upstream should answer somehow. So I think the code should probably stay and agree with Hugo on the short-term band-aid of syncing up the default return value ...
> 
> David Edmundson wrote:
>     Ignore all my original patch.
>     
>     I can get access to the QML type being used in the theme.
>     
>     option->styleObject is a QQuickStyleItem. Whilst this is private, it has exported the useful part as a property.
>     
>     I can get it wtih.
>     
>     if (option && option->styleObject) {
>      qDebug() << option->styleObject->property("elementType");
>     }
>     
>     
>     This produces output like "spinbox" "edit", "checkbox". etc. I can do this alongside the qobject_cast code to get work out which hints to use.
>     
>     It slightly complicates the oxygen code, but it means we can fix this without any regressions.
>     
>     \o/
>

Nifty!


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review38928
-----------------------------------------------------------


On Aug. 30, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 11:11 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Use a single frame width for all PM_DefaultFrameWidth
> 
> The current code sets a width of 3 for all line edits, combo boxes
> and frames, otherwise it returns a width of 1.
> 
> The QtQuickControls engine cannot qobject_cast() the widget so always
> return a frame width of 1 for qtquickcontrol line edits and combo boxes.
> 
> This simplifies the code and solves that issue.
> 
> I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility.
> 
> Note this is potentially a visual change in oxygen, however I have yet to see anything actually different.
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/67078f60/attachment.html>

From david at davidedmundson.co.uk  Fri Aug 30 15:55:49 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 30 Aug 2013 15:55:49 -0000
Subject: Review Request 112375: Correctly determine frame width when
 called from QtQuickControls
In-Reply-To: <20130830111147.26996.30198@vidsolbach.de>
References: <20130830111147.26996.30198@vidsolbach.de>
Message-ID: <20130830155549.2300.86276@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/
-----------------------------------------------------------

(Updated Aug. 30, 2013, 3:55 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Summary (updated)
-----------------

Correctly determine frame width when called from QtQuickControls


Description (updated)
-------

Correctly determine frame width when called from QtQuickControls

When oxygen is used in QtQuickControls the widget parameter is empty
as such we need to determine the widget type (lineedit etc. ) in a
different way


Diffs (updated)
-----

  kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 

Diff: http://git.reviewboard.kde.org/r/112375/diff/


Testing
-------


File Attachments
----------------

QML After
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
QML_Before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
Normal oxygen demo
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/d6eb84de/attachment-0001.html>

From david at davidedmundson.co.uk  Fri Aug 30 15:56:36 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Fri, 30 Aug 2013 15:56:36 -0000
Subject: Review Request 112375: Correctly determine frame width when
 called from QtQuickControls
In-Reply-To: <20130830155549.2300.86276@vidsolbach.de>
References: <20130830155549.2300.86276@vidsolbach.de>
Message-ID: <20130830155636.2300.48409@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/
-----------------------------------------------------------

(Updated Aug. 30, 2013, 3:56 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Description
-------

Correctly determine frame width when called from QtQuickControls

When oxygen is used in QtQuickControls the widget parameter is empty
as such we need to determine the widget type (lineedit etc. ) in a
different way


Diffs (updated)
-----

  kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 

Diff: http://git.reviewboard.kde.org/r/112375/diff/


Testing
-------


File Attachments
----------------

QML After
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
QML_Before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
Normal oxygen demo
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/eb545e2e/attachment.html>

From aseigo at kde.org  Fri Aug 30 17:17:54 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Fri, 30 Aug 2013 17:17:54 -0000
Subject: Review Request 112360: Enable mouse DataEngine on KF5
In-Reply-To: <20130829134715.7293.38864@vidsolbach.de>
References: <20130829134715.7293.38864@vidsolbach.de>
Message-ID: <20130830171754.24316.37588@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112360/#review38953
-----------------------------------------------------------


what compilation errors are you getting exactly? is it finding xfixes on your system? ... because if it does, it will be creating a class () that isn't being built!

- Aaron J. Seigo


On Aug. 29, 2013, 1:47 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112360/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 1:47 p.m.)
> 
> 
> Review request for Plasma and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> Enabling mouse DataEngine on KF5. Disabling cursor notification handler support for *now*. Some wired compilation errors.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt f08b3b0 
>   plasma/generic/dataengines/mouse/CMakeLists.txt 86d7acc 
>   plasma/generic/dataengines/mouse/mouseengine.h d55565d 
>   plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7 
> 
> Diff: http://git.reviewboard.kde.org/r/112360/diff/
> 
> 
> Testing
> -------
> 
> Compiles - check without cursor notification handler
> Links - check
> Installs - check
> Works - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/cddb321b/attachment.html>

From aseigo at kde.org  Fri Aug 30 17:18:59 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Fri, 30 Aug 2013 17:18:59 -0000
Subject: Review Request 112236: krunner: Add the full name of completion
 matches to history
In-Reply-To: <20130824095221.18482.38867@vidsolbach.de>
References: <20130824095221.18482.38867@vidsolbach.de>
Message-ID: <20130830171859.24567.58632@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112236/#review38954
-----------------------------------------------------------

Ship it!


minus the unrelated change that got pulled it accidentally, this looks good :)

- Aaron J. Seigo


On Aug. 24, 2013, 9:52 a.m., Harald Hvaal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112236/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 9:52 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Description
> -------
> 
> Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.
> 
> This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
> Exact matches are added as-is.
> 
> example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.
> 
> 
> Diffs
> -----
> 
>   krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 
>   kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 
> 
> Diff: http://git.reviewboard.kde.org/r/112236/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/cfb0785b/attachment.html>

From aseigo at kde.org  Fri Aug 30 17:44:40 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Fri, 30 Aug 2013 19:44:40 +0200
Subject: naming the next major release
In-Reply-To: <4407658.8sGEaQzegb@deimos.diaunet>
References: <137711932.oj8iDjKShl@freedom>
 <CAODYyLYthtWg_1Yj1E5f5nvvokSb-1w+AaS9JvCVYcaH34S8fQ@mail.gmail.com>
 <4407658.8sGEaQzegb@deimos.diaunet>
Message-ID: <1708369.3flGR6tP2R@freedom>

On Friday, August 23, 2013 11:50:20 Marco Martin wrote:
> On Thursday 22 August 2013 23:20:11 Giorgos Tsiapaliokas wrote:
> > KDE, for instance the most references in plasma active are
> > "Plasma Active" and not "KDE Plasma Active", but PA doesn't have any
> > distance from KDE. I believe that projects take some distance
> > from "KDE" when they stop referring to it and not when they remove the
> > "KDE" word, but that is just me of course :)
> 
> To me is the contrary,.. what is now plasma+kwin gets seenn by people as
> "the" KDE

This probably can not be done quite yet. I?m glad we?re slowly reaching that 
point .. but .. 

All of our investment in the first 10+ years was in the brand ?KDE?. That brand 
still has a greater amount of value and we are under zero requirement to 
demote Plasma in a misguided attempt to make things more amenable to 
theoretical options that don?t even currently exist.

If we say that ?KDE Plasma? makes ?Plasma? too much ?KDE?, then we are 
creating a real problem for ourselves: nothing can use ?KDE? in conjunction 
with its project name since that too would suggest exclusivity. That?s utterly 
the wrong direction as it precludes KDE ever being a true umbrella brand.

Without KDE being a brand with value, we lose one of the larger reasons to add 
your project to the KDE galaxy of products.

We need to move ?KDE? into the direction of being our ?Toyota? or ?Sony?. Just 
because there is a Toyota Camry does not mean that Toyota only makes Camrys. 
Just because there is a Sony Bravia doesn?t mean they only make televisions 
with the Bravia brand.

Instead of shying away from ?KDE Foo? we ought to instead be broadening its 
usage. This will do two things:

* remove (slowly) the incorrect perception that KDE implies exclusivity
* continue to invest in the KDE brand to benefit of all KDE projects

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/eb2b1190/attachment.sig>

From aseigo at kde.org  Fri Aug 30 17:48:38 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Fri, 30 Aug 2013 19:48:38 +0200
Subject: Help to display custom settings dialog in plasma widget (Python)
In-Reply-To: <CACVV-Hxjr07J_Xy8bW2ji09nNzbE5PqVKEM6K874sSLBEB=oKQ@mail.gmail.com>
References: <CACVV-Hxjr07J_Xy8bW2ji09nNzbE5PqVKEM6K874sSLBEB=oKQ@mail.gmail.com>
Message-ID: <1451516.surlM6LJV6@freedom>

On Wednesday, August 21, 2013 17:17:18 bug seagull wrote:
> I am creating a plasma widget that displays certain elements of an rss feed
> . It requires a string from the user in order to set the widget up. To get
> this input I made a dialog using qt designer and converted it to python
> code and imported it. I am unable to get this dialog to show up however
> when I click the widget settings.

you mean replace the standard settings dialog with your KInputDialog? if so, 
that is purposefully not possible. otherwise every single applet would have 
their own funky way of configuring and there would be zero opportunity to 
manage configuration for different target form factors centrally.

if you mean that you want to allow the user to bring up a dialog by clicking 
on some area (e.g. a pushbutton) on your widget, this is *highly* discouraged. 
dialogs may not be suitable for the platform in question, for instance.

what you can do, much more cleanly, is add your configuration UI to the 
standard config dialog and then if the setting is not made, call 
setConfigurationRequired(true)  (or the equivalent in Python)

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/25a6d351/attachment.sig>

From aseigo at kde.org  Fri Aug 30 17:50:59 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Fri, 30 Aug 2013 19:50:59 +0200
Subject: My first plasmoid
In-Reply-To: <CAMBZssuEAFpaeeXpj2jGUHoBxgMv+zwoqY8+NHSkH26misvPaA@mail.gmail.com>
References: <CAMBZssuEAFpaeeXpj2jGUHoBxgMv+zwoqY8+NHSkH26misvPaA@mail.gmail.com>
Message-ID: <6338286.YjlCAv1YEg@freedom>

On Friday, August 23, 2013 23:40:06 Niclas Ekstedt wrote:
> So what do you guys think. Would this be possible to do? And are there any
> examples available that would help me along?

There is already lionmail that does much of what you?re looking for .. but it 
needs a developer to apply some love and tenderness to it.

It is currently all C++, but a port to QML would be *awesome*.

Sebastian would be the person who could help you the most on that journey as 
he is the original author and maintainer of lionmail.

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/ea5d624d/attachment-0001.sig>

From yesmichel at gmail.com  Fri Aug 30 16:26:08 2013
From: yesmichel at gmail.com (Anthony Vital)
Date: Fri, 30 Aug 2013 18:26:08 +0200
Subject: QML/javascript and KNotification
Message-ID: <CABvSm-CD789rJdkHO_mKp6c-d3+r7kEtRH-Yhxr3ziHwZtnKZA@mail.gmail.com>

Hello,
I'm trying to use KNotification in a QML plasmoid but there doesn't seem to
be a good way to do this. Using the notifications dataengine is not
satisfying because it won't let me use a .notifyrc file. So for now I use a
qdbus command but it's kind of a hack.

Moreover, in order to install the notifyrc file correctly, I have to
install it (+ the plasmoid icon so that it is detected in the notifications
config panel) with CMake. I read that installing a plasmoid with CMake is
the recommended way, and I personnaly don't mind doing so, but it prevents
installing the plasmoid simply from a plasmoid package/KGHNS. Any thoughts
on this?

Anthony
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/67d4397d/attachment.html>

From aseigo at kde.org  Fri Aug 30 17:57:44 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Fri, 30 Aug 2013 19:57:44 +0200
Subject: QML/javascript and KNotification
In-Reply-To: <CABvSm-CD789rJdkHO_mKp6c-d3+r7kEtRH-Yhxr3ziHwZtnKZA@mail.gmail.com>
References: <CABvSm-CD789rJdkHO_mKp6c-d3+r7kEtRH-Yhxr3ziHwZtnKZA@mail.gmail.com>
Message-ID: <33624675.xzGmBpyCGR@freedom>

On Friday, August 30, 2013 18:26:08 Anthony Vital wrote:
> Moreover, in order to install the notifyrc file correctly, I have to
> install it (+ the plasmoid icon so that it is detected in the notifications
> config panel) with CMake. I read that installing a plasmoid with CMake is
> the recommended way, and I personnaly don't mind doing so, but it prevents
> installing the plasmoid simply from a plasmoid package/KGHNS. Any thoughts
> on this?

* the notifications engine should really be updated to call into the knotify4 
daemon properly rather than ?fake it? as it currently does (it just adds 
entries directly into the local notifications engine .. that this works at all 
is a happy accident of it running in the same process as the notifications 
widget which uses the notifications dataengine! but if you try this in a 
separate process such as plasma-windowed or the applet strip in plasma active, 
this fails completely)

* knotify4 is built around the assumption that all applications are installed 
to the system. this really is no longer a valid assumption in our modern day 
and age. a work around would be to copy .notifyrc files included in applet 
packages to the correct subdirectory in `kde4-config --localprefix` on 
installation and then add information as to which notifyrc to use in calls to 
knotify4 ... but this feels like a maaaaaassive hack.

i really think this is probably only something that can be properly fixed in 
Frameworks 5 with a refactor of KNotification.

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/965440e1/attachment.sig>

From notmart at gmail.com  Fri Aug 30 18:23:26 2013
From: notmart at gmail.com (Marco Martin)
Date: Fri, 30 Aug 2013 20:23:26 +0200
Subject: QML/javascript and KNotification
In-Reply-To: <33624675.xzGmBpyCGR@freedom>
References: <CABvSm-CD789rJdkHO_mKp6c-d3+r7kEtRH-Yhxr3ziHwZtnKZA@mail.gmail.com>
 <33624675.xzGmBpyCGR@freedom>
Message-ID: <1679772.6iNY5qdUWX@deimos.diaunet>

On Friday 30 August 2013 19:57:44 Aaron J. Seigo wrote:
> --localprefix` on installation and then add information as to which
> notifyrc to use in calls to knotify4 ... but this feels like a maaaaaassive
> hack.
> 
> i really think this is probably only something that can be properly fixed in
> Frameworks 5 with a refactor of KNotification.

would pretty much be a relaxing of the requirement "all possible types of 
notifications are preregistered/pre-authorized"?

-- 
Marco Martin

From aseigo at kde.org  Fri Aug 30 18:30:25 2013
From: aseigo at kde.org (Aaron J. Seigo)
Date: Fri, 30 Aug 2013 20:30:25 +0200
Subject: QML/javascript and KNotification
In-Reply-To: <1679772.6iNY5qdUWX@deimos.diaunet>
References: <CABvSm-CD789rJdkHO_mKp6c-d3+r7kEtRH-Yhxr3ziHwZtnKZA@mail.gmail.com>
 <33624675.xzGmBpyCGR@freedom> <1679772.6iNY5qdUWX@deimos.diaunet>
Message-ID: <1802541.OIpJXRM6lr@freedom>

On Friday, August 30, 2013 20:23:26 Marco Martin wrote:
> On Friday 30 August 2013 19:57:44 Aaron J. Seigo wrote:
> > --localprefix` on installation and then add information as to which
> > notifyrc to use in calls to knotify4 ... but this feels like a
> > maaaaaassive
> > hack.
> > 
> > i really think this is probably only something that can be properly fixed
> > in Frameworks 5 with a refactor of KNotification.
> 
> would pretty much be a relaxing of the requirement "all possible types of
> notifications are preregistered/pre-authorized"?

... or allow flexibility in where the knotifyrc file for a given notification is 
located.

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/bedfa5c0/attachment.sig>

From notmart at gmail.com  Fri Aug 30 18:48:57 2013
From: notmart at gmail.com (Marco Martin)
Date: Fri, 30 Aug 2013 20:48:57 +0200
Subject: QML/javascript and KNotification
In-Reply-To: <1802541.OIpJXRM6lr@freedom>
References: <CABvSm-CD789rJdkHO_mKp6c-d3+r7kEtRH-Yhxr3ziHwZtnKZA@mail.gmail.com>
 <1679772.6iNY5qdUWX@deimos.diaunet> <1802541.OIpJXRM6lr@freedom>
Message-ID: <2804906.163EcsWpJZ@deimos.diaunet>

On Friday 30 August 2013 20:30:25 Aaron J. Seigo wrote:
> > 
> > would pretty much be a relaxing of the requirement "all possible types of
> > notifications are preregistered/pre-authorized"?
> 
> ... or allow flexibility in where the knotifyrc file for a given
> notification is located.

could even be passed on the fly on dbus when the notification is done?

-- 
Marco Martin

From bhush94 at gmail.com  Sat Aug 31 04:12:51 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sat, 31 Aug 2013 04:12:51 -0000
Subject: Review Request 112360: Enable mouse DataEngine on KF5
In-Reply-To: <20130830171754.24316.37588@vidsolbach.de>
References: <20130830171754.24316.37588@vidsolbach.de>
Message-ID: <20130831041251.18894.57794@vidsolbach.de>



> On Aug. 30, 2013, 5:17 p.m., Aaron J. Seigo wrote:
> > what compilation errors are you getting exactly? is it finding xfixes on your system? ... because if it does, it will be creating a class () that isn't being built!

If I uncomment the if (X11_Xfixes_FOUND) blocks I get this errors. http://paste.kde.org/pe93ee327/


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112360/#review38953
-----------------------------------------------------------


On Aug. 29, 2013, 1:47 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112360/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 1:47 p.m.)
> 
> 
> Review request for Plasma and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> Enabling mouse DataEngine on KF5. Disabling cursor notification handler support for *now*. Some wired compilation errors.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt f08b3b0 
>   plasma/generic/dataengines/mouse/CMakeLists.txt 86d7acc 
>   plasma/generic/dataengines/mouse/mouseengine.h d55565d 
>   plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7 
> 
> Diff: http://git.reviewboard.kde.org/r/112360/diff/
> 
> 
> Testing
> -------
> 
> Compiles - check without cursor notification handler
> Links - check
> Installs - check
> Works - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/f2b2a4ce/attachment.html>

From mgraesslin at kde.org  Sat Aug 31 06:39:35 2013
From: mgraesslin at kde.org (=?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?=)
Date: Sat, 31 Aug 2013 06:39:35 -0000
Subject: Review Request 112360: Enable mouse DataEngine on KF5
In-Reply-To: <20130829134715.7293.38864@vidsolbach.de>
References: <20130829134715.7293.38864@vidsolbach.de>
Message-ID: <20130831063935.9149.4943@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112360/#review38978
-----------------------------------------------------------


Note: the CursorNotificationHandler has a method x11Event which means this needs porting to XCB and QAbstractNativeEventFilter. If you have any questions about that, just ping me on IRC on Monday.

- Martin Gr??lin


On Aug. 29, 2013, 3:47 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112360/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 3:47 p.m.)
> 
> 
> Review request for Plasma and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> Enabling mouse DataEngine on KF5. Disabling cursor notification handler support for *now*. Some wired compilation errors.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt f08b3b0 
>   plasma/generic/dataengines/mouse/CMakeLists.txt 86d7acc 
>   plasma/generic/dataengines/mouse/mouseengine.h d55565d 
>   plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7 
> 
> Diff: http://git.reviewboard.kde.org/r/112360/diff/
> 
> 
> Testing
> -------
> 
> Compiles - check without cursor notification handler
> Links - check
> Installs - check
> Works - check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/aa0f88a7/attachment-0001.html>

From harald.hvaal at gmail.com  Sat Aug 31 09:34:26 2013
From: harald.hvaal at gmail.com (Harald Hvaal)
Date: Sat, 31 Aug 2013 09:34:26 -0000
Subject: Review Request 112236: krunner: Add the full name of completion
 matches to history
In-Reply-To: <20130824095221.18482.38867@vidsolbach.de>
References: <20130824095221.18482.38867@vidsolbach.de>
Message-ID: <20130831093426.30892.46791@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112236/
-----------------------------------------------------------

(Updated Aug. 31, 2013, 11:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for kde-workspace and Plasma.


Description
-------

Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.

This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
Exact matches are added as-is.

example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.


Diffs
-----

  krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 
  kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 

Diff: http://git.reviewboard.kde.org/r/112236/diff/


Testing
-------


Thanks,

Harald Hvaal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/e3fda367/attachment.html>

From notmart at gmail.com  Sat Aug 31 11:35:27 2013
From: notmart at gmail.com (Marco Martin)
Date: Sat, 31 Aug 2013 13:35:27 +0200
Subject: naming the next major release
In-Reply-To: <1708369.3flGR6tP2R@freedom>
References: <137711932.oj8iDjKShl@freedom> <4407658.8sGEaQzegb@deimos.diaunet>
 <1708369.3flGR6tP2R@freedom>
Message-ID: <201308311335.27837.notmart@gmail.com>

On Friday 30 August 2013, Aaron J. Seigo wrote:
> 
> Without KDE being a brand with value, we lose one of the larger reasons to
> add your project to the KDE galaxy of products.
> 
> We need to move ?KDE? into the direction of being our ?Toyota? or ?Sony?.
> Just because there is a Toyota Camry does not mean that Toyota only makes
> Camrys. Just because there is a Sony Bravia doesn?t mean they only make
> televisions with the Bravia brand.

agreed.
there are other open source projects that tried to do a similar thing (altough 
not exactly the same) apache and mozilla come to my mind.

with varying degrees of success, probably for the same reason. in the case of 
mozilla firefox pretty much eclipses all the other mozilla projects, in the 
case of apache the http server still eclipses any other apache project, so it 
keeps being "the" apache...

in KDE we are probably in a better position, since we have several big 
projects that can be instantly positioned as different products, like plasma, 
calligra, kdevelop.. under an umbrella brand (and probably is already 
happening, slowly)

The one thing that i would really love to get away with tough is replacng the 
conception of "for" KDE (and therefore unusable everywhere else as "KDE" was a 
different operating system altogether) with "by" KDE

Cheers,
Marco Martin

From hugo at oxygen-icons.org  Sat Aug 31 12:14:38 2013
From: hugo at oxygen-icons.org (Hugo Pereira Da Costa)
Date: Sat, 31 Aug 2013 12:14:38 -0000
Subject: Review Request 112375: Correctly determine frame width when
 called from QtQuickControls
In-Reply-To: <20130830155636.2300.48409@vidsolbach.de>
References: <20130830155636.2300.48409@vidsolbach.de>
Message-ID: <20130831121438.20576.29949@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review39005
-----------------------------------------------------------



kstyles/oxygen/oxygenstyle.cpp
<http://git.reviewboard.kde.org/r/112375/#comment28774>

    Rather than looking up the property multiple times, alongside the q_object_cast, I would rather add the test just before the last 'if' (when everything else has failed), and possibly caching the property in a QString. 
    
    Something like
    
    else if( !widget && option && option->styleObject ) {
        const QString elementType = option->styleObject->property( elementType );
    
        ... your code (all ifs, duplicated from the widget case)
    
    } else { 
    
        return 1;
    
    }
    
    This way, you don't lookup the property if the widget is defined,
    and You don't lookup the property multiple times. 
    This comes at the price of some code duplication, but it is a small block of code, so I'd deem that acceptable.
    
    Oppinion ?


- Hugo Pereira Da Costa


On Aug. 30, 2013, 3:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 3:56 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Correctly determine frame width when called from QtQuickControls
> 
> When oxygen is used in QtQuickControls the widget parameter is empty
> as such we need to determine the widget type (lineedit etc. ) in a
> different way
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/412ea422/attachment.html>

From david at davidedmundson.co.uk  Sat Aug 31 12:26:33 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Sat, 31 Aug 2013 12:26:33 -0000
Subject: Review Request 112375: Correctly determine frame width when
 called from QtQuickControls
In-Reply-To: <20130831121438.20576.29949@vidsolbach.de>
References: <20130831121438.20576.29949@vidsolbach.de>
Message-ID: <20130831122633.25131.91048@vidsolbach.de>



> On Aug. 31, 2013, 12:14 p.m., Hugo Pereira Da Costa wrote:
> > kstyles/oxygen/oxygenstyle.cpp, line 612
> > <http://git.reviewboard.kde.org/r/112375/diff/4/?file=185744#file185744line612>
> >
> >     Rather than looking up the property multiple times, alongside the q_object_cast, I would rather add the test just before the last 'if' (when everything else has failed), and possibly caching the property in a QString. 
> >     
> >     Something like
> >     
> >     else if( !widget && option && option->styleObject ) {
> >         const QString elementType = option->styleObject->property( elementType );
> >     
> >         ... your code (all ifs, duplicated from the widget case)
> >     
> >     } else { 
> >     
> >         return 1;
> >     
> >     }
> >     
> >     This way, you don't lookup the property if the widget is defined,
> >     and You don't lookup the property multiple times. 
> >     This comes at the price of some code duplication, but it is a small block of code, so I'd deem that acceptable.
> >     
> >     Oppinion ?

Makes sense. Will change.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/#review39005
-----------------------------------------------------------


On Aug. 30, 2013, 3:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112375/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 3:56 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> Correctly determine frame width when called from QtQuickControls
> 
> When oxygen is used in QtQuickControls the widget parameter is empty
> as such we need to determine the widget type (lineedit etc. ) in a
> different way
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 
> 
> Diff: http://git.reviewboard.kde.org/r/112375/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> QML After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
> QML_Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
> Normal oxygen demo
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/72dc7ceb/attachment.html>

From bcooksley at kde.org  Sat Aug 31 13:03:59 2013
From: bcooksley at kde.org (Ben Cooksley)
Date: Sun, 1 Sep 2013 01:03:59 +1200
Subject: Force push to plasma-framework
Message-ID: <CA+XidOGFA1MuR-Uram9uEYud9ANy98R3x1+cNySsHgjfwQqDjg@mail.gmail.com>

Hi everyone,

Due to an unfortunate accident involving git merge, several branches
of the plasma-framework repository were rendered unusable.

To correct this, two branches have been forcibly rewound. They are:
- master: now at ea1b637
- ivan/shell-switching: now at f8c2ff5.

The following commits have also been blacklisted from entering the repository:
- 89894b9ce0347204b7835d476a11ae24ff77ed5c
- a793df3c7473b25879491163d622acd988c00a5b
- fbb2e749aeaeca987e901e2f0b8046c9f12b578b
- 1fc1fda8331254b01f752fb04a8575b051543fb5
- f68ee1a764513db268644365c7879d3bc9f942bd

If you have any of the above commits in your current checked out
branch, you will need to hard reset it to the upstream version of that
branch before continuing.

Any commits which you have not yet pushed will need to be cherry
picked to the reset branches, or reapplied manually. Do not attempt to
rebase your local branch to correct this under any circumstances.

Regards,
Ben Cooksley
KDE Sysadmin

From bhush94 at gmail.com  Sat Aug 31 13:36:42 2013
From: bhush94 at gmail.com (Bhushan Shah)
Date: Sat, 31 Aug 2013 13:36:42 -0000
Subject: Review Request 112404: enable statusnotiferitem dataengine on KF5
Message-ID: <20130831133642.3818.89029@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112404/
-----------------------------------------------------------

Review request for Plasma and Sebastian K?gler.


Description
-------

name says all.


Diffs
-----

  plasma/generic/dataengines/CMakeLists.txt f08b3b0 
  plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt 18599c8 
  plasma/generic/dataengines/statusnotifieritem/plasma-engine-statusnotifieritem.desktop PRE-CREATION 
  plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop cbbad21 
  plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp 399677a 

Diff: http://git.reviewboard.kde.org/r/112404/diff/


Testing
-------

compiles - check
links - check
installs - check
works- check


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/a926145c/attachment-0001.html>

From david at davidedmundson.co.uk  Sat Aug 31 13:38:37 2013
From: david at davidedmundson.co.uk (David Edmundson)
Date: Sat, 31 Aug 2013 13:38:37 -0000
Subject: Review Request 112404: enable statusnotiferitem dataengine on KF5
In-Reply-To: <20130831133642.3818.89029@vidsolbach.de>
References: <20130831133642.3818.89029@vidsolbach.de>
Message-ID: <20130831133837.4154.79570@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112404/#review39019
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 31, 2013, 1:36 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112404/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2013, 1:36 p.m.)
> 
> 
> Review request for Plasma and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> name says all.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt f08b3b0 
>   plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt 18599c8 
>   plasma/generic/dataengines/statusnotifieritem/plasma-engine-statusnotifieritem.desktop PRE-CREATION 
>   plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop cbbad21 
>   plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp 399677a 
> 
> Diff: http://git.reviewboard.kde.org/r/112404/diff/
> 
> 
> Testing
> -------
> 
> compiles - check
> links - check
> installs - check
> works- check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/91909898/attachment.html>

From notmart at gmail.com  Sat Aug 31 13:41:59 2013
From: notmart at gmail.com (Marco Martin)
Date: Sat, 31 Aug 2013 13:41:59 -0000
Subject: Review Request 112404: enable statusnotiferitem dataengine on KF5
In-Reply-To: <20130831133642.3818.89029@vidsolbach.de>
References: <20130831133642.3818.89029@vidsolbach.de>
Message-ID: <20130831134159.4432.7174@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112404/#review39020
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Aug. 31, 2013, 1:36 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112404/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2013, 1:36 p.m.)
> 
> 
> Review request for Plasma and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> name says all.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt f08b3b0 
>   plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt 18599c8 
>   plasma/generic/dataengines/statusnotifieritem/plasma-engine-statusnotifieritem.desktop PRE-CREATION 
>   plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop cbbad21 
>   plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp 399677a 
> 
> Diff: http://git.reviewboard.kde.org/r/112404/diff/
> 
> 
> Testing
> -------
> 
> compiles - check
> links - check
> installs - check
> works- check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/daa9b0ad/attachment.html>

From null at kde.org  Sat Aug 31 13:47:46 2013
From: null at kde.org (Commit Hook)
Date: Sat, 31 Aug 2013 13:47:46 -0000
Subject: Review Request 112404: enable statusnotiferitem dataengine on KF5
In-Reply-To: <20130831133642.3818.89029@vidsolbach.de>
References: <20130831133642.3818.89029@vidsolbach.de>
Message-ID: <20130831134746.4777.19589@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112404/#review39021
-----------------------------------------------------------


This review has been submitted with commit 14f858445305902107ece1186d38739ad224be76 by Bhushan Shah to branch frameworks-scratch.

- Commit Hook


On Aug. 31, 2013, 1:36 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112404/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2013, 1:36 p.m.)
> 
> 
> Review request for Plasma and Sebastian K?gler.
> 
> 
> Description
> -------
> 
> name says all.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt f08b3b0 
>   plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt 18599c8 
>   plasma/generic/dataengines/statusnotifieritem/plasma-engine-statusnotifieritem.desktop PRE-CREATION 
>   plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop cbbad21 
>   plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp 399677a 
> 
> Diff: http://git.reviewboard.kde.org/r/112404/diff/
> 
> 
> Testing
> -------
> 
> compiles - check
> links - check
> installs - check
> works- check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/dc6d9fac/attachment.html>

From null at kde.org  Sat Aug 31 13:47:49 2013
From: null at kde.org (Commit Hook)
Date: Sat, 31 Aug 2013 13:47:49 -0000
Subject: Review Request 112404: enable statusnotiferitem dataengine on KF5
In-Reply-To: <20130831133642.3818.89029@vidsolbach.de>
References: <20130831133642.3818.89029@vidsolbach.de>
Message-ID: <20130831134749.4806.54242@vidsolbach.de>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112404/
-----------------------------------------------------------

(Updated Aug. 31, 2013, 1:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Sebastian K?gler.


Description
-------

name says all.


Diffs
-----

  plasma/generic/dataengines/CMakeLists.txt f08b3b0 
  plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt 18599c8 
  plasma/generic/dataengines/statusnotifieritem/plasma-engine-statusnotifieritem.desktop PRE-CREATION 
  plasma/generic/dataengines/statusnotifieritem/plasma_engine_statusnotifieritem.desktop cbbad21 
  plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp 399677a 

Diff: http://git.reviewboard.kde.org/r/112404/diff/


Testing
-------

compiles - check
links - check
installs - check
works- check


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130831/fd290f71/attachment.html>

From cristeab at gmail.com  Sat Aug 31 17:33:53 2013
From: cristeab at gmail.com (cristeab at gmail.com)
Date: Sat, 31 Aug 2013 19:33:53 +0200
Subject: Implement plasmoid configuration dialog in QtQuick 1.1
Message-ID: <2192814.BSYCBSoRuZ@linux-sl1a.site>

Hi

What is the easiest way of implementing a plasmoid configuration dialog 
in a mixed C++ and QML application ? Some hints for using only QML 
are provided in
http://aseigo.blogspot.fr/2013/02/elegant-plasmoid-configuration.html
, but this seems to be available only for Qt Quick 2.0

regards
Bogdan