Review Request: Plasmate: when "Enable signing plasmoid" is enabled, automatically choose a key

Giorgos Tsiapaliwkas terietor at gmail.com
Tue Jun 12 11:44:57 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105074/
-----------------------------------------------------------

(Updated June 12, 2012, 11:44 a.m.)


Review request for Plasma, Sebastian Kügler and Aaron J. Seigo.


Changes
-------

I had missed a few issues with the previous patch.
No the patch is working correct.

Should I commit?

P.S.: also I fixed the issues that you mentioned


Description
-------

Hello,

right now when "Enable signing plasmoid" is enabled if the user doesn't choose a gpg key,
plasmate won't have a key enabled. So "Enable signing plasmoid", will be enabled but no signing will
happen. 

How to test the issue,
- rm ${KDEHOME}/share/config/plasmaterc
-create a gpg key(gpg --gen-key)
-open plasmate
-click publisher
-click enable


Diffs (updated)
-----

  publisher/signingwidget.h 501752e 
  publisher/signingwidget.cpp e63dbbd 

Diff: http://git.reviewboard.kde.org/r/105074/diff/


Testing
-------

It works.


Thanks,

Giorgos Tsiapaliwkas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120612/765f2ee9/attachment.html>


More information about the Plasma-devel mailing list