Review Request: Bug fix for 278765

Aaron J. Seigo aseigo at kde.org
Wed Nov 16 17:00:54 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102304/#review8236
-----------------------------------------------------------



plasma/desktop/applets/tasks/abstracttaskitem.cpp
<http://git.reviewboard.kde.org/r/102304/#comment7036>

    much simpler is:
    
    data.setInstantPopup(KWindowSystem::compositingActive());
    
    it does the same thing after all :)


- Aaron J. Seigo


On Sept. 29, 2011, 10:39 a.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102304/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 10:39 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> hello,
> 
> I found a third solution for this bug(Aaron said the other two at tha plasma-devel mailing list).
> 
> 
> This addresses bug 278765.
>     http://bugs.kde.org/show_bug.cgi?id=278765
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/abstracttaskitem.cpp 91e9064 
>   plasma/desktop/applets/tasks/applauncheritem.cpp 4dc24ee 
>   plasma/desktop/applets/tasks/taskgroupitem.cpp 5c0540a 
>   plasma/desktop/applets/tasks/windowtaskitem.cpp a782063 
> 
> Diff: http://git.reviewboard.kde.org/r/102304/diff/diff
> 
> 
> Testing
> -------
> 
> compiles fines
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111116/88768626/attachment.html>


More information about the Plasma-devel mailing list