Review Request: Fix notification adjustPosition on resizeEven

[Alex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101981/
-----------------------------------------------------------

(Updated July 17, 2011, 6:49 p.m.)


Review request for Plasma.


Changes
-------

With the patch, that won't happen


Summary
-------

On resizeEvent adjustPosition will be called so the widget can update the position in relation with the new size. The problem before this patch is that the code is not taking into account the position of the notification, whether it is closer to the top or to the bottom.

The current behavior is correct if the notification is closer to the top but it is incorrect if the notification is closer to the bottom since in that case we want the notification to increment the Y if the old size was bigger than the current size.

I can't find better words to describe the problem, so I will attach a screenshot.


Diffs
-----

  plasma/generic/applets/notifications/ui/stackdialog.h 89c36a9 
  plasma/generic/applets/notifications/ui/stackdialog.cpp 0d3f6a0 

Diff: http://git.reviewboard.kde.org/r/101981/diff


Testing
-------

Everything I could think of:
1-Notifications in each corner of the screen
2-Notifications "gap" into a side.
3-Notifications at the middle

So far, so good!


Screenshots
-----------

Notification Wrong pos
  http://git.reviewboard.kde.org/r/101981/s/204/


Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110717/0a376a5f/attachment-0001.htm