Review Request: allow runners to suspend further match-spawning

[Artur de Souza (MoRpHeUz)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5194/#review7365
-----------------------------------------------------------

Ship it!


Nice catch. From what I saw it seems a nice feature and required one. The code looks 100% too :)

- Artur


On 2010-08-31 02:15:43, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5194/
> -----------------------------------------------------------
> 
> (Updated 2010-08-31 02:15:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Some AbstractRunner subclasses do some set up in their match method which other threads need to wait on and it would be preferable if more threads for that runner were spawned until it was complete. See the kill runner for an example of this.
> 
> In most cases, though possibly not all (but certainly in the case of the Kill runner), this is done to avoid blocking in the slot connected to by prepare(). Even if the prepare()-connect slot is run in a separate thread, however, there's still the need to mark the runner as not currently match-able, preventing unwanted thread spawning.
> 
> This patch provides for this. It is complimentary and orthogonal to the idea of runners with re-entrant match() methods.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/abstractrunner.h 1169194 
>   /trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1169194 
>   /trunk/KDE/kdelibs/plasma/private/abstractrunner_p.h 1169194 
>   /trunk/KDE/kdelibs/plasma/runnermanager.h 1169194 
>   /trunk/KDE/kdelibs/plasma/runnermanager.cpp 1169194 
> 
> Diff: http://svn.reviewboard.kde.org/r/5194/diff
> 
> 
> Testing
> -------
> 
> Tried with kill runner, works charmingly.
> 
> 
> Thanks,
> 
> Aaron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100902/3ff09fd8/attachment.htm