Review Request: Optional passive calendar popup for the Digital Clock

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5513/#review7934
-----------------------------------------------------------


as discussed earlier today on irc, and for all the reasons discussed there, this is not a change we want or care to have. it's one more code path that will end up being maintained by yours truly in the future. sorry.

you are completely welcome to maintain this as a separate plasmoid or as a patch to the source, of course.

"The only downside is that you either have to relog or somehow reload that digital-clock plasmoid when you change the "passivePopup" value."

that's probably because you need to read the value in configChanged().


/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp
<http://svn.reviewboard.kde.org/r/5513/#comment8183>

    i don't see why the behaviour should be different in other form factors. *shrug*


- Aaron


On 2010-10-02 02:05:02, Mark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5513/
> -----------------------------------------------------------
> 
> (Updated 2010-10-02 02:05:02)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I know some people don't like this idea thus the default is the same as it's right now.
> I want to make the calendar passive popup optional since some people like it that way (me included).
> 
> OK to commit?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 1181669 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 1181669 
> 
> Diff: http://svn.reviewboard.kde.org/r/5513/diff
> 
> 
> Testing
> -------
> 
> Tested it a few times with true and false and seems to work just fine.
> The only downside is that you either have to relog or somehow reload that digital-clock plasmoid when you change the "passivePopup" value.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101002/65c5c203/attachment-0001.htm