Review Request: Change device notifier tooltips to respect plasma tooltip style

Aaron Seigo aseigo at kde.org
Fri May 21 17:43:22 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4100/#review5806
-----------------------------------------------------------


unfortunately it's too late for 4.5 due to the string freeze, but this should go into 4.6. in fact, i'd like to see it change from being the last plugged in device to perhaps a list of all devices plugged in along with their mount status? battery, screen resize, audio, etc. are all providing useful "snapshot" information in their tooltips these days, and i feel that the device notifier's tooltip would be more useful if it gave a more accurate idea of what's what. what do you think?

- Aaron


On 2010-05-21 15:15:38, Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4100/
> -----------------------------------------------------------
> 
> (Updated 2010-05-21 15:15:38)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Currently, device notifier tooltips use normal text. while all other plasma tooltips have main text and subtext. To enforce consistency, I've changed it to use main text for "Most recent device" and subtext for the rest. However, I'm not sure if it's OK from string freeze point of view, as I've broken a string in two and killed a dot.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/devicenotifier.cpp 1128711 
> 
> Diff: http://reviewboard.kde.org/r/4100/diff
> 
> 
> Testing
> -------
> 
> Device  Notifier tooltip looks fine now.
> 
> 
> Thanks,
> 
> Ignat
> 
>



More information about the Plasma-devel mailing list