Review Request: SkipSwitcher functionality

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3800/
-----------------------------------------------------------

(Updated 2010-05-02 14:13:46.249350)


Review request for Plasma, Aaron Seigo, Marco Martin, and Lubos Lunak.


Changes
-------

Removed the window state _KDE_SKIP_SWITCHER. The window rule just changes an internal variable without setting a property. This makes it useless for the Plasma usecases, but it is trivial to add support for special plasma window types. We just have to specify the window types (which we should do this week as I will only have time on next Sunday to add features before we have the great feature freeze of 4.5).

The skip switcher state is now also passed to the effects and honoured by present windows and desktop grid.


Summary
-------

This patch adds _KDE_STATE_SKIP_SWITCHER to _NET_WM_STATE. Alt+Tab will exclude windows with this state set (this automatically includes the alt+tab replacement effects). I will extend Present Windows and Desktop Grid to honour this flag, too.

As soon as the patch is committed I will bring this to the NETWM mailinglist to standardise the flag, so that it becomes _NET_WM_STATE_SKIP_SWITCHER.

This can be used by plasma to exclude windows from alt+tab. Therefore KWindowSystem::setState( winId, Net::SkipSwitcher ) can be used.


This addresses bugs 171192 and 179723.
    https://bugs.kde.org/show_bug.cgi?id=171192
    https://bugs.kde.org/show_bug.cgi?id=179723


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/kwin/client.h 1121836 
  trunk/KDE/kdebase/workspace/kwin/client.cpp 1121836 
  trunk/KDE/kdebase/workspace/kwin/effects.h 1121836 
  trunk/KDE/kdebase/workspace/kwin/effects.cpp 1121836 
  trunk/KDE/kdebase/workspace/kwin/effects/desktopgrid/desktopgrid.cpp 1121836 
  trunk/KDE/kdebase/workspace/kwin/effects/presentwindows/presentwindows.cpp 1121836 
  trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.h 1121836 
  trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.cpp 1121836 
  trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 1121836 
  trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1121836 
  trunk/KDE/kdebase/workspace/kwin/manage.cpp 1121836 
  trunk/KDE/kdebase/workspace/kwin/rules.h 1121836 
  trunk/KDE/kdebase/workspace/kwin/rules.cpp 1121836 
  trunk/KDE/kdebase/workspace/kwin/sm.h 1121836 
  trunk/KDE/kdebase/workspace/kwin/sm.cpp 1121836 
  trunk/KDE/kdebase/workspace/kwin/tabbox.cpp 1121836 

Diff: http://reviewboard.kde.org/r/3800/diff


Testing
-------

Adding a window specific rule updates the state and the window is not shown in tabbox.


Thanks,

Martin