Review Request: Adds support for corner widgets in Plasma::TabBar

[Giulio Camuffo]

> On 2010-07-07 20:10:37, Marco Martin wrote:
> > i don't  think i'm in favor or such a change.
> > the tabbar was designed to be something really simple, never to really work as complex stuff like a browser tabbar.
> > moreover, it's already possible to enable close buttons on the tabs, as well i think putting a qwidget at the top left corner of the tabbar.
> > redoing this from scratch gives also problems like not respecting the layout direction and support different paradigms like where put the new or the close buttons.

i didn't add a showNewTabButton() and a showCloseTabButton() method but a setCornerWidget. While it is true that what i want to do is to add those buttons this is a generic method that can be used to add whenever qgw you want, so the layout direction hasn't to be managed by the TabBar, but by who adds the buttons. 
Unfortunately (Q,K)TabBar don't have any method allowing that, and while putting a button outside the TabBar works, it isn't graphically nice. When the TabBar does the SlideAnimation it sets ItemClipsChildrenToShape so the widgets are cut under the button, while by a user pov the space under the button is of the TabBar.


- Giulio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4537/#review6415
-----------------------------------------------------------


On 2010-07-07 17:17:22, Giulio Camuffo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4537/
> -----------------------------------------------------------
> 
> (Updated 2010-07-07 17:17:22)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch adds two methods that allow to put two QGraphicsWidget in the top left and top right corner of the tab bar, like it is possible with QTabWidget.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 
>   trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 
> 
> Diff: http://reviewboard.kde.org/r/4537/diff
> 
> 
> Testing
> -------
> 
> Tested, it works, but there's one thing that annoys me and I don't how to solve in a clean way: when there are no tabs the NativeTabBar becomes a bit smaller in height and the widgets resize accordingly.
> 
> 
> Screenshots
> -----------
> 
> added two Plasma::PushButton
>   http://reviewboard.kde.org/r/4537/s/446/
> 
> 
> Thanks,
> 
> Giulio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100708/1b805e1e/attachment.htm