Review Request: Allow to know if the machine have batteries during plasma init ( scripting )

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2741/#review3912
-----------------------------------------------------------

Ship it!


i don't think the current patch compiles (a missing '}'), but it looks fine. for 4.5 i could (very easily) add full DataEngine support to the scripting if it becomes useful (i'm not sure it would be useful, but i'm open to use cases). in any case, please ensure it compiles and then commit (and backport). i'll take care of documenting the API in the design file.

- Aaron


On 2010-01-27 15:44:17, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2741/
> -----------------------------------------------------------
> 
> (Updated 2010-01-27 15:44:17)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> When creating scripts for plasma first init there is for the moment no way to add the battery widget only if the machine have batteries. this patch try to work on this issue.
> 
> With this function , haveBattery() return true if the machine have some.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/scriptengine.h 1081032 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/scriptengine.cpp 1081032 
> 
> Diff: http://reviewboard.kde.org/r/2741/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>