Review Request: Imgur support in Pastebin applet

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2324/#review3895
-----------------------------------------------------------



trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.h
<http://reviewboard.kde.org/r/2324/#comment3269>

    Left-over? :)



trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.cpp
<http://reviewboard.kde.org/r/2324/#comment3270>

    A comment where these magic numbers come from would be good



trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.cpp
<http://reviewboard.kde.org/r/2324/#comment3271>

    Did you also copy the FlickR Kipi plugin's copyright? If you copy code, you also need to take the copyright.



trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.cpp
<http://reviewboard.kde.org/r/2324/#comment3268>

    How does this work? Everybody using KDE will use Shantanu's key?
    
    It might be a good idea to ask Imgur what they want to do with this.


- Sebastian


On 2010-01-26 04:29:10, Nikhil Marathe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2324/
> -----------------------------------------------------------
> 
> (Updated 2010-01-26 04:29:10)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> A patch to add support for uploading images to imgur.com for the Pastebin applet.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1079836 
>   trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1079836 
>   trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1079836 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/CMakeLists.txt 1079836 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/backends.h 1079836 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.h PRE-CREATION 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.cpp PRE-CREATION 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/pastebinservice.h 1079836 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/pastebinservice.cpp 1079836 
> 
> Diff: http://reviewboard.kde.org/r/2324/diff
> 
> 
> Testing
> -------
> 
> Tried on current trunk, works fine.
> 
> 
> Thanks,
> 
> Nikhil
> 
>