Review Request: Supporting theme colors on the fifteenPuzzle plasmoid

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4904/#review6796
-----------------------------------------------------------


is that really a problem? if you choose a custom colour .. you choose a custom colour.

- Aaron


On 2010-08-04 18:13:29, Alex Raymond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4904/
> -----------------------------------------------------------
> 
> (Updated 2010-08-04 18:13:29)
> 
> 
> Review request for Plasma, Aaron Seigo and Tomaz Canabrava.
> 
> 
> Summary
> -------
> 
> This patch automatically adds the current background Plasma color as the first in the KColorCombo list. :)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp 1159160 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.cpp 1159160 
> 
> Diff: http://reviewboard.kde.org/r/4904/diff
> 
> 
> Testing
> -------
> 
> It works fine, but there is still a problem. If you manually select a theme color, and have your theme changed afterwards, you will need to manually re-select the theme color on the list in order to make it go for the right one. Any suggestions?
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100804/06c0136e/attachment.htm