Review Request: battery: change brightness on mouse wheel

Rafa? Mi?ecki zajec5 at gmail.com
Sun Aug 1 03:01:33 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4810/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This implements feature requested in bug 230888 . Scrolling over battery plasmoid changes brightness.

In (uncommon) case of multiple brightness devices it affects the first registered device. We may want to make it configurable in the future.


This addresses bug 230888.
    https://bugs.kde.org/show_bug.cgi?id=230888


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1157714 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1157714 

Diff: http://reviewboard.kde.org/r/4810/diff


Testing
-------

It works fine for my notebook, doesn't crash on machine without brightness device.

The part I am not sure about is:
Applet::wheelEvent(e);
I though we need to propagate events so tried to use this call. However using it causes crash. Help?


Thanks,

Rafa?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100801/d8f67dbe/attachment.htm 


More information about the Plasma-devel mailing list