Review Request: Use sunrise and sunset times from the Environment Canada weather service to set weather icon to day/night, accordingly.

[Andrew Coles]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/665/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Previously, day began at 6am, and night began at 6pm.  However, as summer approaches, this is increasingly far from the truth.  Hence, the real sunrise/sunset times are now used to determine whether it is day or night, and the weather icon set appropriately.  This also fixes issues with the weather wallpaper picking night-time images during the day.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_envcan.cpp 963098 

Diff: http://reviewboard.kde.org/r/665/diff


Testing
-------

I need someone who uses this weather service to test it for me.


Thanks,

Andrew