Review Request: Ported akonaditray to KNotificationAreaItem

Tom Albers tomalbers at kde.nl
Sun May 3 13:45:20 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/618/#review1038
-----------------------------------------------------------


Patch in general looks ok. I've not yet tested it though. Though this can not go into kdepim until the lib is in kdelibs or a copy is added to kdepim. I will wait with final review untill that has happened.

- Tom


On 2009-04-28 11:05:58, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/618/
> -----------------------------------------------------------
> 
> (Updated 2009-04-28 11:05:58)
> 
> 
> Review request for KDE PIM, Plasma and Tom Albers.
> 
> 
> Summary
> -------
> 
> Ported akonaditray to KNotificationAreaItem.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/tray/CMakeLists.txt 957204 
>   /trunk/KDE/kdepim/akonadi/tray/dock.h 957204 
>   /trunk/KDE/kdepim/akonadi/tray/dock.cpp 957204 
>   /trunk/KDE/kdepim/akonadi/tray/main.cpp 957204 
> 
> Diff: http://reviewboard.kde.org/r/618/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>



More information about the Plasma-devel mailing list