Review Request: Add keyboard navigation to plasma applet Folder View

[Shantanu Tushar Jha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
-----------------------------------------------------------

(Updated 2009-03-20 22:14:51.976726)


Review request for Plasma.


Changes
-------

Have attached new diff. I've renamed the function to scrollTo(), with effort to adhere to the coding style. I will work on the following -

1. I'm not sure currently what/how to implement the parameter QAbstractItemView::ScrollHint hint, will work on this.
2. I've noted the problems of the view being unsorted, with IconView::keyPressEvent(QKeyEvent *event) and IconView::scrollTo(const QModelIndex &index, QAbstractItemView::ScrollHint hint). I will work on them and try to resolve the problem.

I'm not aware if I should commit in small working steps, or at once in the end. As the applet is in a working stage, is it ok to commit it?
( I commited a previous diff2, and after that I thought of the above. Regrets if I did it wrong :( )


Summary
-------

This partly addresses the above bug, adding keyboard navigation and launch using Enter key.
Please report if the code is too complex, I've tried my best to keep it to the point.


This addresses bug 187241.
    https://bugs.kde.org/show_bug.cgi?id=187241


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 942106 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 942106 

Diff: http://reviewboard.kde.org/r/368/diff


Testing
-------

Tested on latest SVN build. Navigation and launch work fine. The problem is with movement of the scrollbar with the keyboard focus, the scrollbar refuses to go to minimum value when m_scrollBar->setValue( m_scrollBar->minimum() ); is used. What am I doing wrong?


Thanks,

Shantanu