Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

[Aaron J. Seigo]

On Wednesday 11 March 2009, Petri Damstén wrote:
> On Wednesday 11 March 2009 08:28:47 Shantanu Tushar Jha wrote:
> > > whenever a new source is added in the engine, the sourceAdded signal
> > > will be emitted; likewise, the sourceRemoved signal will be emitted
> > > whenever a source is removed. the applet should listen to those signals
> > > and manage its connections that way.
> >
> > All is fine with sourceAdded, but somehow, engine()::sourceRemoved is
> > not getting emitted called when I disconnect my dial-up connection
> > (interface ppp0). I've notified Petri of this.
>
> I guess the dataengine should call removeSource for removed sources in
> answerReceived. Attached patch for testing.

yes, that looks correct.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090311/fbd4150e/attachment.sig