Review Request: Addition to UI for Config page "Filter" in FolderView applet to make behavior clear.

[Shantanu Tushar Jha]

Added all the requested features. Patch attached. Is this ok to commit?

-- 
Shantanu Tushar    (GMT +0530)
http://www.shantanutushar.com

On Wed, Mar 11, 2009 at 3:38 AM, Aaron Seigo <aseigo at kde.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/262/#review450
> -----------------------------------------------------------
>
>
> i think this addition is worth while; but i think we could also make the labels clearer: "And Only Files of Type:" and all the mimetypes should be selected by default.
>
> - Aaron
>
>
> On 2009-03-08 09:58:46, Shantanu Tushar Jha wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/262/
>> -----------------------------------------------------------
>>
>> (Updated 2009-03-08 09:58:46)
>>
>>
>> Review request for Plasma.
>>
>>
>> Summary
>> -------
>>
>> This changes the UI for the configuration page "Filter" for the applet folderview. As seen in the bug 186283, files are only displayed if they match both the pattern and the MIME type. But there is no obvious indication to this behavior in the interface.
>> Added a label "Can't see files?" which has a tooltip explaining the above behavior. (screenshot attached)
>> Please review, and if found helpful, commit it, as I don't have a svn account.
>>
>>
>> This addresses bug 186283.
>>     https://bugs.kde.org/show_bug.cgi?id=186283
>>
>>
>> Diffs
>> -----
>>
>>   trunk/KDE/kdebase/apps/plasma/applets/folderview/folderviewFilterConfig.ui 936718
>>
>> Diff: http://reviewboard.kde.org/r/262/diff
>>
>>
>> Testing
>> -------
>>
>> On latest svn trunk build.
>>
>>
>> Screenshots
>> -----------
>>
>> Filter config page
>>   http://reviewboard.kde.org/r/262/s/52/
>>
>>
>> Thanks,
>>
>> Shantanu
>>
>>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: folderview.diff
Type: text/x-diff
Size: 1898 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090311/c3b72829/attachment-0001.bin