Review Request: add action collection to the corona

[Chani]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/268/#review443
-----------------------------------------------------------


if I add a function for getting the whole collection... should I expose the KActionCollection itself, or give a QList of all the actions in it?


trunk/KDE/kdelibs/plasma/containment.cpp
<http://reviewboard.kde.org/r/268/#comment277>

    um, not necessarily. the contextmenu plugins will use it too, but I assume we still want it visible in the containment's cashew when we're zoomed in.



trunk/KDE/kdelibs/plasma/containment.cpp
<http://reviewboard.kde.org/r/268/#comment278>

    oops :)



trunk/KDE/kdelibs/plasma/containment.cpp
<http://reviewboard.kde.org/r/268/#comment279>

    there's a qprivateslot whatsit in containment.h which afaik means it'd be BIC to remove it :( I could remove the *contents* of hte function, but then if some silly person tries to use it it won't work.



trunk/KDE/kdelibs/plasma/corona.h
<http://reviewboard.kde.org/r/268/#comment280>

    ok. private slot then, I suppose. it was in the corona's dptr until I noticed that wasn't actually a qobject


- Chani


On 2009-03-09 10:24:36, Chani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/268/
> -----------------------------------------------------------
> 
> (Updated 2009-03-09 10:24:36)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> some of the actions in Containment don't belong there, and there'll probably be more of those after the summer, so let's give them a home in Corona.
> I've only moved over the lock action so far; I'll move the "new activity" one next.
> Containment can grab the actions from the corona so the UI isn't affected by this patch and nothing breaks. there's just less duplicate actions. I'll leave the UI changes to notmart. :)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/containment.cpp 936946 
>   trunk/KDE/kdelibs/plasma/corona.h 936946 
>   trunk/KDE/kdelibs/plasma/corona.cpp 936946 
> 
> Diff: http://reviewboard.kde.org/r/268/diff
> 
> 
> Testing
> -------
> 
> works with desktop and screensaver.
> 
> 
> Thanks,
> 
> Chani
> 
>