Review Request: Addition to UI for Config page "Filter" in FolderView applet to make behavior clear.

[Shantanu Tushar Jha]

Oops, sorry, (now I understand why they tell in techbase to attach the patch
first).

On Tue, Mar 10, 2009 at 12:47 AM, Shantanu Tushar Jha
<jhahoneyk at gmail.com>wrote:

> I had to attach the patch here, somehow I can't update the diff on
> reviewboard to that particular request.
> I've added that If the user selects "Show Files Matching" or "Hide Files
> Matching", the MIME types automatically get selected.
> Please review, is it ok to commit?
>
>
> On Mon, Mar 9, 2009 at 10:40 AM, Shantanu Tushar Jha <jhahoneyk at gmail.com>wrote:
>
>> If we have every file-type selected on default for "Show files matching",
>> that will be fine, but I'm not sure if deselecting all file types for "Hide
>> files matching" would work, because if the user enters some filter, say
>> "foo*" even then foo will be displayed, because its not selected in the MIME
>> types (the file will if hidden if it satisfies both the conditions). So,
>> should I make the MIME types enabled by default in both cases, or any better
>> idea?
>>
>> P.S. I could not leave a comment at reviewboard, because due to some
>> reason, its not showing be logged in on this particular page.
>>
>>
>> On Mon, Mar 9, 2009 at 3:03 AM, Matthias Fuchs <mat69 at gmx.net> wrote:
>>
>>>
>>>
>>> > On 2009-03-08 12:29:21, Chani wrote:
>>> > > the patch itself looks fine, but... isn't there a way we can make the
>>> UI better so that there's no need for a tooltip at all?
>>>
>>> One way to avoid unwanted behavior without changing the ui would be to
>>> have every file-type selected on default for "Show files matching" and
>>> having none selected for "Hide files matching".
>>>
>>> Imo that way it would be more clear how filtering works.
>>>
>>>
>>> - Matthias
>>>
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> http://reviewboard.kde.org/r/262/#review413
>>> -----------------------------------------------------------
>>>
>>>
>>> On 2009-03-08 09:58:46, Shantanu Tushar Jha wrote:
>>> >
>>> > -----------------------------------------------------------
>>> > This is an automatically generated e-mail. To reply, visit:
>>> > http://reviewboard.kde.org/r/262/
>>> > -----------------------------------------------------------
>>> >
>>> > (Updated 2009-03-08 09:58:46)
>>> >
>>> >
>>> > Review request for Plasma.
>>> >
>>> >
>>> > Summary
>>> > -------
>>> >
>>> > This changes the UI for the configuration page "Filter" for the applet
>>> folderview. As seen in the bug 186283, files are only displayed if they
>>> match both the pattern and the MIME type. But there is no obvious indication
>>> to this behavior in the interface.
>>> > Added a label "Can't see files?" which has a tooltip explaining the
>>> above behavior. (screenshot attached)
>>> > Please review, and if found helpful, commit it, as I don't have a svn
>>> account.
>>> >
>>> >
>>> > This addresses bug 186283.
>>> >     https://bugs.kde.org/show_bug.cgi?id=186283
>>> >
>>> >
>>> > Diffs
>>> > -----
>>> >
>>> >
>>> trunk/KDE/kdebase/apps/plasma/applets/folderview/folderviewFilterConfig.ui
>>> 936718
>>> >
>>> > Diff: http://reviewboard.kde.org/r/262/diff
>>> >
>>> >
>>> > Testing
>>> > -------
>>> >
>>> > On latest svn trunk build.
>>> >
>>> >
>>> > Screenshots
>>> > -----------
>>> >
>>> > Filter config page
>>> >   http://reviewboard.kde.org/r/262/s/52/
>>> >
>>> >
>>> > Thanks,
>>> >
>>> > Shantanu
>>> >
>>> >
>>>
>>>
>>
>>
>> --
>> Shantanu Tushar
>> http://www.shantanutushar.com
>>
>
>
>
> --
> Shantanu Tushar
> http://www.shantanutushar.com
>



-- 
Shantanu Tushar
http://www.shantanutushar.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090310/4fb0883f/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: folderview.diff
Type: text/x-diff
Size: 12778 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090310/4fb0883f/attachment-0001.bin