Review Request: Adds support for tabs to the comic applet

Matthias Fuchs mat69 at gmx.net
Sun Mar 8 22:47:12 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/251/
-----------------------------------------------------------

(Updated 2009-03-08 14:47:11.968191)


Review request for Plasma.


Changes
-------

Removes unnecessary code parts and accepts events.


Summary
-------

Adds tabs to the comic applet, on default the tab bar is not shown.

Ctrl + Scrolling on the image also changes the tabs, that way you can hide the tab bar but still access the tabs.


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/applets/comic/appearanceSettings.ui 936860 
  /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 936860 
  /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 936860 
  /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 936860 
  /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 936860 
  /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.cpp 936860 

Diff: http://reviewboard.kde.org/r/251/diff


Testing
-------

Works, though sometimes the tab bar disappears, especially when scrolling back. notmart could not reproduce it though, so maybe a local problem.


Thanks,

Matthias



More information about the Plasma-devel mailing list