Review Request: Activate present windows from task group context menu

[Martin Gräßlin]

> On 2009-06-27 07:31:22, Aaron Seigo wrote:
> > i'm with Ivan on this one, i like the idea ... but i'm not comfortable with how it's being exposed to the user. there should probably be a way to select which effect is associated with the taskbar "show me these windows" effect. when this effect is enabled, it should also probably override the taskbar tooltips? finally, the context menu is pretty long already and it's a very slow way to access something that is really a shortcut. i do like the idea of a tooltip-replacing hover effect with one xatom to set with kwin deciding which effect gets employed. then plasma only needs to decide whether it sets that atom or shows the thumbnail tooltip.
> 
> Ivan Cukic wrote:
>     +1 for this (that is, I'm agreeing with Aaron agreeing with me :) )

agreed, that context menu is not the easiest way to access.

I'm currently thinking about the ways we have and which could go optional. We have 
 * the thumbails providing both preview and a way to activate the window
 * the highlight window effect only providing "preview", which could be useless in case of a group when windows are on top of each other.
 * present windows which is the most powerful probably. Providing preview, activating and optional search. This one is only useful for groups while the other two are useful for single tasks as well.

Highlight window cannot replace one of the others as it does not provide activation. Present windows could be useful instead of highlight windows for groups... Always show tooltips and activate highlight window/present windows only when pressing a modifier? hmm I'm not really sure what's best way. Point for discussion at akademy (KWin/Plasma integration).


> On 2009-06-27 07:31:22, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp, line 308
> > <http://reviewboard.kde.org/r/897/diff/1/?file=7646#file7646line308>
> >
> >     probably too much "geek speak": "what's 'present windows'"? :)
> >     
> >     perhaps just "present windows" or "show overview of windows" ... hm.. this will require some user testing i think.

I used present windows as that's the name of the effect. But probably most users do not even know the name of it or refer to it as Exposé. So I like "show overview of windows".


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/897/#review1400
-----------------------------------------------------------


On 2009-06-27 04:30:57, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/897/
> -----------------------------------------------------------
> 
> (Updated 2009-06-27 04:30:57)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Patch adds a new menu entry to task group context menu to show the group of windows in kwin's present windows effect. When this entry is selected the window ids of the tasks listed in the group are passed to an XAtom which activates present windows effect for the passed windows (other windows will be hidden). The atom will be removed by present windows effect when it get's disabled.
> 
> This patch requires current kwin from trunk. What's missing is the detection if present windows effect is available or not (e.g. compositing not active, Compiz used instead of KWin). KWin announces support via setting atom on root window.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 972097 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h 972097 
> 
> Diff: http://reviewboard.kde.org/r/897/diff
> 
> 
> Testing
> -------
> 
> Tested with both manual and automatic grouping.
> 
> 
> Thanks,
> 
> Martin
> 
>